Re: RFR: JDK-8050818 Predicate::not - provide an easier way to negate a predicate

2018-05-30 Thread Paul Sandoz
+1 — Actually… even small API tweaks are not easy :-), this got me thinking whether this method should explicitly state negate is called, since it has implications for subtypes. Something to consider as a follow on tweak perhaps. Paul. > On May 29, 2018, at 5:52 AM, Jim Laskey wrote: > >

Re: RFR: JDK-8050818 Predicate::not - provide an easier way to negate a predicate

2018-05-30 Thread Remi Forax
Hi Jim, looks good. Rémi - Mail original - > De: "Jim Laskey" > À: "core-libs-dev" > Envoyé: Mardi 29 Mai 2018 14:52:24 > Objet: RFR: JDK-8050818 Predicate::not - provide an easier way to negate a > predicate > Introduce a new static method Pred

Re: RFR: JDK-8050818 Predicate::not - provide an easier way to negate a predicate

2018-05-30 Thread Claes Redestad
On 2018-05-29 14:52, Jim Laskey wrote: Introduce a new static method Predicate::not which will allow developers to negate predicate lambdas trivially. webrev: http://cr.openjdk.java.net/~jlaskey/8050818/webrev/index.html Implementation and test looks good to me. Thanks! /Claes

Re: RFR: JDK-8050818 Predicate::not - provide an easier way to negate a predicate

2018-05-29 Thread Zheka Kozlov
What about "not null" predicate? This is also very common. Right now it is possible via `Objects::nonNull` but many people do not know about this method. So, having a `Predicate.notNull` method would be nice. 2018-05-29 19:52 GMT+07:00 Jim Laskey : > Introduce a new static method Predicate::not

RFR: JDK-8050818 Predicate::not - provide an easier way to negate a predicate

2018-05-29 Thread Jim Laskey
Introduce a new static method Predicate::not which will allow developers to negate predicate lambdas trivially. webrev: http://cr.openjdk.java.net/~jlaskey/8050818/webrev/index.html bug: https://bugs.openjdk.java.net/browse/JDK-8050818 csr: https://bugs.openjdk.java.net/browse/JDK-8203428