Thanks Joe and Lance. do you mind sponsor this for me.
Tristan
On Jan 8, 2015, at 2:54 PM, huizhe wang huizhe.w...@oracle.com wrote:
Thanks for the update. I think the webrev is ready for putback.
Best,
Joe
On 1/7/2015 9:41 PM, Tristan Yan wrote:
Hi Joe/Lance and others.
Please
Thanks for the update. I think the webrev is ready for putback.
Best,
Joe
On 1/7/2015 9:41 PM, Tristan Yan wrote:
Hi Joe/Lance and others.
Please review updated version for this one.
http://cr.openjdk.java.net/~tyan/8051563/webrev.01/
http://cr.openjdk.java.net/%7Etyan/8051563/webrev.01/
Hi Joe/Lance and others.
Please review updated version for this one.
http://cr.openjdk.java.net/~tyan/8051563/webrev.01/
http://cr.openjdk.java.net/~tyan/8051563/webrev.01/
Thank you
Tristan
On Jan 6, 2015, at 2:27 PM, huizhe wang huizhe.w...@oracle.com
mailto:huizhe.w...@oracle.com
Hi Tristan,
Sorry for the delay but with the holidays and the number of files, it took a
while to go through :-)
Overall, it looks pretty good.
A couple of suggestions, but I would not necessarily hold back from committing:
- For tests where you are not caring about the actual exception that
Thanks, I will update it.
Tristan
On Jan 6, 2015, at 2:27 PM, huizhe wang huizhe.w...@oracle.com wrote:
On 1/6/2015 2:25 PM, Lance Andersen wrote:
One more thing :-)
Remember to update your copyright year to 2015 also
Indeed, that applies to my webrevs as well :-)
Joe
Best
Thanks for taking the initiative and effort to refactor and clean up all
of the Functional tests in previous changeset!
We've gone through several iterations for the new ones (xslt tests). I
totally agree with Lance, it looks very good overall, a lot better than
its original form.
It's nice
On 1/6/2015 2:25 PM, Lance Andersen wrote:
One more thing :-)
Remember to update your copyright year to 2015 also
Indeed, that applies to my webrevs as well :-)
Joe
Best
Lance
On Jan 6, 2015, at 5:04 PM, Lance Andersen lance.ander...@oracle.com
mailto:lance.ander...@oracle.com wrote:
On Jan 6, 2015, at 4:31 PM, Tristan Yan tristan@oracle.com wrote:
Thank you Lance and Joe.
You are very welcome.
I am working on the fix.
No rush from my perspective, have a lot to keep me busy in the interim before
your next webrev . :-)
it may take a couple of days that the code
Thank you Lance and Joe.
I am working on the fix. it may take a couple of days that the code needs some
refactor. I will send out next review once I finish it.
Thanks
Tristan
On Jan 6, 2015, at 1:22 PM, huizhe wang huizhe.w...@oracle.com wrote:
Thanks for taking the initiative and effort to
One more thing :-)
Remember to update your copyright year to 2015 also
Best
Lance
On Jan 6, 2015, at 5:04 PM, Lance Andersen lance.ander...@oracle.com wrote:
On Jan 6, 2015, at 4:31 PM, Tristan Yan tristan@oracle.com wrote:
Thank you Lance and Joe.
You are very welcome.
I am
Hi Joe and Lance
Sorry for my late reply. I just uploaded the new webrev which is trying to
limit minimal permissions for most of tests. The new changeset has two base
classes; class JAXPBaseTest has only minimal set permissions; class
JAXPFileBaseTest adds two permissions that need access
Lance,
Tristan is looking into adding an extension base class for about 60
tests that require file permission, then the current base class would
indeed set minimal permission. So please wait for his update :-)
Best,
Joe
On 12/30/2014 3:07 PM, Lance @ Oracle wrote:
Hi Tristan,
I will look
Hi All
Can I get your review on this change.
http://cr.openjdk.java.net/~tyan/8051563/webrev.00/
http://cr.openjdk.java.net/~tyan/8051563/webrev.00/
These fixes originally come from bug
https://bugs.openjdk.java.net/browse/JDK-8051563
https://bugs.openjdk.java.net/browse/JDK-8051563 as part
Hi Tristan,
I will look at this but doubt I will get to this tomorrow
Best,
Lance
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPad
On Dec 30, 2014, at 5:28 PM,
14 matches
Mail list logo
