Re: RFR: JDK-8238168: Remove Copyright from WinLauncher.template

2020-01-29 Thread Philip Race
+1 -phil. On 1/29/20, 10:34 AM, Andy Herrick wrote: Please review trivial jpackage fix to [1] at [2] [1] https://bugs.openjdk.java.net/browse/JDK-8238168 [2] http://cr.openjdk.java.net/~herrick/8238168/webrev.01/ /Andy

Re: RFR: JDK-8238168: Remove Copyright from WinLauncher.template

2020-01-29 Thread Alexey Semenyuk
Looks good. - Alexey On 1/29/2020 1:34 PM, Andy Herrick wrote: Please review trivial jpackage fix to [1] at [2] [1] https://bugs.openjdk.java.net/browse/JDK-8238168 [2] http://cr.openjdk.java.net/~herrick/8238168/webrev.01/ /Andy

Re: RFR: JDK-8238168: Remove Copyright from WinLauncher.template

2020-01-29 Thread Kevin Rushforth
Looks good. +1 -- Kevin On 1/29/2020 10:34 AM, Andy Herrick wrote: Please review trivial jpackage fix to [1] at [2] [1] https://bugs.openjdk.java.net/browse/JDK-8238168 [2] http://cr.openjdk.java.net/~herrick/8238168/webrev.01/ /Andy

RFR: JDK-8238168: Remove Copyright from WinLauncher.template

2020-01-29 Thread Andy Herrick
Please review trivial jpackage fix to [1] at [2] [1] https://bugs.openjdk.java.net/browse/JDK-8238168 [2] http://cr.openjdk.java.net/~herrick/8238168/webrev.01/ /Andy