Re: RFR: JDK-8251397 NPE on ClassValue.ClassValueMap.cacheArray

2020-09-09 Thread Galder Zamarreno
Hi Paul, Thanks a lot for the feedback. I've waited a bit before tackling your feedback to see if others would provide further feedback. Not yet able to create webrevs (not yet author), so I've gone ahead and created a PR with the updated changes [6]. Basically, I've moved the fence to

Re: RFR: JDK-8251397 NPE on ClassValue.ClassValueMap.cacheArray

2020-08-19 Thread Paul Sandoz
Hi Galder, Thanks for doing the fix and the work verifying. I also verified using a fence fixes the jcstress test. Similarly, I found I could only reproduce the issue in HotSpot when running a test more like ClassValue (the double checked locking pattern when publishing to a plan field) with

RFR: JDK-8251397 NPE on ClassValue.ClassValueMap.cacheArray

2020-08-19 Thread Galder Zamarreno
Hi all, I've created patch [1] to fix the ClassValue$ClassValueMap NPE bug in [2]. The bug has been discussed by other members in the list in thread [3]. The patch follows the simple fix suggested by Doug and others in that exchange, e.g. [4]. That is, it adds a release fence to