Re: RFR: JDK-8260335: [macos] Running app using relative path causes problems [v2]

2021-02-02 Thread Andy Herrick
On Tue, 2 Feb 2021 17:10:15 GMT, Alexey Semenyuk wrote: >> Andy Herrick has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 86 additional >>

Re: RFR: JDK-8260335: [macos] Running app using relative path causes problems [v2]

2021-02-02 Thread Andy Herrick
> Fixing FileUtils.dirname() to skip over "/.". Andy Herrick has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 86 additional commits since the last

Re: RFR: JDK-8260335: [macos] Running app using relative path causes problems

2021-02-02 Thread Alexander Zuev
On Wed, 27 Jan 2021 12:43:40 GMT, Andy Herrick wrote: > Fixing FileUtils.dirname() to skip over "/.". Aside of small change requested by @alexeysemenyukoracle looks fine. - Marked as reviewed by kizune (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2260

Re: RFR: JDK-8260335: [macos] Running app using relative path causes problems

2021-02-02 Thread Alexey Semenyuk
On Wed, 27 Jan 2021 12:43:40 GMT, Andy Herrick wrote: > Fixing FileUtils.dirname() to skip over "/.". Changes requested by asemenyuk (Committer). src/jdk.jpackage/share/native/common/FileUtils.cpp line 57: > 55: tstring dirname(const tstring ) { > 56: tstring::size_type pos; > 57: if

Re: RFR: JDK-8260335: [macos] Running app using relative path causes problems

2021-01-28 Thread Alexander Matveev
On Wed, 27 Jan 2021 12:43:40 GMT, Andy Herrick wrote: > Fixing FileUtils.dirname() to skip over "/.". Marked as reviewed by almatvee (Committer). - PR: https://git.openjdk.java.net/jdk/pull/2260

RFR: JDK-8260335: [macos] Running app using relative path causes problems

2021-01-28 Thread Andy Herrick
Fixing FileUtils.dirname() to skip over "/.". - Commit messages: - JDK-8260335: [macos] Running app using relative path causes problems on MacOS Changes: https://git.openjdk.java.net/jdk/pull/2260/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2260=00 Issue: