Re: RFR: JDK-8266490: Extend the OSContainer API to support the pids controller of cgroups [v2]

2021-07-15 Thread Matthias Baesken
On Fri, 9 Jul 2021 13:53:27 GMT, Matthias Baesken wrote: > > OK. Please also add a test on the hotspot side. You may want to add > > relevant parts to `TestMisc.java`. > > Thanks for the suggestion, I will look into TestMisc.java . I added some HS testing code in the latest commit. Best

Re: RFR: JDK-8266490: Extend the OSContainer API to support the pids controller of cgroups [v2]

2021-07-09 Thread Matthias Baesken
On Fri, 9 Jul 2021 13:42:15 GMT, Severin Gehwolf wrote: > OK. Please also add a test on the hotspot side. You may want to add relevant > parts to `TestMisc.java`. Thanks for the suggestion, I will look into TestMisc.java . - PR: https://git.openjdk.java.net/jdk/pull/4518

Re: RFR: JDK-8266490: Extend the OSContainer API to support the pids controller of cgroups [v2]

2021-07-09 Thread Severin Gehwolf
On Fri, 9 Jul 2021 11:35:34 GMT, Matthias Baesken wrote: > > This looks pretty good now. Looking forward to seeing container tests for > > this new code. > > Hi Severin , I did some adjustments following your suggestions. > I added docker based test coding for testing pids-limit (with limits

Re: RFR: JDK-8266490: Extend the OSContainer API to support the pids controller of cgroups [v2]

2021-07-09 Thread Matthias Baesken
On Tue, 29 Jun 2021 08:21:51 GMT, Severin Gehwolf wrote: > This looks pretty good now. Looking forward to seeing container tests for > this new code. Hi Severin , I did some adjustments following your suggestions. I added docker based test coding for testing pids-limit (with limits and also

Re: RFR: JDK-8266490: Extend the OSContainer API to support the pids controller of cgroups [v2]

2021-06-29 Thread Severin Gehwolf
On Wed, 23 Jun 2021 13:37:59 GMT, Matthias Baesken wrote: >> Hello, please review this PR; it extend the OSContainer API in order to also >> support the pids controller of cgroups. >> >> I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct", >> "memory" on some older Linux

Re: RFR: JDK-8266490: Extend the OSContainer API to support the pids controller of cgroups [v2]

2021-06-24 Thread Matthias Baesken
On Wed, 23 Jun 2021 14:48:22 GMT, Severin Gehwolf wrote: > > But I think that the testing needs to be enhanced (e.g. with some added > > docker tests?). Do you have some good suggestions > > where I could look at existing (docker?) tests and adjust those for the new > > pids.max ? > > Have a

Re: RFR: JDK-8266490: Extend the OSContainer API to support the pids controller of cgroups [v2]

2021-06-23 Thread Severin Gehwolf
On Wed, 23 Jun 2021 13:38:58 GMT, Matthias Baesken wrote: > But I think that the testing needs to be enhanced (e.g. with some added > docker tests?). Do you have some good suggestions > where I could look at existing (docker?) tests and adjust those for the new > pids.max ? Have a look at

Re: RFR: JDK-8266490: Extend the OSContainer API to support the pids controller of cgroups [v2]

2021-06-23 Thread Matthias Baesken
On Wed, 23 Jun 2021 13:37:59 GMT, Matthias Baesken wrote: >> Hello, please review this PR; it extend the OSContainer API in order to also >> support the pids controller of cgroups. >> >> I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct", >> "memory" on some older Linux

Re: RFR: JDK-8266490: Extend the OSContainer API to support the pids controller of cgroups [v2]

2021-06-23 Thread Matthias Baesken
> Hello, please review this PR; it extend the OSContainer API in order to also > support the pids controller of cgroups. > > I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct", > "memory" on some older Linux distros (SLES 12.1, RHEL 7.1) the pids > controller might not be