Re: RFR: JDK-8288094: cleanup old _MSC_VER handling [v2]

2022-06-13 Thread Matthias Baesken
On Mon, 13 Jun 2022 10:33:24 GMT, Andrey Turbanov wrote: >> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> use round directly > > src/hotspot/share/adlc/main.cpp line 491: > >> 489: } >> 490: >> 491: // VS2005 has

Re: RFR: JDK-8288094: cleanup old _MSC_VER handling [v2]

2022-06-13 Thread Andrey Turbanov
On Mon, 13 Jun 2022 07:24:52 GMT, Matthias Baesken wrote: >> We still handle at a number of places ancient historic _MSC_VER versions of >> Visual Studio releases e.g. pre VS2013 (VS2013 has _MSC_VER 1800). >> This should be cleaned up, as long as it is not 3rd party code that we don't >> want

Re: RFR: JDK-8288094: cleanup old _MSC_VER handling [v2]

2022-06-13 Thread Martin Doerr
On Mon, 13 Jun 2022 07:24:52 GMT, Matthias Baesken wrote: >> We still handle at a number of places ancient historic _MSC_VER versions of >> Visual Studio releases e.g. pre VS2013 (VS2013 has _MSC_VER 1800). >> This should be cleaned up, as long as it is not 3rd party code that we don't >> want

Re: RFR: JDK-8288094: cleanup old _MSC_VER handling [v2]

2022-06-13 Thread Matthias Baesken
On Fri, 10 Jun 2022 21:04:04 GMT, Phil Race wrote: >> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> use round directly > > src/java.desktop/windows/native/libawt/windows/ThemeReader.cpp line 38: > >> 36: # define

Re: RFR: JDK-8288094: cleanup old _MSC_VER handling [v2]

2022-06-13 Thread Matthias Baesken
> We still handle at a number of places ancient historic _MSC_VER versions of > Visual Studio releases e.g. pre VS2013 (VS2013 has _MSC_VER 1800). > This should be cleaned up, as long as it is not 3rd party code that we don't > want to adjust. > > Currently still supported ("valid") VS version