Re: RFR: Small cleanups in java.lang.ref

> On May 18, 2018, at 4:47 PM, Martin Buchholz wrote: > > On Fri, May 18, 2018 at 3:26 AM, Thomas Schatzl > wrote: > >> Hi, >> >> On Wed, 2018-05-16 at 18:31 -0700, Martin Buchholz wrote: >>> I've been confused by NULL vs null for years. >>>

Re: RFR: Small cleanups in java.lang.ref

> On May 18, 2018, at 5:40 PM, Roger Riggs wrote: > > Hi Kim, > > In the cleanup category also is:JDK-8132984 > incorrect type for > Reference.discovered > > Is that within the scope of 8203028? I’d like to keep them

Re: RFR: Small cleanups in java.lang.ref

On 5/18/18 7:47 AM, Martin Buchholz wrote: On the contrary, I'm very happy to see gc team actively maintaining java.lang.ref. I've reverted changes to Reference.java http://cr.openjdk.java.net/~martin/webrevs/jdk/Reference-cleanup-1/ This looks okay.

Re: RFR: Small cleanups in java.lang.ref

On Fri, May 18, 2018 at 8:32 AM, wrote: > > What’s missing here is a similar comment on the `Reference.queue` field. > Suggested text: > > /* When active: queue with which this reference is registered > * pending: queue with which this reference is

Re: RFR: Small cleanups in java.lang.ref

Hi Martin, On Fri, 2018-05-18 at 07:47 -0700, Martin Buchholz wrote: > > > On Fri, May 18, 2018 at 3:26 AM, Thomas Schatzl e.com> wrote: > > Hi, > > > > On Wed, 2018-05-16 at 18:31 -0700, Martin Buchholz wrote: > > > I've been confused by NULL vs null for years. > > >

Re: RFR: Small cleanups in java.lang.ref

Hi Kim, In the cleanup category also is:JDK-8132984 incorrect type for Reference.discovered Is that within the scope of 8203028? Thanks, Roger On 5/18/18 10:47 AM, Martin Buchholz wrote: On Fri, May 18, 2018 at 3:26 AM, Thomas Schatzl

Re: RFR: Small cleanups in java.lang.ref

2018/5/18 3:11:25 -0700, per.li...@oracle.com: > On 05/17/2018 10:03 PM, mark.reinh...@oracle.com wrote: >> 2018/5/16 18:31:15 -0700, marti...@google.com: >>> I've been confused by NULL vs null for years. >> >> That’s because `NULL` in ReferenceQueue.java refers to the singleton >> object

Re: RFR: Small cleanups in java.lang.ref

On Fri, May 18, 2018 at 3:26 AM, Thomas Schatzl wrote: > Hi, > > On Wed, 2018-05-16 at 18:31 -0700, Martin Buchholz wrote: > > I've been confused by NULL vs null for years. > > > > 8203327: Small cleanups in java.lang.ref > >

Re: RFR: Small cleanups in java.lang.ref

Hi, On Wed, 2018-05-16 at 18:31 -0700, Martin Buchholz wrote: > I've been confused by NULL vs null for years. > > 8203327: Small cleanups in java.lang.ref > http://cr.openjdk.java.net/~martin/webrevs/jdk/Reference-cleanup/ > https://bugs.openjdk.java.net/browse/JDK-8203327 JDK-8203028 which

Re: RFR: Small cleanups in java.lang.ref

On 05/17/2018 10:03 PM, mark.reinh...@oracle.com wrote: 2018/5/16 18:31:15 -0700, marti...@google.com: I've been confused by NULL vs null for years. That’s because `NULL` in ReferenceQueue.java refers to the singleton object `ReferenceQueue.NULL`, not the null value. See the long comment at

Re: RFR: Small cleanups in java.lang.ref

2018/5/16 18:31:15 -0700, marti...@google.com: > I've been confused by NULL vs null for years. That’s because `NULL` in ReferenceQueue.java refers to the singleton object `ReferenceQueue.NULL`, not the null value. See the long comment at the top of Reference.java for an explanation. To improve

RFR: Small cleanups in java.lang.ref

I've been confused by NULL vs null for years. 8203327: Small cleanups in java.lang.ref http://cr.openjdk.java.net/~martin/webrevs/jdk/Reference-cleanup/ https://bugs.openjdk.java.net/browse/JDK-8203327