MutableCallSite.syncAll() (Re: RFR: Update code in java.lang to use new language features)

2014-01-24 Thread Aleksey Shipilev
On 01/24/2014 06:45 PM, Paul Sandoz wrote: I think the update to java.lang.invoke.MutableCallSite.java should be safe: public static void syncAll(MutableCallSite[] sites) { if (sites.length == 0) return; STORE_BARRIER.lazySet(0); -for (int i = 0; i

Re: RFR: Update code in java.lang to use new language features

2014-01-24 Thread Joe Darcy
On 01/24/2014 06:45 AM, Paul Sandoz wrote: Hi, Here are some patches that update code in java.lang to use newer language features. I will log a bug and fold into one patch once reviewed. Locally run java.lang tests all pass, but i will also kick off a JPRT test. Paul. --

Re: RFR: Update code in java.lang to use new language features

2014-01-24 Thread Alan Bateman
On 24/01/2014 14:45, Paul Sandoz wrote: -- http://cr.openjdk.java.net/~psandoz/jdk9/java.lang-StringBuilder/ -- http://cr.openjdk.java.net/~psandoz/jdk9/java.lang-collapse-catches/ -- http://cr.openjdk.java.net/~psandoz/jdk9/java.lang-boxing/ I looked through the StringBuilder, multi-catch

Re: RFR: Update code in java.lang to use new language features

2014-01-24 Thread Paul Sandoz
Hi Joe, Alan, Many thanks! Before folding/committing i will kick off a JPRT job (if i can get it to work on 9!) -- BTW if one uses IntelliJ it is very easy to make such changes, review and tweak them. Select menu item Analyze - Run Inspection By Name... and type in migration. Hint hint for