Re: RFR: jsr166 integration 2018-06

2018-06-25 Thread Martin Buchholz
Committed except for http://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/overview.html 8203662: remove increment of modCount from ArrayList and Vector replaceAll() http://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/replaceAll/index.html

Re: RFR: jsr166 integration 2018-06

2018-06-25 Thread Paul Sandoz
> On Jun 24, 2018, at 1:29 PM, Doug Lea wrote: > > On 06/22/2018 01:28 PM, Paul Sandoz wrote: > >>> 8203864: Execution error in Java's Timsort >>> http://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/TimSort/index.html >>> https://bugs.openjdk.java.net/browse/JDK-8203864 >>> >>

Re: RFR: jsr166 integration 2018-06

2018-06-24 Thread Doug Lea
On 06/22/2018 01:28 PM, Paul Sandoz wrote: >> 8203864: Execution error in Java's Timsort >> http://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/TimSort/index.html >> https://bugs.openjdk.java.net/browse/JDK-8203864 >> > > 406 if (n > 0 && runLen[n-1] <= runLen[n] +

Re: RFR: jsr166 integration 2018-06

2018-06-22 Thread joe darcy
On 6/22/2018 10:51 AM, Martin Buchholz wrote: On Fri, Jun 22, 2018 at 10:28 AM, Paul Sandoz wrote: --- We've been unable to reach agreement on 8203662 - it remains in limbo. 8203662: remove increment of modCount from ArrayList and Vector replaceAll()

Re: RFR: jsr166 integration 2018-06

2018-06-22 Thread Martin Buchholz
On Fri, Jun 22, 2018 at 10:28 AM, Paul Sandoz wrote: > > > --- > > We've been unable to reach agreement on 8203662 - it remains in limbo. > > > > 8203662: remove increment of modCount from ArrayList and Vector > replaceAll() > > http://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166- >

Re: RFR: jsr166 integration 2018-06

2018-06-22 Thread Martin Buchholz
On Fri, Jun 22, 2018 at 10:28 AM, Paul Sandoz wrote: > > TimeUnit.java > — > > * is equivalent to > * {@code unit.convert(n, NANOSECONDS)}, and > * {@code unit.convert(Duration.of(n, unit.toChronoUnit()))} > * is equivalent to {@code n} (in the absence of overflow). >

Re: RFR: jsr166 integration 2018-06

2018-06-22 Thread Paul Sandoz
> On Jun 21, 2018, at 6:28 PM, Martin Buchholz wrote: > > JDK 11 draws nigh. > Indeed, comments below, Paul. > http://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/overview.html > > 8202422: value of 'sizeCtl' in ConcurrentHashMap varies with the constructor > called >

RFR: jsr166 integration 2018-06

2018-06-21 Thread Martin Buchholz
JDK 11 draws nigh. http://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/overview.html 8202422: value of 'sizeCtl' in ConcurrentHashMap varies with the constructor called http://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/sizeCtl/index.html