We didn't file any bugs because I don't remember finding anything
specific, other than gosh that code is scary and I wish we didn't
have to do this.
If you find a null 'm' below and call m-print() is the method obsolete?
Coleen
On 4/30/14, 8:24 PM, Jeremy Manson wrote:
Did the new bugs
On 4 okt 2013, at 00:49, Coleen Phillmore coleen.phillim...@oracle.com wrote:
Thanks Dan -
On 10/3/2013 4:28 PM, Daniel D. Daugherty wrote:
open webrev at http://cr.openjdk.java.net/~coleenp/8025238_jdk
test/java/lang/instrument/RedefineMethodInBacktrace.sh
No comments.
Summary: Redefined class in stack trace may not be found by method_idnum
so handle null.
This is a simple change. I had another change to save the method name
(as u2) in the backtrace, but it's not worth the extra footprint in
backtraces for this rare case.
The root problem was that we
Coleen,
The fix looks good.
It is nice you've come up with this.
Thanks,
Serguei
On 10/3/13 11:02 AM, Coleen Phillimore wrote:
Summary: Redefined class in stack trace may not be found by
method_idnum so handle null.
This is a simple change. I had another change to save the method name
(as
http://cr.openjdk.java.net/~coleenp/8025238/
src/share/vm/classfile/javaClasses.cpp
1804 if (method == NULL) {
1805 // leave name and fileName null
1806 java_lang_StackTraceElement::set_lineNumber(element(), -1);
Is it possible to set the name and fileName to
Thanks Dan -
On 10/3/2013 4:28 PM, Daniel D. Daugherty wrote:
open webrev at http://cr.openjdk.java.net/~coleenp/8025238_jdk
test/java/lang/instrument/RedefineMethodInBacktrace.sh
No comments.
test/java/lang/instrument/RedefineMethodInBacktraceApp.java
line 78:
Thanks Serguei!
Coleen
On 10/3/2013 3:50 PM, serguei.spit...@oracle.com wrote:
Coleen,
The fix looks good.
It is nice you've come up with this.
Thanks,
Serguei
On 10/3/13 11:02 AM, Coleen Phillimore wrote:
Summary: Redefined class in stack trace may not be found by
method_idnum so handle
On 10/3/2013 7:01 PM, Daniel D. Daugherty wrote:
On 10/3/13 4:56 PM, Coleen Phillmore wrote:
Thanks Dan -
On 10/3/2013 4:07 PM, Daniel D. Daugherty wrote:
http://cr.openjdk.java.net/~coleenp/8025238/
src/share/vm/classfile/javaClasses.cpp
1804 if (method == NULL) {
1805 //
