Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

2013-11-27 Thread Peter Levart
On 11/27/2013 08:40 AM, David Holmes wrote: On 27/11/2013 2:16 AM, David Chase wrote: On 2013-11-26, at 8:12 AM, David Chase david.r.ch...@oracle.com wrote: On 2013-11-26, at 7:32 AM, David Holmes david.hol...@oracle.com wrote: On 26/11/2013 10:16 PM, David Chase wrote: On 2013-11-26, at

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

2013-11-27 Thread Peter Levart
On 11/27/2013 11:03 AM, David Holmes wrote: Hi Peter, On 27/11/2013 7:20 PM, Peter Levart wrote: On 11/27/2013 08:40 AM, David Holmes wrote: On 27/11/2013 2:16 AM, David Chase wrote: On 2013-11-26, at 8:12 AM, David Chase david.r.ch...@oracle.com wrote: On 2013-11-26, at 7:32 AM, David

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

2013-11-27 Thread David Chase
On 2013-11-27, at 6:53 AM, Peter Levart peter.lev...@gmail.com wrote: Ah, I have misunderstood the back-porting issue. It was not about not having new class but about which existing class to use as a host that might not exist in older version of platform... Sorry for noise. Noise is

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

2013-11-27 Thread Peter Levart
On 11/27/2013 02:40 PM, David Chase wrote: On 2013-11-27, at 6:53 AM, Peter Levart peter.lev...@gmail.com wrote: Ah, I have misunderstood the back-porting issue. It was not about not having new class but about which existing class to use as a host that might not exist in older version of

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

2013-11-26 Thread David Chase
On 2013-11-25, at 9:18 PM, David Holmes david.hol...@oracle.com wrote: We do have the jdk.internal namespace. But I think Unsafe is as good a place as any - though maybe sun.misc.VM is marginally better? Does anyone have any problems with sun.misc.VM as a choice? I have to do a minor revision

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

2013-11-26 Thread David Holmes
On 26/11/2013 9:56 PM, David Chase wrote: On 2013-11-25, at 9:18 PM, David Holmes david.hol...@oracle.com wrote: We do have the jdk.internal namespace. But I think Unsafe is as good a place as any - though maybe sun.misc.VM is marginally better? Does anyone have any problems with

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

2013-11-26 Thread David Chase
On 2013-11-26, at 7:12 AM, David Holmes david.hol...@oracle.com wrote: On 26/11/2013 9:56 PM, David Chase wrote: On 2013-11-25, at 9:18 PM, David Holmes david.hol...@oracle.com wrote: We do have the jdk.internal namespace. But I think Unsafe is as good a place as any - though maybe

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

2013-11-26 Thread David Holmes
On 26/11/2013 10:16 PM, David Chase wrote: On 2013-11-26, at 7:12 AM, David Holmes david.hol...@oracle.com wrote: On 26/11/2013 9:56 PM, David Chase wrote: On 2013-11-25, at 9:18 PM, David Holmes david.hol...@oracle.com wrote: We do have the jdk.internal namespace. But I think Unsafe is as

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

2013-11-26 Thread David Chase
On 2013-11-26, at 7:32 AM, David Holmes david.hol...@oracle.com wrote: On 26/11/2013 10:16 PM, David Chase wrote: On 2013-11-26, at 7:12 AM, David Holmes david.hol...@oracle.com wrote: On 26/11/2013 9:56 PM, David Chase wrote: On 2013-11-25, at 9:18 PM, David Holmes

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

2013-11-26 Thread David Chase
On 2013-11-26, at 8:12 AM, David Chase david.r.ch...@oracle.com wrote: On 2013-11-26, at 7:32 AM, David Holmes david.hol...@oracle.com wrote: On 26/11/2013 10:16 PM, David Chase wrote: On 2013-11-26, at 7:12 AM, David Holmes david.hol...@oracle.com wrote: On 26/11/2013 9:56 PM, David Chase

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

2013-11-26 Thread John Rose
On Nov 22, 2013, at 11:07 AM, David Chase david.r.ch...@oracle.com wrote: Webrev(s): http://cr.openjdk.java.net/~drchase/8016839/webrev-hotspot.01/ http://cr.openjdk.java.net/~drchase/8016839/webrev-jdk.01/ Excellent work. Count me as reviewer, please. — John

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

2013-11-26 Thread David Holmes
On 27/11/2013 2:16 AM, David Chase wrote: On 2013-11-26, at 8:12 AM, David Chase david.r.ch...@oracle.com wrote: On 2013-11-26, at 7:32 AM, David Holmes david.hol...@oracle.com wrote: On 26/11/2013 10:16 PM, David Chase wrote: On 2013-11-26, at 7:12 AM, David Holmes

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

2013-11-25 Thread Paul Sandoz
HI David, Just curious: why did you chose to add the method, throwIllegalAccessError, to s.m.Unsafe and add Unsafe to the list pre-loaded classes rather than modifying an existing pre-loaded class? Paul.

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

2013-11-25 Thread John Rose
On Nov 25, 2013, at 1:49 AM, Paul Sandoz paul.san...@oracle.com wrote: Just curious: why did you chose to add the method, throwIllegalAccessError, to s.m.Unsafe and add Unsafe to the list pre-loaded classes rather than modifying an existing pre-loaded class? Unsafe is used everywhere,

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

2013-11-25 Thread David Holmes
On 26/11/2013 11:29 AM, John Rose wrote: On Nov 25, 2013, at 1:49 AM, Paul Sandoz paul.san...@oracle.com wrote: Just curious: why did you chose to add the method, throwIllegalAccessError, to s.m.Unsafe and add Unsafe to the list pre-loaded classes rather than modifying an existing pre-loaded

RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

2013-11-22 Thread David Chase
Updated request. This is for a bug that it deferred by compilers, but runtime really wants it fixed because they are working in the same area and don't like it at all. In particular, they want it committed to hotspot-rt ASAP (don't want to wait for the multiweek turnaround) and thus the diffs and

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

2013-11-22 Thread Karen Kinnear
David, Thank you so much for finding a way to do this. We do think this is important to get in for 8. And thank you for a way to check the hotspot changes in without waiting for the jdk changes. Code looks good. Couple of minor comments: 1. universe.cpp - when the hotspot change gets in and

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

2013-11-22 Thread David Chase
On 2013-11-22, at 2:56 PM, Karen Kinnear karen.kinn...@oracle.com wrote: David, Thank you so much for finding a way to do this. We do think this is important to get in for 8. And thank you for a way to check the hotspot changes in without waiting for the jdk changes. Code looks good.