Re: RFR : 6799426 : (xs) Add constructor PriorityQueue(Comparator)

2013-08-07 Thread Doug Lea
On 07/25/13 10:15, Doug Lea wrote: On 07/24/13 19:30, Martin Buchholz wrote: PriorityQueue is unusual in that Doug maintains a copy in jsr166 CVS even though it is a non-thread-safe collection. I think it makes sense, because PriorityQueue and PriorityBlockingQueue have parallel APIs and

Re: RFR : 6799426 : (xs) Add constructor PriorityQueue(Comparator)

2013-07-25 Thread Doug Lea
On 07/24/13 19:30, Martin Buchholz wrote: PriorityQueue is unusual in that Doug maintains a copy in jsr166 CVS even though it is a non-thread-safe collection. I think it makes sense, because PriorityQueue and PriorityBlockingQueue have parallel APIs and parallel implementations. Many changes

Re: RFR : 6799426 : (xs) Add constructor PriorityQueue(Comparator)

2013-07-24 Thread Mike Duigou
Yes, and there should be. I will open an issue. Mike On Jul 23 2013, at 17:26 , Alan Bateman wrote: On 22/07/2013 12:24, Mike Duigou wrote: Hello all; A simple rewiew for the addition of another constructor to PriorityQueue. Currently if you wish to specify a Comparator you must also

Re: RFR : 6799426 : (xs) Add constructor PriorityQueue(Comparator)

2013-07-23 Thread Alan Bateman
On 22/07/2013 12:24, Mike Duigou wrote: Hello all; A simple rewiew for the addition of another constructor to PriorityQueue. Currently if you wish to specify a Comparator you must also supply a size. This addition allows use of the default size which is good for two reason; you don't have to

RFR : 6799426 : (xs) Add constructor PriorityQueue(Comparator)

2013-07-22 Thread Mike Duigou
Hello all; A simple rewiew for the addition of another constructor to PriorityQueue. Currently if you wish to specify a Comparator you must also supply a size. This addition allows use of the default size which is good for two reason; you don't have to specify a fixed value and the

Re: RFR : 6799426 : (xs) Add constructor PriorityQueue(Comparator)

2013-07-22 Thread Lance Andersen - Oracle
looks fine Mike Best Lance On Jul 22, 2013, at 3:24 PM, Mike Duigou wrote: Hello all; A simple rewiew for the addition of another constructor to PriorityQueue. Currently if you wish to specify a Comparator you must also supply a size. This addition allows use of the default size which is

Re: RFR : 6799426 : (xs) Add constructor PriorityQueue(Comparator)

2013-07-22 Thread Remi Forax
On 07/22/2013 09:42 PM, Lance Andersen - Oracle wrote: looks fine Mike Best Lance Yes, fine for me too. RĂ©mi On Jul 22, 2013, at 3:24 PM, Mike Duigou wrote: Hello all; A simple rewiew for the addition of another constructor to PriorityQueue. Currently if you wish to specify a Comparator

Re: RFR : 6799426 : (xs) Add constructor PriorityQueue(Comparator)

2013-07-22 Thread Chris Hegarty
On 22/07/2013 20:24, Mike Duigou wrote: Hello all; A simple rewiew for the addition of another constructor to PriorityQueue. Currently if you wish to specify a Comparator you must also supply a size. This addition allows use of the default size which is good for two reason; you don't have to

RFR : 6799426 : (xs) Add constructor PriorityQueue(Comparator)

2013-07-22 Thread Paul Benedict
Mike, I know the description is pulled from the previous constructor, but both sound a bit awkward. Both can probably benefit from an improvement. Currently: Creates a {@code PriorityQueue} with the default initial capacity that orders its elements according to the specified comparator.

Re: RFR : 6799426 : (xs) Add constructor PriorityQueue(Comparator)

2013-07-22 Thread Mike Duigou
Reasonable comment but unfortunately missed my push by mere seconds. I've made a note to correct the docs but will likely wait for some other issue to incorporate it. Mike On Jul 22 2013, at 14:00 , Paul Benedict wrote: Mike, I know the description is pulled from the previous constructor,