Re: RFR [9] 8077332: tidy warnings from javax/xml

2015-04-17 Thread alexander stepanov
Hello Joe, [jw] as I mentioned, pre/pre is needed for the code snippet. Fixed, please see http://cr.openjdk.java.net/~avstepan/8077332/webrev.01/jaxp/src/java.xml/share/classes/javax/xml/stream/XMLStreamReader.java.udiff.html [jw] I saw in a few cases where two @code tags are next to each

Re: RFR [9] 8077332: tidy warnings from javax/xml

2015-04-17 Thread huizhe wang
Hi Alexander, That fixed the issue in the existing Javadoc. The JAXP changes look good now. Thanks for doing this! Best, Joe On 4/17/2015 4:36 AM, alexander stepanov wrote: Hello Joe, [jw] as I mentioned, pre/pre is needed for the code snippet. Fixed, please see

Re: RFR [9] 8077332: tidy warnings from javax/xml

2015-04-17 Thread alexander stepanov
Thanks! Regards, Alexander On 17.04.2015 19:33, huizhe wang wrote: Hi Alexander, That fixed the issue in the existing Javadoc. The JAXP changes look good now. Thanks for doing this! Best, Joe On 4/17/2015 4:36 AM, alexander stepanov wrote: Hello Joe, [jw] as I mentioned, pre/pre is

Re: RFR [9] 8077332: tidy warnings from javax/xml

2015-04-16 Thread alexander stepanov
Please note also that a couple of new files were touched: http://cr.openjdk.java.net/~avstepan/8077332/webrev.01/jaxws/src/java.annotations.common/share/classes/javax/annotation/PostConstruct.java.udiff.html

Re: RFR [9] 8077332: tidy warnings from javax/xml

2015-04-16 Thread alexander stepanov
I'm sorry, two extra files touched - http://cr.openjdk.java.net/~avstepan/8077332/webrev.01/jaxws/src/java.activation/share/classes/javax/activation/MailcapCommandMap.java.udiff.html

Re: RFR [9] 8077332: tidy warnings from javax/xml

2015-04-16 Thread alexander stepanov
Hello Joe, Thanks! as I mentioned, pre/pre is needed for the code snippet. Oh, yes, that was that was forgotten. BTW, have you compiled Yes; some javadoc errors were fixed as well and verified the Javadoc after the changes? Only briefly. So as the above example shows I have to look it over

Re: RFR [9] 8077332: tidy warnings from javax/xml

2015-04-16 Thread alexander stepanov
Hello Lance, Thanks. Regards, Alexander On 16.04.2015 19:58, Lance Andersen wrote: Hi Alexander, These seem to be OK Best Lance On Apr 16, 2015, at 10:07 AM, alexander stepanov alexander.v.stepa...@oracle.com mailto:alexander.v.stepa...@oracle.com wrote: I'm sorry, two extra files

Re: RFR [9] 8077332: tidy warnings from javax/xml

2015-04-16 Thread huizhe wang
Hi Alexander, Looks very good. Thanks for making all the changes! Please note that for the JAXWS, you may need to check with JAXWS/Miran (miroslav@oracle.com). Changes to JAXWS generally goes into the standalone first. They do periodic integration. For the jaxp portion: ---

Re: RFR [9] 8077332: tidy warnings from javax/xml

2015-04-16 Thread Lance Andersen
Hi Alexander, These seem to be OK Best Lance On Apr 16, 2015, at 10:07 AM, alexander stepanov alexander.v.stepa...@oracle.com wrote: I'm sorry, two extra files touched -

Re: RFR [9] 8077332: tidy warnings from javax/xml

2015-04-15 Thread alexander stepanov
Hello Joe, The copyright changes were reverted. Please review the updated fix: http://cr.openjdk.java.net/~avstepan/8077332/webrev.01/ (code/code replaced with {@code}, removed unnecessary /p, used @literal tag). Thanks, Alexander On 13.04.2015 21:19, huizhe wang wrote: On 4/13/2015

Re: RFR [9] 8077332: tidy warnings from javax/xml

2015-04-13 Thread huizhe wang
On 4/13/2015 4:42 AM, Alan Bateman wrote: On 13/04/2015 12:22, alexander stepanov wrote: Hello Joe, Thank you for the notes; Copyright year shall not be changed. That seems to be a bit controversial point; sometimes (while cleaning docs) I was asked to do that, other times - not to do

Re: RFR [9] 8077332: tidy warnings from javax/xml

2015-04-13 Thread alexander stepanov
Thanks! On 10.04.2015 20:07, Sean Mullan wrote: On 04/10/2015 12:01 PM, Alan Bateman wrote: On 10/04/2015 16:50, alexander stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8077332/ for https://bugs.openjdk.java.net/browse/JDK-8077332

Re: RFR [9] 8077332: tidy warnings from javax/xml

2015-04-13 Thread Alan Bateman
On 13/04/2015 12:22, alexander stepanov wrote: Hello Joe, Thank you for the notes; Copyright year shall not be changed. That seems to be a bit controversial point; sometimes (while cleaning docs) I was asked to do that, other times - not to do that. Our internal policy seemingly assigns to

Re: RFR [9] 8077332: tidy warnings from javax/xml

2015-04-13 Thread alexander stepanov
Hello Joe, Thank you for the notes; Copyright year shall not be changed. That seems to be a bit controversial point; sometimes (while cleaning docs) I was asked to do that, other times - not to do that. Our internal policy seemingly assigns to change the 2nd date every time the sources

Re: RFR [9] 8077332: tidy warnings from javax/xml

2015-04-13 Thread alexander stepanov
Hello Alan, Thank you. Regards, Alexander On 10.04.2015 19:01, Alan Bateman wrote: On 10/04/2015 16:50, alexander stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8077332/ for https://bugs.openjdk.java.net/browse/JDK-8077332 Some HTML