Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool

quot; <hotspot-...@openjdk.java.net>, core-libs-dev@openjdk.java.net <mailto:core-libs-dev@openjdk.java.net> Envoyé: Lundi 16 Novembre 2015 23:41:45 Objet: Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool [CC'ing core-libs-dev] On Nov 13, 2015, at 4:55 AM,

Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool

o:christian.thalin...@oracle.com>> À: "Konstantin Shefov" <konstantin.she...@oracle.com> Cc: "hotspot-dev developers" <hotspot-...@openjdk.java.net>, core-libs-dev@openjdk.java.net <mailto:core-libs-dev@openjdk.java.net> Envoyé: Lundi 16 Novembre 2015 23:41

Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool

> On 11 Jan 2016, at 14:34, Konstantin Shefov > wrote: > > Kindly reminder. > > Already approved by C. Thalinger and I. Ignatyev. > JDK changes look ok to me. I would prefer if the JDK test ConstantPoolTest.java could be converted to TestNG using data

Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool

.java.net>, core-libs-dev@openjdk.java.net <mailto:core-libs-dev@openjdk.java.net> Envoyé: Lundi 16 Novembre 2015 23:41:45 Objet: Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool [CC'ing core-libs-dev] On Nov 13, 2015, at 4:55 AM, Konstantin Shefov <konstantin.

Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool

hotspot-dev developers" <hotspot-...@openjdk.java.net>, core-libs-dev@openjdk.java.net <mailto:core-libs-dev@openjdk.java.net> Envoyé: Lundi 16 Novembre 2015 23:41:45 Objet: Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool [CC'ing core-libs-dev] On

Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool

t;>>>>>>> Webrev jdk: http://cr.openjdk.java.net/~kshefov/8141615/jdk/webrev.01 >>>>>>>> <http://cr.openjdk.java.net/%7Ekshefov/8141615/jdk/webrev.01> >>>>>>>> >>>>>>>> Thanks >>>>>>>

Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool

Your suggestion sounds sensibly. >>>>>>> May be it also has sense to make a method >>>>>>> "getMethodRefNameAndTypeIndex(int index)" to acquire name-and-type >>>>>>> entry index for methods also. >>>>>>> >>

Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool

in Shefov" <konstantin.she...@oracle.com <mailto:konstantin.she...@oracle.com>> Cc: "hotspot-dev developers" <hotspot-...@openjdk.java.net <mailto:hotspot-...@openjdk.java.net>>, core-libs-dev@openjdk.java.net <mailto:core-libs-dev@openjdk.java.net> Envoyé

Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool

eOfInvokedynamicRefInfoAt because it only extract the >>>>>> nameAndType value of the InvokeDynamicRef. >>>>>> >>>>>> In term of API, I think it's better to decompose the API, i.e. to have a >>>>>> method >>>>

Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool

an Thalinger" <christian.thalin...@oracle.com> À: "Konstantin Shefov" <konstantin.she...@oracle.com> Cc: "hotspot-dev developers" <hotspot-...@openjdk.java.net>, core-libs-dev@openjdk.java.net Envoyé: Lundi 16 Novembre 2015 23:41:45 Objet: Re: RFR [9] 8141615:

Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool

e-libs-dev@openjdk.java.net Envoyé: Lundi 16 Novembre 2015 23:41:45 Objet: Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool [CC'ing core-libs-dev] On Nov 13, 2015, at 4:55 AM, Konstantin Shefov <konstantin.she...@oracle.com> wrote: Hello Please review an enhancement

Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool

gt;>> Hi Konstantin, >>>>>> Technically, getInvokedynamicRefInfoAt should be >>>>>> getNameAndTypeOfInvokedynamicRefInfoAt because it only extract the >>>>>> nameAndType value of the InvokeDynamicRef. >>>>>> >>>&g

Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool

ev developers" <hotspot-...@openjdk.java.net>, core-libs-dev@openjdk.java.net Envoyé: Lundi 16 Novembre 2015 23:41:45 Objet: Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool [CC'ing core-libs-dev] On Nov 13, 2015, at 4:55 AM, Konstantin Shefov <konstanti

Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool

oracle.com> Cc: "hotspot-dev developers" <hotspot-...@openjdk.java.net>, core-libs-dev@openjdk.java.net Envoyé: Lundi 16 Novembre 2015 23:41:45 Objet: Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool [CC'ing core-libs-dev] On Nov 13, 2015, at 4:55 AM, Kons

Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool

gt; > - Mail original - >> De: "Christian Thalinger" <christian.thalin...@oracle.com> >> À: "Konstantin Shefov" <konstantin.she...@oracle.com> >> Cc: "hotspot-dev developers" <hotspot-...@openjdk.java.net>, &

Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool

> Cc: "hotspot-dev developers" <hotspot-...@openjdk.java.net>, core-libs-dev@openjdk.java.net Envoyé: Lundi 16 Novembre 2015 23:41:45 Objet: Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool [CC'ing core-libs-dev] On Nov 13, 2015, at 4:55 AM, Konstantin Shefov &

Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool

Looks good to me. In an unmodularized world I would think twice before adding the hotspot specific tags. (I'm not a HotSpot Reviewer). cheers /Joel On Mon, Nov 16, 2015 at 11:41 PM, Christian Thalinger wrote: > [CC'ing core-libs-dev] > >> On Nov 13, 2015, at

Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool

;konstantin.she...@oracle.com> > Cc: "hotspot-dev developers" <hotspot-...@openjdk.java.net>, > core-libs-dev@openjdk.java.net > Envoyé: Lundi 16 Novembre 2015 23:41:45 > Objet: Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool > > [CC'

Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool

[CC'ing core-libs-dev] > On Nov 13, 2015, at 4:55 AM, Konstantin Shefov > wrote: > > Hello > > Please review an enhancement to add three new methods to > sun.reflect.ConstantPool class. > The following methods are suggested: > > public String[]