Re: RFR 15: 8243010: Test support: Customizable Hex Printer

2020-04-24 Thread Daniel Fuchs
Hi Roger, On 23/04/2020 19:46, Roger Riggs wrote: A review would be appreciated. Ship it! cheers, -- daniel

Re: RFR 15: 8243010: Test support: Customizable Hex Printer

2020-04-23 Thread Lance Andersen
Hi Roger, Sorry, I thought I replied. I think this looks good and I look forward to using it more going forward. +1 from me Best Lance > On Apr 23, 2020, at 2:46 PM, Roger Riggs wrote: > > Ping... > > I appreciate the comments about extending the functionality and uses and will > take

Re: RFR 15: 8243010: Test support: Customizable Hex Printer

2020-04-23 Thread Roger Riggs
Ping... I appreciate the comments about extending the functionality and uses and will take them up as a separate enhancement. A review would be appreciated. Thanks, Roger On 4/16/20 3:17 PM, Roger Riggs wrote: Please review[2] and comment on a new Hex printing utility to support OpenJDK

Re: RFR 15: 8243010: Test support: Customizable Hex Printer

2020-04-17 Thread Lance Andersen
Hi Roger, I think tackling this via the new Developer’s guide project makes sense as it would help folks re-inventing the wheel and making it easier to find what already exists. Best Lance > On Apr 17, 2020, at 12:55 PM, Roger Riggs wrote: > > Hi Lance, > > The test library is a bit of a

Re: RFR 15: 8243010: Test support: Customizable Hex Printer

2020-04-17 Thread Roger Riggs
Hi Pavel, Thanks for the scan of potential replacements. I'll take a look and file followup issues for candidates for cleanup. Some are going to be sensitive to the specific formatting. Roger On 4/17/20 11:36 AM, Pavel Rappo wrote: On 17 Apr 2020, at 15:11, Roger Riggs wrote: Hi Pavel, On

Re: RFR 15: 8243010: Test support: Customizable Hex Printer

2020-04-17 Thread Roger Riggs
Hi Lance, The test library is a bit of a black box usually approached from the angle of existing tests. And unfortunately, there is a lower bar for documentation and API development. Perhaps an item to be looked at as part of the new developer guide project. Thanks, Roger On 4/17/20 11:34

Re: RFR 15: 8243010: Test support: Customizable Hex Printer

2020-04-17 Thread Pavel Rappo
> On 17 Apr 2020, at 15:11, Roger Riggs wrote: > > Hi Pavel, > > On 4/17/20 8:27 AM, Pavel Rappo wrote: >> Hi Roger, >> >> First of all, many thanks for doing this. After skimming through that webrev >> I have two comments. >> >> 1. It might make sense to beef this up with more retrofitted

Re: RFR 15: 8243010: Test support: Customizable Hex Printer

2020-04-17 Thread Lance Andersen
Hi Roger, Thank you for creating this as it looks good. A couple of quick questions - Will the javadoc be hosted somewhere - Maybe I have not stumbled onto it yet, but is there a document/wiki somewhere that describes all of the useful test libraries vs discovering as you go? Best Lance >

Re: RFR 15: 8243010: Test support: Customizable Hex Printer

2020-04-17 Thread Roger Riggs
Hi Pavel, On 4/17/20 8:27 AM, Pavel Rappo wrote: Hi Roger, First of all, many thanks for doing this. After skimming through that webrev I have two comments. 1. It might make sense to beef this up with more retrofitted tests, so people could more clearly see how applicable this API is. If

Re: RFR 15: 8243010: Test support: Customizable Hex Printer

2020-04-17 Thread Pavel Rappo
Hi Roger, First of all, many thanks for doing this. After skimming through that webrev I have two comments. 1. It might make sense to beef this up with more retrofitted tests, so people could more clearly see how applicable this API is. If you'd like I could help you with looking for those

RFR 15: 8243010: Test support: Customizable Hex Printer

2020-04-16 Thread Roger Riggs
Please review[2] and comment on a new Hex printing utility to support OpenJDK tests. The usefulness of a hex printing has been discussed from time to time with many suggestions as to the API shape and features. To get an idea of the API and features, take a look at the javadoc[1]. It covers the