Re: RFR 8165726: fix for 8165595 revealed a bug in pack200 tool's handling of main class attribute of module-info classes

2016-09-09 Thread Alan Bateman
On 09/09/2016 19:15, Kumar Srinivasan wrote: Looks good, thanks for taking care of it. We need to double check these again, I will take a closer look later. It's a CONSTANT_Class_info so I think it's right. It would be good to check the others as it's easy to get these wrong, maybe additional

Re: RFR 8165726: fix for 8165595 revealed a bug in pack200 tool's handling of main class attribute of module-info classes

2016-09-09 Thread Kumar Srinivasan
Looks good, thanks for taking care of it. We need to double check these again, I will take a closer look later. Kumar On 9/9/2016 9:36 AM, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8165726/webrev.01/ for

RFR 8165726: fix for 8165595 revealed a bug in pack200 tool's handling of main class attribute of module-info classes

2016-09-09 Thread Sundararajan Athijegannathan
Please review http://cr.openjdk.java.net/~sundar/8165726/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8165726 Thanks, -Sundar