Re: RFR 8198669: Refactor annotation array value parsing to reduce duplication

2018-06-18 Thread Joseph D. Darcy
Looks good Liam; thanks, -Joe On 6/15/2018 10:58 AM, Liam Miller-Cushon wrote: Hello, This change is a follow-up to JDK-7183985 which replaces the interior of parseClassArray, parseEnumArray, and parseAnnotationArray with a shared method that is passed a lambda for the type-specific parsing

Re: RFR 8198669: Refactor annotation array value parsing to reduce duplication

2018-06-15 Thread Paul Sandoz
> On Jun 15, 2018, at 2:31 PM, Liam Miller-Cushon wrote: > > On Fri, Jun 15, 2018 at 1:44 PM Paul Sandoz > wrote: > A nice cleanup. Did you run any tiered tests just to double check that the > use of lambdas causes no bootstrapping issues? (i suspect it

Re: RFR 8198669: Refactor annotation array value parsing to reduce duplication

2018-06-15 Thread Paul Sandoz
+1 A nice cleanup. Did you run any tiered tests just to double check that the use of lambdas causes no bootstrapping issues? (i suspect it probably does not). Paul. > On Jun 15, 2018, at 10:58 AM, Liam Miller-Cushon wrote: > > Hello, > > This change is a follow-up to JDK-7183985 which