Re: RFR 8205547 : FileChannel/CleanerTest.java fails due to expected FD count

Thanks Paul, I'll add a comment. On 6/25/2018 2:26 PM, Paul Sandoz wrote: On Jun 25, 2018, at 11:08 AM, Roger Riggs > wrote: Hi Paul, Updated the webrev in place: http://cr.openjdk.java.net/~rriggs/webrev-fd-count-wrong-8205547/ On 6/25/2018 1:41 PM, Paul

Re: RFR 8205547 : FileChannel/CleanerTest.java fails due to expected FD count

> On Jun 25, 2018, at 11:08 AM, Roger Riggs wrote: > > Hi Paul, > > Updated the webrev in place: > http://cr.openjdk.java.net/~rriggs/webrev-fd-count-wrong-8205547/ > > > On 6/25/2018 1:41 PM, Paul Sandoz wrote: >> Hi

Re: RFR 8205547 : FileChannel/CleanerTest.java fails due to expected FD count

Hi Paul, Updated the webrev in place:   http://cr.openjdk.java.net/~rriggs/webrev-fd-count-wrong-8205547/ On 6/25/2018 1:41 PM, Paul Sandoz wrote: Hi Roger, Are you missing the throwing of an exception when the fdCount != fdCount0? (and relatedly i could not tell if the print statements were

Re: RFR 8205547 : FileChannel/CleanerTest.java fails due to expected FD count

Hi Roger, Are you missing the throwing of an exception when the fdCount != fdCount0? (and relatedly i could not tell if the print statements were for temporary debugging and you intended to remove them) Since you check before hand for support of UnixOperatingSystemMXBean there appears no need

RFR 8205547 : FileChannel/CleanerTest.java fails due to expected FD count

Please review a test improvement to avoid unexpected file opens/closes during the file channel CleanerTest. The test now follows the pattern of the other java/io/File*/UnreferencedXXXClosesFd tests by waiting for the cleaner and file descriptors to be reclaimed by GC. Webrev: