Re: RFR 8251989: Hex formatter and parser utility

2020-08-27 Thread Roger Riggs
Hi Peter, I made the same observation when exploring the API and ended up concluding that the declared exceptions on Appendable made the API much harder to use. Though the formatted characters can't be directly accumulated in the Appendable it is possible to build the output in a StringBuilder

Re: RFR 8251989: Hex formatter and parser utility

2020-08-27 Thread Roger Riggs
-dev@openjdk.java.net>> Subject: RFR 8251989: Hex formatter and parser utility Message-ID: <6378b60b-7a45-d8b0-5ebd-3d3bf9144...@oracle.com <mailto:6378b60b-7a45-d8b0-5ebd-3d3bf9144...@oracle.com>> Content-Type: text/plain; charset=utf-8; format=flowed Please review updates to

Re: RFR 8251989: Hex formatter and parser utility

2020-08-27 Thread Roger Riggs
Hi Chris, On 8/27/20 9:20 AM, Chris Hegarty wrote: Roger, On 27 Aug 2020, at 02:34, Roger Riggs wrote: Please review updates to the formatting and parsing API based on the last round of comments. There are many changes, so it may be useful to read it as a fresh draft. - Rename classes:

Re: RFR 8251989: Hex formatter and parser utility

2020-08-27 Thread Peter Levart
Hi Roger, About methods in Hex.Formatter that append to StringBuilder, like the following one:     public StringBuilder format​(StringBuilder sb, byte[] bytes) ...I was thinking that such method could have more utility if it was specified as:     public A format(A appendable, byte[]

Re: RFR 8251989: Hex formatter and parser utility

2020-08-27 Thread Douglas Surber
libs-dev-requ...@openjdk.java.net wrote: > > Message: 1 > Date: Wed, 26 Aug 2020 21:34:47 -0400 > From: Roger Riggs mailto:roger.ri...@oracle.com>> > To: core-libs-dev <mailto:core-libs-dev@openjdk.java.net>> > Subject: RFR 8251989: Hex formatter and parser util

Re: RFR 8251989: Hex formatter and parser utility

2020-08-27 Thread Chris Hegarty
Roger, > On 27 Aug 2020, at 02:34, Roger Riggs wrote: > > Please review updates to the formatting and parsing API based on the last > round of comments. > There are many changes, so it may be useful to read it as a fresh draft. > > - Rename classes: Encoder -> Formatter; Decoder -> Parser >

RFR 8251989: Hex formatter and parser utility

2020-08-26 Thread Roger Riggs
Please review updates to the formatting and parsing API based on the last round of comments. There are many changes, so it may be useful to read it as a fresh draft.  - Rename classes: Encoder -> Formatter; Decoder -> Parser  - Rename methods: encode -> format; decode -> parse, etc.  - Rename