On 17/04/2015 20:12, Roger Riggs wrote:
The webrev for ProcessAPI updates has been updated to reflect recent
comments.
Please review and comment by April 23rd.
The updates include:
- Renaming Process/ProcessHandle supportsDestroyForcibly to
supportsNormalTermination
and updating related
Hi Alan,
On 4/24/2015 8:06 AM, Alan Bateman wrote:
On 17/04/2015 20:12, Roger Riggs wrote:
The webrev for ProcessAPI updates has been updated to reflect recent
comments.
Please review and comment by April 23rd.
The updates include:
- Renaming Process/ProcessHandle supportsDestroyForcibly
On 24/04/2015 16:49, Roger Riggs wrote:
:
I'm not sure about the @implSpec in
Process::supportsNormalTermination. Shouldn't that just specify that
the default implementation throws UOE. An @implNote could comment on
how ProcessBuilder works. Same comment on Process::toHandle.
There needs
Hi Alan,
On 4/24/2015 12:21 PM, Alan Bateman wrote:
On 24/04/2015 16:49, Roger Riggs wrote:
:
I'm not sure about the @implSpec in
Process::supportsNormalTermination. Shouldn't that just specify that
the default implementation throws UOE. An @implNote could comment on
how ProcessBuilder
Hi Paul,
On 4/21/2015 8:29 AM, Paul Sandoz wrote:
There are statements in Process about the specified behavior of
Processes created by ProcessBuilder. That's why I included them in the
@implSpec clause. If @implSpec is only for the specifics of the method
itself then where should the behavior
On Apr 21, 2015, at 2:57 PM, Roger Riggs roger.ri...@oracle.com wrote:
Hi Paul,
On 4/21/2015 8:29 AM, Paul Sandoz wrote:
There are statements in Process about the specified behavior of Processes
created by ProcessBuilder. That's why I included them in the @implSpec
clause. If @implSpec
Hi Paul,
The onExit() @implNote recommends the subclass delegate to the
underlying process.
For a simple subclass acting as a proxy or decorator that will provide
the best implementation.
I'll add the onExit() method to the class level recommendation for
Subclasses of Process.
Thanks,
Hi Roger,
small remark, I see you at a number of places using the same pattern when
reading information from /proc:
342 ret = fread(psinfo, 1, (sizeof psinfo), fp);
343 fclose(fp);
344 if (ret 0) {
345 return;
346 }
A better way would be to check for the whole size
Hi Thomas,
Good point and more robust.
Thanks, Roger
On 4/21/2015 11:49 AM, Thomas Stüfe wrote:
Hi Roger,
small remark, I see you at a number of places using the same pattern
when reading information from /proc:
342 ret = fread(psinfo, 1, (sizeof psinfo), fp);
343 fclose(fp);
Hi Roger,
I am not sure you have the @implSpec/@implNote quite correct on the new methods
of Process.
For example, for Process.toHandle i would expect something like:
...
@implSpec
This implementation throws an instance of UnsupportedOperationException and
performs no other action.
Hi Paul,
There are statements in Process about the specified behavior of Processes
created by ProcessBuilder. That's why I included them in the @implSpec
clause.
If @implSpec is only for the specifics of the method itself then where
should the behavior of ProcessBuilder created instances be
On Apr 20, 2015, at 5:49 PM, Roger Riggs roger.ri...@oracle.com wrote:
Hi Paul,
On 4/20/2015 9:01 AM, Paul Sandoz wrote:
Hi Roger,
I am not sure you have the @implSpec/@implNote quite correct on the new
methods of Process.
For example, for Process.toHandle i would expect something
Hi Paul,
On 4/20/2015 9:01 AM, Paul Sandoz wrote:
Hi Roger,
I am not sure you have the @implSpec/@implNote quite correct on the new methods
of Process.
For example, for Process.toHandle i would expect something like:
...
@implSpec
This implementation throws an instance of
On Apr 20, 2015, at 7:33 PM, Roger Riggs roger.ri...@oracle.com wrote:
Hi Paul,
There are statements in Process about the specified behavior of Processes
created by ProcessBuilder. That's why I included them in the @implSpec
clause.
If @implSpec is only for the specifics of the method
Hi Paul,
On 4/20/2015 2:26 PM, Paul Sandoz wrote:
On Apr 20, 2015, at 7:33 PM, Roger Riggs roger.ri...@oracle.com wrote:
Hi Paul,
There are statements in Process about the specified behavior of Processes
created by ProcessBuilder. That's why I included them in the @implSpec clause.
If
The webrev for ProcessAPI updates has been updated to reflect recent
comments.
Please review and comment by April 23rd.
The updates include:
- Renaming Process/ProcessHandle supportsDestroyForcibly to
supportsNormalTermination
and updating related descriptions
-
16 matches
Mail list logo
