Re: Race condition in TimerTask KillThread test

2011-11-10 Thread David Holmes
On 10/11/2011 9:50 PM, Gary Adams wrote: On 11/10/11 2:22 AM, David Holmes wrote: Aside: it would be good if whomever is going to do the commits for you could assist with publishing webrevs for these changes. There was a bulk request to add Vivian's team to the openjdk authors list that may

Re: Race condition in TimerTask KillThread test

2011-11-09 Thread Gary Adams
Here's a revised diff for the KillThread timing problem : - added current CR# to @bug tag - capture the thread from the timer task - wait for the timertask thread to be visible to the main thread then join the thread before fall through to attempt the second timertask schedule

Re: Race condition in TimerTask KillThread test

2011-11-09 Thread David Holmes
Hi Gary, On 10/11/2011 5:36 AM, Gary Adams wrote: Here's a revised diff for the KillThread timing problem : - added current CR# to @bug tag I don't think that is correct. AFAIK the @bug indicates what bug this test is testing the fix for, not which bugs modified the test. (Ditto for your

Re: Race condition in TimerTask KillThread test

2011-11-06 Thread David Holmes
On 5/11/2011 8:37 AM, Alan Bateman wrote: On 04/11/2011 15:52, Gary Adams wrote: : I'll attempt a simple fix for the KillThread case by replacing : Thread.sleep(100); with a simple loop do { Thread.sleep(100); } while (waiting); where the TimerTask runnable will clear the flag with waiting

Race condition in TimerTask KillThread test

2011-11-04 Thread Gary Adams
I'm taking a look at some older timing based bugs that may cause problems on slower machines 6818464: TEST_BUG: Timeout values in several java/util tests are insufficient I'd like to split this bug into two, based on the example problems that are mentioned in the bug report. The first example

Re: Race condition in TimerTask KillThread test

2011-11-04 Thread Alan Bateman
On 04/11/2011 15:52, Gary Adams wrote: : I'll attempt a simple fix for the KillThread case by replacing : Thread.sleep(100); with a simple loop do { Thread.sleep(100); } while (waiting); where the TimerTask runnable will clear the flag with waiting = false once