Re: Request Review for small change to remove 2 warnings in rmic

2011-08-18 Thread Alan Bateman
Mandy Chung wrote: Thumbs up from me. Are you going to include this change with another CR that you have a fix to be pushed? Mandy I think it's best to separate this fix and so I've created the following to track it: 7080622: Remove varargs warnings from rmic -Alan.

Fwd: Re: Request Review for small change to remove 2 warnings in rmic

2011-08-18 Thread Sebastian Sickelmann
Sorry. Does't Poster it to the list Original-Nachricht Betreff: Re: Request Review for small change to remove 2 warnings in rmic Von: Sebastian Sickelmann sebastian.sickelm...@gmx.de An: Alan Bateman alan.bate...@oracle.com CC: I updated my Patch so that it handles all

Re: Request Review for small change to remove 2 warnings in rmic

2011-08-18 Thread Mandy Chung
On 8/17/11 9:46 PM, Sebastian Sickelmann wrote: Are you going to include this change with another CR that you have a fix to be pushed? Is the CR to small, or what is the reason for your question? I was just curious which CR this change is going into since it's not mentioned in your email.

Request Review for small change to remove 2 warnings in rmic

2011-08-17 Thread Sebastian Sickelmann
Hi while searching if i created warnings with an change i have seen that there are 2 warnings in rmic that are easy to remove. Please review this hg export (no webrev unfortunately, because my free-file-host-provider is out of service :-( ) # HG changeset patch # User Sebastian # Date

Re: Request Review for small change to remove 2 warnings in rmic

2011-08-17 Thread Mandy Chung
Thumbs up from me. Are you going to include this change with another CR that you have a fix to be pushed? Mandy On 8/17/11 3:45 PM, Sebastian Sickelmann wrote: Hi while searching if i created warnings with an change i have seen that there are 2 warnings in rmic that are easy to remove.

Re: Request Review for small change to remove 2 warnings in rmic

2011-08-17 Thread Sebastian Sickelmann
Am 18.08.2011 06:46, schrieb Sebastian Sickelmann: Am 18.08.2011 00:52, schrieb Mandy Chung: Thumbs up from me. Are you going to include this change with another CR that you have a fix to be pushed? I have some other improved that are reviewed by Joe actually. But there are on a completly