Looks good to me - approved.
Thanks
Kumar
Hopefully all interested parties are addressed in the cc lists.
webrev at:
http://cr.openjdk.java.net/~dholmes/7022370/webrev/
The launcher ergonomics (ergo.c) currently relies on per-architecture,
eg ergo_sparc.c, ergo_i586.c, files to define the
There was a glitch with the use of CTARGDIR (which isn't defined), so
now we check for the ergo file in LAUNCHER_PLATFORM_SRC. Webrev has been
updated - same location.
Verified with i586 and non-i586 builds.
Thanks,
David
Gary Benson said the following on 03/07/11 19:57:
Hi David,
I'm good
On 3/7/11 10:10 PM, David Holmes wrote:
There was a glitch with the use of CTARGDIR (which isn't defined), so
now we check for the ergo file in LAUNCHER_PLATFORM_SRC. Webrev has
been updated - same location.
Looks good. Sorry I didn't catch that CTARGDIR isn't defined as it
exists in the
Looks good.
Kumar
There was a glitch with the use of CTARGDIR (which isn't defined), so
now we check for the ergo file in LAUNCHER_PLATFORM_SRC. Webrev has
been updated - same location.
Verified with i586 and non-i586 builds.
Thanks,
David
Gary Benson said the following on 03/07/11 19:57:
Hi David,
I'm good with these changes, and I'm happy for ergo_zero.c to vanish.
Thanks,
Gary
David Holmes wrote:
Hopefully all interested parties are addressed in the cc lists.
webrev at:
http://cr.openjdk.java.net/~dholmes/7022370/webrev/
The launcher ergonomics (ergo.c) currently
Looks good to me.
Mandy
On 3/3/11 10:33 PM, David Holmes wrote:
Hopefully all interested parties are addressed in the cc lists.
webrev at:
http://cr.openjdk.java.net/~dholmes/7022370/webrev/
The launcher ergonomics (ergo.c) currently relies on per-architecture,
eg ergo_sparc.c,
Hopefully all interested parties are addressed in the cc lists.
webrev at:
http://cr.openjdk.java.net/~dholmes/7022370/webrev/
The launcher ergonomics (ergo.c) currently relies on per-architecture,
eg ergo_sparc.c, ergo_i586.c, files to define the actual ergonomics
operations. Only x86 is
