Hello Dima,
Yes that would be helpful and appreciated. There is another patch to the same
files that I will be looking into, but the changes are disjoint so there should
not be a significant merge issue.
Thanks,
Brian
On Feb 21, 2013, at 7:27 PM, Dmitry Nadezhin wrote:
Do you want that I
Brian,
Class FloatingDecimal contains both conversion from String to
float/double and conversion from float/double to String.
My change is in conversion from String to float/double.
The methods if FloatingDecimal that implement this conversion are:
static FloatingDecimal readJavaFormatString(
Dima,
If the methods are definitely unused that would be correct. I suppose if a
clean build of the JDK does not complain then it is acceptable and correct.
Thanks,
Brian
On Feb 22, 2013, at 9:41 AM, Dmitry Nadezhin wrote:
So I think that the required change in FormattedFloatingDecimal is
Dima,
Great! Thanks. I will take a look later and re-post the review.
Brian
On Feb 22, 2013, at 12:29 PM, Dmitry Nadezhin wrote:
Brian,
I removed unused methods and fields from FormattedFloatingDecimal.
JDK build passes.
The result of hg diff is attached.
-Dima
On Fri, Feb 22,
I am withdrawing this patch for the time being as properly the changes should
also go into the fork sun.misc.FormattedFloatingDecimal. I'll post an updated
patch once it is available.
Thanks,
Brian
On Feb 14, 2013, at 5:23 PM, Brian Burkhalter wrote:
The patch below is as submitted to
Do you want that I prepare this FloatingDecimal/FormattedFloatingDecimal patch ?
-Dima
On Fri, Feb 22, 2013 at 2:32 AM, Brian Burkhalter
brian.burkhal...@oracle.com wrote:
I am withdrawing this patch for the time being as properly the changes should
also go into the fork
The patch below is as submitted to OpenJDK bugzilla but with enhanced comments.
It pertains to the correction loop in the doubleValue() method of
FloatingDecimal. The situation appears to arise when the candidate value is
less than 2*Double.MIN_NORMAL as for such values the ULP is less than
