Re: Review request for 6810254

2009-03-06 Thread Mandy Chung
Thanks Alan. This is a good approach that avoids using reflection and addresses David's concern. I was a bit aggressive to lazily instantiate Java*Access objects as many as I can. I'll revise the fix and send out a new webrev. Thanks Mandy Alan Bateman wrote: Mandy Chung wrote: 6810254:

Re: Review request for 6810254

2009-03-05 Thread David Holmes - Sun Microsystems
Hi Mandy, Note that my main concern is the use of reflection. If the class involved has not previously had it's reflection objects initialized then getDeclaredMethod can lead to a lot of native and Java-level allocation (I'm assuming this hasn't changed a great deal from the Java 5 code).