Re: argfiles parsing broken for argfiles > 4096 bytes

2020-03-05 Thread Henry Jen
Thanks for the report and investigation, bug confirmed, JDK-8240629 is filed to tacking the issue. https://bugs.openjdk.java.net/browse/JDK-8240629 Cheers, Henry > On Mar 5, 2020, at 11:43 AM, Robert Stupp wrote: > > Another note: I've also seen it appending a comment-line in >

Re: argfiles parsing broken for argfiles > 4096 bytes

2020-03-05 Thread Robert Stupp
Another note: I've also seen it appending a comment-line in http://hg.openjdk.java.net/jdk-updates/jdk11u/annotate/20e49753c388/src/java.base/share/native/libjli/args.c#l296 with pctx->state==IN_COMMENT, but wasn't able to reconstruct the behavior with a "clean" argfile. But that behavior was also

Re: argfiles parsing broken for argfiles > 4096 bytes

2020-03-05 Thread Robert Stupp
Sorry for the broken formatting... I recently came across a bug in the java executable with an argfile that's larger than 4096 bytes, if a 4096-byte-chunk ends in a comment line. The bug happens when the last character of a comment line is the 4096th byte and the trailing newline is the first

argfiles parsing broken for argfiles > 4096 bytes

2020-03-05 Thread Robert Stupp
Hi, I recently came across a bug in the java executable with an argfile that's larger than 4096 bytes, if a 4096-byte-chunk ends in a comment line. One bug happens when the last character of a comment line is the 4096th byte and the trailing newline is the first byte in the next chunk. In that