Re: core-libs-dev New constructor in sun.tools.java.ClassPath builds a path using File.separator instead of File.pathSeparatorChar

2012-04-14 Thread Alan Bateman
On 13/04/2012 10:14, Charles Lee wrote: Hi Alan, The patch is @ http://cr.openjdk.java.net/~littlee/7161282/webrev.00/ http://cr.openjdk.java.net/%7Elittlee/7161282/webrev.00/ Please help reviewing it :-) Looks okay to me, thanks for moving it. -Alan

Re: core-libs-dev New constructor in sun.tools.java.ClassPath builds a path using File.separator instead of File.pathSeparatorChar

2012-04-13 Thread Alan Bateman
On 13/04/2012 03:21, Charles Lee wrote: On 04/12/2012 04:26 PM, Alan Bateman wrote: On 12/04/2012 08:22, Deven You wrote: I have verified this commit. Thanks Alan and Charles! The change-set that Charles pushed added test/sun/tools/classpath/ RMICClassPathTest.java but I didn't see it in the

Re: core-libs-dev New constructor in sun.tools.java.ClassPath builds a path using File.separator instead of File.pathSeparatorChar

2012-04-12 Thread Charles Lee
On 04/11/2012 03:44 PM, Deven You wrote: On 04/10/2012 04:12 PM, Alan Bateman wrote: On 09/04/2012 10:32, Deven You wrote: : The issue is reported by one of our test team which maintains a set of ORB test cases. Okay but I guess I'm still a bit curious as it's not obvious that rmic (or

Re: core-libs-dev New constructor in sun.tools.java.ClassPath builds a path using File.separator instead of File.pathSeparatorChar

2012-04-12 Thread Deven You
I have verified this commit. Thanks Alan and Charles! On 04/12/2012 03:12 PM, Charles Lee wrote: On 04/11/2012 03:44 PM, Deven You wrote: On 04/10/2012 04:12 PM, Alan Bateman wrote: On 09/04/2012 10:32, Deven You wrote: : The issue is reported by one of our test team which maintains a

Re: core-libs-dev New constructor in sun.tools.java.ClassPath builds a path using File.separator instead of File.pathSeparatorChar

2012-04-12 Thread Alan Bateman
On 12/04/2012 08:22, Deven You wrote: I have verified this commit. Thanks Alan and Charles! The change-set that Charles pushed added test/sun/tools/classpath/ RMICClassPathTest.java but I didn't see it in the original webrev. I see now that your original mail had the proposed test in a

Re: core-libs-dev New constructor in sun.tools.java.ClassPath builds a path using File.separator instead of File.pathSeparatorChar

2012-04-12 Thread Deven You
Hi Alan, I choose the test/sun/tools/classpath/ RMICClassPathTest.java because the fix is made in sun.tools.java.ClassPath. However the test case uses BatchEnvironment.createClassPath to create a new ClassPath. I think test/sun/tools/classpath/ is more closer to sun.tools.java.ClassPath.

Re: core-libs-dev New constructor in sun.tools.java.ClassPath builds a path using File.separator instead of File.pathSeparatorChar

2012-04-12 Thread Charles Lee
On 04/12/2012 04:26 PM, Alan Bateman wrote: On 12/04/2012 08:22, Deven You wrote: I have verified this commit. Thanks Alan and Charles! The change-set that Charles pushed added test/sun/tools/classpath/ RMICClassPathTest.java but I didn't see it in the original webrev. I see now that your

Re: core-libs-dev New constructor in sun.tools.java.ClassPath builds a path using File.separator instead of File.pathSeparatorChar

2012-04-11 Thread Deven You
On 04/10/2012 04:12 PM, Alan Bateman wrote: On 09/04/2012 10:32, Deven You wrote: : The issue is reported by one of our test team which maintains a set of ORB test cases. Okay but I guess I'm still a bit curious as it's not obvious that rmic (or rmic --iiop) invokes toString, maybe this is

Re: core-libs-dev New constructor in sun.tools.java.ClassPath builds a path using File.separator instead of File.pathSeparatorChar

2012-04-10 Thread Alan Bateman
On 09/04/2012 10:32, Deven You wrote: : The issue is reported by one of our test team which maintains a set of ORB test cases. Okay but I guess I'm still a bit curious as it's not obvious that rmic (or rmic --iiop) invokes toString, maybe this is a white box test or a test that is using

core-libs-dev New constructor in sun.tools.java.ClassPath builds a path using File.separator instead of File.pathSeparatorChar

2012-04-09 Thread Deven You
Hi core-libs-devs, There are 2 sun bugs related to this issue: http://bugs.sun.com/view_bug.do;jsessionid=663548580556ae43f50bf92c75b5?bug_id=6695325^and http://bugs.sun.com/view_bug.do;jsessionid=663548580556ae43f50bf92c75b5?bug_id=6610897^ The basic problem is that the new

Re: core-libs-dev New constructor in sun.tools.java.ClassPath builds a path using File.separator instead of File.pathSeparatorChar

2012-04-09 Thread Alan Bateman
On 09/04/2012 08:01, Deven You wrote: Hi core-libs-devs, There are 2 sun bugs related to this issue: http://bugs.sun.com/view_bug.do;jsessionid=663548580556ae43f50bf92c75b5?bug_id=6695325^and

Re: core-libs-dev New constructor in sun.tools.java.ClassPath builds a path using File.separator instead of File.pathSeparatorChar

2012-04-09 Thread Deven You
On 04/09/2012 05:03 PM, Alan Bateman wrote: On 09/04/2012 08:01, Deven You wrote: Hi core-libs-devs, There are 2 sun bugs related to this issue: http://bugs.sun.com/view_bug.do;jsessionid=663548580556ae43f50bf92c75b5?bug_id=6695325^and