Re: core-libs-dev sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-05-17 Thread Dmitry Samersoff
Deven, The fix is submitted to openjdk tl workspace http://hg.openjdk.java.net/jdk8/tl/jdk/rev/df33f5f750ec -Dmitry On 2012-04-26 05:21, Deven You wrote: Hi Dmitry, Thanks for your help. I have created a CR with internal id 2236492 which hasn't be published yet. So please set this

Re: core-libs-dev sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-05-17 Thread Deven You
Hi Dmitry, I have verified the change set. Thanks for your commit! On 05/17/2012 03:44 PM, Dmitry Samersoff wrote: Deven, The fix is submitted to openjdk tl workspace http://hg.openjdk.java.net/jdk8/tl/jdk/rev/df33f5f750ec -Dmitry On 2012-04-26 05:21, Deven You wrote: Hi Dmitry,

Re: core-libs-dev sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-04-26 Thread Dmitry Samersoff
Deven, Thank you! On 2012-04-26 05:21, Deven You wrote: Hi Dmitry, Thanks for your help. I have created a CR with internal id 2236492 which hasn't be published yet. So please set this internal CR id as duplicate to 716419 as well. This is the original mail for this problem:

Re: core-libs-dev sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-04-25 Thread Dmitry Samersoff
Deven, CR number is 7164191 . Could you re-send me your original e-mail with problem description and webrev link. I'll put it to CR comment field. -Dmitry On 2012-04-24 16:15, Dmitry Samersoff wrote: Deven, After close look and off-line discussion with David Holmes, the changes

Re: core-libs-dev sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-04-25 Thread Deven You
Hi Dmitry, Thanks for your help. I have created a CR with internal id 2236492 which hasn't be published yet. So please set this internal CR id as duplicate to 716419 as well. This is the original mail for this problem:

Re: core-libs-dev sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-04-24 Thread Dmitry Samersoff
Deven, After close look and off-line discussion with David Holmes, the changes looks good for me. I'll take care of the rest. We have one more place in Agent.java executing exactly the same code so I'll change both of them on your behalf. -Dmitry On 2012-04-23 11:43, Deven You wrote:

Re: core-libs-dev sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-04-23 Thread David Holmes
Deven, On 23/04/2012 3:54 PM, Deven You wrote: On 04/18/2012 02:20 PM, Deven You wrote: On 04/18/2012 01:34 PM, Mandy Chung wrote: I think this could still run into CME. System Properties is not a synchronized map and the setter methods (System.setProperty or Properties.put method) doesn't

Re: core-libs-dev sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-04-23 Thread David Holmes
Except of course that Properties is a Hashtable and synchronizes on 'this' for all public methods. So locking the properties object in the client code will guarantee exclusive access to it. Sorry about that. David - On 23/04/2012 4:30 PM, David Holmes wrote: Deven, On 23/04/2012 3:54

Re: core-libs-dev sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-04-23 Thread Deven You
Thanks David, So is it ok for you to contribute this patch? On 04/23/2012 02:36 PM, David Holmes wrote: Except of course that Properties is a Hashtable and synchronizes on 'this' for all public methods. So locking the properties object in the client code will guarantee exclusive access to it.

Re: core-libs-dev sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-04-23 Thread David Holmes
On 23/04/2012 5:43 PM, Deven You wrote: Thanks David, So is it ok for you to contribute this patch? You can count me as a Reviewer, but it still needs sign-off from Mandy as a serviceability representative. I don't have the spare cycles to act as sponsor for this if you need someone to

Re: core-libs-dev sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-04-23 Thread Mandy Chung
On 04/23/2012 02:36 PM, David Holmes wrote: Except of course that Properties is a Hashtable and synchronizes on 'this' for all public methods. So locking the properties object in the client code will guarantee exclusive access to it. David, thanks for looking at this closer. I missed that

Re: core-libs-dev sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-04-23 Thread Dmitry Samersoff
Deven, Sorry for stepping latter. I'll sponsor this fix, but I need some time to take a close look at changes as I don't understand clearly why synchronization should help in this case. -Dmitry On 2012-04-23 23:36, Mandy Chung wrote: On 04/23/2012 02:36 PM, David Holmes wrote: Except

Re: core-libs-dev sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-04-22 Thread Deven You
On 04/18/2012 02:20 PM, Deven You wrote: On 04/18/2012 01:34 PM, Mandy Chung wrote: On 4/17/2012 12:33 AM, Deven You wrote: I think this could still run into CME. System Properties is not a synchronized map and the setter methods (System.setProperty or Properties.put method) doesn't

Re: core-libs-dev sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-04-18 Thread Deven You
On 04/18/2012 01:34 PM, Mandy Chung wrote: On 4/17/2012 12:33 AM, Deven You wrote: I think this could still run into CME. System Properties is not a synchronized map and the setter methods (System.setProperty or Properties.put method) doesn't synchronize on the Properties object. Hi

Re: core-libs-dev sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-04-17 Thread Deven You
On 04/12/2012 10:09 AM, Mandy Chung wrote: On 4/11/2012 12:36 AM, Deven You wrote: Hi core-libs-devs, I am not sure if sun.management.Agent belongs to jmx-dev mailing list, if so please anyone tell me. serviceability-dev (cc'ed) is the mailing list for this patch. This issue is that the

core-libs-dev sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-04-11 Thread Deven You
Hi core-libs-devs, I am not sure if sun.management.Agent belongs to jmx-dev mailing list, if so please anyone tell me. This issue is that the sun.management.Agent.loadManagementProperties() will invoke properties.putAll which will throw ConcurrentModifcationException if there are other

Re: core-libs-dev sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-04-11 Thread Mandy Chung
On 4/11/2012 12:36 AM, Deven You wrote: Hi core-libs-devs, I am not sure if sun.management.Agent belongs to jmx-dev mailing list, if so please anyone tell me. serviceability-dev (cc'ed) is the mailing list for this patch. This issue is that the