JMH results for IndexedLinkedList

2022-07-08 Thread Rodion Efremov
Data structure repo: https://github.com/coderodde/IndexedLinkedList Benchmark repo: https://github.com/coderodde/IndexedLinkedListBenchmark I have profiled my data structure and it seems it’s more performant than java.util.LinkedList or TreeList, if nothing else. So, is there any chance of inclu

Re: RFR: 8275662: remove test/lib/sun/hotspot

2022-07-08 Thread Leonid Mesnik
On Fri, 8 Jul 2022 19:46:17 GMT, Coleen Phillimore wrote: > This change removes the last remnants of sun/hotspot/WhiteBox.java and other > classes, and uses the versions in jdk/test/whitebox. > I used sed to change sun.hotspot.{gc,code,cpuinfo} to jdk.test.whitebox and > deleted the old files a

Re: RFR: 8289643: File descriptor leak with ProcessBuilder.startPipeline [v2]

2022-07-08 Thread David Schlosnagle
On Fri, 8 Jul 2022 16:24:16 GMT, Roger Riggs wrote: >> The `ProcessBuilder.pipelineStart()` implementation does not close all of >> the file descriptors it uses to create the pipeline of processes. >> >> The process calling `pipelineStart()` is creating the pipes between the >> stages. >> As e

Re: RFR: 8288984: Simplification in java.lang.Runtime::exit [v5]

2022-07-08 Thread Kim Barrett
On Tue, 5 Jul 2022 18:43:26 GMT, Ryan Ernst wrote: >> This is a followup to simplify Shutdown.exit after the removal of >> finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement >> on the approach has been reached in this PR, a CSR will be filed to >> propose the spec change to

Re: RFR: 8275662: remove test/lib/sun/hotspot

2022-07-08 Thread Serguei Spitsyn
On Fri, 8 Jul 2022 19:46:17 GMT, Coleen Phillimore wrote: > This change removes the last remnants of sun/hotspot/WhiteBox.java and other > classes, and uses the versions in jdk/test/whitebox. > I used sed to change sun.hotspot.{gc,code,cpuinfo} to jdk.test.whitebox and > deleted the old files a

Re: RFR: 8288984: Simplification in java.lang.Runtime::exit [v2]

2022-07-08 Thread Kim Barrett
On Thu, 7 Jul 2022 08:03:52 GMT, David Holmes wrote: > > I think that isn't true. If a hook doesn't terminate then VM.shutdown > > doesn't get called, so the window never gets cracked opened to call halt > > directly. > > @kimbarrett Any thread can call halt() directly while the attempted shut

Re: RFR: 8249834: java/util/ArrayList/Bug8146568.java and j/u/Vector/Bug8148174.java use @ignore w/o bug-id [v2]

2022-07-08 Thread Bill Huang
On Fri, 8 Jul 2022 21:34:44 GMT, crazybones wrote: >> Bill Huang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added missing backslash in jdk/TEST.groups > > test/jdk/TEST.groups line 587: > >> 585: javax/net/ssl/compatibility/Hrr

Re: RFR: 8249834: java/util/ArrayList/Bug8146568.java and j/u/Vector/Bug8148174.java use @ignore w/o bug-id [v2]

2022-07-08 Thread crazybones
On Fri, 8 Jul 2022 21:50:40 GMT, Bill Huang wrote: >> Tests Bug8146568 and Bug8148174 were disabled for high memory consumption, >> over 17G. This is a task to re-enable these two tests by marking them as >> manual tests. > > Bill Huang has updated the pull request incrementally with one additi

Re: RFR: 8249834: java/util/ArrayList/Bug8146568.java and j/u/Vector/Bug8148174.java use @ignore w/o bug-id [v2]

2022-07-08 Thread Bill Huang
> Tests Bug8146568 and Bug8148174 were disabled for high memory consumption, > over 17G. This is a task to re-enable these two tests by marking them as > manual tests. Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Added missing back

Re: RFR: 8275662: remove test/lib/sun/hotspot

2022-07-08 Thread Coleen Phillimore
On Fri, 8 Jul 2022 19:46:17 GMT, Coleen Phillimore wrote: > This change removes the last remnants of sun/hotspot/WhiteBox.java and other > classes, and uses the versions in jdk/test/whitebox. > I used sed to change sun.hotspot.{gc,code,cpuinfo} to jdk.test.whitebox and > deleted the old files a

Re: RFR: 8275662: remove test/lib/sun/hotspot

2022-07-08 Thread Mikhailo Seledtsov
On Fri, 8 Jul 2022 19:46:17 GMT, Coleen Phillimore wrote: > This change removes the last remnants of sun/hotspot/WhiteBox.java and other > classes, and uses the versions in jdk/test/whitebox. > I used sed to change sun.hotspot.{gc,code,cpuinfo} to jdk.test.whitebox and > deleted the old files a

RFR: 8275662: remove test/lib/sun/hotspot

2022-07-08 Thread Coleen Phillimore
This change removes the last remnants of sun/hotspot/WhiteBox.java and other classes, and uses the versions in jdk/test/whitebox. I used sed to change sun.hotspot.{gc,code,cpuinfo} to jdk.test.whitebox and deleted the old files and some references to sun.hotspot. Tested with tier1-4. ---

[jdk19] Integrated: 8282071: Update java.xml module-info

2022-07-08 Thread Joe Wang
On Fri, 8 Jul 2022 18:23:05 GMT, Joe Wang wrote: > Update module-info This pull request has now been integrated. Changeset: c86c51cc Author:Joe Wang URL: https://git.openjdk.org/jdk19/commit/c86c51cc72e3457756434b9150b0c5ef2f5d496d Stats: 6 lines in 1 file changed: 2 ins; 0 del;

Re: RFR: 8265891: (ch) InputStream returned by Channels.newInputStream should override transferTo [v13]

2022-07-08 Thread Markus KARG
On Sun, 1 Aug 2021 22:01:33 GMT, Markus KARG wrote: >> This PR-*draft* is **work in progress** and an invitation to discuss a >> possible solution for issue >> [JDK-8265891](https://bugs.openjdk.java.net/browse/JDK-8265891). It is *not >> yet* intended for a final review. >> >> As proposed in

Re: [jdk19] RFR: 8282071: Update java.xml module-info

2022-07-08 Thread Naoto Sato
On Fri, 8 Jul 2022 18:23:05 GMT, Joe Wang wrote: > Update module-info Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.org/jdk19/pull/126

Re: [jdk19] RFR: 8282071: Update java.xml module-info

2022-07-08 Thread Iris Clark
On Fri, 8 Jul 2022 18:23:05 GMT, Joe Wang wrote: > Update module-info Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.org/jdk19/pull/126

Re: RFR: 8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows enviromnent

2022-07-08 Thread Naoto Sato
On Wed, 6 Jul 2022 06:40:32 GMT, KIRIYAMA Takuya wrote: > I removed a section of via JDK_JAVA_OPTIONS because including main class is > not allowed in the specification. > This behavior is added in JDK-8170832, which add JAVA_OPTIONS environment > variable. At this time, this test is mismatch w

Re: [jdk19] RFR: 8282071: Update java.xml module-info

2022-07-08 Thread Lance Andersen
On Fri, 8 Jul 2022 18:23:05 GMT, Joe Wang wrote: > Update module-info Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.org/jdk19/pull/126

[jdk19] RFR: 8282071: Update java.xml module-info

2022-07-08 Thread Joe Wang
Update module-info - Commit messages: - 8282071: Update java.xml module-info Changes: https://git.openjdk.org/jdk19/pull/126/files Webrev: https://webrevs.openjdk.org/?repo=jdk19&pr=126&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282071 Stats: 6 lines in 1 file changed

Re: RFR: 8278469: Test java/nio/channels/FileChannel/LargeGatheringWrite.java times out

2022-07-08 Thread Brian Burkhalter
On Fri, 8 Jul 2022 16:55:28 GMT, Alan Bateman wrote: > My preference is to keep the unit tests in the original location and the only > tests in largeMemory are the tests that really need a lot of memory. Likewise. - PR: https://git.openjdk.org/jdk/pull/9416

Re: RFR: 8278469: Test java/nio/channels/FileChannel/LargeGatheringWrite.java times out

2022-07-08 Thread Alan Bateman
On Fri, 8 Jul 2022 15:15:03 GMT, Brian Burkhalter wrote: > We can see whether they both stop failing regularly after this change and if > so move `MapTest` out of the large memory list. I suspect it's a victim and shouldn't in the largeMemory directory but let's see if there are issues in the

[jdk19] Integrated: 8289872: wrong wording in @param doc for HashMap.newHashMap et. al.

2022-07-08 Thread Stuart Marks
On Thu, 7 Jul 2022 06:06:42 GMT, Stuart Marks wrote: > Minor doc wording changes, to be consistent with HashSet.newHashSet et. al. This pull request has now been integrated. Changeset: eeaf0bba Author:Stuart Marks URL: https://git.openjdk.org/jdk19/commit/eeaf0bbabc6632c181b19185467

Re: RFR: 8289643: File descriptor leak with ProcessBuilder.startPipeline [v2]

2022-07-08 Thread Roger Riggs
> The `ProcessBuilder.pipelineStart()` implementation does not close all of the > file descriptors it uses to create the pipeline of processes. > > The process calling `pipelineStart()` is creating the pipes between the > stages. > As each process is launched, the file descriptor is inherited by

Integrated: 8271707: migrate tests to use jdk.test.whitebox.WhiteBox

2022-07-08 Thread Coleen Phillimore
On Thu, 7 Jul 2022 20:43:09 GMT, Coleen Phillimore wrote: > This change uses sed to change sun.hotspot.WhiteBox to > jdk.test.whitebox.Whitebox, and sun/hotspot/Whitebox similarly. Due to > indirect inclusions of some of the test libraries, changing a few wasn't a > reliable option, and I nee

[jdk19] Integrated: 8289601: SegmentAllocator::allocateUtf8String(String str) should be clarified for strings containing \0

2022-07-08 Thread Jorn Vernee
On Mon, 4 Jul 2022 13:01:34 GMT, Jorn Vernee wrote: > This PR updates the spec and implementation to throw an > `IllegalArgumentException` when an attempt is made to convert a Java string > containing null characters to a C string. > > Testing: local run of the `jdk_foreign` test suite. This

Re: RFR: 8271707: migrate tests to use jdk.test.whitebox.WhiteBox

2022-07-08 Thread Coleen Phillimore
On Thu, 7 Jul 2022 20:43:09 GMT, Coleen Phillimore wrote: > This change uses sed to change sun.hotspot.WhiteBox to > jdk.test.whitebox.Whitebox, and sun/hotspot/Whitebox similarly. Due to > indirect inclusions of some of the test libraries, changing a few wasn't a > reliable option, and I nee

Re: RFR: 8289768: Clean up unused code [v2]

2022-07-08 Thread Daniel Jeliński
On Thu, 7 Jul 2022 19:06:52 GMT, Chris Plummer wrote: >> Daniel Jeliński has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> comm

Re: RFR: 8271707: migrate tests to use jdk.test.whitebox.WhiteBox

2022-07-08 Thread David Holmes
On Thu, 7 Jul 2022 20:43:09 GMT, Coleen Phillimore wrote: > This change uses sed to change sun.hotspot.WhiteBox to > jdk.test.whitebox.Whitebox, and sun/hotspot/Whitebox similarly. Due to > indirect inclusions of some of the test libraries, changing a few wasn't a > reliable option, and I nee

Re: RFR: 8271707: migrate tests to use jdk.test.whitebox.WhiteBox

2022-07-08 Thread Coleen Phillimore
On Fri, 8 Jul 2022 06:12:18 GMT, David Holmes wrote: >> This change uses sed to change sun.hotspot.WhiteBox to >> jdk.test.whitebox.Whitebox, and sun/hotspot/Whitebox similarly. Due to >> indirect inclusions of some of the test libraries, changing a few wasn't a >> reliable option, and I need

Re: RFR: 8289908: Skip bounds check for cases when String is constructed from entirely used byte[]

2022-07-08 Thread Roger Riggs
On Fri, 8 Jul 2022 07:37:36 GMT, Сергей Цыпанов wrote: >> src/java.base/share/classes/java/lang/String.java line 1429: >> >>> 1427: */ >>> 1428: public String(byte[] bytes, int offset, int length) { >>> 1429: this(bytes, offset, length, Charset.defaultCharset(), >>> checkBounds

Re: [jdk19] Integrated: 8278469: Test java/nio/channels/FileChannel/LargeGatheringWrite.java times out

2022-07-08 Thread Jaikiran Pai
On Thu, 7 Jul 2022 22:25:10 GMT, Brian Burkhalter wrote: > Modify test directives so that `LargeGatheringWrite` and `MapTest` in > `java/nio/channels/FileChannel` are not run concurrently with other tests. > > Redirected from https://github.com/openjdk/jdk/pull/9416. Hello Brian, should `java/

Re: RFR: 8278469: Test java/nio/channels/FileChannel/LargeGatheringWrite.java times out

2022-07-08 Thread Brian Burkhalter
On Fri, 8 Jul 2022 06:30:53 GMT, Alan Bateman wrote: > Are you sure MapTest needs a lot of memory? It's a unit test and doesn't have > anything in its jtreg test description to require a lot of resources. I > wonder if it's just the victim. We can see whether they both stop failing regularly a

Re: [jdk19] Integrated: 8278469: Test java/nio/channels/FileChannel/LargeGatheringWrite.java times out

2022-07-08 Thread Brian Burkhalter
On Fri, 8 Jul 2022 11:12:26 GMT, Jaikiran Pai wrote: > Hello Brian, should `java/nio/channels/Channels/ReadXBytes.java` be treated > similarly to prevent https://bugs.openjdk.org/browse/JDK-8289470? That test > uses `-Xmx12G`, so probably would need to be running exclusively? Probably. I had b

Re: RFR: 8284780: Need methods to create pre-sized HashSet and LinkedHashSet [v17]

2022-07-08 Thread XenoAmess
On Wed, 1 Jun 2022 16:45:35 GMT, liach wrote: >> XenoAmess has updated the pull request incrementally with one additional >> commit since the last revision: >> >> do it as naotoj said > > 'the new' fix should be applied to newHashMap etc. too. > @liach > > > 'the new' fix should be applied

Re: [jdk19] RFR: 8287809: Revisit implementation of memory session [v6]

2022-07-08 Thread Jorn Vernee
On Wed, 6 Jul 2022 21:50:36 GMT, Maurizio Cimadamore wrote: >> This is a JDK 19 clone of: https://github.com/openjdk/jdk/pull/9017 > > Maurizio Cimadamore has updated the pull request incrementally with one > additional commit since the last revision: > > Turn non-closeable view back into Me

Re: RFR: 8289643: File descriptor leak with ProcessBuilder.startPipeline

2022-07-08 Thread Jaikiran Pai
On Thu, 7 Jul 2022 19:08:35 GMT, Roger Riggs wrote: > The `ProcessBuilder.pipelineStart()` implementation does not close all of the > file descriptors it uses to create the pipeline of processes. > > The process calling `pipelineStart()` is creating the pipes between the > stages. > As each pr

Re: RFR: 8289643: File descriptor leak with ProcessBuilder.startPipeline

2022-07-08 Thread Roger Riggs
On Fri, 8 Jul 2022 13:27:42 GMT, Alan Bateman wrote: >> The `ProcessBuilder.pipelineStart()` implementation does not close all of >> the file descriptors it uses to create the pipeline of processes. >> >> The process calling `pipelineStart()` is creating the pipes between the >> stages. >> As

[jdk19] Integrated: 8289223: Canonicalize header ids in foreign API javadocs

2022-07-08 Thread Jorn Vernee
On Mon, 27 Jun 2022 16:44:17 GMT, Jorn Vernee wrote: > https://github.com/openjdk/jdk/pull/8817 added a button to copy a link to a > section of javadoc to the clipboard. For the copy button to appear, the > header needs to have an `id`. > > This cleanup PR canonicalizes all header ids in the j

Re: RFR: 8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows enviromnent

2022-07-08 Thread Jaikiran Pai
On Wed, 6 Jul 2022 06:40:32 GMT, KIRIYAMA Takuya wrote: > I removed a section of via JDK_JAVA_OPTIONS because including main class is > not allowed in the specification. > This behavior is added in JDK-8170832, which add JAVA_OPTIONS environment > variable. At this time, this test is mismatch w

Re: RFR: 8289643: File descriptor leak with ProcessBuilder.startPipeline

2022-07-08 Thread Alan Bateman
On Thu, 7 Jul 2022 19:08:35 GMT, Roger Riggs wrote: > The `ProcessBuilder.pipelineStart()` implementation does not close all of the > file descriptors it uses to create the pipeline of processes. > > The process calling `pipelineStart()` is creating the pipes between the > stages. > As each pr

RFR: Merge jdk19

2022-07-08 Thread Jesper Wilhelmsson
Forwardport JDK 19 -> JDK 20 - Commit messages: - Merge - 8289486: Improve XSLT XPath operators count efficiency - 8289779: Map::replaceAll javadoc has redundant @throws clauses - 8289558: Need spec clarification of j.l.foreign.*Layout - 8289196: Pattern domination not working pr

Re: [jdk19] RFR: 8289872: wrong wording in @param doc for HashMap.newHashMap et. al.

2022-07-08 Thread Iris Clark
On Thu, 7 Jul 2022 06:06:42 GMT, Stuart Marks wrote: > Minor doc wording changes, to be consistent with HashSet.newHashSet et. al. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.org/jdk19/pull/118

Re: RFR: 8289768: Clean up unused code [v3]

2022-07-08 Thread Daniel Jeliński
On Fri, 8 Jul 2022 07:08:46 GMT, Daniel Jeliński wrote: >> This patch removes many unused variables and one unused label reported by >> the compilers when relevant warnings are enabled. >> >> The unused code was found by compiling after removing `unused` from the list >> of disabled warnings

Re: RFR: 8289908: Skip bounds check for cases when String is constructed from entirely used byte[]

2022-07-08 Thread Сергей Цыпанов
On Thu, 7 Jul 2022 18:45:03 GMT, Roger Riggs wrote: >> We can skip bounds check and null check for Charset in case we use the array >> entirely and the Charset is either default one or proven to be non-null. >> >> Benchmark results: >> >> before >> >> Benchmark

Withdrawn: 8278469: Test java/nio/channels/FileChannel/LargeGatheringWrite.java times out

2022-07-08 Thread Brian Burkhalter
On Thu, 7 Jul 2022 20:36:43 GMT, Brian Burkhalter wrote: > Modify test directives so that `LargeGatheringWrite` and `MapTest` in > `java/nio/channels/FileChannel` are not run concurrently with other tests. This pull request has been closed without being integrated. - PR: https://g

Re: [jdk19] Integrated: 8278469: Test java/nio/channels/FileChannel/LargeGatheringWrite.java times out

2022-07-08 Thread Daniel D . Daugherty
On Thu, 7 Jul 2022 22:25:10 GMT, Brian Burkhalter wrote: > Modify test directives so that `LargeGatheringWrite` and `MapTest` in > `java/nio/channels/FileChannel` are not run concurrently with other tests. > > Redirected from https://github.com/openjdk/jdk/pull/9416. Thumbs up. This is a trivi

Re: RFR: 8289768: Clean up unused code [v3]

2022-07-08 Thread Daniel Jeliński
> This patch removes many unused variables and one unused label reported by the > compilers when relevant warnings are enabled. > > The unused code was found by compiling after removing `unused` from the list > of disabled warnings for > [gcc](https://github.com/openjdk/jdk/blob/master/make/au

Re: [jdk19] RFR: 8289030: [macos] app image signature invalid when creating DMG or PKG [v3]

2022-07-08 Thread Alexander Matveev
On Thu, 7 Jul 2022 19:52:57 GMT, Alexey Semenyuk wrote: >> We need to add `.package` file during app image creation, since we need to >> sign it. With your proposed change we will add `.package` file to already >> signed app image. > > Oh, right. > Anyways let's keep `.package`-related stuff aw

Re: RFR: 8289834: Add SBCS and DBCS Only EBCDIC charsets

2022-07-08 Thread Bernd Eckenfels
And also there is no reason why db drivers or host connectors should not ship their own charset support (Oracle JDBC for example had nls_charset addons. My employer also ship a custom EBCDIC encoding which includes some compatibility hacks, and that took some effort to adopt it to the missing ex

Re: RFR: 8278469: Test java/nio/channels/FileChannel/LargeGatheringWrite.java times out

2022-07-08 Thread Daniel D . Daugherty
On Thu, 7 Jul 2022 20:36:43 GMT, Brian Burkhalter wrote: > Modify test directives so that `LargeGatheringWrite` and `MapTest` in > `java/nio/channels/FileChannel` are not run concurrently with other tests. Thumbs up. I didn't realize that other test dirs already had the mechanism in place to is

Integrated: Merge jdk19

2022-07-08 Thread Jesper Wilhelmsson
On Thu, 7 Jul 2022 22:31:27 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 19 -> JDK 20 This pull request has now been integrated. Changeset: 01b9f95c Author:Jesper Wilhelmsson URL: https://git.openjdk.org/jdk/commit/01b9f95c62953e7f9ca10eafd42d21c634413827 Stats: 807 lines i

RFR: Merge jdk19

2022-07-08 Thread Jesper Wilhelmsson
Forwardport JDK 19 -> JDK 20 - Commit messages: - Merge - 8289486: Improve XSLT XPath operators count efficiency - 8289779: Map::replaceAll javadoc has redundant @throws clauses - 8289558: Need spec clarification of j.l.foreign.*Layout - 8289196: Pattern domination not working pr

Re: RFR: 8271707: migrate tests to use jdk.test.whitebox.WhiteBox

2022-07-08 Thread Leonid Mesnik
On Thu, 7 Jul 2022 20:43:09 GMT, Coleen Phillimore wrote: > This change uses sed to change sun.hotspot.WhiteBox to > jdk.test.whitebox.Whitebox, and sun/hotspot/Whitebox similarly. Due to > indirect inclusions of some of the test libraries, changing a few wasn't a > reliable option, and I nee

RFR: 8278469: Test java/nio/channels/FileChannel/LargeGatheringWrite.java times out

2022-07-08 Thread Brian Burkhalter
Modify test directives so that `LargeGatheringWrite` and `MapTest` in `java/nio/channels/FileChannel` are not run concurrently with other tests. - Commit messages: - 8278469: Test java/nio/channels/FileChannel/LargeGatheringWrite.java times out Changes: https://git.openjdk.org/jdk

[jdk19] Integrated: 8289030: [macos] app image signature invalid when creating DMG or PKG

2022-07-08 Thread Alexander Matveev
On Wed, 29 Jun 2022 03:03:15 GMT, Alexander Matveev wrote: > Fixed 3 issues which made signature invalid: > - We should not remove .jpackage.xml from signed app image when creating DMG > or PKG otherwise it invalidates signature. > - .package should be created when app image is generated, so th

[jdk19] RFR: 8289930: Improve Thread description of inherited AccessControlContext

2022-07-08 Thread Alan Bateman
This is javadoc only change. The "Inheritance when creating threads" section in the Thread description lists the things that are inherited when creating a Thread. This includes the somewhat obscure "inherited AccessControlContext" where the first sentence looks like it wants to be a heading. The

Re: RFR: 8289768: Clean up unused code [v3]

2022-07-08 Thread Alan Bateman
On Fri, 8 Jul 2022 07:08:46 GMT, Daniel Jeliński wrote: >> This patch removes many unused variables and one unused label reported by >> the compilers when relevant warnings are enabled. >> >> The unused code was found by compiling after removing `unused` from the list >> of disabled warnings

Re: RFR: 8289768: Clean up unused code [v3]

2022-07-08 Thread Chris Plummer
On Fri, 8 Jul 2022 07:08:46 GMT, Daniel Jeliński wrote: >> This patch removes many unused variables and one unused label reported by >> the compilers when relevant warnings are enabled. >> >> The unused code was found by compiling after removing `unused` from the list >> of disabled warnings

Re: RFR: 8278469: Test java/nio/channels/FileChannel/LargeGatheringWrite.java times out

2022-07-08 Thread Alan Bateman
On Thu, 7 Jul 2022 20:36:43 GMT, Brian Burkhalter wrote: > Modify test directives so that `LargeGatheringWrite` and `MapTest` in > `java/nio/channels/FileChannel` are not run concurrently with other tests. Are you sure MapTest needs a lot of memory? It's a unit test and doesn't have anything i

[jdk19] Integrated: 8278469: Test java/nio/channels/FileChannel/LargeGatheringWrite.java times out

2022-07-08 Thread Brian Burkhalter
On Thu, 7 Jul 2022 22:25:10 GMT, Brian Burkhalter wrote: > Modify test directives so that `LargeGatheringWrite` and `MapTest` in > `java/nio/channels/FileChannel` are not run concurrently with other tests. > > Redirected from https://github.com/openjdk/jdk/pull/9416. This pull request has now

Re: RFR: 8278469: Test java/nio/channels/FileChannel/LargeGatheringWrite.java times out

2022-07-08 Thread Brian Burkhalter
On Thu, 7 Jul 2022 22:04:09 GMT, Daniel D. Daugherty wrote: > I just realized this is targeted at jdk/jdk (JDK20). Can you please close > this PR and create a new one for JDK19? Done. - PR: https://git.openjdk.org/jdk/pull/9416

Re: [jdk19] Integrated: 8278469: Test java/nio/channels/FileChannel/LargeGatheringWrite.java times out

2022-07-08 Thread Brian Burkhalter
On Thu, 7 Jul 2022 22:25:10 GMT, Brian Burkhalter wrote: > Modify test directives so that `LargeGatheringWrite` and `MapTest` in > `java/nio/channels/FileChannel` are not run concurrently with other tests. > > Redirected from https://github.com/openjdk/jdk/pull/9416. It is conjectured that sev

Withdrawn: Merge jdk19

2022-07-08 Thread Jesper Wilhelmsson
On Thu, 7 Jul 2022 20:14:12 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 19 -> JDK 20 This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/9415

Re: [jdk19] RFR: 8289030: [macos] app image signature invalid when creating DMG or PKG [v3]

2022-07-08 Thread Alexander Matveev
> Fixed 3 issues which made signature invalid: > - We should not remove .jpackage.xml from signed app image when creating DMG > or PKG otherwise it invalidates signature. > - .package should be created when app image is generated, so this file can be > signed. > - Copying predefine app image for

Re: RFR: 8278469: Test java/nio/channels/FileChannel/LargeGatheringWrite.java times out

2022-07-08 Thread Brian Burkhalter
On Thu, 7 Jul 2022 20:36:43 GMT, Brian Burkhalter wrote: > Modify test directives so that `LargeGatheringWrite` and `MapTest` in > `java/nio/channels/FileChannel` are not run concurrently with other tests. It is conjectured that several tests with large memory demands such as these could be fa

Re: RFR: 8278469: Test java/nio/channels/FileChannel/LargeGatheringWrite.java times out

2022-07-08 Thread Brian Burkhalter
On Thu, 7 Jul 2022 20:36:43 GMT, Brian Burkhalter wrote: > Modify test directives so that `LargeGatheringWrite` and `MapTest` in > `java/nio/channels/FileChannel` are not run concurrently with other tests. Superseded by https://github.com/openjdk/jdk19/pull/122 - PR: https://git.o

Re: [jdk19] RFR: 8289872: wrong wording in @param doc for HashMap.newHashMap et. al.

2022-07-08 Thread Naoto Sato
On Thu, 7 Jul 2022 06:06:42 GMT, Stuart Marks wrote: > Minor doc wording changes, to be consistent with HashSet.newHashSet et. al. Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.org/jdk19/pull/118

Re: RFR: Merge jdk19 [v2]

2022-07-08 Thread Jesper Wilhelmsson
> Forwardport JDK 19 -> JDK 20 Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: Fix merge error - Changes: - all: https://git.openjdk.org/jdk/pull/9415/files - new: https://git.openjdk.org/jdk/pull/9415/files/0f

RFR: 8271707: migrate tests to use jdk.test.whitebox.WhiteBox

2022-07-08 Thread Coleen Phillimore
This change uses sed to change sun.hotspot.WhiteBox to jdk.test.whitebox.Whitebox, and sun/hotspot/Whitebox similarly. Due to indirect inclusions of some of the test libraries, changing a few wasn't a reliable option, and I need the new one for a different change I was looking at. The non-sed c

[jdk19] Integrated: 8278469: Test java/nio/channels/FileChannel/LargeGatheringWrite.java times out

2022-07-08 Thread Brian Burkhalter
Modify test directives so that `LargeGatheringWrite` and `MapTest` in `java/nio/channels/FileChannel` are not run concurrently with other tests. Redirected from https://github.com/openjdk/jdk/pull/9416. - Commit messages: - 8278469: Test java/nio/channels/FileChannel/LargeGathering

Re: [jdk19] RFR: 8289030: [macos] app image signature invalid when creating DMG or PKG [v2]

2022-07-08 Thread Alexander Matveev
On Thu, 7 Jul 2022 17:11:23 GMT, Alexey Semenyuk wrote: >> Alexander Matveev has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >>

Re: [jdk19] RFR: 8289030: [macos] app image signature invalid when creating DMG or PKG [v3]

2022-07-08 Thread Alexey Semenyuk
On Fri, 8 Jul 2022 00:14:27 GMT, Alexander Matveev wrote: >> Fixed 3 issues which made signature invalid: >> - We should not remove .jpackage.xml from signed app image when creating DMG >> or PKG otherwise it invalidates signature. >> - .package should be created when app image is generated, so

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v14]

2022-07-08 Thread iaroslavski
On Thu, 7 Jul 2022 13:41:17 GMT, Alan Bateman wrote: >> iaroslavski has updated the pull request incrementally with one additional >> commit since the last revision: >> >> JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) >> >> * Fix @since version > > This PR has been open and

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v15]

2022-07-08 Thread iaroslavski
> Sorting: > > - adopt radix sort for sequential and parallel sorts on int/long/float/double > arrays (almost random and length > 6K) > - fix tryMergeRuns() to better handle case when the last run is a single > element > - minor javadoc and comment changes > > Testing: > - add new data inputs i

Re: RFR: 8289768: Clean up unused code [v2]

2022-07-08 Thread Chris Plummer
On Wed, 6 Jul 2022 05:32:29 GMT, Daniel Jeliński wrote: >> This patch removes many unused variables and one unused label reported by >> the compilers when relevant warnings are enabled. >> >> The unused code was found by compiling after removing `unused` from the list >> of disabled warnings

Re: RFR: 8289834: Add SBCS and DBCS Only EBCDIC charsets

2022-07-08 Thread Naoto Sato
On Wed, 6 Jul 2022 14:05:39 GMT, Ichiroh Takiguchi wrote: > OpenJDK supports "Japanese EBCDIC - Katakana" and "Korean EBCDIC" SBCS and > DBCS Only charsets. > |Charset|Mix|SBCS|DBCS| > | -- | -- | -- | -- | > | Japanese EBCDIC - Katakana | Cp930 | Cp290 | Cp300 | > | Korean | Cp933 | Cp833 | Cp

Re: RFR: 8205592: BigDecimal.doubleValue() is depressingly slow

2022-07-08 Thread Raffaello Giulietti
On Thu, 7 Jul 2022 15:20:32 GMT, Raffaello Giulietti wrote: > A reimplementation of `BigDecimal.[double|float]Value()` to enhance > performance, avoiding an intermediate string and its subsequent parsing on > the slow path. These are the improvements over the current implementation: - Much mo

Re: [jdk19] RFR: 8289030: [macos] app image signature invalid when creating DMG or PKG [v2]

2022-07-08 Thread Alexey Semenyuk
On Thu, 7 Jul 2022 07:27:56 GMT, Alexander Matveev wrote: >> Fixed 3 issues which made signature invalid: >> - We should not remove .jpackage.xml from signed app image when creating DMG >> or PKG otherwise it invalidates signature. >> - .package should be created when app image is generated, so

Re: [jdk19] RFR: 8289030: [macos] app image signature invalid when creating DMG or PKG [v2]

2022-07-08 Thread Alexey Semenyuk
On Thu, 7 Jul 2022 19:30:07 GMT, Alexander Matveev wrote: >> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacBaseInstallerBundler.java >> line 171: >> >>> 169: >>> Files.deleteIfExists(AppImageFile.getPathInAppImage(appDir)); >>> 170: } >>> 171: >> >> I think ther

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v14]

2022-07-08 Thread iaroslavski
On Wed, 6 Jul 2022 08:49:45 GMT, Сергей Цыпанов wrote: >> iaroslavski has updated the pull request incrementally with one additional >> commit since the last revision: >> >> JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) >> >> * Fix @since version > > I mean adding benchmark

RFR: 8205592: BigDecimal.doubleValue() is depressingly slow

2022-07-08 Thread Raffaello Giulietti
A reimplementation of `BigDecimal.[double|float]Value()` to enhance performance, avoiding an intermediate string and its subsequent parsing on the slow path. - Commit messages: - 8205592: BigDecimal.doubleValue() is depressingly slow Changes: https://git.openjdk.org/jdk/pull/9410/

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v15]

2022-07-08 Thread Laurent Bourgès
On Thu, 7 Jul 2022 15:58:33 GMT, iaroslavski wrote: >> Sorting: >> >> - adopt radix sort for sequential and parallel sorts on >> int/long/float/double arrays (almost random and length > 6K) >> - fix tryMergeRuns() to better handle case when the last run is a single >> element >> - minor javado

Re: [jdk19] RFR: 8289486: Improve XSLT XPath operators count efficiency [v2]

2022-07-08 Thread Joe Wang
> To improve efficiency, this patch moves the limit check to within the Lexer > and reports any overlimit situation as soon as it happens. > > Note the change in XPathParser: diff (and also webrevs) showed the whole > error-report block was changed, the actual change was only placing the block

[jdk19] Integrated: 8289779: Map::replaceAll javadoc has redundant @throws clauses

2022-07-08 Thread Stuart Marks
On Wed, 6 Jul 2022 00:32:00 GMT, Stuart Marks wrote: > Simple javadoc fix of an editorial nature. This pull request has now been integrated. Changeset: a8eb7286 Author:Stuart Marks URL: https://git.openjdk.org/jdk19/commit/a8eb728680529e81bea0584912dead394c35b040 Stats: 10 lines

RFR: 8289643: File descriptor leak with ProcessBuilder.startPipeline

2022-07-08 Thread Roger Riggs
The `ProcessBuilder.pipelineStart()` implementation does not close all of the file descriptors it uses to create the pipeline of processes. The process calling `pipelineStart()` is creating the pipes between the stages. As each process is launched, the file descriptor is inherited by the child p

Re: [jdk19] RFR: 8289030: [macos] app image signature invalid when creating DMG or PKG [v2]

2022-07-08 Thread Alexander Matveev
On Thu, 7 Jul 2022 17:07:51 GMT, Alexey Semenyuk wrote: >> Alexander Matveev has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >>