On Mon, 4 Jul 2022 17:21:14 GMT, Shruthi wrote:
> Modifying inaccurate initialization of keys in ErrorMsg.java and
> XPATHErrorResources.java
> The bug report for the same: https://bugs.openjdk.org/browse/JDK-8289471
Marked as reviewed by joehw (Reviewer).
-
PR:
On Thu, 21 Jul 2022 00:34:53 GMT, David Holmes wrote:
> The version will be 20-ea and the copyright year 2023 (for March 2023 release
> date).
>
> Thanks.
This pull request has now been integrated.
Changeset: e9f97b2e
Author:David Holmes
URL:
On Fri, 22 Jul 2022 00:52:37 GMT, Chris Plummer wrote:
>> Yes, ZGC reports dash for eden and survivor spaces.
>
> So shouldn't we have ZGC test failures then?
No, test passes with ZGC.
-
PR: https://git.openjdk.org/jdk/pull/9604
> Initial implementation.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Implement review feedback.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9422/files
- new:
On Fri, 22 Jul 2022 00:03:26 GMT, Leonid Mesnik wrote:
>> test/jdk/sun/tools/jstatd/JstatGCUtilParser.java line 48:
>>
>>> 46: S0(GcStatisticsType.PERCENTAGE_OR_DASH),
>>> 47: S1(GcStatisticsType.PERCENTAGE_OR_DASH),
>>> 48: E(GcStatisticsType.PERCENTAGE_OR_DASH),
>>
>>
On Thu, 21 Jul 2022 23:01:55 GMT, Chris Plummer wrote:
>> Propagate test.vm.opts/test.java.opts to tested process. Also, accept the
>> output of non-generation (ZGC) GC as valid.
>
> test/jdk/sun/tools/jstatd/JstatGCUtilParser.java line 48:
>
>> 46:
On Thu, 21 Jul 2022 22:33:36 GMT, Leonid Mesnik wrote:
> Propagate test.vm.opts/test.java.opts to tested process. Also, accept the
> output of non-generation (ZGC) GC as valid.
test/jdk/sun/tools/jstatd/JstatGCUtilParser.java line 48:
> 46: S0(GcStatisticsType.PERCENTAGE_OR_DASH),
>
Propagate test.vm.opts/test.java.opts to tested process. Also, accept the
output of non-generation (ZGC) GC as valid.
-
Commit messages:
- 8290846: sun/tools/jstatd/JstatdTest* tests should use VM options
Changes: https://git.openjdk.org/jdk/pull/9604/files
Webrev:
On Thu, 21 Jul 2022 21:22:19 GMT, Joe Darcy wrote:
>> Initial implementation.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull request contains 20
On Thu, 21 Jul 2022 21:22:19 GMT, Joe Darcy wrote:
>> Initial implementation.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull request contains 20
On Wed, 20 Jul 2022 22:21:35 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `LdapClient enumClnt`) are moved to
> Please review this change to replace the finalizer in
> `AbstractLdapNamingEnumeration` with a Cleaner.
>
> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
> res`, and `LdapClient enumClnt`) are moved to a static inner class . From
> there, the change is fairly
> Initial implementation.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 20 additional commits since the
last revision:
- Method rename.
On Thu, 21 Jul 2022 15:37:40 GMT, Сергей Цыпанов wrote:
> We can use `InputStream.readAllBytes()` in `ModuleHashes` and `X509CertPath`.
If by “surrogates” you mean “substitutes”, then this wording is confusing. At
the time these explicit loops were written they weren’t surrogates for
On Thu, 21 Jul 2022 18:42:40 GMT, Brian Burkhalter wrote:
>> src/java.base/unix/classes/sun/nio/ch/UnixAsynchronousSocketChannelImpl.java
>> line 744:
>>
>>> 742: }
>>> 743: } catch (Throwable x) {
>>> 744: System.out.println("Caught " + x);
>>
>> Leftover
> For a `String` “s”, `s.indexOf(int)` can never return a value `>= s.length()`
> so change the check
>
> int pos = syntaxAndInput.indexOf(':');
> if (pos <= 0 || pos == syntaxAndInput.length())
>
> to
>
> if (pos <= 0)
Brian Burkhalter has updated the pull request
On Thu, 21 Jul 2022 15:37:40 GMT, Сергей Цыпанов wrote:
> We can use `InputStream.readAllBytes()` in `ModuleHashes` and `X509CertPath`.
By "surrogate code" I mean hand-written snippets reading all the bytes from an
InputStream.
> It means the whole content from the input stream is read into a
On Thu, 21 Jul 2022 18:54:04 GMT, Roger Riggs wrote:
> The IAE message in JrtFileSystem wording is a bit like it is leftover
> debugging output. The messages for all 4 IAE could be something as simple as
> "missing pattern".
Not sure a message is needed. At the other extreme one could say
On Thu, 21 Jul 2022 18:37:25 GMT, Naoto Sato wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8290047: Ensure that colon is not at the last index
>
>
On Thu, 7 Jul 2022 19:08:35 GMT, Roger Riggs wrote:
> The `ProcessBuilder.pipelineStart()` implementation does not close all of the
> file descriptors it uses to create the pipeline of processes.
>
> The process calling `pipelineStart()` is creating the pipes between the
> stages.
> As each
On Thu, 21 Jul 2022 18:29:03 GMT, Brian Burkhalter wrote:
>> For a `String` “s”, `s.indexOf(int)` can never return a value `>=
>> s.length()` so change the check
>>
>> int pos = syntaxAndInput.indexOf(':');
>> if (pos <= 0 || pos == syntaxAndInput.length())
>>
>> to
>>
>>
On Thu, 21 Jul 2022 18:36:57 GMT, Naoto Sato wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8290047: Ensure that colon is not at the last index
>
>
On Thu, 21 Jul 2022 18:29:03 GMT, Brian Burkhalter wrote:
>> For a `String` “s”, `s.indexOf(int)` can never return a value `>=
>> s.length()` so change the check
>>
>> int pos = syntaxAndInput.indexOf(':');
>> if (pos <= 0 || pos == syntaxAndInput.length())
>>
>> to
>>
>>
On Thu, 21 Jul 2022 15:37:40 GMT, Сергей Цыпанов wrote:
> We can use `InputStream.readAllBytes()` in `ModuleHashes` and `X509CertPath`.
The `X509CertPath.java` change looks fine, but I'm not sure about the other
one. It means the whole content from the input stream is read into a single
array
On Thu, 21 Jul 2022 17:13:58 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/jdk/internal/jrtfs/JrtFileSystem.java line 178:
>>
>>> 176: public PathMatcher getPathMatcher(String syntaxAndInput) {
>>> 177: int pos = syntaxAndInput.indexOf(':');
>>> 178: if (pos <=
> For a `String` “s”, `s.indexOf(int)` can never return a value `>= s.length()`
> so change the check
>
> int pos = syntaxAndInput.indexOf(':');
> if (pos <= 0 || pos == syntaxAndInput.length())
>
> to
>
> if (pos <= 0)
Brian Burkhalter has updated the pull request
On Tue, 19 Jul 2022 14:07:17 GMT, Ryan Ernst wrote:
> This commit ensures streams returned by ModuleReader::list are closed.
This pull request has now been integrated.
Changeset: 80bd8c35
Author:Ryan Ernst
Committer: Chris Hegarty
URL:
On Thu, 21 Jul 2022 16:01:01 GMT, Roger Riggs wrote:
>> The `ProcessBuilder.pipelineStart()` implementation does not close all of
>> the file descriptors it uses to create the pipeline of processes.
>>
>> The process calling `pipelineStart()` is creating the pipes between the
>> stages.
>> As
On Tue, 12 Jul 2022 17:04:47 GMT, Eric Caspole wrote:
> This JMH was accidentally committed with package vm.compiler but it is in the
> path bench/java/lang. I renamed the package so as to more easily run it with
> the other ArrayCopy JMH.
Thanks Roger!
-
PR:
On Tue, 12 Jul 2022 17:04:47 GMT, Eric Caspole wrote:
> This JMH was accidentally committed with package vm.compiler but it is in the
> path bench/java/lang. I renamed the package so as to more easily run it with
> the other ArrayCopy JMH.
This pull request has now been integrated.
On Mon, 9 May 2022 09:56:19 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream`
On Tue, 12 Jul 2022 17:04:47 GMT, Eric Caspole wrote:
> This JMH was accidentally committed with package vm.compiler but it is in the
> path bench/java/lang. I renamed the package so as to more easily run it with
> the other ArrayCopy JMH.
LGTM
-
Marked as reviewed by rriggs
On Thu, 21 Jul 2022 15:37:40 GMT, Сергей Цыпанов wrote:
> We can use `InputStream.readAllBytes()` in `ModuleHashes` and `X509CertPath`.
Why do you say “instead of surrogate code”? I don’t see any Unicode surrogate
processing here, but maybe you mean something else. Would “instead of explicit
On Thu, 21 Jul 2022 15:29:10 GMT, Brian Burkhalter wrote:
> For a `String` “s”, `s.indexOf(int)` can never return a value `>= s.length()`
> so change the check
>
> int pos = syntaxAndInput.indexOf(':');
> if (pos <= 0 || pos == syntaxAndInput.length())
>
> to
>
> if
On Thu, 21 Jul 2022 17:10:12 GMT, Roger Riggs wrote:
>> For a `String` “s”, `s.indexOf(int)` can never return a value `>=
>> s.length()` so change the check
>>
>> int pos = syntaxAndInput.indexOf(':');
>> if (pos <= 0 || pos == syntaxAndInput.length())
>>
>> to
>>
>>
On Thu, 21 Jul 2022 15:29:10 GMT, Brian Burkhalter wrote:
> For a `String` “s”, `s.indexOf(int)` can never return a value `>= s.length()`
> so change the check
>
> int pos = syntaxAndInput.indexOf(':');
> if (pos <= 0 || pos == syntaxAndInput.length())
>
> to
>
> if
> The `ProcessBuilder.pipelineStart()` implementation does not close all of the
> file descriptors it uses to create the pipeline of processes.
>
> The process calling `pipelineStart()` is creating the pipes between the
> stages.
> As each process is launched, the file descriptor is inherited
For a `String` “s”, `s.indexOf(int)` can never return a value `>= s.length()`
so change the check
int pos = syntaxAndInput.indexOf(':');
if (pos <= 0 || pos == syntaxAndInput.length())
to
if (pos <= 0)
-
Commit messages:
- 8290047: (fs)
We can use `InputStream.readAllBytes()` in `ModuleHashes` and `X509CertPath`.
-
Commit messages:
- 8290824: Remove unused JavaDoc
- 8290824: Use InputStream.readAllBytes() instead of surrogate code
Changes: https://git.openjdk.org/jdk/pull/9596/files
Webrev:
On Tue, 16 Nov 2021 20:53:26 GMT, kabutz wrote:
>> This is a draft proposal for how we could improve stream performance for the
>> case where the streams are empty. Empty collections are common-place. If we
>> iterate over them with an Iterator, we would have to create one small
>> Iterator
On Mon, 18 Jul 2022 17:53:16 GMT, Roger Riggs wrote:
>> The `ProcessBuilder.pipelineStart()` implementation does not close all of
>> the file descriptors it uses to create the pipeline of processes.
>>
>> The process calling `pipelineStart()` is creating the pipes between the
>> stages.
>> As
On Thu, 21 Jul 2022 13:23:43 GMT, Ryan Ernst wrote:
>> This commit ensures streams returned by ModuleReader::list are closed.
>
> Ryan Ernst has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains six commits:
>
> - Merge branch 'master'
- Original Message -
> From: "John R Rose"
> To: core-libs-dev@openjdk.org
> Sent: Thursday, July 21, 2022 4:12:14 AM
> Subject: Re: RFR: JDK-8277095 : Empty streams create too many objects [v2]
> On Tue, 16 Nov 2021 20:53:26 GMT, kabutz wrote:
>
>>> This is a draft proposal for how we
> This commit ensures streams returned by ModuleReader::list are closed.
Ryan Ernst has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains six commits:
- Merge branch 'master' into try_files/module_reader_uses
- fix caller sensitive test
On Thu, 21 Jul 2022 06:53:53 GMT, Chris Hegarty wrote:
>> Done in
>> [4a94c64](https://github.com/openjdk/jdk/pull/9557/commits/4a94c645fe1e37abc694f81fd8e401c5dc367d68)
>
> @rjernst it seems that the _revert_ part of the above has been done, but not
> the "have the callerSensitiveMethods
On Thu, 21 Jul 2022 12:06:37 GMT, Maurizio Cimadamore
wrote:
> The javadoc for `Linker` states that some operations throw
> `UnsupportedOperationException` when called on an unsupported platform. These
> operations are:
>
> * `Linker::nativeLinker`
> * `VaList::empty`
> * `VaList::make`
> *
The javadoc for `Linker` states that some operations throw
`UnsupportedOperationException` when called on an unsupported platform. These
operations are:
* `Linker::nativeLinker`
* `VaList::empty`
* `VaList::make`
* `VaList::ofAddress`
While the code throws an UOE as required, since the
On Sat, 18 Jun 2022 10:43:08 GMT, Andrey Turbanov wrote:
> Instead of separate ConcurrentHashMap.get call, we can use result of previous
> putIfAbsent call.
This pull request has now been integrated.
Changeset: 52cc6cd0
Author:Andrey Turbanov
URL:
On Wed, 20 Jul 2022 11:19:07 GMT, Andrey Turbanov wrote:
>> Instead of separate ConcurrentHashMap.get call, we can use result of
>> previous putIfAbsent call.
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8288723:
On Tue, 16 Nov 2021 20:53:26 GMT, kabutz wrote:
>> This is a draft proposal for how we could improve stream performance for the
>> case where the streams are empty. Empty collections are common-place. If we
>> iterate over them with an Iterator, we would have to create one small
>> Iterator
On Wed, 20 Jul 2022 20:54:27 GMT, Ryan Ernst wrote:
>> yes, this would solve it.
>
> Done in
> [4a94c64](https://github.com/openjdk/jdk/pull/9557/commits/4a94c645fe1e37abc694f81fd8e401c5dc367d68)
@rjernst it seems that the _revert_ part of the above has been done, but not
the "have the
On Fri, 15 Jul 2022 16:18:17 GMT, Ryan Ernst wrote:
> This commit adds try-with-resources for uses of Stream from Files
> methods that walk directories.
This pull request has now been integrated.
Changeset: 3582fd9e
Author:Ryan Ernst
Committer: Chris Hegarty
URL:
On Fri, 15 Jul 2022 16:06:21 GMT, Ryan Ernst wrote:
> This commit guards uses of Files methods returning path streams in
> java.base to use try-with-resources.
This pull request has now been integrated.
Changeset: 53fc495e
Author:Ryan Ernst
Committer: Chris Hegarty
URL:
53 matches
Mail list logo
