On Sun, 7 Aug 2022 08:14:58 GMT, Alan Bateman wrote:
> > Sorry for joining late. I noticed that modsHashCode is a private method and
> > it takes Iterable as a parameter. But everywhere it is called, a Set is
> > passed to it. So why not just calling the set.hashCode() and be done with
> > it?
On Tue, 9 Aug 2022 09:36:28 GMT, Jaikiran Pai wrote:
> (This is a recreation of a previous pull request which had received some
> reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that
> personal branch and recreate it due to some git issues)
>
> Can I please get a review of th
> (This is a recreation of a previous pull request which had received some
> reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that
> personal branch and recreate it due to some git issues)
>
> Can I please get a review of this change which addresses
> https://bugs.openjdk.java.
> Container configuration information is useful for troubleshooting
> problems,Exposing information in MBeans is ideal for monitoring, jConsole,
> and other scenarios.
> Results the following
> ![图片](https://user-images.githubusercontent.com/7837910/177248834-50beefe9-4db6-470c-8f15-df5a93892804.
> JDK-8289106: Add model of class file versions to core reflection
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 18 additional commits since
On Tue, 2 Aug 2022 21:21:51 GMT, Roger Riggs wrote:
> True, many ways to factor the code. Another possibility is add a field to the
> enum that holds a `java.util.Function>)` and initialize
> it each with a lambda of the code now in the locations(cffv) method that maps
> the cffv to the set of
On Fri, 4 Mar 2022 15:54:14 GMT, Ludovic Henry wrote:
> Despite the hash value being cached for Strings, computing the hash still
> represents a significant CPU usage for applications handling lots of text.
>
> Even though it would be generally better to do it through an enhancement to
> the a
On Sat, 23 Jul 2022 03:03:25 GMT, Alisen Chung wrote:
> open l10n msg drop
> All tests passed.
This pull request has now been integrated.
Changeset: 0def5316
Author:Alisen Chung
Committer: Alexey Semenyuk
URL:
https://git.openjdk.org/jdk19/commit/0def5316cd2ec7699c649bf67bf58e6315c
On Tue, 9 Aug 2022 21:14:39 GMT, Bill Huang wrote:
> This task converts 5 shell tests below to java version.
> test/java/lang/management/MemoryMXBean/LowMemoryTest2.sh
> test/java/lang/management/MemoryMXBean/MemoryManagementParallelGC.sh
> test/java/lang/management/MemoryMXBean/MemoryManageme
This task converts 5 shell tests below to java version.
test/java/lang/management/MemoryMXBean/LowMemoryTest2.sh
test/java/lang/management/MemoryMXBean/MemoryManagementParallelGC.sh
test/java/lang/management/MemoryMXBean/MemoryManagementSerialGC.sh
test/java/lang/management/MemoryMXBean/MemoryT
On Fri, 5 Aug 2022 02:15:21 GMT, Ichiroh Takiguchi
wrote:
> To support Windows command prompt's codepage, following charsets should be
> moved from jdk.charsets module to java.base module.
>
> - IBM860
> - IBM861
> - IBM863
> - IBM864
> - IBM865
> - IBM869
I looked at this issue a bit more. I
On Mon, 8 Aug 2022 18:55:39 GMT, Max Mielchen wrote:
>> David Schlosnagle has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 11 additional
>> commi
On Tue, 9 Aug 2022 18:35:05 GMT, Mandy Chung wrote:
>> David Schlosnagle has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 11 additional
>> commit
> I would like to contribute an optimized version of
> `StackTraceElement#toString()` that uses a single StringBuilder throughout
> creation to avoid intermediate `String` allocations.
> `StackTraceElement#toString()` is used in a number of JDK code paths
> including `Throwable#printStackTrace(
On Tue, 9 Aug 2022 19:16:04 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java.
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9812
On Tue, 9 Aug 2022 19:16:04 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java.
This pull request has now been integrated.
Changeset: 57e0da15
Author:Daniel D. Daugherty
URL:
https://git.openjdk.
A trivial fix to ProblemList
jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java.
-
Commit messages:
- 8292132: ProblemList
jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java
Changes: https://git.openjdk.org/jdk/pull/9812/files
Webrev: h
On Tue, 9 Aug 2022 19:19:00 GMT, Brian Burkhalter wrote:
>> A trivial fix to ProblemList
>> jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java.
>
> Marked as reviewed by bpb (Reviewer).
@bplb - Thanks for the fast review!
-
PR: https://git.openjdk.org/jdk/pul
On Sat, 6 Aug 2022 14:55:17 GMT, David Schlosnagle wrote:
>> I would like to contribute an optimized version of
>> `StackTraceElement#toString()` that uses a single StringBuilder throughout
>> creation to avoid intermediate `String` allocations.
>> `StackTraceElement#toString()` is used in a n
On Sat, 6 Aug 2022 14:55:17 GMT, David Schlosnagle wrote:
>> I would like to contribute an optimized version of
>> `StackTraceElement#toString()` that uses a single StringBuilder throughout
>> creation to avoid intermediate `String` allocations.
>> `StackTraceElement#toString()` is used in a n
On Thu, 4 Aug 2022 17:40:43 GMT, Bill Huang wrote:
> Improve test coverage for XPath functions:
> [JDK-8290836](https://bugs.openjdk.org/browse/JDK-8290836),
> [JDK-8290837](https://bugs.openjdk.org/browse/JDK-8290837),
> [JDK-8290838](https://bugs.openjdk.org/browse/JDK-8290838).
This pull r
On Tue, 9 Aug 2022 09:36:28 GMT, Jaikiran Pai wrote:
> (This is a recreation of a previous pull request which had received some
> reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that
> personal branch and recreate it due to some git issues)
>
> Can I please get a review of th
On Fri, 29 Jul 2022 18:13:25 GMT, Alisen Chung wrote:
>> open l10n msg drop
>> All tests passed.
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> added comments in CurrencyNames root in base, moved US CurrencyNames back
> t
On Thu, 21 Jul 2022 15:29:10 GMT, Brian Burkhalter wrote:
> For a `String` “s”, `s.indexOf(int)` can never return a value `>= s.length()`
> so change the check
>
> int pos = syntaxAndInput.indexOf(':');
> if (pos <= 0 || pos == syntaxAndInput.length())
>
> to
>
> if (p
On Tue, 9 Aug 2022 09:36:28 GMT, Jaikiran Pai wrote:
> (This is a recreation of a previous pull request which had received some
> reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that
> personal branch and recreate it due to some git issues)
>
> Can I please get a review of th
On Tue, 9 Aug 2022 05:51:17 GMT, Alan Bateman wrote:
>> The whole paragraph is about thread termination, so I don't think we need to
>> say "terminate" again in the last sentence. We could mention isAlive or the
>> TERMINATED state, but that brings in Thread.State which which require a
>> disc
On Mon, 8 Aug 2022 22:59:33 GMT, Stuart Marks wrote:
>> Initial edits to addShutdownHook from Alex.
>>
>> See [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036).
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Upda
On Tue, 9 Aug 2022 10:28:02 GMT, Jan Lahoda wrote:
> > Would it be possible to add a special case where the labels are all the
> > same type? Like all labels are Class.class or Object.class? While testing
> > out the pattern matching, I've found myself doing the following
> > ```java
> > switch
On Fri, 5 Aug 2022 16:12:08 GMT, Jan Lahoda wrote:
> The pattern matching switches are using a bootstrap method
> `SwitchBootstrap.typeSwitch` to implement the jumps in the switch. Basically,
> for a switch like:
>
> switch (obj) {
> case String s when s.isEmpty() -> {}
> case String s
On Tue, 9 Aug 2022 09:36:28 GMT, Jaikiran Pai wrote:
> (This is a recreation of a previous pull request which had received some
> reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that
> personal branch and recreate it due to some git issues)
>
> Can I please get a review of th
On Tue, 9 Aug 2022 09:36:28 GMT, Jaikiran Pai wrote:
> (This is a recreation of a previous pull request which had received some
> reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that
> personal branch and recreate it due to some git issues)
>
> Can I please get a review of th
(This is a recreation of a previous pull request which had received some
reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that personal
branch and recreate it due to some git issues)
Can I please get a review of this change which addresses
https://bugs.openjdk.java.net/browse/J
On Mon, 6 Jun 2022 06:57:23 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8285405?
>
> I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the existing
> `test/jdk/java/util/LinkedHashMap/Basic.java`
On Tue, 9 Aug 2022 08:38:26 GMT, Jaikiran Pai wrote:
>> ScientificWare has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains ten additional
>> commits
On Fri, 5 Aug 2022 08:59:00 GMT, ScientificWare wrote:
>> This is tracked in JBS as
>>
>> [JDK-8289741](https://bugs.openjdk.org/browse/JDK-8289741) and duplicated by
>> [JDK-8290070](https://bugs.openjdk.org/browse/JDK-8290070)
>>
>> Unused imports in DTDBuider.java.
>>
>>> **Remove unused i
On Mon, 4 Jul 2022 07:04:40 GMT, ScientificWare wrote:
> This is tracked in JBS as
>
> [JDK-8289741](https://bugs.openjdk.org/browse/JDK-8289741) and duplicated by
> [JDK-8290070](https://bugs.openjdk.org/browse/JDK-8290070)
>
> Unused imports in DTDBuider.java.
>
>> **Remove unused imports f
On Tue, 9 Aug 2022 02:37:21 GMT, Jaikiran Pai wrote:
>> Hello @jaikiran, the copyright years were updated by a previous commit.
>
> @scientificware, please issue the integrate command when you are ready and I
> can sponsor this for you. In the meantime, I'll run some tests to be sure
> that thi
37 matches
Mail list logo