Re: RFR: 8178355: IdentityHashMap uses identity-based comparison for values everywhere except remove(K,V) and replace(K,V,V) [v4]

2022-08-30 Thread liach
On Fri, 6 May 2022 22:05:35 GMT, liach wrote: >> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare >> values by identity. Updated API documentation of these two methods >>

Integrated: 8293020: jmod should not be treated as "small" tool for large modules

2022-08-30 Thread Aleksey Shipilev
On Mon, 29 Aug 2022 10:13:29 GMT, Aleksey Shipilev wrote: > This is similar to > [JDK-8245168](https://bugs.openjdk.org/browse/JDK-8245168), but the blanket > change to allow all modules be compiled with default options is a net loss. > Instead, we can hand-pick the major offenders (large

Re: RFR: JDK-8173605: Remove support for source and target 1.7 option in javac

2022-08-30 Thread Joe Darcy
On Tue, 30 Aug 2022 06:26:25 GMT, Alan Bateman wrote: >> Update to remove support for -source/-target/--release 7 from javac. >> >> As seen in the PR, many test fails are affected. Further refactorings of >> javac's implementation that can be made from dropping 7 support are left as >> future

Re: RFR: 8065554: MatchResult should provide values of named-capturing groups [v4]

2022-08-30 Thread Stuart Marks
On Tue, 30 Aug 2022 20:17:04 GMT, Raffaello Giulietti wrote: >> test/jdk/java/util/regex/NamedGroupsTests.java line 45: >> >>> 43: >>> 44: testMatchResultStartEndGroup(); >>> 45: } >> >> I haven't gone through all the tests in great detail (yet), but it occurs to >> me that we

Re: RFR: 8065554: MatchResult should provide values of named-capturing groups [v4]

2022-08-30 Thread Raffaello Giulietti
On Tue, 30 Aug 2022 19:27:26 GMT, Stuart Marks wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8065554: MatchResult should provide values of named-capturing groups > >

Re: RFR: 8065554: MatchResult should provide values of named-capturing groups [v4]

2022-08-30 Thread Stuart Marks
On Mon, 29 Aug 2022 13:49:52 GMT, Raffaello Giulietti wrote: >> Add support for named groups to java.util.regex.MatchResult > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > 8065554: MatchResult should provide values

Re: RFR: 8065554: MatchResult should provide values of named-capturing groups [v4]

2022-08-30 Thread Stuart Marks
On Mon, 29 Aug 2022 13:49:52 GMT, Raffaello Giulietti wrote: >> Add support for named groups to java.util.regex.MatchResult > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > 8065554: MatchResult should provide values

Re: RFR: 8293020: jmod should not be treated as "small" tool for large modules [v3]

2022-08-30 Thread Alan Bateman
On Mon, 29 Aug 2022 18:01:36 GMT, Aleksey Shipilev wrote: >> This is similar to >> [JDK-8245168](https://bugs.openjdk.org/browse/JDK-8245168), but the blanket >> change to allow all modules be compiled with default options is a net loss. >> Instead, we can hand-pick the major offenders (large

Re: RFR: 8065554: MatchResult should provide values of named-capturing groups [v4]

2022-08-30 Thread Stuart Marks
On Mon, 29 Aug 2022 13:49:52 GMT, Raffaello Giulietti wrote: >> Add support for named groups to java.util.regex.MatchResult > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > 8065554: MatchResult should provide values

Re: RFR: 8293020: jmod should not be treated as "small" tool for large modules [v3]

2022-08-30 Thread Aleksey Shipilev
On Mon, 29 Aug 2022 18:01:36 GMT, Aleksey Shipilev wrote: >> This is similar to >> [JDK-8245168](https://bugs.openjdk.org/browse/JDK-8245168), but the blanket >> change to allow all modules be compiled with default options is a net loss. >> Instead, we can hand-pick the major offenders (large

Re: RFR: 8275535: Retrying a failed authentication on multiple LDAP servers can lead to users blocked

2022-08-30 Thread Ryan Flegel
On Wed, 20 Oct 2021 13:35:22 GMT, Martin Balao wrote: > I'd like to propose a fix for JDK-8275535. This fix reverts the behavior to > the state previous to JDK-8160768, where an authentication failure stops from > trying other LDAP servers with the same credentials [1]. After JDK-8160768 we >

Re: RFR: 8291651: CleanerTest.java fails with "Cleanable was cleaned" [v2]

2022-08-30 Thread Roger Riggs
> CleanerTest is failing intermittently on Aarch64, with -Xcomp, and using a > VirtualThread for the Cleaner in the test. > The extensively relies on references processing and invokes GC on a very > short cycle. > The existing 10ms delay between GC requests is too short for the changes to >

Integrated: 8293009: Remove unused field 'millisPerHour' in DateFormatSymbols

2022-08-30 Thread Andrey Turbanov
On Wed, 24 Aug 2022 19:22:51 GMT, Andrey Turbanov wrote: > Field `java.text.DateFormatSymbols#millisPerHour` is unused. It was unused in > initial OpenJDK sources. This pull request has now been integrated. Changeset: d3d2e669 Author:Andrey Turbanov URL:

Re: RFR: 8282648: Weaken the InflaterInputStream specification in order to allow faster Zip implementations [v12]

2022-08-30 Thread Lance Andersen
On Mon, 29 Aug 2022 11:58:15 GMT, Volker Simonis wrote: >> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)` >> to highlight that it might write more bytes than the returned number of >> inflated bytes into the buffer `b`. >> >> The superclass `java.io.InputStream`

Re: RFR: 8292407: Improve Weak CAS VarHandle/Unsafe tests resilience under spurious failures [v7]

2022-08-30 Thread Aleksey Shipilev
On Tue, 30 Aug 2022 14:18:11 GMT, Aleksey Shipilev wrote: >> We have a few reports that existing Weak* VarHandle tests are still flaky, >> for example on large AArch64 machines or small RISC-V machines. >> >> The flakiness is intrinsic to the nature of Weak* operations under tests, >> that

Re: RFR: 8292407: Improve Weak CAS VarHandle/Unsafe tests resilience under spurious failures [v7]

2022-08-30 Thread Aleksey Shipilev
> We have a few reports that existing Weak* VarHandle tests are still flaky, > for example on large AArch64 machines or small RISC-V machines. > > The flakiness is intrinsic to the nature of Weak* operations under tests, > that can spuriously fail. The last attempt to fix these was >

Re: RFR: 8065554: MatchResult should provide values of named-capturing groups [v4]

2022-08-30 Thread Raffaello Giulietti
On Mon, 29 Aug 2022 13:49:52 GMT, Raffaello Giulietti wrote: >> Add support for named groups to java.util.regex.MatchResult > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > 8065554: MatchResult should provide values

Re: RFR: JDK-8289798: Update to use jtreg 7 [v5]

2022-08-30 Thread Jaikiran Pai
On Tue, 23 Aug 2022 11:22:55 GMT, Christian Stein wrote: >> Please review the change to update to using jtreg 7. >> >> The primary change is to the `jib-profiles.js` file, which specifies the >> version of jtreg to use, for those systems that rely on this file. In >> addition, the

Re: RFR: JDK-8289798: Update to use jtreg 7 [v5]

2022-08-30 Thread Christian Stein
On Tue, 30 Aug 2022 09:14:12 GMT, Jaikiran Pai wrote: > Hello Christian, is it intentional that in some file the minimum required > jtreg version is represented as `7` (`lib-tests.m4`) and in some other files > as `7+1` (GitHub actions config file, then the TEST.ROOT files)? Yes. Some systems

Re: RFR: 8293008: Replace uses of StringBuffer with StringBuilder in MergeCollation

2022-08-30 Thread Jaikiran Pai
On Wed, 24 Aug 2022 19:31:23 GMT, Andrey Turbanov wrote: > Couple of package-private classes in `java.text` package still use > `StringBuffer`: `MergeCollation` and `PatternEntry`. > StringBuffer is a legacy synchronized class. StringBuilder is a direct > replacement to StringBuffer which

Re: RFR: 8291651: CleanerTest.java fails with "Cleanable was cleaned"

2022-08-30 Thread Jaikiran Pai
On Fri, 26 Aug 2022 19:09:45 GMT, Roger Riggs wrote: > CleanerTest is failing intermittently on Aarch64, with -Xcomp, and using a > VirtualThread for the Cleaner in the test. > The extensively relies on references processing and invokes GC on a very > short cycle. > The existing 10ms delay

Re: RFR: JDK-8173605: Remove support for source and target 1.7 option in javac

2022-08-30 Thread Alan Bateman
On Tue, 30 Aug 2022 00:04:03 GMT, Joe Darcy wrote: > Update to remove support for -source/-target/--release 7 from javac. > > As seen in the PR, many test fails are affected. Further refactorings of > javac's implementation that can be made from dropping 7 support are left as > future work.