Re: RFR: JDK-8293466: libjsig should ignore non-modifying sigaction calls

2022-09-10 Thread Man Cao
On Sat, 10 Sep 2022 06:15:05 GMT, Thomas Stuefe wrote: > Found during code review of > [JDK-8292695](https://bugs.openjdk.org/browse/JDK-8292695). > > We have two bugs in libjsig when we install hotspot signal handlers. Relevant > code in libjsig: > > > int sigaction(int sig, const struct

Re: Standard Artifact Resolution API

2022-09-10 Thread Ethan McCue
Okay so from what I can parse there are different streams of work here 1. The JDK could be well served by a "standard" build tool. I don't think this is controversial, but I'm nowhere near qualified enough to say what the "right" choice is. Maybe it is just taking gradle, who knows. What I do

Re: RFR: 8279283 - BufferedInputStream should override transferTo [v7]

2022-09-10 Thread Markus KARG
On Mon, 5 Sep 2022 18:33:43 GMT, Alan Bateman wrote: >> Markus KARG has updated the pull request incrementally with one additional >> commit since the last revision: >> >> HexPrinter::transferTo > > It looks like this patch is against a repository that hasn't been sync'ed up > since late

RFR: JDK-8293466: libjsig should ignore non-modifying sigaction calls

2022-09-10 Thread Thomas Stuefe
Found during code review of [JDK-8292695](https://bugs.openjdk.org/browse/JDK-8292695). We have two bugs in libjsig when we install hotspot signal handlers. Relevant code in libjsig: int sigaction(int sig, const struct sigaction *act, struct sigaction *oact) { sigused = sigismember(,

Integrated: 8292240: CarrierThread.blocking not reset when spare not activated

2022-09-10 Thread Alan Bateman
On Thu, 11 Aug 2022 16:11:02 GMT, Alan Bateman wrote: > Some blocking operations that pin a virtual thread to its carrier will > compensate by activating a spare carrier (essentially managed blocker). This > is done by wrapping the operation in a Blocker begin/end. This code is not > correct