Re: RFR: 8293910: tools/launcher/FXLauncherTest.java fail with jfx [v2]

On Sat, 17 Sep 2022 04:03:35 GMT, Leslie Zhai wrote: >> Hi, >> >> @dumasun reported the issue: >> >> Configured with jfx-ls-modular-sdk: >> >> >> configure --with-import-modules=modular-sdk >> >> >> `make run-test CONF=fastdebug TEST="tools/launcher/FXLauncherTest.java"` >> failed: >> >>

Re: RFR: 8293910: tools/launcher/FXLauncherTest.java fail with jfx [v2]

> Hi, > > @dumasun reported the issue: > > Configured with jfx-ls-modular-sdk: > > > configure --with-import-modules=modular-sdk > > > `make run-test CONF=fastdebug TEST="tools/launcher/FXLauncherTest.java"` > failed: > > > --System.err:(11/697)-- >

Re: RFR: 8293499: Provide jmod --compress option [v7]

On Fri, 16 Sep 2022 08:03:28 GMT, Aleksey Shipilev wrote: >> I have been looking into `make clean-images images` performance, and >> realized jmod keeps compressing files with default compression level. Tuning >> that toward lighter compression levels improves build performance >>

Re: RFR: 8293462: [macos] app image signature invalid when creating DMG or PKG from post processed signed image

> On Sep 16, 2022, at 6:02 PM, Alexander Matveev wrote: > > Problem is that [JDK-8286850](https://bugs.openjdk.org/browse/JDK-8286850 > ) never set correct value in > .jpackage.xml to mark image as signed. >

RFR: 8293462: [macos] app image signature invalid when creating DMG or PKG from post processed signed image

Problem is that [JDK-8286850](https://bugs.openjdk.org/browse/JDK-8286850) never set correct value in .jpackage.xml to mark image as signed. [JDK-8289030](https://bugs.openjdk.org/browse/JDK-8289030) reads this value to check if we can add per-user and system wide configuration to packaged app.

Re: RFR: 8292698: Improve performance of DataInputStream [v4]

On Mon, 29 Aug 2022 08:46:20 GMT, Сергей Цыпанов wrote: >> I found out that reading from `DataInputStream` wrapping >> `ByteArrayInputStream` (as well as `BufferedInputStream` or any >> `InputStream` relying on `byte[]`) can be significantly improved by >> accessing volatile `in` field only

Re: RFR: JDK-8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present

On Fri, 16 Sep 2022 08:26:00 GMT, Matthias Baesken wrote: > We noticed that with certain jar file input, jdeps runs into the following > exception, this happens with jdk11, 17 and 20. > > jdeps.exe --multi-release 11 --module-path . --inverse --package > com.sap.nw.performance.supa.client

Integrated: 8278165: Clarify that ZipInputStream does not access the CEN fields for a ZipEntry

On Wed, 31 Aug 2022 16:06:57 GMT, Lance Andersen wrote: > Hi, > > Please review this update to the ZipInputStream class description to clarify > that ZipInputStream walks sequentially through each Zip Entry contained > within the Zip File. As a result, the CEN header for the Zip file entries

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v4]

On Fri, 16 Sep 2022 18:01:40 GMT, Alan Bateman wrote: > Okay, in which case what would you think about just saying that the > getNextEntry/getNextJarEntry method do not return the Manifest when it's at > the start of the stream, and it's unspecified whether they return the > Manifest when it

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v4]

On Fri, 16 Sep 2022 16:15:44 GMT, Lance Andersen wrote: >> src/java.base/share/classes/java/util/jar/JarInputStream.java line 51: >> >>> 49: * If {@code META-INF/} is the first entry in the input stream it will >>> be >>> 50: * also not be returned by {@link #getNextEntry()} and >>> 51: *

Re: RFR: 8293499: Provide jmod --compress option [v7]

On Fri, 16 Sep 2022 08:03:28 GMT, Aleksey Shipilev wrote: >> I have been looking into `make clean-images images` performance, and >> realized jmod keeps compressing files with default compression level. Tuning >> that toward lighter compression levels improves build performance >>

Integrated: JDK-8293892: Add links to JVMS 19 and 20 from ClassFileFormatVersion enum constants

On Fri, 16 Sep 2022 02:59:32 GMT, Joe Darcy wrote: > Analogous fix to one already done for javax.lang.model.SourceVersion > (JDK-8293768), the links to JVMS 19 and 20 are not currently valid, but > redirect to the spec language page > > https://docs.oracle.com/javase/specs/index.html > > The

Re: RFR: 8293499: Provide jmod --compress option [v7]

On Fri, 16 Sep 2022 08:03:28 GMT, Aleksey Shipilev wrote: >> I have been looking into `make clean-images images` performance, and >> realized jmod keeps compressing files with default compression level. Tuning >> that toward lighter compression levels improves build performance >>

Re: RFR: JDK-8293659: Improve UnsatisfiedLinkError error message to include dlopen error details [v2]

On Fri, 16 Sep 2022 07:27:44 GMT, Matthias Baesken wrote: >> When trying to load a x64 lib on macOS aarch64 one got previously this >> detailed message before >> [JDK-8275703](https://bugs.openjdk.org/browse/JDK-8275703): >> >> java.lang.UnsatisfiedLinkError:

Re: RFR: JDK-8293892: Add links to JVMS 19 and 20 from ClassFileFormatVersion enum constants

On Fri, 16 Sep 2022 02:59:32 GMT, Joe Darcy wrote: > Analogous fix to one already done for javax.lang.model.SourceVersion > (JDK-8293768), the links to JVMS 19 and 20 are not currently valid, but > redirect to the spec language page > > https://docs.oracle.com/javase/specs/index.html > > The

Re: RFR: 8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows environment [v3]

On Fri, 16 Sep 2022 13:59:32 GMT, Roger Riggs wrote: >> I'm sorry, I can't replace this code with a HexFormat one-line. Do you have >> an example code? > > Extract to a byte array with the appropriate charset and then HexFormat the > bytearray. > > > var SysPropHexVal = >

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v4]

On Fri, 16 Sep 2022 13:06:28 GMT, Alan Bateman wrote: >> Lance Andersen has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address latest input regarding wording > > src/java.base/share/classes/java/util/jar/JarInputStream.java line 44: >

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v5]

> Please review this PR which updates the JarInputStream class description to > clarify when the Manifest is accessible via JarInputStream::getManifest and > JarInputStream::get[Jar]Entry. > > It is worth noting that with this update, we are finally documenting > behavior that dates back to

Re: RFR: 8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows environment [v3]

On Fri, 16 Sep 2022 08:31:19 GMT, KIRIYAMA Takuya wrote: >> test/jdk/tools/launcher/I18NArgTest.java line 147: >> >>> 145: for (int i = 0; i < sysPropVal.length(); i++) { >>> 146: sysPropHexVal = >>> sysPropHexVal.concat(Integer.toHexString(sysPropVal.charAt(i)));

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v4]

On Wed, 14 Sep 2022 16:43:43 GMT, Lance Andersen wrote: >> Please review this PR which updates the JarInputStream class description to >> clarify when the Manifest is accessible via JarInputStream::getManifest and >> JarInputStream::get[Jar]Entry. >> >> It is worth noting that with this

Re: RFR: 8289610: Degrade Thread.stop [v3]

On Fri, 16 Sep 2022 09:45:14 GMT, Alan Bateman wrote: >> Degrade Thread.stop to throw UOE unconditionally, deprecate ThreadDeath for >> removal, and remove the remaining special handling of ThreadDeath from the >> JDK. >> >> Thread.stop is inherently unsafe and has been deprecated since JDK

Re: RFR: 8293910: tools/launcher/FXLauncherTest.java fail with jfx

On Fri, 16 Sep 2022 07:35:03 GMT, Leslie Zhai wrote: > Hi, > > @dumasun reported the issue: > > Configured with jfx-ls-modular-sdk: > > > configure --with-import-modules=modular-sdk > > > `make run-test CONF=fastdebug TEST="tools/launcher/FXLauncherTest.java"` > failed: > > >

Re: RFR: 8293910: tools/launcher/FXLauncherTest.java fail with jfx

On Fri, 16 Sep 2022 07:35:03 GMT, Leslie Zhai wrote: > Hi, > > @dumasun reported the issue: > > Configured with jfx-ls-modular-sdk: > > > configure --with-import-modules=modular-sdk > > > `make run-test CONF=fastdebug TEST="tools/launcher/FXLauncherTest.java"` > failed: > > >

Re: RFR: 8278165: Clarify that ZipInputStream does not access the CEN fields for a ZipEntry [v6]

On Fri, 16 Sep 2022 11:01:02 GMT, Lance Andersen wrote: >> Hi, >> >> Please review this update to the ZipInputStream class description to clarify >> that ZipInputStream walks sequentially through each Zip Entry contained >> within the Zip File. As a result, the CEN header for the Zip file

Re: RFR: 8278165: Clarify that ZipInputStream does not access the CEN fields for a ZipEntry [v6]

> Hi, > > Please review this update to the ZipInputStream class description to clarify > that ZipInputStream walks sequentially through each Zip Entry contained > within the Zip File. As a result, the CEN header for the Zip file entries > are not read resulting in ZipInputStream not having

Re: RFR: JDK-8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present

On Fri, 16 Sep 2022 08:38:05 GMT, Alan Bateman wrote: > Do you think it would be possible to create a small test case that > demonstrates the issue? A number of the fixes to jdeps in recent releases > have be due to some unusual scenarios and I think it would be useful to build > up more test

Integrated: 8290367: Update default value and extend the scope of com.sun.jndi.ldap.object.trustSerialData system property

On Fri, 9 Sep 2022 11:03:14 GMT, Aleksei Efimov wrote: > ### Summary of the change > > The LDAP Naming Service Provider implementation's default settings are > changed to disallow deserialization and reconstruction of Java objects from > different LDAP attributes (RFC 2713). Currently, only

Re: RFR: 8289610: Degrade Thread.stop [v3]

On Fri, 16 Sep 2022 09:45:14 GMT, Alan Bateman wrote: >> Degrade Thread.stop to throw UOE unconditionally, deprecate ThreadDeath for >> removal, and remove the remaining special handling of ThreadDeath from the >> JDK. >> >> Thread.stop is inherently unsafe and has been deprecated since JDK

Re: RFR: 8289610: Degrade Thread.stop [v3]

> Degrade Thread.stop to throw UOE unconditionally, deprecate ThreadDeath for > removal, and remove the remaining special handling of ThreadDeath from the > JDK. > > Thread.stop is inherently unsafe and has been deprecated since JDK 1.2 (1998) > with a link to a supplementary page that

Re: RFR: JDK-8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present

On Fri, 16 Sep 2022 08:26:00 GMT, Matthias Baesken wrote: > We noticed that with certain jar file input, jdeps runs into the following > exception, this happens with jdk11, 17 and 20. > > jdeps.exe --multi-release 11 --module-path . --inverse --package > com.sap.nw.performance.supa.client

Integrated: 8293819: sun/util/logging/PlatformLoggerTest.java failed with "RuntimeException: Retrieved backing PlatformLogger level null is not the expected CONFIG"

On Thu, 15 Sep 2022 11:29:40 GMT, Daniel Fuchs wrote: > The sun/util/logging/PlatformLoggerTest.java is missing a couple of > Reference::reachabilityFence calls to maintain loggers alive while the test > is running. It has been observed failing under stress. This pull request has now been

Re: RFR: 8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows environment [v3]

On Sat, 27 Aug 2022 00:19:28 GMT, Naoto Sato wrote: >> KIRIYAMA Takuya has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows > > test/jdk/tools/launcher/I18NArgTest.java line

Re: RFR: 8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows environment [v4]

> I removed a section of via JDK_JAVA_OPTIONS because including main class is > not allowed in the specification. > This behavior is added in JDK-8170832, which add JAVA_OPTIONS environment > variable. At this time, this test is mismatch with the specification. > I tried to test and get Passed

Re: RFR: JDK-8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present

On Fri, 16 Sep 2022 08:26:00 GMT, Matthias Baesken wrote: > We noticed that with certain jar file input, jdeps runs into the following > exception, this happens with jdk11, 17 and 20. > > jdeps.exe --multi-release 11 --module-path . --inverse --package > com.sap.nw.performance.supa.client

Re: RFR: 8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows environment [v3]

On Sat, 27 Aug 2022 00:20:46 GMT, Naoto Sato wrote: >> KIRIYAMA Takuya has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows > > test/jdk/tools/launcher/I18NArgTest.java line

RFR: JDK-8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present

We noticed that with certain jar file input, jdeps runs into the following exception, this happens with jdk11, 17 and 20. jdeps.exe --multi-release 11 --module-path . --inverse --package com.sap.nw.performance.supa.client test.jar Inverse transitive dependences matching packages

Re: RFR: 8293499: Provide jmod --compress option [v6]

On Tue, 13 Sep 2022 17:41:04 GMT, Aleksey Shipilev wrote: >> I have been looking into `make clean-images images` performance, and >> realized jmod keeps compressing files with default compression level. Tuning >> that toward lighter compression levels improves build performance >>

Re: RFR: 8293499: Provide jmod --compress option [v7]

> I have been looking into `make clean-images images` performance, and realized > jmod keeps compressing files with default compression level. Tuning that > toward lighter compression levels improves build performance considerably, > without a heavy loss in *.jmod sizes. > > This PR allows

Re: RFR: 8293910: tools/launcher/FXLauncherTest.java fail with jfx

On Fri, 16 Sep 2022 07:35:03 GMT, Leslie Zhai wrote: > Hi, > > @dumasun reported the issue: > > Configured with jfx-ls-modular-sdk: > > > configure --with-import-modules=modular-sdk > > > `make run-test CONF=fastdebug TEST="tools/launcher/FXLauncherTest.java"` > failed: > > >

RFR: 8293910: tools/launcher/FXLauncherTest.java fail with jfx

Hi, @dumasun reported the issue: Configured with jfx-ls-modular-sdk: configure --with-import-modules=modular-sdk `make run-test CONF=fastdebug TEST="tools/launcher/FXLauncherTest.java"` failed: --System.err:(11/697)-- java.lang.RuntimeException: JavaFX modules erroneously

Re: RFR: JDK-8293659: Improve UnsatisfiedLinkError error message to include dlopen error details

On Thu, 15 Sep 2022 11:54:41 GMT, Matthias Baesken wrote: > When trying to load a x64 lib on macOS aarch64 one got previously this > detailed message before > [JDK-8275703](https://bugs.openjdk.org/browse/JDK-8275703): > > java.lang.UnsatisfiedLinkError:

Re: RFR: JDK-8293659: Improve UnsatisfiedLinkError error message to include dlopen error details [v2]

> When trying to load a x64 lib on macOS aarch64 one got previously this > detailed message before > [JDK-8275703](https://bugs.openjdk.org/browse/JDK-8275703): > > java.lang.UnsatisfiedLinkError: /testing/jco3/macOsx64/libsapjco3.dylib: > dlopen(/testing/jco3/macOsx64/libsapjco3.dylib, 1): no

Re: RFR: 8293499: Provide jmod --compress option [v6]

On Tue, 13 Sep 2022 17:41:04 GMT, Aleksey Shipilev wrote: >> I have been looking into `make clean-images images` performance, and >> realized jmod keeps compressing files with default compression level. Tuning >> that toward lighter compression levels improves build performance >>

Withdrawn: JDK-8287597: List all preview features on the javadoc PREVIEW page

On Thu, 30 Jun 2022 15:14:40 GMT, Hannes Wallnöfer wrote: > Please review an enhancement to the preview page to add a list of preview > features and allow users to explore the preview APIs by feature. > > While the changes for the enhancement itself are not overly complex, the work >