Re: RFR: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts [v3]

On Thu, 15 Sep 2022 08:55:41 GMT, Severin Gehwolf wrote: >> Similar issue to the hotspot change discussed in >> https://bugs.openjdk.org/browse/JDK-8293472. The Java metrics implementation >> may get the resource limits wrong if there are additional cgroup fs mounts. >> Apparently that's more

Integrated: 8293613: need to properly handle and hide tmp VTMS transitions

On Sun, 18 Sep 2022 09:13:11 GMT, Serguei Spitsyn wrote: > There are several places in VirtualThread class implementation where virtual > threads are being mounted or unmounted, so there is a transition of the > JavaThread identity from carrier thread to virtual thread and back. The >

Re: RFR: 8293613: need to properly handle and hide tmp VTMS transitions [v4]

On Thu, 22 Sep 2022 09:16:28 GMT, Serguei Spitsyn wrote: >> There are several places in VirtualThread class implementation where virtual >> threads are being mounted or unmounted, so there is a transition of the >> JavaThread identity from carrier thread to virtual thread and back. The >>

Re: RFR: 8065554: MatchResult should provide values of named-capturing groups [v7]

On Thu, 22 Sep 2022 10:22:40 GMT, Raffaello Giulietti wrote: >> Add support for named groups to java.util.regex.MatchResult > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > 8065554: MatchResult should provide values

Re: RFR: 8292016: Split Windows API error handling from errors passed through the runtime in the JDK [v22]

On Tue, 27 Sep 2022 16:14:43 GMT, Julian Waters wrote: > Are any of these a part of the public JNI API? No this is all internal-use-only - PR: https://git.openjdk.org/jdk/pull/9870

Integrated: 8290482: Update JNI Specification of DestroyJavaVM for better alignment with JLS, JVMS, and Java SE API Specifications

On Tue, 20 Sep 2022 00:55:32 GMT, David Holmes wrote: > This update is primarily about changes to the JNI Invocation API > specification, mainly in relation to `DestroyJavaVM`. The motivation for the > changes is to align with changes being made to the JLS, JVMS and > `java.lang.Runtime`,

Re: RFR: 8290482: Update JNI Specification of DestroyJavaVM for better alignment with JLS, JVMS, and Java SE API Specifications [v4]

On Tue, 20 Sep 2022 10:37:41 GMT, David Holmes wrote: >> This update is primarily about changes to the JNI Invocation API >> specification, mainly in relation to `DestroyJavaVM`. The motivation for the >> changes is to align with changes being made to the JLS, JVMS and >> `java.lang.Runtime`,

Re: RFR: 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni [v2]

On Mon, 26 Sep 2022 19:36:02 GMT, Lance Andersen wrote: > Thank you for your efforts on the cleaning up these typos > > I would suggest breaking these changes into separate PRs by team as there > seems to be changes to hotspot, core-libs, and client to make it easier to > review. > > I

Re: RFR: 8237467: jlink plugin to save the argument files as input to jlink in the output image [v3]

On Tue, 27 Sep 2022 22:37:16 GMT, Doug Simon wrote: >> This PR adds a new jlink plugin (`--save-jlink-argfiles=`) to >> support persisting jlink options. >> >> >>> echo "--add-modules jdk.internal.vm.ci --add-options=-Dfoo=xyzzy >>> --vendor-version="XyzzyVM 3.14.15" >>>

Re: RFR: 8237467: jlink plugin to save the argument files as input to jlink in the output image [v3]

> This PR adds a new jlink plugin (`--save-jlink-argfiles=`) to > support persisting jlink options. > > >> echo "--add-modules jdk.internal.vm.ci --add-options=-Dfoo=xyzzy >> --vendor-version="XyzzyVM 3.14.15" --vendor-bug-url=https://bugs.xyzzy.com/; >> > my_image.argfile >> export

Re: RFR: 8237467: jlink plugin to save the argument files as input to jlink in the output image [v2]

On Tue, 27 Sep 2022 22:01:40 GMT, Doug Simon wrote: >> This PR adds a new jlink plugin (`--save-jlink-argfiles=`) to >> support persisting jlink options. >> >> >>> echo "--add-modules jdk.internal.vm.ci --add-options=-Dfoo=xyzzy >>> --vendor-version="XyzzyVM 3.14.15" >>>

Re: RFR: 8237467: effect of jlink plugins for vendor information and command-line options should be sticky [v2]

> This PR adds a new jlink plugin (`--save-jlink-argfiles=`) to > support persisting jlink options. > > >> echo "--add-modules jdk.internal.vm.ci --add-options=-Dfoo=xyzzy >> --vendor-version="XyzzyVM 3.14.15" --vendor-bug-url=https://bugs.xyzzy.com/; >> > my_image.argfile >> export

Re: RFR: 8290036: Define and specify Runtime shutdown sequence [v8]

> The concept of the shutdown sequence needs to be specified more clearly. This > PR adds text for this into the class specification of `java.lang.Runtime`. > Also includes adjustments to related areas in `addShutdownHook`, `halt`, and > in the `System` and `Thread` classes. The changes here

Re: RFR: 8293613: need to properly handle and hide tmp VTMS transitions [v4]

On Thu, 22 Sep 2022 09:16:28 GMT, Serguei Spitsyn wrote: >> There are several places in VirtualThread class implementation where virtual >> threads are being mounted or unmounted, so there is a transition of the >> JavaThread identity from carrier thread to virtual thread and back. The >>

Re: [External] : Re: RFR: 8293462: [macos] app image signature invalid when creating DMG or PKG from post processed signed image

> On Sep 27, 2022, at 2:48 PM, Alexander Matveev > wrote: > > Hi Michael, > > It is not possible to provide a unique or hashed CFBundleIdentifier. We > already implemented to throw error if —strip-native-commands are not provided > to jlink or if provided runtime contain bin directory. >

Integrated: 8293592: Remove JVM_StopThread, stillborn, and related cleanup

On Fri, 23 Sep 2022 06:17:34 GMT, David Holmes wrote: > Now that Thread.stop has been degraded to throw > `UnsupportedOperationException` (JDK-8299610) the only direct source of async > exceptions is from JVMTI `StopThread`. We can remove the `JVM_StopThread` > code, remove the `stillborn`

Re: RFR: 8293806: JDK_JAVA_OPTIONS picked up twice if LD_LIBRARY_PATH is set

On Mon, 26 Sep 2022 18:15:17 GMT, Dmitry Samersoff wrote: > If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options > from the JDK_JAVA_OPTIONS environment variable are picked up twice. > > If an option cannot be accepted twice (e.g., -agentlib), the application > fails to

Re: RFR: 8293592: Remove JVM_StopThread, stillborn, and related cleanup [v2]

On Tue, 27 Sep 2022 08:01:48 GMT, Robbin Ehn wrote: >> David Holmes has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 16 commits: >> >> - Merge branch 'master' into 8293592-JVM_StopThread >> - Removal all special handling of

Re: RFR: 8237467: effect of jlink plugins for vendor information and command-line options should be sticky

On Tue, 27 Sep 2022 19:11:07 GMT, Mandy Chung wrote: >> This PR adds a new jlink plugin (`--save-jlink-argfiles=`) to >> support persisting jlink options. >> >> >>> echo "--add-modules jdk.internal.vm.ci --add-options=-Dfoo=xyzzy >>> --vendor-version="XyzzyVM 3.14.15" >>>

Re: Thread Weak Local / Thread Rental

Hi, Have you considered switching to java.time.format.DateTimeFormatter ? If you are going to have to change the callsites, you can use a faster and more modern API at the same time.

Thread Weak Local / Thread Rental

Hey folks, I’ve been looking at some performance bottlenecks in a system recently, and found that we have some that stem from synchronizing on a SimpleDateFormat (which, as we know, isn’t thread safe.) This got me thinking about switching to a ThreadLocal of them, but I realized that I don’t

Re: RFR: 8294472: Remove redundant rawtypes suppression in AbstractChronology

On Mon, 26 Sep 2022 19:12:16 GMT, Andrey Turbanov wrote: > Found this redundant suppressions by IntelliJ IDEA inspection. > Seems initially `Chronology` was generic class? +1 - Marked as reviewed by naoto (Reviewer). PR: https://git.openjdk.org/jdk/pull/10433

Re: RFR: 8294198: Implement isFinite intrinsic for RISC-V

On Thu, 22 Sep 2022 12:56:49 GMT, Aleksei Voitylov wrote: > Unlike on x86 (see 8285868 and the discussion in review), isFinite intrinsic > turned out to be profitable on RISC-V using the same fclass instruction as > for 8293695 (isInfinite instrinsic). Therefore, I'm proposing to have it >

Re: RFR: 8292177: InitialSecurityProperty JFR event

On Thu, 22 Sep 2022 15:57:56 GMT, Sean Coffey wrote: > New JFR event to record state of initial security properties. > > Debug output is also now added for these properties via > -Djava.security.debug=properties src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java line 312:

Re: [External] : Re: RFR: 8293462: [macos] app image signature invalid when creating DMG or PKG from post processed signed image

Hi Michael, It is not possible to provide a unique or hashed CFBundleIdentifier. We already implemented to throw error if —strip-native-commands are not provided to jlink or if provided runtime contain bin directory. Look at https://github.com/openjdk/jdk/pull/8666 Thanks, Alexander On Sep

Re: RFR: 8294472: Remove redundant rawtypes suppression in AbstractChronology

On Mon, 26 Sep 2022 19:12:16 GMT, Andrey Turbanov wrote: > Found this redundant suppressions by IntelliJ IDEA inspection. > Seems initially `Chronology` was generic class? Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.org/jdk/pull/10433

RFR: 8294472: Remove redundant rawtypes suppression in AbstractChronology

Found this redundant suppressions by IntelliJ IDEA inspection. Seems initially `Chronology` was generic class? - Commit messages: - [PATCH] Remove redundant rawtypes suppression in AbstractChronology Changes: https://git.openjdk.org/jdk/pull/10433/files Webrev:

Re: RFR: 8237467: effect of jlink plugins for vendor information and command-line options should be sticky

On Tue, 27 Sep 2022 19:00:01 GMT, Mandy Chung wrote: >> This PR adds a new jlink plugin (`--save-jlink-argfiles=`) to >> support persisting jlink options. >> >> >>> echo "--add-modules jdk.internal.vm.ci --add-options=-Dfoo=xyzzy >>> --vendor-version="XyzzyVM 3.14.15" >>>

Re: RFR: 8237467: effect of jlink plugins for vendor information and command-line options should be sticky

On Tue, 27 Sep 2022 11:12:57 GMT, Doug Simon wrote: > This PR adds a new jlink plugin (`--save-jlink-argfiles=`) to > support persisting jlink options. > > >> echo "--add-modules jdk.internal.vm.ci --add-options=-Dfoo=xyzzy >> --vendor-version="XyzzyVM 3.14.15"

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v10]

On Tue, 27 Sep 2022 13:20:51 GMT, Jatin Bhateja wrote: >> Smita Kamath has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressed review comments > > I have verified my other comments, we can either handle auto-vectorization > of newly

Re: RFR: 8294394: running jlink in GraalVM must copy libgraal into the output image

On Tue, 27 Sep 2022 11:30:26 GMT, Doug Simon wrote: > This PR adds a new jlink plugin (`--copy-files=`) that copies > specified files from the current image into the output image. > This is useful in the context of GraalVM where libgraal (e.g. > `lib/libjvmcicompiler.so`) is produced after the

Re: RFR: 8294198: Implement isFinite intrinsic for RISC-V

On Thu, 22 Sep 2022 12:56:49 GMT, Aleksei Voitylov wrote: > Unlike on x86 (see 8285868 and the discussion in review), isFinite intrinsic > turned out to be profitable on RISC-V using the same fclass instruction as > for 8293695 (isInfinite instrinsic). Therefore, I'm proposing to have it >

Re: RFR: 8292016: Split Windows API error handling from errors passed through the runtime in the JDK [v22]

On Tue, 27 Sep 2022 04:22:59 GMT, David Holmes wrote: > This seems to be trying to future-proof the reporting code by introducing a > duality that is not actually needed at present in some cases. That means the > code is untested. Are there planned uses of `RUNTIME` in the very near future?

Integrated: 8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows environment

On Wed, 6 Jul 2022 06:40:32 GMT, KIRIYAMA Takuya wrote: > I removed a section of via JDK_JAVA_OPTIONS because including main class is > not allowed in the specification. > This behavior is added in JDK-8170832, which add JAVA_OPTIONS environment > variable. At this time, this test is mismatch

Integrated: 8294317: Insufficient build rules for tzdb.dat

On Fri, 23 Sep 2022 22:10:03 GMT, Naoto Sato wrote: > The current makefile for `tzdb.dat` won't recompile if some dependent files > (e.g. `VERSION`) are updated. Adding all files under the tzdb directory to > the dependency will fix this issue. This pull request has now been integrated.

Re: RFR: 8294198: Implement isFinite intrinsic for RISC-V

On Thu, 22 Sep 2022 12:56:49 GMT, Aleksei Voitylov wrote: > Unlike on x86 (see 8285868 and the discussion in review), isFinite intrinsic > turned out to be profitable on RISC-V using the same fclass instruction as > for 8293695 (isInfinite instrinsic). Therefore, I'm proposing to have it >

Re: RFR: 8294394: running jlink in GraalVM must copy libgraal into the output image

On Tue, 27 Sep 2022 11:30:26 GMT, Doug Simon wrote: > This PR adds a new jlink plugin (`--copy-files=`) that copies > specified files from the current image into the output image. > This is useful in the context of GraalVM where libgraal (e.g. > `lib/libjvmcicompiler.so`) is produced after the

Re: RFR: 8293806: JDK_JAVA_OPTIONS picked up twice if LD_LIBRARY_PATH is set

On Tue, 27 Sep 2022 06:00:10 GMT, David Holmes wrote: > Sorry @dsamersoff but I don't understand how this arises - can you explain in > more detail please? I'm not seeing the connection between setting > `LD_LIBRARY_PATH` and reading an env var twice. Thanks Linker read LD_LIBRARY_PATH only

Re: RFR: 8292937: Improve performance of some read operations of RandomAccessFile [v5]

On Fri, 26 Aug 2022 20:59:57 GMT, Сергей Цыпанов wrote: >> Currently some operations of RandomAccessFile are implemented with multiple >> read() invocations: >> >> public final int readInt() throws IOException { >> int ch1 = this.read(); >> int ch2 = this.read(); >> int ch3 =

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v10]

On Tue, 27 Sep 2022 07:40:19 GMT, Smita Kamath wrote: >> 8289552: Make intrinsic conversions between bit representations of half >> precision values and floats > > Smita Kamath has updated the pull request incrementally with one additional > commit since the last revision: > > Addressed

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v10]

On Tue, 27 Sep 2022 07:40:19 GMT, Smita Kamath wrote: >> 8289552: Make intrinsic conversions between bit representations of half >> precision values and floats > > Smita Kamath has updated the pull request incrementally with one additional > commit since the last revision: > > Addressed

Integrated: 8294361: Cleanup usages of StringBuffer in SQLOutputImpl

On Sat, 17 Sep 2022 21:43:04 GMT, Andrey Turbanov wrote: > There a few unnecessary usages of StringBuffer in SQLOutputImpl class. > All of them create StringBuffer from single character and then concatenate > with String. Instead of this, we can concatenate character directly. This pull

Re: RFR: 8294376: Minimize disabled warnings in java.base [v2]

On Tue, 27 Sep 2022 08:32:09 GMT, Magnus Ihse Bursie wrote: >> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now >> possible to disable warnings for individual files instead for whole >> libraries. I used this opportunity to go through all disabled warnings in >>

Re: RFR: 8293592: Remove JVM_StopThread, stillborn, and related cleanup [v2]

On Fri, 23 Sep 2022 21:47:06 GMT, David Holmes wrote: >> Now that Thread.stop has been degraded to throw >> `UnsupportedOperationException` (JDK-8299610) the only direct source of >> async exceptions is from JVMTI `StopThread`. We can remove the >> `JVM_StopThread` code, remove the

Re: RFR: 8294377: Prepare to stop auto-inheriting documentation for subclasses of exceptions whose documentation is inherited [v2]

> This adds exception documentation to JDK methods that would otherwise lose > that documentation once JDK-8287796 is integrated. While adding this > exception documentation now does not change [^1] the JDK API Documentation, > it will automatically counterbalance the effect that JDK-8287796

RFR: 8294377: Prepare to stop auto-inheriting documentation for subclasses of exceptions whose documentation is inherited

This adds exception documentation to JDK methods that would otherwise lose that documentation once JDK-8287796 is integrated. While adding this exception documentation now does not change [^1] the JDK API Documentation, it will automatically counterbalance the effect that JDK-8287796 will have.

Integrated: 8249627: Degrade Thread.suspend and Thread.resume

On Sun, 18 Sep 2022 16:32:31 GMT, Alan Bateman wrote: > Degrade Thread.suspend/resume to throw UOE unconditionally. > > Another step in the removal of this deadlock prone mis-feature from the > user-facing API. Thread.suspend/resume have been deprecated since JDK 1.2 > (1998) and terminally

Re: RFR: 8293462: [macos] app image signature invalid when creating DMG or PKG from post processed signed image

> On Sep 26, 2022, at 9:24 PM, Michael Hall wrote: > > > >> On Sep 20, 2022, at 5:50 PM, Michael Hall > > wrote: >> >> Still you could use post-processing to add whatever java binary executable >> commands you wanted. This again would mean changes to the embedded

Re: RFR: 8249627: Degrade Thread.suspend and Thread.resume [v3]

On Sat, 24 Sep 2022 06:50:45 GMT, Alan Bateman wrote: >> Degrade Thread.suspend/resume to throw UOE unconditionally. >> >> Another step in the removal of this deadlock prone mis-feature from the >> user-facing API. Thread.suspend/resume have been deprecated since JDK 1.2 >> (1998) and

RFR: 8294394: running jlink in GraalVM must copy libgraal into the output image

This PR adds a new jlink plugin (`--copy-files=`) that copies specified files from the current image into the output image. This is useful in the context of GraalVM where libgraal (e.g. `lib/libjvmcicompiler.so`) is produced after the final jlink step in the GraalVM JDK build process. The

RFR: 8237467: effect of jlink plugins for vendor information and command-line options should be sticky

This PR adds a new jlink plugin (`--save-jlink-argfiles=`) to support persisting jlink options. > echo "--add-modules jdk.internal.vm.ci --add-options=-Dfoo=xyzzy > --vendor-version="XyzzyVM 3.14.15" --vendor-bug-url=https://bugs.xyzzy.com/; > > my_image.argfile > export ALL_MODULES=$(java

Re: RFR: JDK-8287597: List all preview features on the javadoc PREVIEW page [v4]

> Please review an enhancement to the preview page to add a list of preview > features and allow users to explore the preview APIs by feature. > > While the changes for the enhancement itself are not overly complex, the work > entailed a moderate cleanup of other summary API lists (Deprecated

Integrated: 8292969: Bad Thread Utilization in ForkJoinPool

On Wed, 7 Sep 2022 12:44:11 GMT, Doug Lea wrote: > 8292969: This small change in signal propagation rules improves utilization > when entry queues are resized, This pull request has now been integrated. Changeset: bc12e955 Author:Doug Lea URL:

Re: RFR: 8294198: Implement isFinite intrinsic for RISC-V

On Thu, 22 Sep 2022 12:56:49 GMT, Aleksei Voitylov wrote: > Unlike on x86 (see 8285868 and the discussion in review), isFinite intrinsic > turned out to be profitable on RISC-V using the same fclass instruction as > for 8293695 (isInfinite instrinsic). Therefore, I'm proposing to have it >

Collections.shuffle to accept RandomGenerator

Hello! Currently, Collections.shuffle(List, Random) accepts an outdated Random class instead of RandomGenerator interface. It looks like, RandomGenerator would suffice. The code change looks trivial (aside from documentation and testing), as shuffle() implementation does not need anything except

Re: RFR: 8294376: Minimize disabled warnings in java.base [v2]

> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now > possible to disable warnings for individual files instead for whole > libraries. I used this opportunity to go through all disabled warnings in > java.base native libraries. > > Any warnings that were only

Re: RFR: 8293592: Remove JVM_StopThread, stillborn, and related cleanup [v2]

On Fri, 23 Sep 2022 21:47:06 GMT, David Holmes wrote: >> Now that Thread.stop has been degraded to throw >> `UnsupportedOperationException` (JDK-8299610) the only direct source of >> async exceptions is from JVMTI `StopThread`. We can remove the >> `JVM_StopThread` code, remove the

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v8]

On Wed, 21 Sep 2022 16:41:19 GMT, Vladimir Kozlov wrote: >> Smita Kamath has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressed review comments > > tier2 and 3 passed. I will wait update with test and JVMCI fix before doing > more

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v8]

On Wed, 21 Sep 2022 17:49:51 GMT, Jatin Bhateja wrote: >> Smita Kamath has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressed review comments > > src/hotspot/share/opto/convertnode.cpp line 166: > >> 164: >>

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v10]

> 8289552: Make intrinsic conversions between bit representations of half > precision values and floats Smita Kamath has updated the pull request incrementally with one additional commit since the last revision: Addressed review comments - Changes: - all:

Re: RFR: 8294376: Minimize disabled warnings in java.base

On Mon, 26 Sep 2022 17:03:40 GMT, Aleksey Shipilev wrote: >> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now >> possible to disable warnings for individual files instead for whole >> libraries. I used this opportunity to go through all disabled warnings in >>

Re: RFR: 8293409: [vectorapi] Intrinsify VectorSupport.indexVector

On Mon, 19 Sep 2022 08:51:24 GMT, Xiaohong Gong wrote: > "`VectorSupport.indexVector()`" is used to compute a vector that contains the > index values based on a given vector and a scale value (`i.e. index = vec + > iota * scale`). This function is widely used in other APIs like >

Re: RFR: 8293806: JDK_JAVA_OPTIONS picked up twice if LD_LIBRARY_PATH is set

On Mon, 26 Sep 2022 18:15:17 GMT, Dmitry Samersoff wrote: > If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options > from the JDK_JAVA_OPTIONS environment variable are picked up twice. > > If an option cannot be accepted twice (e.g., -agentlib), the application > fails to