On Fri, 30 Sep 2022 20:08:10 GMT, Justin Lu wrote:
>> Problem: Unnecessary instances of StringBuffer within java.text (internal
>> only)
>>
>> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
>> names
>
> Justin Lu has updated the pull request incrementally with two
On Fri, 30 Sep 2022 21:46:34 GMT, Stuart Marks wrote:
>> The concept of the shutdown sequence needs to be specified more clearly.
>> This PR adds text for this into the class specification of
>> `java.lang.Runtime`. Also includes adjustments to related areas in
>> `addShutdownHook`, `halt`,
> The concept of the shutdown sequence needs to be specified more clearly. This
> PR adds text for this into the class specification of `java.lang.Runtime`.
> Also includes adjustments to related areas in `addShutdownHook`, `halt`, and
> in the `System` and `Thread` classes. The changes here
On Thu, 11 Aug 2022 07:23:28 GMT, David Holmes wrote:
>> What you have is okay although I would have preferred if the sentence on the
>> join method was in the previous paragraph rather as it fits with termination.
>
> Plus one on the join() bit. You could also argue for mentioning isAlive()
>
On Thu, 1 Sep 2022 06:31:11 GMT, David Holmes wrote:
>> There are subtle differences (invoking a virtual Thread's run method
>> directly does no nothing) but that is too much detail and would confusing to
>> say anything about in the introduction paragraphs.
>>
>> The following is closer to
On Wed, 28 Sep 2022 15:36:50 GMT, Viktor Klang wrote:
> This JavaDoc change attempts to shine some light on the `combiner`-function
> as it relates to the third variant of `Stream.reduce` since it according to
> the bug submission in JBS can be confusing that the `combiner` is not
> mentioned
On Fri, 30 Sep 2022 17:38:54 GMT, Phil Race wrote:
> This is correct. AccessBridge.h is published with the include/header files of
> the JDK and anyone reading it there can't exactly make use of "../"
Update to persistent git links.
-
PR: https://git.openjdk.org/jdk/pull/10501
On Fri, 30 Sep 2022 13:59:12 GMT, Magnus Ihse Bursie wrote:
> Also, FWIW, there are 100+ hits in `test` as well. But that is so many it
> might warrant a separate PR..?
Yes; I think it is sufficient to update src and doc with this PR.
-
PR: https://git.openjdk.org/jdk/pull/10501
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request with a new target base due to a merge or
a
On Fri, 30 Sep 2022 17:24:40 GMT, Joe Darcy wrote:
>> While the floating-point == operation is *not* an equivalence relation,
>> there are useful equivalence relations that can be defined over
>> floating-point values. Text is added to java.lang.Double to discuss and name
>> those relations.
On Wed, 28 Sep 2022 20:39:03 GMT, Andrey Turbanov wrote:
> Found this redundant suppressions by IntelliJ IDEA inspection.
> It seems [JDK-8189330](https://bugs.openjdk.org/browse/JDK-8189330) made them
> redundant.
This pull request has now been integrated.
Changeset: 375f02fb
Author:
On Thu, 29 Sep 2022 13:11:03 GMT, Raffaello Giulietti
wrote:
> This fixes misleading indentations, which allows enabling the (currently
> disabled) `misleading-indentation` warning flag on two `.gmk` files.
Marked as reviewed by iris (Reviewer).
-
PR:
> Problem: Unnecessary instances of StringBuffer within java.text (internal
> only)
>
> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
> names
Justin Lu has updated the pull request incrementally with two additional
commits since the last revision:
- Remove
On Thu, 29 Sep 2022 13:11:03 GMT, Raffaello Giulietti
wrote:
> This fixes misleading indentations, which allows enabling the (currently
> disabled) `misleading-indentation` warning flag on two `.gmk` files.
LGTM
-
Marked as reviewed by rriggs (Reviewer).
PR:
On Thu, 29 Sep 2022 15:12:06 GMT, Sean Coffey wrote:
>> With event streaming, beginChunk is usually to prefer. Otherwise, a client
>> that monitors the JVM must wait until the first chunk rotation to get the
>> data.
>>
>> That said, we want startup to be quick. There should probably be a
On Tue, 27 Sep 2022 12:14:23 GMT, Pavel Rappo wrote:
>> This adds exception documentation to JDK methods that would otherwise lose
>> that documentation once JDK-8287796 is integrated. While adding this
>> exception documentation now does not change [^1] the JDK API Documentation,
>> it will
On Thu, 29 Sep 2022 15:01:25 GMT, Roger Riggs wrote:
> Correct javadoc links and references.
>
> The links should refer to the method `()` instead of field.
>
> The apiNote in `getErrorStream` should refer to the error stream not the
> input stream and reader.
This pull request has now been
On Thu, 11 Aug 2022 10:35:55 GMT, Daniel Fuchs wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revise Implementation Note discussing JNI Invocation API.
>
> src/java.base/share/classes/java/lang/Runtime.java line
On Fri, 30 Sep 2022 01:11:45 GMT, Joe Darcy wrote:
>> With the domain change from openjdk.java.net to openjdk.org, references to
>> URLs in the sources should be updated.
>>
>> Updates were made using a shell script. I"ll run a copyright updater before
>> any push.
>
> Joe Darcy has updated
On Fri, 30 Sep 2022 14:16:24 GMT, Weijun Wang wrote:
>> src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.h line
>> 34:
>>
>>> 32: * the following link:
>>> 33: *
>>> 34: *
>>>
On Fri, 30 Sep 2022 16:52:40 GMT, Brent Christian wrote:
>> Due to some [bootstrapping
>> issues](https://stackoverflow.com/questions/71834059/why-invokedynamic-based-string-concatenation-is-not-available-for-javac-in-java)
>> in `java.base` explicit String concatenation is not translated into
On Fri, 30 Sep 2022 03:13:09 GMT, Sandhya Viswanathan
wrote:
>> @smita-kamath I have builds failures. Please, build and test yourself to
>> verify changes.
>>
>> src/hotspot/cpu/x86/assembler_x86.cpp: In member function 'void
>> Assembler::evcvtps2ph(Address, KRegister, XMMRegister, int,
> While the floating-point == operation is *not* an equivalence relation, there
> are useful equivalence relations that can be defined over floating-point
> values. Text is added to java.lang.Double to discuss and name those relations.
Joe Darcy has updated the pull request incrementally with
> EDIT: Cave and add the ErrorOrigin enum, to differentiate which error type
> the error reporting functions in libjava will look up. RUNTIME refers to
> errors passed through the runtime via errno, and SYSTEM is for native errors
> not visible to the runtime.
Julian Waters has updated the
On Thu, 29 Sep 2022 23:19:16 GMT, Justin Lu wrote:
> Problem: Amendment number outdated
>
> Fix: Update amendment number + date in properties file and test case data file
This pull request has now been integrated.
Changeset: 3b1bc217
Author:Justin Lu
Committer: Naoto Sato
URL:
> EDIT: Cave and add the ErrorOrigin enum, to differentiate which error type
> the error reporting functions in libjava will look up. RUNTIME refers to
> errors passed through the runtime via errno, and SYSTEM is for native errors
> not visible to the runtime.
Julian Waters has updated the
> EDIT: Cave and add the ErrorOrigin enum, to differentiate which error type
> the error reporting functions in libjava will look up. RUNTIME refers to
> errors passed through the runtime via errno, and SYSTEM is for native errors
> not visible to the runtime.
Julian Waters has updated the
On Fri, 30 Sep 2022 16:14:38 GMT, Сергей Цыпанов wrote:
>> src/java.base/share/classes/java/text/PatternEntry.java line 291:
>>
>>> 289: // We re-use these objects in order to improve performance
>>> 290: private StringBuilder newChars = new StringBuilder();
>>> 291:
> EDIT: Cave and add the ErrorOrigin enum, to differentiate which error type
> the error reporting functions in libjava will look up. RUNTIME refers to
> errors passed through the runtime via errno, and SYSTEM is for native errors
> not visible to the runtime.
Julian Waters has updated the
On Wed, 28 Sep 2022 08:07:25 GMT, Alan Bateman wrote:
> This is a test only change to split the execution of some of the larger tests
> for virtual threads and reduce the execution time of a few others.
>
> The tests StructuredTaskScopeTest, ThreadFockTest and
> ThreadPerTaskExecutorTest
On Fri, 30 Sep 2022 10:51:53 GMT, Matthias Baesken wrote:
>> We noticed that with certain jar file input, jdeps runs into the following
>> exception, this happens with jdk11, 17 and 20.
>>
>> jdeps.exe --multi-release 11 --module-path . --inverse --package
>>
On Thu, 29 Sep 2022 23:19:16 GMT, Justin Lu wrote:
> Problem: Amendment number outdated
>
> Fix: Update amendment number + date in properties file and test case data file
LGTM
-
Marked as reviewed by naoto (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10499
On Thu, 29 Sep 2022 22:29:43 GMT, Brent Christian wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Tweak indentation in PaternEntry
>
> src/java.base/share/classes/java/text/PatternEntry.java line 291:
>
>> 289:
On Wed, 28 Sep 2022 20:39:03 GMT, Andrey Turbanov wrote:
> Found this redundant suppressions by IntelliJ IDEA inspection.
> It seems [JDK-8189330](https://bugs.openjdk.org/browse/JDK-8189330) made them
> redundant.
Marked as reviewed by bpb (Reviewer).
-
PR:
On Thu, 29 Sep 2022 23:19:16 GMT, Justin Lu wrote:
> Problem: Amendment number outdated
>
> Fix: Update amendment number + date in properties file and test case data file
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10499
On Fri, 30 Sep 2022 04:05:51 GMT, Iris Clark wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> http -> https
>
> src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.h line
> 34:
>
>> 32: * the
On Fri, 30 Sep 2022 01:11:45 GMT, Joe Darcy wrote:
>> With the domain change from openjdk.java.net to openjdk.org, references to
>> URLs in the sources should be updated.
>>
>> Updates were made using a shell script. I"ll run a copyright updater before
>> any push.
>
> Joe Darcy has updated
On Tue, 26 Apr 2022 00:32:48 GMT, Naoto Sato wrote:
> This was caused by incorporating CLDR v39, which switched the Norwegian
> locale inheritance from `no` -> `nb` to `nb` ->`no` and moved the resources
> from `nb` to `no`, which now contradicts Java's locale fallback. Explicitly
>
On Wed, 28 Sep 2022 03:40:06 GMT, Yoshiki Sato wrote:
> Please review this PR. The change include some code changes in
> ZoneInfoFile.java and TestZoneInfo310.java since tzdata2022d breaks
> TestZoneInfo310.java.
Marked as reviewed by naoto (Reviewer).
-
PR:
On Mon, 26 Sep 2022 18:15:17 GMT, Dmitry Samersoff
wrote:
> If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options
> from the JDK_JAVA_OPTIONS environment variable are picked up twice.
>
> If an option cannot be accepted twice (e.g., -agentlib), the application
> fails to
On Wed, 28 Sep 2022 03:40:06 GMT, Yoshiki Sato wrote:
> Please review this PR. The change include some code changes in
> ZoneInfoFile.java and TestZoneInfo310.java since tzdata2022d breaks
> TestZoneInfo310.java.
This pull request has now been integrated.
Changeset: f0157336
Author:
On Fri, 30 Sep 2022 04:54:27 GMT, Yoshiki Sato wrote:
>> test/jdk/java/util/TimeZone/TimeZoneData/displaynames.txt line 170:
>>
>>> 168: Europe/Vilnius EET EEST
>>> 169: Europe/Warsaw CET CEST
>>> 170: Europe/Zaporozhye EET EEST
>>
>> Do we need to remove those newly linked zone ids from
Java Sound is in the client-libs area. You can file the bug yourself at
https://bugreport.java.com/ if you like, or ask the sponsor of your bug
(when one steps forward) to do it.
If you want to contribute your fix, please see the contributing a patch
section [1] in the JDK Developers Guide
On Thu, 30 Jun 2022 15:14:40 GMT, Hannes Wallnöfer wrote:
> Please review an enhancement to the preview page to add a list of preview
> features and allow users to explore the preview APIs by feature.
>
> While the changes for the enhancement itself are not overly complex, the work
>
On Fri, 30 Sep 2022 03:13:09 GMT, Sandhya Viswanathan
wrote:
>> @smita-kamath I have builds failures. Please, build and test yourself to
>> verify changes.
>>
>> src/hotspot/cpu/x86/assembler_x86.cpp: In member function 'void
>> Assembler::evcvtps2ph(Address, KRegister, XMMRegister, int,
On Thu, 29 Sep 2022 16:05:44 GMT, Matthias Baesken wrote:
>> We noticed that with certain jar file input, jdeps runs into the following
>> exception, this happens with jdk11, 17 and 20.
>>
>> jdeps.exe --multi-release 11 --module-path . --inverse --package
>>
> We noticed that with certain jar file input, jdeps runs into the following
> exception, this happens with jdk11, 17 and 20.
>
> jdeps.exe --multi-release 11 --module-path . --inverse --package
> com.sap.nw.performance.supa.client test.jar
>
> Inverse transitive dependences matching packages
On Thu, 29 Sep 2022 21:21:44 GMT, Jonathan Gibbons wrote:
> Approved, with a question...
>
> Looking at the generated output, would it be better to prefix theJEP numbers
> in the initial list of checkboxes with the word `JEP` ?
That format was suggested by Alex as it is the one used in other
On Wed, 28 Sep 2022 17:40:36 GMT, Smita Kamath wrote:
>> 8289552: Make intrinsic conversions between bit representations of half
>> precision values and floats
>
> Smita Kamath has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed
On Wed, 28 Sep 2022 08:07:25 GMT, Alan Bateman wrote:
> This is a test only change to split the execution of some of the larger tests
> for virtual threads and reduce the execution time of a few others.
>
> The tests StructuredTaskScopeTest, ThreadFockTest and
> ThreadPerTaskExecutorTest
On Thu, 29 Sep 2022 20:12:43 GMT, Jonathan Gibbons wrote:
>> Hannes Wallnöfer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix URL in test
>
>
On Wed, 28 Sep 2022 17:40:36 GMT, Smita Kamath wrote:
>> 8289552: Make intrinsic conversions between bit representations of half
>> precision values and floats
>
> Smita Kamath has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed
> Please review an enhancement to the preview page to add a list of preview
> features and allow users to explore the preview APIs by feature.
>
> While the changes for the enhancement itself are not overly complex, the work
> entailed a moderate cleanup of other summary API lists (Deprecated
On Fri, 30 Sep 2022 00:44:01 GMT, Stuart Marks wrote:
>> This JavaDoc change attempts to shine some light on the `combiner`-function
>> as it relates to the third variant of `Stream.reduce` since it according to
>> the bug submission in JBS can be confusing that the `combiner` is not
>>
On Tue, 13 Sep 2022 13:06:10 GMT, Severin Gehwolf wrote:
> Similar issue to the hotspot change discussed in
> https://bugs.openjdk.org/browse/JDK-8293472. The Java metrics implementation
> may get the resource limits wrong if there are additional cgroup fs mounts.
> Apparently that's more
55 matches
Mail list logo
