On Mon, 3 Oct 2022 07:29:02 GMT, Markus KARG wrote:
> Fixes JDK-8294702
src/java.base/share/classes/java/io/BufferedInputStream.java line 546:
> 544: private void implReset() throws IOException {
> 545: getBufIfOpen(); // Cause exception if closed
> 546: if (markpos == -1)
On Mon, 3 Oct 2022 17:47:00 GMT, Smita Kamath wrote:
>> Rethink about it, you can get 0x01 by right shifting k0 to the right -
>> `kshiftrw(ktmp, k0, 15)`
>
> @merykitty Thanks for the suggestion. I will update the instruct to use
> kmovwl. I will also experiment with kshiftrw and let you know.
On Mon, 3 Oct 2022 13:37:38 GMT, Julian Waters wrote:
>> A large section of error reporting code in the JDK does not properly handle
>> WIN32 API errors and instead mixes them with errors originating from C.
>> Since they can be rather easily replaced and coming up with an elegant
>> solution
On Mon, 3 Oct 2022 20:04:09 GMT, Stuart Marks wrote:
>> Joe Darcy has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add discussion of numerical equality.
>> - Fix typo.
>
> src/java.base/share/classes/java/lang/Double.java line 181:
>
> While the floating-point == operation is *not* an equivalence relation, there
> are useful equivalence relations that can be defined over floating-point
> values. Text is added to java.lang.Double to discuss and name those relations.
Joe Darcy has updated the pull request with a new target bas
On Mon, 3 Oct 2022 13:37:38 GMT, Julian Waters wrote:
>> A large section of error reporting code in the JDK does not properly handle
>> WIN32 API errors and instead mixes them with errors originating from C.
>> Since they can be rather easily replaced and coming up with an elegant
>> solution
On Fri, 30 Sep 2022 20:08:36 GMT, Paul Sandoz wrote:
>> Joe Darcy has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add discussion of numerical equality.
>> - Fix typo.
>
> src/java.base/share/classes/java/lang/Double.java line 166:
>
On Fri, 30 Sep 2022 21:46:34 GMT, Stuart Marks wrote:
>> The concept of the shutdown sequence needs to be specified more clearly.
>> This PR adds text for this into the class specification of
>> `java.lang.Runtime`. Also includes adjustments to related areas in
>> `addShutdownHook`, `halt`, an
On Tue, 4 Oct 2022 01:03:25 GMT, Ioi Lam wrote:
> Please review this trivial fix. TestDockerBasic.java uses cgroups features
> so it should be tagged with `@key cgroups`.
This pull request has now been integrated.
Changeset: ae79af2a
Author:Ioi Lam
URL:
https://git.openjdk.org/jdk
On Tue, 4 Oct 2022 01:10:41 GMT, David Holmes wrote:
>> Please review this trivial fix. TestDockerBasic.java uses cgroups features
>> so it should be tagged with `@key cgroups`.
>
> Looks good and trivial. Thanks for the quick fix.
Thanks @dholmes-ora and @mseledts for the review.
---
On Tue, 4 Oct 2022 01:03:25 GMT, Ioi Lam wrote:
> Please review this trivial fix. TestDockerBasic.java uses cgroups features
> so it should be tagged with `@key cgroups`.
Looks good and trivial. Thanks for the quick fix.
-
Marked as reviewed by dholmes (Reviewer).
PR: https://gi
On Tue, 4 Oct 2022 01:03:25 GMT, Ioi Lam wrote:
> Please review this trivial fix. TestDockerBasic.java uses cgroups features
> so it should be tagged with `@key cgroups`.
Marked as reviewed by mseledtsov (Committer).
-
PR: https://git.openjdk.org/jdk/pull/10547
Please review this trivial fix. TestDockerBasic.java uses cgroups features so
it should be tagged with `@key cgroups`.
-
Commit messages:
- 8294740: Add cgroups keyword to TestDockerBasic.java
Changes: https://git.openjdk.org/jdk/pull/10547/files
Webrev: https://webrevs.openjdk.o
On Sun, 19 Jun 2022 23:38:36 GMT, Chris Hennick wrote:
>> This PR improves both the performance of `nextExponential` and
>> `nextGaussian` and the distribution of output at the tails. It fixes the
>> following imperfections:
>>
>> * Repeatedly adding DoubleZigguratTables.exponentialX0 to extra
On Sat, 1 Oct 2022 08:06:44 GMT, Tagir F. Valeev wrote:
> Java 17 added RandomGenerator interface. However, existing method
> Collections.shuffle accepts old java.util.Random class. While since Java 19,
> it's possible to use Random.from(RandomGenerator) wrapper, it would be more
> convenient
On Mon, 3 Oct 2022 20:42:55 GMT, Jonathan Gibbons wrote:
>> Justin Lu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Remove comment typo
>> - Remove test wrapper
>
> src/java.base/share/classes/java/text/DigitList.java line 796:
>
>
I'm ok with not adding a default shuffle() method to List. Shuffling does seem
fairly rare, and it potentially has a some semantic issues regarding updates to the
RNG state. Those would make it difficult to specify or to override without possibly
breaking the contract.
Having a List::shuffle d
> Problem: Unnecessary instances of StringBuffer within java.text (internal
> only)
>
> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
> names
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Remove temp va
On Fri, 30 Sep 2022 20:08:10 GMT, Justin Lu wrote:
>> Problem: Unnecessary instances of StringBuffer within java.text (internal
>> only)
>>
>> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
>> names
>
> Justin Lu has updated the pull request incrementally with two
On Fri, 30 Sep 2022 20:08:10 GMT, Justin Lu wrote:
>> Problem: Unnecessary instances of StringBuffer within java.text (internal
>> only)
>>
>> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
>> names
>
> Justin Lu has updated the pull request incrementally with two
On Mon, 3 Oct 2022 20:04:38 GMT, Phil Race wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update make directory.
>
> src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.h line
> 36:
>
>> 34: *
>
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request with a new target base due to a merge or
a re
On Mon, 3 Oct 2022 17:29:45 GMT, Joe Darcy wrote:
>> With the domain change from openjdk.java.net to openjdk.org, references to
>> URLs in the sources should be updated.
>>
>> Updates were made using a shell script. I"ll run a copyright updater before
>> any push.
>
> Joe Darcy has updated the
On Fri, 30 Sep 2022 17:24:40 GMT, Joe Darcy wrote:
>> While the floating-point == operation is *not* an equivalence relation,
>> there are useful equivalence relations that can be defined over
>> floating-point values. Text is added to java.lang.Double to discuss and name
>> those relations.
>
On Fri, 30 Sep 2022 17:24:40 GMT, Joe Darcy wrote:
>> While the floating-point == operation is *not* an equivalence relation,
>> there are useful equivalence relations that can be defined over
>> floating-point values. Text is added to java.lang.Double to discuss and name
>> those relations.
>
On Wed, 28 Sep 2022 09:45:32 GMT, KIRIYAMA Takuya wrote:
>> Could you please review the JDK-8293579 bug fixes?
>>
>> tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java attempts to
>> give
>> the launcher the character which is encoded by Windows API
>> WideCharToMultiByte()
>> from
On Sat, 1 Oct 2022 17:54:37 GMT, Markus KARG wrote:
> Fixes 8294541
This patch still failed on macOS:
Seed from RandomFactory = 9174133304664648308L
test TransferTo.testNullPointerException(): success
test TransferTo.testStreamContents(): failure
java.lang.OutOfMemoryError: Java heap space
Completes the spec of [PR 10541](https://github.com/openjdk/jdk/pull/10541)
-
Commit messages:
- 8294730: Add @throws and @implNote clauses to BigInteger::isProblablePrime
and BigInteger::nextProblablePrime
Changes: https://git.openjdk.org/jdk/pull/10543/files
Webrev: https://webr
On Mon, 3 Oct 2022 17:02:44 GMT, Raffaello Giulietti
wrote:
> Throws an `ArithemticException` when the target is huge.
This pull request has now been integrated.
Changeset: 081691ad
Author:Raffaello Giulietti
URL:
https://git.openjdk.org/jdk/commit/081691adf42919237b2a5b71a4b1064c7
On Mon, 3 Oct 2022 08:34:06 GMT, Quan Anh Mai wrote:
>> src/hotspot/cpu/x86/x86.ad line 3674:
>>
>>> 3672: %}
>>> 3673:
>>> 3674: instruct convF2HF_mem_reg(memory mem, regF src, kReg ktmp, rRegI
>>> rtmp) %{
>>
>> You can use `kmovwl` instead which will relax the avx512bw constraint,
>> howe
On Fri, 30 Sep 2022 09:59:02 GMT, Bhavana Kilambi wrote:
>> Smita Kamath has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed review comment to update test case
>
> Hi, would you be adding IR tests to verify the generation of the th
On Mon, 3 Oct 2022 17:17:39 GMT, Joe Darcy wrote:
> > Also, FWIW, there are 100+ hits in `test` as well. But that is so many it
> > might warrant a separate PR..?
>
> Filed a few follow-up bugs:
>
> JDK-8294724: Update openjdk.java.net => openjdk.org in tests (umbrella)
> JDK-8294725: Update
On Wed, 28 Sep 2022 09:45:32 GMT, KIRIYAMA Takuya wrote:
>> Could you please review the JDK-8293579 bug fixes?
>>
>> tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java attempts to
>> give
>> the launcher the character which is encoded by Windows API
>> WideCharToMultiByte()
>> from
On Mon, 3 Oct 2022 16:59:40 GMT, Alexey Semenyuk wrote:
>> At least, the results in different encodings are the same as before the fix.
>> How about not fixing the pattern for other encordings to avoid false
>> negative?
>
> This looks good to me. The only requirement to the value of `testString
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request incrementally with one additional commit
sinc
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request incrementally with one additional commit
sinc
On Fri, 30 Sep 2022 20:25:28 GMT, Joe Darcy wrote:
> Also, FWIW, there are 100+ hits in `test` as well. But that is so many it
> might warrant a separate PR..?
Filed a few follow-up bugs:
JDK-8294724: Update openjdk.java.net => openjdk.org in tests (umbrella)
JDK-8294725: Update openjdk.java.n
On Mon, 3 Oct 2022 17:02:44 GMT, Raffaello Giulietti
wrote:
> Throws an `ArithemticException` when the target is huge.
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10541
Throws an `ArithemticException` when the target is huge.
-
Commit messages:
- 8294593: Check the size of the target on invocations of
BigInteger::isProbablePrime
Changes: https://git.openjdk.org/jdk/pull/10541/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10541&range=00
On Mon, 3 Oct 2022 17:02:44 GMT, Raffaello Giulietti
wrote:
> Throws an `ArithemticException` when the target is huge.
This parallels the existing behavior in `BigInteger::nextProbablePrime`.
A separate CSR + PR will follow.
-
PR: https://git.openjdk.org/jdk/pull/10541
On Mon, 3 Oct 2022 09:39:08 GMT, KIRIYAMA Takuya wrote:
>> I don't think it will be many practical setups where this test fails. This
>> test has been around for more than 2 years and this is the first accident.
>
> At least, the results in different encodings are the same as before the fix.
> H
On Wed, 28 Sep 2022 09:45:32 GMT, KIRIYAMA Takuya wrote:
>> Could you please review the JDK-8293579 bug fixes?
>>
>> tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java attempts to
>> give
>> the launcher the character which is encoded by Windows API
>> WideCharToMultiByte()
>> from
On Mon, 3 Oct 2022 11:03:48 GMT, Claes Redestad wrote:
> I agree that getting rid of the clone can help -- but since [JEP
> 416](https://openjdk.org/jeps/416) the generators modified here is mostly a
> fallback and the bulk of the use will use `MethodHandles` (unless you disable
> JEP 416 and
On Tue, 27 Sep 2022 11:12:57 GMT, Doug Simon wrote:
> This PR adds a new jlink plugin (`--save-jlink-argfiles=`) to
> support persisting jlink options.
>
>
>> echo "--add-modules jdk.internal.vm.ci --add-options=-Dfoo=xyzzy
>> --vendor-version="XyzzyVM 3.14.15" --vendor-bug-url=https://bugs.x
On Tue, 27 Sep 2022 22:38:48 GMT, Mandy Chung wrote:
>> Doug Simon has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> SaveJlinkArgfilesPlugin should verify that jdk.jlink is in the output image
>
> Looks good.
Thanks for the reviews @mlchu
On Sat, 1 Oct 2022 16:17:58 GMT, Andrey Turbanov wrote:
> This suppression were added with Loom integration, but method
> `Thread.getThreadGroup()` is not deprecated.
> Let's cleanup code a bit.
> https://mail.openjdk.org/pipermail/core-libs-dev/2022-September/094907.html
This pull request has
On Mon, 3 Oct 2022 13:37:38 GMT, Julian Waters wrote:
>> A large section of error reporting code in the JDK does not properly handle
>> WIN32 API errors and instead mixes them with errors originating from C.
>> Since they can be rather easily replaced and coming up with an elegant
>> solution
On Mon, 3 Oct 2022 13:37:38 GMT, Julian Waters wrote:
>> A large section of error reporting code in the JDK does not properly handle
>> WIN32 API errors and instead mixes them with errors originating from C.
>> Since they can be rather easily replaced and coming up with an elegant
>> solution
On Mon, 3 Oct 2022 13:37:38 GMT, Julian Waters wrote:
>> A large section of error reporting code in the JDK does not properly handle
>> WIN32 API errors and instead mixes them with errors originating from C.
>> Since they can be rather easily replaced and coming up with an elegant
>> solution
> WIP
Julian Waters has updated the pull request incrementally with one additional
commit since the last revision:
Naming
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9870/files
- new: https://git.openjdk.org/jdk/pull/9870/files/b89fb8b8..1be7e721
Webrevs:
- full: htt
On Sun, 2 Oct 2022 20:45:02 GMT, Сергей Цыпанов wrote:
> `checkedExceptions` param of `MethodAccessorGenerator.generateMethod()` is
> unused and should be removed in order to prevent allocations from
> `Method.getExceptionTypes()`
This pull request has now been integrated.
Changeset: 46633e64
The issue can be worked around on Windows 10 Version 1903 or later (including
Windows 11) by modifying the
src/java.base/windows/native/launcher/java.manifest file as follows:
Java(TM) SE process
http://schemas.mic
On Sun, 2 Oct 2022 20:45:02 GMT, Сергей Цыпанов wrote:
> `checkedExceptions` param of `MethodAccessorGenerator.generateMethod()` is
> unused and should be removed in order to prevent allocations from
> `Method.getExceptionTypes()`
Marked as reviewed by redestad (Reviewer).
Approving since cha
On Mon, 3 Oct 2022 08:26:00 GMT, Alan Bateman wrote:
>> Fixes JDK-8294702
>
> This looks fine, just change the description to "BufferedInputStream uses
> undefined ..." as this issue is nothing to do with transferTo.
@AlanBateman Kindly requesting `/sponsor`: -)
-
PR: https://git.
On Sun, 2 Oct 2022 20:45:02 GMT, Сергей Цыпанов wrote:
> `checkedExceptions` param of `MethodAccessorGenerator.generateMethod()` is
> unused and should be removed in order to prevent allocations from
> `Method.getExceptionTypes()`
I agree that getting rid of the clone can help -- but since [JE
On Mon, 3 Oct 2022 08:26:00 GMT, Alan Bateman wrote:
> This looks fine, just change the description to "BufferedInputStream uses
> undefined ..." as this issue is nothing to do with transferTo.
Done. Thanks! :-)
-
PR: https://git.openjdk.org/jdk/pull/10528
> On Oct 2, 2022, at 8:36 AM, Michael Hall wrote:
>
> and a test that some changes can be made to the jdk itself and still get a
> valid signed application.
Alexander
You may want to consider if this opens up a security vulnerability that doesn’t
currently exist.
> New JFR event to record state of initial security properties.
>
> Debug output is also now added for these properties via
> -Djava.security.debug=properties
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Check for 0 security even
On Fri, 30 Sep 2022 19:32:29 GMT, Sean Mullan wrote:
>> Thanks @egahlin - maybe we can leave it at beginChunk setting then.
>>
>> I've been doing some testing to satisfy myself that the impact of this event
>> on performance is minimal, Running the new `emitInitialSecurityProperties()`
>> is
Fixes sign extension propagation to higher bits.
-
Commit messages:
- 8294509: The sign extension bug applies to 'public static int[]
convertSeedBytesToInts(byte[] seed, int n, int z)' in RandomSupport
Changes: https://git.openjdk.org/jdk/pull/10530/files
Webrev: https://webrevs.o
On Thu, 29 Sep 2022 19:03:18 GMT, Alexey Semenyuk wrote:
>> Well, what concerns me with the current fix is that it is simply patching
>> only the case for the Japanese setup. We don't know if the same failure
>> would happen in other setups (I'm pretty sure the same failure would happen
>> wit
On Mon, 3 Oct 2022 07:14:09 GMT, Ichiroh Takiguchi
wrote:
> Test results are as follows on RHEL8.6 x86_64 (Intel Core i7 3520M) :
>
> ```
> 1.8.0_345-b01
> Benchmark Mode Cnt Score Error Units
> MyBenchmark.testIBM1047 thrpt 25 53213.092 ± 126.962 ops/s
>
> This JavaDoc change attempts to shine some light on the `combiner`-function
> as it relates to the third variant of `Stream.reduce` since it according to
> the bug submission in JBS can be confusing that the `combiner` is not
> mentioned in the code example in the documentation.
Viktor Klang
On Fri, 30 Sep 2022 21:34:44 GMT, Stuart Marks wrote:
>> This JavaDoc change attempts to shine some light on the `combiner`-function
>> as it relates to the third variant of `Stream.reduce` since it according to
>> the bug submission in JBS can be confusing that the `combiner` is not
>> mentio
> This JavaDoc change attempts to shine some light on the `combiner`-function
> as it relates to the third variant of `Stream.reduce` since it according to
> the bug submission in JBS can be confusing that the `combiner` is not
> mentioned in the code example in the documentation.
Viktor Klang
On Fri, 30 Sep 2022 10:04:34 GMT, Quan Anh Mai wrote:
>> Smita Kamath has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed review comment to update test case
>
> src/hotspot/cpu/x86/x86.ad line 3674:
>
>> 3672: %}
>> 3673:
>> 3674
On Mon, 3 Oct 2022 07:29:02 GMT, Markus KARG wrote:
> Fixes JDK-8294702
Marked as reviewed by saraw...@github.com (no known OpenJDK username).
-
PR: https://git.openjdk.org/jdk/pull/10528
Disables a specific assertion that causes intermittent failures.
-
Commit messages:
- 8294705: Disable an assertion in
test/jdk/java/util/DoubleStreamSums/CompensatedSums.java
Changes: https://git.openjdk.org/jdk/pull/10529/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10
On Mon, 3 Oct 2022 07:29:02 GMT, Markus KARG wrote:
> Fixes JDK-8294702
This looks fine, just change the description to "BufferedInputStream uses
undefined ..." as this issue is nothing to do with transferTo.
-
Marked as reviewed by alanb (Reviewer).
PR: https://git.openjdk.org/j
On Sun, 2 Oct 2022 22:16:46 GMT, Claes Redestad wrote:
>> `checkedExceptions` param of `MethodAccessorGenerator.generateMethod()` is
>> unused and should be removed in order to prevent allocations from
>> `Method.getExceptionTypes()`
>
> Seems reasonable, although these generators should only r
On Mon, 3 Oct 2022 07:29:02 GMT, Markus KARG wrote:
> Fixes JDK-8294702
@AlanBateman Kindly requesting review, as originally it was you who complained
about using `< 0` in that class, see
https://github.com/openjdk/jdk/pull/10525#issuecomment-1264966011.
-
PR: https://git.openjdk
Fixes JDK-8294702
-
Commit messages:
- Fixes JDK-8294702
Changes: https://git.openjdk.org/jdk/pull/10528/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10528&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8294702
Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mo
On Fri, 26 Aug 2022 09:25:55 GMT, Alan Bateman wrote:
>> OpenJDK supports "Japanese EBCDIC - Katakana" and "Korean EBCDIC" SBCS and
>> DBCS Only charsets.
>> |Charset|Mix|SBCS|DBCS|
>> | -- | -- | -- | -- |
>> | Japanese EBCDIC - Katakana | Cp930 | Cp290 | Cp300 |
>> | Korean | Cp933 | Cp833 | C
73 matches
Mail list logo
