On Fri, 21 Oct 2022 14:28:02 GMT, Daniel Jeliński wrote:
> Please review this PR that removes the remains of old fdTable-based socket
> close synchronization.
>
> Verified that tier1-3 tests continue to pass on Linux, MacOS and Windows. Did
> not verify AIX.
>
> Also removed one slow test for
On Fri, 14 Oct 2022 20:38:32 GMT, Justin Lu wrote:
> Issue: Formatter unit tests are launched via basic.sh
>
> Fix: Replace basic.sh with a Java test launcher
>
> Note: Java.internal.math was included in the original configuration of Basic,
> but I removed it as it was not used within the Basi
On Fri, 21 Oct 2022 22:10:45 GMT, Brent Christian wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> white space
>
> test/jdk/javax/sql/resourceBundleTests/ValidateGetBundle.java line 49:
>
>> 47: // The resourc
On Fri, 21 Oct 2022 19:55:55 GMT, Justin Lu wrote:
>> Issue: Resource bundle name does not follow proper naming conventions
>> according to [getBundle
>> method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Local
The current non local registry tests require a manual process that runs
rmiregitrty on a different machine and changes the -Dregistry.host property in
the source before running the tests on the local machine. This task is created
to improve this manual process and provide a clearer instruction t
On Fri, 21 Oct 2022 16:55:28 GMT, Naoto Sato wrote:
> This is to update the CLDR data from version 41 to version 42. The vast
> majority of the changes are basically replacing the CLDR data, along with
> tools/testcase alignments to those upstream changes:
>
> https://unicode-org.atlassian.net
On Fri, 21 Oct 2022 16:55:28 GMT, Naoto Sato wrote:
> This is to update the CLDR data from version 41 to version 42. The vast
> majority of the changes are basically replacing the CLDR data, along with
> tools/testcase alignments to those upstream changes:
>
> https://unicode-org.atlassian.net
On Fri, 21 Oct 2022 16:55:28 GMT, Naoto Sato wrote:
> This is to update the CLDR data from version 41 to version 42. The vast
> majority of the changes are basically replacing the CLDR data, along with
> tools/testcase alignments to those upstream changes:
>
> https://unicode-org.atlassian.net
> Issue: Resource bundle name does not follow proper naming conventions
> according to [getBundle
> method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Locale,java.lang.Module))
> for base name parameter
>
> Fix
On Fri, 21 Oct 2022 19:16:57 GMT, Joe Wang wrote:
> Are the first two items (CLDR-14032, CLDR-14831) considered a behavior change
> (e.g. the format string will be different) that could use a CSR or the
> release notes to document it? I see the later points to the CLDR release
> notes, but may
On Fri, 21 Oct 2022 16:55:28 GMT, Naoto Sato wrote:
> This is to update the CLDR data from version 41 to version 42. The vast
> majority of the changes are basically replacing the CLDR data, along with
> tools/testcase alignments to those upstream changes:
>
> https://unicode-org.atlassian.net
> Issue: Resource bundle name does not follow proper naming conventions
> according to [getBundle
> method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Locale,java.lang.Module))
> for base name parameter
>
> Fix
On Fri, 21 Oct 2022 16:55:28 GMT, Naoto Sato wrote:
> This is to update the CLDR data from version 41 to version 42. The vast
> majority of the changes are basically replacing the CLDR data, along with
> tools/testcase alignments to those upstream changes:
>
> https://unicode-org.atlassian.net
On Fri, 21 Oct 2022 18:04:29 GMT, Lance Andersen wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Pass exception to constuctor directly
>
> test/jdk/javax/sql/testng/test/rowset/ValidateResourceBundleAccess.java line
On Fri, 21 Oct 2022 18:03:27 GMT, Lance Andersen wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Pass exception to constuctor directly
>
> test/jdk/javax/sql/testng/test/rowset/ValidateResourceBundleAccess.java line
On Fri, 21 Oct 2022 17:35:22 GMT, Justin Lu wrote:
>> Issue: Resource bundle name does not follow proper naming conventions
>> according to [getBundle
>> method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Local
> Issue: Resource bundle name does not follow proper naming conventions
> according to [getBundle
> method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Locale,java.lang.Module))
> for base name parameter
>
> Fix
On Fri, 21 Oct 2022 16:55:28 GMT, Naoto Sato wrote:
> This is to update the CLDR data from version 41 to version 42. The vast
> majority of the changes are basically replacing the CLDR data, along with
> tools/testcase alignments to those upstream changes:
>
> https://unicode-org.atlassian.net
> Issue: Resource bundle name does not follow proper naming conventions
> according to [getBundle
> method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Locale,java.lang.Module))
> for base name parameter
>
> Fix
On Fri, 21 Oct 2022 01:13:31 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Run Validate_.java in othervm mode
>
> test/jdk/javax/sql/resourceBundleTests/ValidateGetBundle.java line 67:
>
>> 65:
On Fri, 21 Oct 2022 01:08:36 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Run Validate_.java in othervm mode
>
> test/jdk/javax/sql/resourceBundleTests/ValidateGetBundle.java line 61:
>
>> 59:
> Issue: Resource bundle name does not follow proper naming conventions
> according to [getBundle
> method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Locale,java.lang.Module))
> for base name parameter
>
> Fix
On Fri, 21 Oct 2022 01:17:33 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Run Validate_.java in othervm mode
>
> test/jdk/javax/sql/testng/test/rowset/ValidateResourceBundleAccess.java line
> 49:
>
> Issue: Resource bundle name does not follow proper naming conventions
> according to [getBundle
> method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Locale,java.lang.Module))
> for base name parameter
>
> Fix
On Fri, 21 Oct 2022 17:08:07 GMT, Daniel Jeliński wrote:
>> src/java.base/unix/native/libnet/net_util_md.c line 703:
>>
>>> 701:
>>> 702: errno = 0;
>>> 703: read_rv = poll(&pfd, 1, nanoTimeout / NET_NSEC_PER_MSEC);
>>
>> I suspect this one will need to handle EINTR like the or
On Fri, 21 Oct 2022 16:04:24 GMT, Alan Bateman wrote:
>> Please review this PR that removes the remains of old fdTable-based socket
>> close synchronization.
>>
>> Verified that tier1-3 tests continue to pass on Linux, MacOS and Windows.
>> Did not verify AIX.
>>
>> Also removed one slow test
This is to update the CLDR data from version 41 to version 42. The vast
majority of the changes are basically replacing the CLDR data, along with
tools/testcase alignments to those upstream changes:
https://unicode-org.atlassian.net/browse/CLDR-14032 (" at " is no longer used
for standard date/
> Issue: Resource bundle name does not follow proper naming conventions
> according to [getBundle
> method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Locale,java.lang.Module))
> for base name parameter
>
> Fix
On Fri, 21 Oct 2022 16:04:14 GMT, Naoto Sato wrote:
> replace those dangling white spaces with explicit Unicode escapes
this is a *very good* idea.
-
PR: https://git.openjdk.org/jdk/pull/10792
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Fri, 21 Oct 2022 14:28:02 GMT, Daniel Jeliński wrote:
> Please review this PR that removes the remains of old fdTable-based socket
> close synchronization.
>
> Verified that tier1-3 tests continue to pass on Linux, MacOS and Windows. Did
> not verify AIX.
>
> Also removed one slow test for
Please review this PR that removes the remains of old fdTable-based socket
close synchronization.
Verified that tier1-3 tests continue to pass on Linux, MacOS and Windows. Did
not verify AIX.
Also removed one slow test for an issue in fdtable implementation; as far as I
could tell, it is no lo
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Tue, 2 Aug 2022 13:57:03 GMT, iaroslavski wrote:
>> Sorting:
>>
>> - adopt radix sort for sequential and parallel sorts on
>> int/long/float/double arrays (almost random and length > 6K)
>> - fix tryMergeRuns() to better handle case when the last run is a single
>> element
>> - minor javado
On Fri, 21 Oct 2022 12:11:28 GMT, ExE Boss wrote:
>> From one point this is obviously a change in behaviour, from another the
>> spec of `Spliterator.getComparator()` says nothing about serializability of
>> returned comparator and the actual value is hardly ever going to be
>> serialized.
>
>
On Fri, 21 Oct 2022 11:56:57 GMT, Сергей Цыпанов wrote:
>> src/java.base/share/classes/java/util/TreeMap.java line 3329:
>>
>>> 3327: }
>>> 3328: else {
>>> 3329: return (Comparator> & Serializable)
>>> (e1, e2) -> {
>>
>> I think this cast hints compile
On Mon, 17 Oct 2022 19:42:14 GMT, liach wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8293630: Inline natural()
>
> src/java.base/share/classes/java/util/TreeMap.java line 3329:
>
>> 3327: }
>> 332
On Wed, 19 Oct 2022 16:45:12 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this PR which will update the Zlib Data Compression Library
> from 1.2.11 to 1.2.13.
>
> - I have run all of the Mach5 tiers which did not show any issues related to
> the upgrade.
> - The JCK zip/jar tests al
On Sun, 18 Sep 2022 11:52:28 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test only change which proposes to fix the
> recent intermittent failures in `RmiBootstrapTest` reported in
> https://bugs.openjdk.org/browse/JDK-8030616?
>
> The test has been intermittently failing with
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Thu, 20 Oct 2022 10:01:19 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test only change which proposes to fix the
>> recent intermittent failures in `RmiBootstrapTest` reported in
>> https://bugs.openjdk.org/browse/JDK-8030616?
>>
>> The test has been intermittently failing
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase the coverage of the
> whitespace checks (in the old mercurial ve
42 matches
Mail list logo
