Re: RFR: 8295970: Add jdk_vector tests in GHA [v2]

2022-10-29 Thread Sergey Bylokhov
On Fri, 28 Oct 2022 07:19:31 GMT, Jie Fu wrote: >> Hi all, >> >> As discussed here >> https://github.com/openjdk/jdk/pull/10807#pullrequestreview-1150314487 , it >> would be better to add the vector api tests in GHA. >> >> Thanks. >> Best regards, >> Jie > > Jie Fu has updated the pull reques

Re: RFR: 8295670: Remove duplication in java/util/Formatter/Basic*.java

2022-10-29 Thread Сергей Цыпанов
On Fri, 28 Oct 2022 21:51:03 GMT, Justin Lu wrote: > Issue: Duplication of methods between Basic*.java test classes, due to auto > generation by genBasic.sh > > Fix: Reorganize parts of Basic-X.java.template into base class in Basic.java. > Toggled -nel flag for generation script (genBasic.sh)

Re: RFR: 8282664: Unroll by hand StringUTF16 and StringLatin1 polynomial hash loops

2022-10-29 Thread Quan Anh Mai
On Tue, 25 Oct 2022 10:37:40 GMT, Claes Redestad wrote: > Continuing the work initiated by @luhenry to unroll and then intrinsify > polynomial hash loops. > > I've rewired the library changes to route via a single `@IntrinsicCandidate` > method. To make this work I've harmonized how they are i

Re: RFR: 8294241: Deprecate URL public constructors [v2]

2022-10-29 Thread Alan Bateman
On Fri, 28 Oct 2022 14:54:26 GMT, Daniel Fuchs wrote: >> Deprecate URL constructors. Developers are encouraged to use `java.net.URI` >> to parse or construct any URL. >> >> The `java.net.URL` class does not itself encode or decode any URL components >> according to the escaping mechanism defin

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-29 Thread Alexey Ivanov
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: 8294696 - BufferedInputStream.transferTo should drain buffer when mark set [v5]

2022-10-29 Thread Markus KARG
> This PR implements JDK-8294696. Markus KARG has updated the pull request incrementally with one additional commit since the last revision: No immediate buffer resize; in the rare case of read-past-EOF automatic buffer grow will happen anyways - Changes: - all: https://git.op

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-29 Thread Alexey Ivanov
On Mon, 24 Oct 2022 19:29:41 GMT, Andy Goryachev wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Revert "Remove check for .properties from jcheck" >> >>This reverts commit c91fdaa19dc06351598bd1c061

Re: RFR: 8294241: Deprecate URL public constructors [v2]

2022-10-29 Thread Jaikiran Pai
On Wed, 26 Oct 2022 17:51:31 GMT, Daniel Fuchs wrote: >> I see your point. It may be more appropriate if URI.toURL was designed as >> URL.fromURL. >> >> I was wondering to have application developers a consistent way to get an >> URL instance. Now there are two methods in different classes U

Re: RFR: 8294241: Deprecate URL public constructors [v2]

2022-10-29 Thread Jaikiran Pai
On Thu, 27 Oct 2022 11:24:32 GMT, Daniel Fuchs wrote: >> How about `_unused` or `_unused1`, `_unused2` then in the meantime? > > I'd be happy to make the change. Let's wait to see if anybody has a better > naming suggestion. Hello Daniel, I think calling it `unused` is fine. I did a quick searc

Re: RFR: 8282664: Unroll by hand StringUTF16 and StringLatin1 polynomial hash loops

2022-10-29 Thread Claes Redestad
On Tue, 25 Oct 2022 10:37:40 GMT, Claes Redestad wrote: > Continuing the work initiated by @luhenry to unroll and then intrinsify > polynomial hash loops. > > I've rewired the library changes to route via a single `@IntrinsicCandidate` > method. To make this work I've harmonized how they are i

Re: RFR: 8282664: Unroll by hand StringUTF16 and StringLatin1 polynomial hash loops

2022-10-29 Thread Piotr Tarsa
On Fri, 28 Oct 2022 20:43:04 GMT, Claes Redestad wrote: > Porting to aarch64 and other platforms can be done as follow-ups and > shouldn't block integration. I'm not an expert in JVM internals, but there's an already seemingly working String.hashCode intrinsification that's ISA independent: h

Re: RFR: 8295970: Add jdk_vector tests in GHA

2022-10-29 Thread Alan Bateman
On Fri, 28 Oct 2022 07:21:05 GMT, Jie Fu wrote: > Good suggestion! > And the `jdk_vector_sanity` test group had been added. In general, running a few fast sanity tests from several areas in tier1 seems a good idea. Having test lists in the TEST.group files isn't very appealing as they easily g

Re: RFR: 8294696 - BufferedInputStream.transferTo should drain buffer when mark set [v2]

2022-10-29 Thread Alan Bateman
On Sun, 23 Oct 2022 08:40:35 GMT, Markus KARG wrote: > Silly me, you are certainly right! I have modified the code as you proposed, > so now we should be safe, finally. :-) The updated version (7350a533) looks safe but it makes for a more complicated transferTo so it would be good to see updat