On Wed, 9 Nov 2022 10:14:45 GMT, Adam Sotona wrote:
> When `Class.getEnumConstants()` is called on a bad enum class where
> `values()` is an instance method, or returns a non‑array, then it throws
> `NullPointerException` or `ClassCastException` respectively.
>
> This patch fixes
On Wed, 9 Nov 2022 20:02:05 GMT, Alexander Matveev wrote:
> Additional DMG content will be arranged in raws with 3 items per raw. DMG
> windows will be resized to show one or two raws without any scrolling
> required. To see any additional content after two raws (7 or more items) user
> will
Please review a "somewhat automated" change to insert `@spec` tags into doc
comments, as appropriate, to leverage the recent new javadoc feature to
generate a new page listing the references to all external specifications
listed in the `@spec` tags.
"Somewhat automated" means that I wrote and
The cache named `signerToCodeSource` is never used now.
-
Commit messages:
- Make signerToCodeSource cache work.
Changes: https://git.openjdk.org/jdk/pull/11072/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=11072=00
Issue: https://bugs.openjdk.org/browse/JDK-8296734
On Wed, 9 Nov 2022 20:02:05 GMT, Alexander Matveev wrote:
> Additional DMG content will be arranged in raws with 3 items per raw. DMG
> windows will be resized to show one or two raws without any scrolling
> required. To see any additional content after two raws (7 or more items) user
> will
On Tue, 8 Nov 2022 21:39:03 GMT, Mikhailo Seledtsov
wrote:
> Trivial change, updated jdk problem list.
This pull request has now been integrated.
Changeset: d6e2d0d0
Author:Mikhailo Seledtsov
URL:
https://git.openjdk.org/jdk/commit/d6e2d0d03d2161f934474fa1d4299513d14cb9c5
Stats:
On Wed, 9 Nov 2022 17:36:12 GMT, Mikhailo Seledtsov
wrote:
>> Trivial change, updated jdk problem list.
>
> Mikhailo Seledtsov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Addressed review feedback
Thank you Rajan.
-
PR:
> On Windows, suppress failure if the total space indicated by `df` is less
> than `FileStore::getTotalSpace` and the free space indicated by `df` equals
> `FileStore::getUnallocatedSpace`.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or a rebase. The
On Wed, 9 Nov 2022 21:09:30 GMT, Roger Riggs wrote:
>> Brian Burkhalter has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>>
On Wed, 9 Nov 2022 17:36:12 GMT, Mikhailo Seledtsov
wrote:
>> Trivial change, updated jdk problem list.
>
> Mikhailo Seledtsov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Addressed review feedback
Marked as reviewed by rhalade
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation
On Wed, 9 Nov 2022 23:48:57 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of
On Mon, 7 Nov 2022 18:12:39 GMT, Naoto Sato wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Internalize FormatConcatItem
>
> src/java.base/share/classes/java/util/FormatItem.java line 540:
>
>> 538:
On Wed, 9 Nov 2022 17:36:12 GMT, Mikhailo Seledtsov
wrote:
>> Trivial change, updated jdk problem list.
>
> Mikhailo Seledtsov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Addressed review feedback
Please update the PR commit message
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation
On Wed, 9 Nov 2022 22:42:29 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/java/lang/template/StringTemplate.java line 299:
>>
>>> 297: * @throws NullPointerException fragments or values is null or if
>>> any of the fragments is null
>>> 298: */
>>> 299: public static
On Sun, 6 Nov 2022 22:14:29 GMT, Joe Darcy wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Internalize FormatConcatItem
>
> src/java.base/share/classes/java/util/FormatProcessor.java line 38:
>
>> 36:
>> 37: /**
On Wed, 9 Nov 2022 18:58:30 GMT, Naoto Sato wrote:
> Pick up the fix in the upstream CLDR v42 maintenance branch for their
> tzdata2022f changes.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11066
On Sat, 5 Nov 2022 22:23:56 GMT, Rémi Forax wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Internalize FormatConcatItem
>
> src/java.base/share/classes/java/lang/template/StringTemplate.java line 299:
>
>> 297:
On Sun, 6 Nov 2022 22:15:22 GMT, Joe Darcy wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Internalize FormatConcatItem
>
> src/java.base/share/classes/java/util/FormatProcessor.java line 56:
>
>> 54: * to produce
On Sun, 6 Nov 2022 13:28:18 GMT, ExE Boss wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Internalize FormatConcatItem
>
> src/java.base/share/classes/java/util/FormatItem.java line 75:
>
>> 73: try {
>>
On Wed, 9 Nov 2022 17:36:12 GMT, Mikhailo Seledtsov
wrote:
>> Trivial change, updated jdk problem list.
>
> Mikhailo Seledtsov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Addressed review feedback
I have updated the problem list to
On Sat, 5 Nov 2022 22:23:23 GMT, Rémi Forax wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Internalize FormatConcatItem
>
> src/java.base/share/classes/java/lang/template/StringTemplate.java line 276:
>
>> 274:
On Wed, 9 Nov 2022 21:55:24 GMT, Rémi Forax wrote:
>> src/java.base/share/classes/java/lang/template/StringTemplate.java line 276:
>>
>>> 274: * @implNote Contents of both lists are copied to construct
>>> immutable lists.
>>> 275: */
>>> 276: public static StringTemplate of(List
On Wed, 2 Nov 2022 17:41:57 GMT, Jorn Vernee wrote:
>> It is also a duplicate of a private method in TemplateRuntime
>
> Yes, this is leaking access. I suppose this is public because it is called
> from `javac` generated code. But, from the perspective of the runtime, code
> generated by
On Wed, 9 Nov 2022 21:12:46 GMT, Jim Laskey wrote:
>> Changing
>
> Raw list?
I think this comment is not on the right part of the code.
-
PR: https://git.openjdk.org/jdk/pull/10889
On Thu, 3 Nov 2022 14:48:25 GMT, Jim Laskey wrote:
>> i agree
>
> I agree. Need a balance of performance and #classes. Just something I'll work
> on during preview.
Changing
-
PR: https://git.openjdk.org/jdk/pull/10889
On Wed, 9 Nov 2022 10:14:45 GMT, Adam Sotona wrote:
> When `Class.getEnumConstants()` is called on a bad enum class where
> `values()` is an instance method, or returns a non‑array, then it throws
> `NullPointerException` or `ClassCastException` respectively.
>
> This patch fixes
On Fri, 28 Oct 2022 19:38:28 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 32:
>>
>>> 30:
>>> 31: import java.io.IOException;
>>> 32: import java.util.*;
>>
>> Please do not use import *.
>
> Changing.
Changing
-
PR:
On Fri, 28 Oct 2022 19:38:26 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java line
>> 36:
>>
>>> 34: import java.lang.invoke.MethodHandles.Lookup;
>>> 35: import java.lang.template.StringTemplate;
>>> 36: import java.util.*;
>>
>> Another import
> Sorting:
>
> - adopt radix sort for sequential and parallel sorts on int/long/float/double
> arrays (almost random and length > 6K)
> - fix tryMergeRuns() to better handle case when the last run is a single
> element
> - minor javadoc and comment changes
>
> Testing:
> - add new data inputs
On Tue, 1 Nov 2022 19:06:57 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/java/lang/template/TemplateRuntime.java line 99:
>>
>>> 97: private static List toList(E... elements) {
>>> 98: return JUCA.listFromTrustedArrayNullsAllowed(elements);
>>> 99: }
>>
>> I'm ok with
On Tue, 11 Oct 2022 20:50:15 GMT, Brian Burkhalter wrote:
>> On Windows, suppress failure if the total space indicated by `df` is less
>> than `FileStore::getTotalSpace` and the free space indicated by `df` equals
>> `FileStore::getUnallocatedSpace`.
>
> Brian Burkhalter has updated the pull
Additional DMG content will be arranged in raws with 3 items per raw. DMG
windows will be resized to show one or two raws without any scrolling required.
To see any additional content after two raws (7 or more items) user will need
to use vertical scroll bar. See JBS for screen shots.
On Mon, 7 Nov 2022 19:23:05 GMT, Bill Huang wrote:
> There is no new changes in the open portion of JDK, but extracting common
> functionalities in bootstrap Utils to test/lib/Utils which can be used in the
> closed part.
This pull request has now been integrated.
Changeset: cc8bf950
Author:
Pick up the fix in the upstream CLDR v42 maintenance branch for their
tzdata2022f changes.
-
Commit messages:
- 8296715: CLDR v42 update for tzdata 2022f
Changes: https://git.openjdk.org/jdk/pull/11066/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=11066=00
Issue:
On Tue, 8 Nov 2022 21:39:03 GMT, Mikhailo Seledtsov
wrote:
> Trivial change, updated jdk problem list.
Thanks Sean. I will remove the fixed tests from the list.
-
PR: https://git.openjdk.org/jdk/pull/11045
On Tue, 11 Oct 2022 20:50:15 GMT, Brian Burkhalter wrote:
>> On Windows, suppress failure if the total space indicated by `df` is less
>> than `FileStore::getTotalSpace` and the free space indicated by `df` equals
>> `FileStore::getUnallocatedSpace`.
>
> Brian Burkhalter has updated the pull
> Trivial change, updated jdk problem list.
Mikhailo Seledtsov has updated the pull request incrementally with one
additional commit since the last revision:
Addressed review feedback
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11045/files
- new:
> Pull in linker implementation changes, that include non-trivial changes to VM
> code, from the panama-foreign repo into the main JDK.
>
> This is split off from the main JEP integration to make reviewing easier.
>
> This includes the following patches:
>
> 1.
On Tue, 8 Nov 2022 18:20:34 GMT, Bill Huang wrote:
>> There is no new changes in the open portion of JDK, but extracting common
>> functionalities in bootstrap Utils to test/lib/Utils which can be used in
>> the closed part.
>
> Bill Huang has updated the pull request incrementally with one
On Tue, 8 Nov 2022 21:39:03 GMT, Mikhailo Seledtsov
wrote:
> Trivial change, updated jdk problem list.
The `java/security/cert/pkix/policyChanges/TestPolicy.java` and
`java/security/cert/CertPathBuilder/targetConstraints/BuildEEBasicConstraints.java`
test failures are already fixed. There
On Mon, 17 Oct 2022 10:19:26 GMT, Сергей Цыпанов wrote:
>> We can use `Comparator.naturalOrder()` for cases when a `TreeMap` instance
>> is constructed without comparator. This allows to squash two branches in
>> `TreeMap.get()` into one.
>>
>> P.S. I think the comment of
> A small spec change to match established behavior.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
8296292: Document the default behavior of '$' in regular expressions correctly
-
Changes:
- all:
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request
On Tue, 8 Nov 2022 12:03:06 GMT, Erik Gahlin wrote:
> Could I have a review of PR that fixes so unsigned numbers are printed
> correctly in the jfr tool.
>
> Testing:
> test/jdk/jdk/jfr
> test/jdk/jdk/security/logging/
>
> Thanks
> Erik
Marked as reviewed by mgronlun (Reviewer).
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request
On Tue, 8 Nov 2022 18:20:34 GMT, Bill Huang wrote:
>> There is no new changes in the open portion of JDK, but extracting common
>> functionalities in bootstrap Utils to test/lib/Utils which can be used in
>> the closed part.
>
> Bill Huang has updated the pull request incrementally with one
On Tue, 8 Nov 2022 22:12:46 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request
On Wed, 9 Nov 2022 09:49:10 GMT, Alan Bateman wrote:
>> src/hotspot/share/prims/jvmtiEnvBase.cpp line 557:
>>
>>> 555: JvmtiEnvBase::new_jthreadGroupArray(int length, objArrayHandle groups)
>>> {
>>> 556: if (length == 0) {
>>> 557: return NULL;
>>
>> I do not think returning NULL is
On Tue, 8 Nov 2022 12:03:06 GMT, Erik Gahlin wrote:
> Could I have a review of PR that fixes so unsigned numbers are printed
> correctly in the jfr tool.
>
> Testing:
> test/jdk/jdk/jfr
> test/jdk/jdk/security/logging/
>
> Thanks
> Erik
Marked as reviewed by coffeys (Reviewer).
LGTM
On Wed, 9 Nov 2022 09:16:49 GMT, Alan Bateman wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix typo
>
> src/java.base/share/classes/java/lang/foreign/Arena.java line 131:
>
>> 129: * @param thread
When `Class.getEnumConstants()` is called on a bad enum class where `values()`
is an instance method, or returns a non‑array, then it throws
`NullPointerException` or `ClassCastException` respectively.
This patch fixes `Class.getEnumConstants()` method to handle above mentioned
bad enums and
On Wed, 9 Nov 2022 09:32:42 GMT, Serguei Spitsyn wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Forgot a null check.
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 557:
>
>> 555:
On Tue, 8 Nov 2022 18:20:34 GMT, Bill Huang wrote:
>> There is no new changes in the open portion of JDK, but extracting common
>> functionalities in bootstrap Utils to test/lib/Utils which can be used in
>> the closed part.
>
> Bill Huang has updated the pull request incrementally with one
On Tue, 8 Nov 2022 14:55:17 GMT, Coleen Phillimore wrote:
>> The JVM code took a ThreadGroup lock before poking into ThreadGroup fields.
>> Call a method in the ThreadGroup to call the synchronized method instead.
>> Tested with tier 1-4.
>
> Coleen Phillimore has updated the pull request
On Tue, 8 Nov 2022 14:55:17 GMT, Coleen Phillimore wrote:
>> The JVM code took a ThreadGroup lock before poking into ThreadGroup fields.
>> Call a method in the ThreadGroup to call the synchronized method instead.
>> Tested with tier 1-4.
>
> Coleen Phillimore has updated the pull request
On Tue, 8 Nov 2022 22:12:46 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
On Mon, 7 Nov 2022 14:34:45 GMT, Jorn Vernee wrote:
> Pull in linker implementation changes, that include non-trivial changes to VM
> code, from the panama-foreign repo into the main JDK.
>
> This is split off from the main JEP integration to make reviewing easier.
>
> This includes the
On Thu, 27 Oct 2022 19:07:36 GMT, Andrey Turbanov wrote:
> There is no usages for this field. As it has the same value as
> `DAY_OF_MONTH_MASK` we can drop it.
This pull request has now been integrated.
Changeset: 82cbfb5f
Author:Andrey Turbanov
URL:
On Tue, 8 Nov 2022 23:45:18 GMT, David Holmes wrote:
> "in the custom class loader must append to the class path in a thread-safe
> manner."
Maybe "its search path" rather than "the class path" because the custom class
loader can't add to the class path (the application class path continues
62 matches
Mail list logo
