On Tue, 17 Jan 2023 22:28:50 GMT, Claes Redestad wrote:
>> Sergey Tsypanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Merge map() calls
>
> src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 6752:
>
>> 6750:
On Tue, 17 Jan 2023 17:40:33 GMT, Calvin Cheung wrote:
>> Moving the `ArchivedEnumTest.java` from `runtime/cds/appcds/cacheObject` to
>> `jdk/internal/misc/CDS` so that the test will be run in jdk-tier1. This is
>> to avoid inadvertently breakage of the test like in JDK-8292499.
>>
>>
On Sat, 10 Dec 2022 18:11:30 GMT, Victor Toni wrote:
> Being able to compare instances of Throwable allows simple detection of
> exceptions raised by the same circumstances. Comparison allows for reduction
> of excessive logging e.g. in hotspots without requiring custom code to
> compare
On Tue, 17 Jan 2023 18:12:44 GMT, Phil Race wrote:
> client changes are OK by me.
Thanks @prrace .
-
PR: https://git.openjdk.org/jdk/pull/12005
On Tue, 17 Jan 2023 23:14:53 GMT, Justin Lu wrote:
> This PR implements _JEP 413: Code Snippets in Java API Documentation_ for
> [java.text.CollationElementIterator](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/CollationElementIterator.html).
>
> Code examples using
On Tue, 17 Jan 2023 23:15:26 GMT, Justin Lu wrote:
>> This PR implements _JEP 413: Code Snippets in Java API Documentation_ for
>> [java.text.CollationElementIterator](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/CollationElementIterator.html).
>>
>> Code examples
v. 2023 ? 17:55, Alan Bateman a ?crit :
>
> -- next part -- An HTML attachment was scrubbed...
> URL:
> <https://mail.openjdk.org/pipermail/build-dev/attachments/20230117/4dc50b9b/attachment.htm>
-
PR: https://git.openjdk.org/jdk/pull/12005
On Tue, 17 Jan 2023 23:14:53 GMT, Justin Lu wrote:
> This PR implements _JEP 413: Code Snippets in Java API Documentation_ for
> [java.text.CollationElementIterator](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/CollationElementIterator.html).
>
> Code examples using
This PR implements _JEP 413: Code Snippets in Java API Documentation_ for
[java.text.CollationElementIterator](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/CollationElementIterator.html).
Code examples using ... blocks are replaced with the @ snippet
syntax where
On Tue, 17 Jan 2023 22:35:54 GMT, Justin Lu wrote:
> This PR implements JEP 413: Code Snippets in Java API Documentation for
> [java.text.DateFormat](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/DateFormat.html).
>
> Code examples using ... blocks are replaced with
On Tue, 17 Jan 2023 22:44:29 GMT, Justin Lu wrote:
> A code example for text.MessageFormat under the **Usage Information** section
> has a comment with the wrong variable name.
>
>
> * Object[] objs = mf.parse(forParsing, new ParsePosition(0));
> * // result now equals {new String("z")}
>
>
On Tue, 17 Jan 2023 22:35:54 GMT, Justin Lu wrote:
> This PR implements JEP 413: Code Snippets in Java API Documentation for
> [java.text.DateFormat](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/DateFormat.html).
>
> Code examples using ... blocks are replaced with
On Tue, 17 Jan 2023 17:24:20 GMT, Jatin Bhateja wrote:
> Patch optimizes Adler32 stub for AVX512 target.
>
> Main computation loop now uses zero extended lane widening load vector
> operation.
>
> New sequence also honors AVX3Thresholds so that implementation uses existing
> AVX2 instruction
On Tue, 17 Jan 2023 22:44:29 GMT, Justin Lu wrote:
> A code example for text.MessageFormat under the **Usage Information** section
> has a comment with the wrong variable name.
>
>
> * Object[] objs = mf.parse(forParsing, new ParsePosition(0));
> * // result now equals {new String("z")}
>
>
A code example for text.MessageFormat under the **Usage Information** section
has a comment with the wrong variable name.
* Object[] objs = mf.parse(forParsing, new ParsePosition(0));
* // result now equals {new String("z")}
The name of the intended variable should be `objs`, not `result`
This PR implements JEP 413: Code Snippets in Java API Documentation for
[java.text.DateFormat](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/DateFormat.html).
Code examples using ... blocks are replaced with the @ snippet
syntax where applicable.
Additionally,
On Tue, 17 Jan 2023 22:35:54 GMT, Justin Lu wrote:
> This PR implements JEP 413: Code Snippets in Java API Documentation for
> [java.text.DateFormat](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/DateFormat.html).
>
> Code examples using ... blocks are replaced with
On Tue, 17 Jan 2023 22:00:29 GMT, Justin Lu wrote:
>> A code example for text.MessageFormat under the **Usage Information**
>> section has a comment with the wrong variable name.
>>
>>
>> * Object[] objs = mf.parse(forParsing, new ParsePosition(0));
>> * // result now equals {new String("z")}
On Tue, 17 Jan 2023 21:24:34 GMT, Sergey Tsypanov wrote:
>> - `MethodType.ptypes()` can be used instead of `MethodType.parameterList()`
>> when we don't need a copy
>> - comparison of two lists can be done without `Stream.reduce()`
>
> Sergey Tsypanov has updated the pull request incrementally
On Tue, 17 Jan 2023 21:29:15 GMT, Joe Darcy wrote:
> In the course of some other work (JDK-8300133), I noticed some cases where
> the javadoc in the package-info file for javax.sql.rowset used HTML links
> where a more readable javadoc link tag would suffice.
This pull request has now been
On Tue, 17 Jan 2023 21:29:15 GMT, Joe Darcy wrote:
> In the course of some other work (JDK-8300133), I noticed some cases where
> the javadoc in the package-info file for javax.sql.rowset used HTML links
> where a more readable javadoc link tag would suffice.
Marked as reviewed by iris
On Tue, 17 Jan 2023 21:29:15 GMT, Joe Darcy wrote:
> In the course of some other work (JDK-8300133), I noticed some cases where
> the javadoc in the package-info file for javax.sql.rowset used HTML links
> where a more readable javadoc link tag would suffice.
Marked as reviewed by lancea
> - `MethodType.ptypes()` can be used instead of `MethodType.parameterList()`
> when we don't need a copy
> - comparison of two lists can be done without `Stream.reduce()`
Sergey Tsypanov has updated the pull request incrementally with one additional
commit since the last revision:
Merge
On Tue, 17 Jan 2023 20:51:06 GMT, Rémi Forax wrote:
>> Sergey Tsypanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Polishing
>
> src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 59:
>
>> 57: import
> A code example for text.MessageFormat under the **Usage Information** section
> has a comment with the wrong variable name.
>
>
> * Object[] objs = mf.parse(forParsing, new ParsePosition(0));
> * // result now equals {new String("z")}
>
>
> The name of the intended variable should be
On Tue, 17 Jan 2023 21:28:23 GMT, Justin Lu wrote:
> A code example for text.MessageFormat under the **Usage Information** section
> has a comment with the wrong variable name.
>
>
> * Object[] objs = mf.parse(forParsing, new ParsePosition(0));
> * // result now equals {new String("z")}
>
>
On Tue, 17 Jan 2023 21:28:23 GMT, Justin Lu wrote:
> A code example for text.MessageFormat under the **Usage Information** section
> has a comment with the wrong variable name.
>
>
> * Object[] objs = mf.parse(forParsing, new ParsePosition(0));
> * // result now equals {new String("z")}
>
>
The implementation of MemorySessionImpl::isAccessibleBy is incorrect, and ends
up always returning `false` for scopes associated with shared arenas.
This patch rectifies that, and adds some tests.
-
Commit messages:
- Fix bug in MemorySessionImpl::isAccessibleBy
Changes:
A code example for text.MessageFormat under the **Usage Information** section
has a comment with the wrong variable name.
* Object[] objs = mf.parse(forParsing, new ParsePosition(0));
* // result now equals {new String("z")}
The name of the intended variable should be `objs`, not `result`
In the course of some other work (JDK-8300133), I noticed some cases where the
javadoc in the package-info file for javax.sql.rowset used HTML links where a
more readable javadoc link tag would suffice.
-
Commit messages:
- JDK-8300321: Use link tags in javax.sql.rowset
On Tue, 17 Jan 2023 20:55:08 GMT, Claes Redestad wrote:
>> Continuing the work initiated by @luhenry to unroll and then intrinsify
>> polynomial hash loops.
>>
>> I've rewired the library changes to route via a single `@IntrinsicCandidate`
>> method. To make this work I've harmonized how they
On Tue, 25 Oct 2022 10:37:40 GMT, Claes Redestad wrote:
> Continuing the work initiated by @luhenry to unroll and then intrinsify
> polynomial hash loops.
>
> I've rewired the library changes to route via a single `@IntrinsicCandidate`
> method. To make this work I've harmonized how they are
> Continuing the work initiated by @luhenry to unroll and then intrinsify
> polynomial hash loops.
>
> I've rewired the library changes to route via a single `@IntrinsicCandidate`
> method. To make this work I've harmonized how they are invoked so that
> there's less special handling and
On Tue, 17 Jan 2023 18:46:00 GMT, Vladimir Ivanov wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> trailing ws
>
> src/hotspot/share/opto/machnode.cpp line 211:
>
>> 209: opcnt++; //
> Continuing the work initiated by @luhenry to unroll and then intrinsify
> polynomial hash loops.
>
> I've rewired the library changes to route via a single `@IntrinsicCandidate`
> method. To make this work I've harmonized how they are invoked so that
> there's less special handling and
On Tue, 17 Jan 2023 18:07:37 GMT, Sergey Tsypanov wrote:
>> - `MethodType.ptypes()` can be used instead of `MethodType.parameterList()`
>> when we don't need a copy
>> - comparison of two lists can be done without `Stream.reduce()`
>
> Sergey Tsypanov has updated the pull request incrementally
On Fri, 13 Jan 2023 21:47:40 GMT, Justin Lu wrote:
> This PR implements _JEP 413: Code Snippets in Java API Documentation_ for
> [java.text.MessageFormat](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/class-use/MessageFormat.html).
>
> Code examples using ... blocks
On Tue, 17 Jan 2023 19:24:09 GMT, Naoto Sato wrote:
>> This PR implements _JEP 413: Code Snippets in Java API Documentation_ for
>> [java.text.MessageFormat](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/class-use/MessageFormat.html).
>>
>> Code examples using ...
On Fri, 13 Jan 2023 21:47:40 GMT, Justin Lu wrote:
> This PR implements _JEP 413: Code Snippets in Java API Documentation_ for
> [java.text.MessageFormat](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/class-use/MessageFormat.html).
>
> Code examples using ... blocks
On Fri, 13 Jan 2023 21:47:40 GMT, Justin Lu wrote:
> This PR implements _JEP 413: Code Snippets in Java API Documentation_ for
> [java.text.MessageFormat](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/class-use/MessageFormat.html).
>
> Code examples using ... blocks
On Wed, 11 Jan 2023 13:19:32 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>
> The `jlink` command allows a `--endian` option to specify the byte order in
> the generated image.
On Tue, 17 Jan 2023 17:40:33 GMT, Calvin Cheung wrote:
>> Moving the `ArchivedEnumTest.java` from `runtime/cds/appcds/cacheObject` to
>> `jdk/internal/misc/CDS` so that the test will be run in jdk-tier1. This is
>> to avoid inadvertently breakage of the test like in JDK-8292499.
>>
>>
On Mon, 16 Jan 2023 23:28:37 GMT, Claes Redestad wrote:
>> Continuing the work initiated by @luhenry to unroll and then intrinsify
>> polynomial hash loops.
>>
>> I've rewired the library changes to route via a single `@IntrinsicCandidate`
>> method. To make this work I've harmonized how they
On Tue, 17 Jan 2023 18:15:21 GMT, Alan Bateman wrote:
>> Eirik Bjorsnos has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Make it more clear in the @summary tag that it is the block file that is
>> pending, not the signature file
>> -
> This PR adds test coverage for pending block files in signed JAR files
>
> A signed JAR has pending block files if the block file [RSA, DSA, EC] comes
> before the corresponding signature file [SF] in the JAR.
>
> JarVerifier.processEntry supports processing of such pending block files, but
On Wed, 11 Jan 2023 23:41:46 GMT, Justin Lu wrote:
> This PR implements JEP 413: Code Snippets in Java API Documentation for
> _[java.util.TimeZone](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/TimeZone.html)_.
>
> Code examples using ... blocks are replaced with
On Wed, 9 Nov 2022 21:06:50 GMT, iaroslavski wrote:
>> Sorting:
>>
>> - adopt radix sort for sequential and parallel sorts on
>> int/long/float/double arrays (almost random and length > 6K)
>> - fix tryMergeRuns() to better handle case when the last run is a single
>> element
>> - minor
On Mon, 16 Jan 2023 11:44:36 GMT, Eirik Bjorsnos wrote:
> This PR adds test coverage for pending block files in signed JAR files
>
> A signed JAR has pending block files if the block file [RSA, DSA, EC] comes
> before the corresponding signature file [SF] in the JAR.
>
>
On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote:
> Hi all,
>
> Please review the fix for the build failure with clang-15.
>
> 1. -Wbitwise-instead-of-logical
>
>1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the
> warning
>2)
On Tue, 17 Jan 2023 15:30:12 GMT, Rémi Forax wrote:
>> Precious little method handle use in lambda bootstrap since JDK 11. Though I
>> agree with the sentiment - having fixed a number of bootstrap issues in the
>> past - `MethodHandles` is a small step up the abstraction ladder and the
>>
On Mon, 16 Jan 2023 11:44:36 GMT, Eirik Bjorsnos wrote:
> This PR adds test coverage for pending block files in signed JAR files
>
> A signed JAR has pending block files if the block file [RSA, DSA, EC] comes
> before the corresponding signature file [SF] in the JAR.
>
>
On Tue, 17 Jan 2023 14:07:01 GMT, Weijun Wang wrote:
>> This PR adds test coverage for pending block files in signed JAR files
>>
>> A signed JAR has pending block files if the block file [RSA, DSA, EC] comes
>> before the corresponding signature file [SF] in the JAR.
>>
>>
This PR adds test coverage for pending block files in signed JAR files
A signed JAR has pending block files if the block file [RSA, DSA, EC] comes
before the corresponding signature file [SF] in the JAR.
JarVerifier.processEntry supports processing of such pending block files, but
this code
> - `MethodType.ptypes()` can be used instead of `MethodType.parameterList()`
> when we don't need a copy
> - comparison of two lists can be done without `Stream.reduce()`
Sergey Tsypanov has updated the pull request incrementally with one additional
commit since the last revision:
Polishing
On Tue, 17 Jan 2023 13:35:25 GMT, Kevin Rushforth wrote:
>>> Normally, such changes in third-party libraries need to be done upstream,
>>> and not locally. @prrace can confirm.
>>
>> Thanks @kevinrushforth for your review.
>>
>> Yes, it had been fixed in the upstream and I just follow it.
>>
On Wed, 11 Jan 2023 14:07:53 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of
On Wed, 11 Jan 2023 13:19:32 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>
> The `jlink` command allows a `--endian` option to specify the byte order in
> the generated image.
On Wed, 11 Jan 2023 13:19:32 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>
> The `jlink` command allows a `--endian` option to specify the byte order in
> the generated image.
> Moving the `ArchivedEnumTest.java` from `runtime/cds/appcds/cacheObject` to
> `jdk/internal/misc/CDS` so that the test will be run in jdk-tier1. This is to
> avoid inadvertently breakage of the test like in JDK-8292499.
>
> Testing: jdk-tier1, tier3, tier4.
Calvin Cheung has updated the pull
Patch optimizes Adler32 stub for AVX512 target.
Main computation loop now uses zero extended lane widening load vector
operation.
New sequence also honors AVX3Thresholds so that implementation uses existing
AVX2 instruction sequence on relevant targets
if input size is smaller than threshold
On Thu, 12 Jan 2023 17:08:29 GMT, Naoto Sato wrote:
> Fixing a regression caused by the fix to
> [JDK-8298971](https://bugs.openjdk.org/browse/JDK-8298971). The previous fix
> lacked the native part change on Windows.
This pull request has now been integrated.
Changeset: e7e37121
Author:
On Tue, 17 Jan 2023 13:33:06 GMT, Kevin Rushforth wrote:
>> Hi all,
>>
>> Please review the fix for the build failure with clang-15.
>>
>> 1. -Wbitwise-instead-of-logical
>>
>>1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the
>> warning
>>2)
On Sat, 14 Jan 2023 12:02:11 GMT, Eirik Bjorsnos wrote:
>> src/java.base/share/classes/java/util/zip/ZipFile.java line 1748:
>>
>>> 1746: .isBlockOrSF(new String(name, off, len,
>>> UTF_8.INSTANCE)
>>> 1747: .toUpperCase(Locale.ENGLISH)));
>>> 1748:
>>
>>
On Tue, 17 Jan 2023 11:34:52 GMT, Alan Bateman wrote:
> The ModuleReader implementation for exploded modules maps resource names to
> file paths. A small oversight is that it doesn't handle InvalidPathException
> which is thrown when the resource name maps to something that can't be parsed
>
On Sat, 14 Jan 2023 12:14:54 GMT, Eirik Bjorsnos wrote:
>> src/jdk.jartool/share/classes/jdk/security/jarsigner/JarSigner.java line 980:
>>
>>> 978: * Returns true iff the entry resides directly in the META-INF/
>>> directory
>>> 979: */
>>> 980: private boolean
> The pattern matching switches are using a bootstrap method
> `SwitchBootstrap.typeSwitch` to implement the jumps in the switch. Basically,
> for a switch like:
>
> switch (obj) {
> case String s when s.isEmpty() -> {}
> case String s -> {}
> case CharSequence cs -> {}
> ...
>
On Wed, 11 Jan 2023 14:30:46 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>>
>> The `jlink` command allows a `--endian` option to specify the byte order in
>> the generated
On Tue, 17 Jan 2023 14:53:41 GMT, Roger Riggs wrote:
> `newStringUTF*NoRepl` is not described or expected to optimizing the array
> allocation. Nor does it mandate that callers must guarantee that the array is
> not re-used or modified. The access to this method through JavaLangAccess is
>
On Tue, 17 Jan 2023 10:18:42 GMT, Claes Redestad wrote:
>> Using lambdas inside MethodHandles is quite dangerous given that lambdas are
>> initialized using method handles. It may work now because
>> longuestParameterList() is not called when initializing a lambda but it may
>> make any
On Tue, 17 Jan 2023 12:23:25 GMT, Alan Bateman wrote:
>> The choice of a `` paragraph rather than `@apiNote` is for consistency
>> with similar commentary paragraphs in the specs of `CASE_INSENSITIVE`,
>> `UNICODE_CASE`, and `UNICODE_CHARACTER_CLASS`.
>>
>> I have no problems in using
> - `MethodType.ptypes()` can be used instead of `MethodType.parameterList()`
> when we don't need a copy
> - comparison of two lists can be done without `Stream.reduce()`
Sergey Tsypanov has updated the pull request incrementally with one additional
commit since the last revision:
Simplify
On Mon, 9 Jan 2023 03:34:55 GMT, Glavo wrote:
> `JavaLangAccess::newStringUTF8NoRepl` and
> `JavaLangAccess::getBytesUTF8NoRepl` are not implemented correctly. They
> always copy arrays, rather than avoiding copying as much as possible as
> javadoc says.
>
> I ran the tier1 test without any
On Tue, 17 Jan 2023 14:10:43 GMT, Alan Bateman wrote:
> So yes, it could be added as a test case, just wouldn't add any more test
> coverage to the existing tests.
Thank you for the explanation, Alan. The current state of the test, in the PR,
looks fine to me then.
-
PR:
On Tue, 17 Jan 2023 12:34:31 GMT, Jaikiran Pai wrote:
> Should we also add a `C:/java` (one with a forward slash) to the new junk
> resource names added in this test, to exercise the path where a forward slash
> is present in a resource name which also has the Windows disallowed `:`
>
On Tue, 17 Jan 2023 11:34:52 GMT, Alan Bateman wrote:
> The ModuleReader implementation for exploded modules maps resource names to
> file paths. A small oversight is that it doesn't handle InvalidPathException
> which is thrown when the resource name maps to something that can't be parsed
>
On Sun, 15 Jan 2023 01:56:06 GMT, Jie Fu wrote:
>> src/java.desktop/share/native/libharfbuzz/hb-meta.hh line 191:
>>
>>> 189: #define hb_int_max(T) hb_int_max::value
>>> 190:
>>> 191: #if defined(__GNUC__) && __GNUC__ < 5 && !defined(__clang__)
>>
>> Normally, such changes in third-party
On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote:
> Hi all,
>
> Please review the fix for the build failure with clang-15.
>
> 1. -Wbitwise-instead-of-logical
>
>1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the
> warning
>2)
On Mon, 16 Jan 2023 11:48:21 GMT, Aleksey Shipilev wrote:
>> Feilong Jiang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> more code style adjustment
>
> src/hotspot/cpu/riscv/codeBuffer_riscv.cpp line 3:
>
>> 1: /*
>> 2: * Copyright
On Tue, 17 Jan 2023 11:34:52 GMT, Alan Bateman wrote:
> The ModuleReader implementation for exploded modules maps resource names to
> file paths. A small oversight is that it doesn't handle InvalidPathException
> which is thrown when the resource name maps to something that can't be parsed
>
On Tue, 17 Jan 2023 11:34:52 GMT, Alan Bateman wrote:
> The ModuleReader implementation for exploded modules maps resource names to
> file paths. A small oversight is that it doesn't handle InvalidPathException
> which is thrown when the resource name maps to something that can't be parsed
>
On Tue, 17 Jan 2023 10:20:43 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/util/regex/Pattern.java line 1099:
>>
>>> 1097: * flags.
>>> 1098: *
>>> 1099: * Setting {@link #CANON_EQ} among the flags may impose a
>>> moderate risk
>>
>> This may be a
On Tue, 17 Jan 2023 11:44:32 GMT, Vladimir Sitnikov
wrote:
>> @RogerRiggs Thanks!
>
> @magicus , have you considered adding `.editorconfig` file (see
> https://editorconfig.org/ ) so it configures developers' editors to trim the
> whitespace?
>
> Of course, `.editorconfig` does not enforce
The ModuleReader implementation for exploded modules maps resource names to
file paths. A small oversight is that it doesn't handle InvalidPathException
which is thrown when the resource name maps to something that can't be parsed
as a file path. This has a knock on impact to Class/ClassLoader
On Mon, 16 Jan 2023 18:52:24 GMT, Magnus Ihse Bursie wrote:
>> The non-client parts look fine.
>
> @RogerRiggs Thanks!
@magicus , have you considered adding `.editorconfig` file (see
https://editorconfig.org/ ) so it configures developers' editors to trim the
whitespace?
Of course,
On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote:
> Hi all,
>
> Please review the fix for the build failure with clang-15.
>
> 1. -Wbitwise-instead-of-logical
>
>1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the
> warning
>2)
On Tue, 17 Jan 2023 10:06:57 GMT, Alan Bateman wrote:
>> - Strengthen a computation that could overflow.
>> - Specify that use of CANON_EQ could exhaust memory in the compilation phase.
>
> src/java.base/share/classes/java/util/regex/Pattern.java line 1099:
>
>> 1097: * flags.
>> 1098:
On Tue, 17 Jan 2023 10:11:49 GMT, Rémi Forax wrote:
>> src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 6754:
>>
>>> 6752: filter(t -> t.parameterCount() > skipSize).
>>> 6753: map(MethodType::ptypes).
>>> 6754:
On Tue, 17 Jan 2023 09:51:31 GMT, Claes Redestad wrote:
>> - `MethodType.ptypes()` can be used instead of `MethodType.parameterList()`
>> when we don't need a copy
>> - comparison of two lists can be done without `Stream.reduce()`
>
>
On Tue, 17 Jan 2023 09:44:17 GMT, Raffaello Giulietti
wrote:
> - Strengthen a computation that could overflow.
> - Specify that use of CANON_EQ could exhaust memory in the compilation phase.
src/java.base/share/classes/java/util/regex/Pattern.java line 1099:
> 1097: * flags.
> 1098:
On Tue, 17 Jan 2023 08:22:28 GMT, Sergey Tsypanov wrote:
> - `MethodType.ptypes()` can be used instead of `MethodType.parameterList()`
> when we don't need a copy
> - comparison of two lists can be done without `Stream.reduce()`
Remove `EMPTY` (using my earlier suggestion or by simply inlining
On Tue, 17 Jan 2023 08:22:28 GMT, Sergey Tsypanov wrote:
> - `MethodType.ptypes()` can be used instead of `MethodType.parameterList()`
> when we don't need a copy
> - comparison of two lists can be done without `Stream.reduce()`
src/java.base/share/classes/java/lang/invoke/MethodHandles.java
- Strengthen a computation that could overflow.
- Specify that use of CANON_EQ could exhaust memory in the compilation phase.
-
Commit messages:
- 8300207: Add a pre-check for the number of canonical equivalent permutations
in j.u.r.Pattern
Changes:
On Mon, 9 Jan 2023 09:22:25 GMT, Per Minborg wrote:
>> Currently, `java.io.Bits` is using explicit logic to read/write various
>> primitive types to/from byte arrays. Switching to the use of `VarHandle`
>> access would provide better performance and less code.
>>
>> Also, using a standard
On Mon, 16 Jan 2023 06:38:35 GMT, Feilong Jiang wrote:
>> Add experimental Foreign Function & Memory API support for RISC-V.
>>
>> For details of the FFM API RISC-V port please refer to [JBS
>> issue](https://bugs.openjdk.org/browse/JDK-8293841)
>>
>> Testing:
>>
>> - [x] jdk_foreign with
On Tue, 17 Jan 2023 08:30:58 GMT, Sergey Tsypanov wrote:
>>> > Do you see any concrete examples of classes in the JDK that could benefit
>>> > from a "VarHandlization"?
>>>
>>> `ImageOutputStreamImpl` and `ImageInputStreamImpl` in
>>> `javax.imageio.stream` have some very similar code that
On Tue, 17 Jan 2023 07:43:07 GMT, Per Minborg wrote:
>>>
>>> Do you see any concrete examples of classes in the JDK that could benefit
>>> from a "VarHandlization"?
>>
>> `ImageOutputStreamImpl` and `ImageInputStreamImpl` in
>> `javax.imageio.stream` have some very similar code that might
- `MethodType.ptypes()` can be used instead of `MethodType.parameterList()`
when we don't need a copy
- comparison of two lists can be done without `Stream.reduce()`
-
Commit messages:
- Fix test
- Improve MH
Changes: https://git.openjdk.org/jdk/pull/12025/files
Webrev:
97 matches
Mail list logo
