Re: RFR: 8303175: (fs) Deprecate com.sun.nio.file.SensitivityWatchEventModifier for removal [v4]

2023-03-01 Thread Alan Bateman
On Wed, 1 Mar 2023 18:23:43 GMT, Brian Burkhalter wrote: >> Deprecate `SensitivityWatchEventModifier` for now instead of directly >> removing it as proposed in #12626. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > >

Re: RFR: JDK-8302801: Remove fdlibm C sources

2023-03-01 Thread Alan Bateman
On Thu, 2 Mar 2023 05:54:52 GMT, Joe Darcy wrote: > While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I > thought I'd get out for the review the next phase of the FDLIBM port: > removing the FDLIBM C sources from the repo. > > A repo with the changes for JDK-8302027

Re: RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v6]

2023-03-01 Thread Martin Doerr
> Implementation of "Foreign Function & Memory API" for linux on Power (Little > Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification". > > This PR does not include code for VaList support because it's supposed to get > removed by

Re: RFR: 8303486: [REDO] Update ProcessTools.startProcess(...) to exit early if process exit before linePredicate is printed.

2023-03-01 Thread David Holmes
On Wed, 1 Mar 2023 20:50:38 GMT, Leonid Mesnik wrote: > It is the 2nd attempt to fix > [JDK-8303133](https://bugs.openjdk.org/browse/JDK-8303133) Update > ProcessTools.startProcess(...) to exit early if the process exit before > linePredicate is printed. > > The first fix failed because it

RFR: JDK-8302801: Remove fdlibm C sources

2023-03-01 Thread Joe Darcy
While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I thought I'd get out for the review the next phase of the FDLIBM port: removing the FDLIBM C sources from the repo. A repo with the changes for JDK-8302027 and this PR successful build on the default set of platform

Withdrawn: JDK-8295756 Improve NonLocalRegistry Manual Test Process

2023-03-01 Thread duke
On Fri, 21 Oct 2022 21:45:30 GMT, Bill Huang wrote: > The current non local registry tests require a manual process that runs > rmiregitrty on a different machine and changes the -Dregistry.host property > in the source before running the tests on the local machine. This task is > created to

Re: RFR: JDK-8297605 DelayQueue javadoc is confusing

2023-03-01 Thread Martin Buchholz
On Mon, 27 Feb 2023 20:09:12 GMT, Martin Buchholz wrote: > I wonder if there's now a way to override javadoc for remove() without > creating a new method body. I thought recent javadoc features might have been useful here, but I scanned the results from this jql: subcomponent in (

Re: RFR: 8303039: Utilize `coverageLevels.txt`

2023-03-01 Thread Jaikiran Pai
On Wed, 1 Mar 2023 23:13:55 GMT, Steven R. Loomis wrote: > my openjdk name should be `srl` … i'm still there > https://openjdk.org/census#srl Hello Steven, please follow the instructions here to have your github account linked to the OpenJDK id

Re: RFR: 8303039: Utilize `coverageLevels.txt` [v2]

2023-03-01 Thread Steven R . Loomis
On Thu, 2 Mar 2023 01:03:20 GMT, Naoto Sato wrote: >> This is a pre-requisite for supporting CLDR v43, where they combine `seeds` >> locales with `common` locales >> (https://cldr.unicode.org/index/downloads/cldr-43#h.7s25aqdv767e). In order >> to have the same coverage level of locales,

Re: RFR: 8294982: Implementation of Classfile API [v31]

2023-03-01 Thread Paul Sandoz
On Wed, 1 Mar 2023 15:00:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8303039: Utilize `coverageLevels.txt` [v2]

2023-03-01 Thread Naoto Sato
> This is a pre-requisite for supporting CLDR v43, where they combine `seeds` > locales with `common` locales > (https://cldr.unicode.org/index/downloads/cldr-43#h.7s25aqdv767e). In order > to have the same coverage level of locales, CLDRConverter tool needs to comb > through the locale files

Re: RFR: 8294982: Implementation of Classfile API [v12]

2023-03-01 Thread Paul Sandoz
On Mon, 6 Feb 2023 13:50:07 GMT, Adam Sotona wrote: >> Actually, we also have a ClassfileVersion class, so that could be a better >> place for version numbers? > > There were several iterations of "where to store numeric constants". > It is hard to find them when spread across many classes and

Re: RFR: 8294982: Implementation of Classfile API [v13]

2023-03-01 Thread Paul Sandoz
On Wed, 8 Feb 2023 11:00:14 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/attribute/StackMapTableAttribute.java >> line 68: >> >>> 66: * A simple stack value. >>> 67: */ >>> 68: public enum SimpleVerificationTypeInfo implements >>>

Re: RFR: 8294982: Implementation of Classfile API [v31]

2023-03-01 Thread Paul Sandoz
On Wed, 1 Mar 2023 15:00:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8303472: Display name for region TR [v2]

2023-03-01 Thread Justin Lu
On Wed, 1 Mar 2023 22:52:09 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Supply test with changes, use unicode escapes to be consistent >> - copyright year > >

Re: RFR: 8303472: Display name for region TR [v2]

2023-03-01 Thread Justin Lu
> This PR changes the English name for the region `TR`, from `Turkey` to > `Türkiye`. Although this change is included in the upcoming CLDR v43, it > should be applied as a spot change so that it can be back-ported properly (As > it is a common English region name). > > > > This change

RFR: 8294137: Review running times of java.math tests

2023-03-01 Thread Brian Burkhalter
Break up `BigIntegerTest` and `SymmetricRangeTests` into subsets which are run quasi-randomly as a function of second within the minute at the time the test is running. `LargeValueExceptions` does not appear amenable to this treatment. - Commit messages: - 8294137: Review running

Re: RFR: 8294137: Review running times of java.math tests

2023-03-01 Thread Brian Burkhalter
On Wed, 1 Mar 2023 23:36:04 GMT, Brian Burkhalter wrote: > Break up `BigIntegerTest` and `SymmetricRangeTests` into subsets which are > run quasi-randomly as a function of second within the minute at the time the > test is running. `LargeValueExceptions` does not appear amenable to this >

Re: RFR: 8303039: Utilize `coverageLevels.txt`

2023-03-01 Thread Steven R . Loomis
On Wed, 1 Mar 2023 23:19:01 GMT, Naoto Sato wrote: >> make/jdk/src/classes/build/tools/cldrconverter/CLDRConverter.java line 1212: >> >>> 1210: a -> >>> Locale.forLanguageTag(a[0].trim().replaceAll("_", "-")), >>> 1211: a -> a[1].trim(), >>> 1212:

Re: RFR: 8303039: Utilize `coverageLevels.txt`

2023-03-01 Thread Naoto Sato
On Wed, 1 Mar 2023 23:06:10 GMT, Steven R. Loomis wrote: >> This is a pre-requisite for supporting CLDR v43, where they combine `seeds` >> locales with `common` locales >> (https://cldr.unicode.org/index/downloads/cldr-43#h.7s25aqdv767e). In order >> to have the same coverage level of

Re: RFR: 8303039: Utilize `coverageLevels.txt`

2023-03-01 Thread Steven R . Loomis
On Wed, 1 Mar 2023 23:18:59 GMT, Naoto Sato wrote: >> is this from the alpha2 drop? or v42's? > > Yes, this is the file from the released CLDR v42. We have not integrated v43 > yet. this is great groundwork. - PR: https://git.openjdk.org/jdk/pull/12812

Re: RFR: 8303039: Utilize `coverageLevels.txt`

2023-03-01 Thread Naoto Sato
On Wed, 1 Mar 2023 23:02:33 GMT, Steven R. Loomis wrote: >> make/data/cldr/common/properties/coverageLevels.txt line 2: >> >>> 1: #coverageLevels.txt >>> 2: #Copyright © 2022 Unicode, Inc. >> >> older version? > > is this from the alpha2 drop? or v42's? Yes, this is the file

Re: RFR: 8303409: Add Windows AArch64 ABI support to the Foreign Function & Memory API

2023-03-01 Thread Jorn Vernee
On Mon, 27 Feb 2023 17:04:28 GMT, Saint Wesonga wrote: > There are 2 primary differences between the Windows ARM64 ABI and the > macOS/Linux ARM64 ABI: variadic floating point arguments are passed in > general purpose registers on Windows (instead of the vector registers). In > addition to

RFR: 8303409: Add Windows AArch64 ABI support to the Foreign Function & Memory API

2023-03-01 Thread Saint Wesonga
There are 2 primary differences between the Windows ARM64 ABI and the macOS/Linux ARM64 ABI: variadic floating point arguments are passed in general purpose registers on Windows (instead of the vector registers). In addition to this, up to 64 bytes of a struct being passed to a variadic

Re: RFR: 8303039: Utilize `coverageLevels.txt`

2023-03-01 Thread Steven R . Loomis
On Wed, 1 Mar 2023 23:02:06 GMT, Steven R. Loomis wrote: >> This is a pre-requisite for supporting CLDR v43, where they combine `seeds` >> locales with `common` locales >> (https://cldr.unicode.org/index/downloads/cldr-43#h.7s25aqdv767e). In order >> to have the same coverage level of

Re: RFR: 8303039: Utilize `coverageLevels.txt`

2023-03-01 Thread Steven R . Loomis
On Wed, 1 Mar 2023 19:50:56 GMT, Naoto Sato wrote: > This is a pre-requisite for supporting CLDR v43, where they combine `seeds` > locales with `common` locales > (https://cldr.unicode.org/index/downloads/cldr-43#h.7s25aqdv767e). In order > to have the same coverage level of locales,

Re: RFR: 8303039: Utilize `coverageLevels.txt`

2023-03-01 Thread Steven R . Loomis
On Wed, 1 Mar 2023 19:50:56 GMT, Naoto Sato wrote: > This is a pre-requisite for supporting CLDR v43, where they combine `seeds` > locales with `common` locales > (https://cldr.unicode.org/index/downloads/cldr-43#h.7s25aqdv767e). In order > to have the same coverage level of locales,

Re: RFR: 8294982: Implementation of Classfile API [v31]

2023-03-01 Thread Paul Sandoz
On Wed, 1 Mar 2023 15:00:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8294982: Implementation of Classfile API [v31]

2023-03-01 Thread Paul Sandoz
On Wed, 1 Mar 2023 15:00:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8303472: Display name for region TR

2023-03-01 Thread Naoto Sato
On Wed, 1 Mar 2023 21:58:00 GMT, Justin Lu wrote: > This PR changes the English name for the region `TR`, from `Turkey` to > `Türkiye`. Although this change is included in the upcoming CLDR v43, it > should be applied as a spot change so that it can be back-ported properly (As > it is a

Re: RFR: 8303266: Prefer ArrayList to LinkedList in JImageTask

2023-03-01 Thread Stuart Marks
On Mon, 27 Feb 2023 11:33:38 GMT, Andrey Turbanov wrote: > `LinkedList` is used as a field > `jdk.tools.jimage.JImageTask.OptionsValues#jimages` > It's created, filled (with `add`) and then iterated. No removes from the head > or something like this. `ArrayList` should be preferred as more

Re: RFR: 8294982: Implementation of Classfile API [v31]

2023-03-01 Thread Paul Sandoz
On Wed, 1 Mar 2023 15:00:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) [v6]

2023-03-01 Thread Raffaello Giulietti
> Add an `indexOf()` variant allowing to specify both a lower and an upper > bound on the search. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) -

Re: RFR: 8294982: Implementation of Classfile API [v31]

2023-03-01 Thread Paul Sandoz
On Wed, 1 Mar 2023 15:00:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8294982: Implementation of Classfile API [v31]

2023-03-01 Thread Paul Sandoz
On Wed, 1 Mar 2023 15:00:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8294982: Implementation of Classfile API [v31]

2023-03-01 Thread Paul Sandoz
On Wed, 1 Mar 2023 15:00:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

RFR: 8303472: Display name for region TR

2023-03-01 Thread Justin Lu
This PR changes the English name for the region `TR`, from `Turkey` to `Türkiye`. Although this change is included in the upcoming CLDR v43, it should be applied as a spot change so that it can be back-ported properly (As it is a common English region name). This change targets both the CLDR

RFR: 8303275: Use {@Return and @linkplain in Locale and related classes

2023-03-01 Thread Justin Lu
This PR modifies the javadoc of methods in Locale, LocaleServiceProvider, and LocaleServiceProviderPool to use {@return and @linkplain. - Commit messages: - fix conflicts - Locale copyright - Use @linkplain and {@return in Locale - Use {@return and spacing in LSPP - Use

Re: RFR: 8303275: Use {@Return and @linkplain in Locale and related classes

2023-03-01 Thread Justin Lu
On Tue, 28 Feb 2023 00:09:45 GMT, Justin Lu wrote: > This PR modifies the javadoc of methods in Locale, LocaleServiceProvider, and > LocaleServiceProviderPool to use {@return and @linkplain. src/java.base/share/classes/java/util/Locale.java line 1200: > 1198: > 1199: /** > 1200: *

Re: RFR: 8294982: Implementation of Classfile API [v31]

2023-03-01 Thread Paul Sandoz
On Wed, 1 Mar 2023 15:00:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8294982: Implementation of Classfile API [v31]

2023-03-01 Thread Paul Sandoz
On Wed, 1 Mar 2023 15:00:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

RFR: 8303486: [REDO] Update ProcessTools.startProcess(...) to exit early if process exit before linePredicate is printed.

2023-03-01 Thread Leonid Mesnik
It is the 2nd attempt to fix [JDK-8303133](https://bugs.openjdk.org/browse/JDK-8303133) Update ProcessTools.startProcess(...) to exit early if the process exit before linePredicate is printed. The first fix failed because it runs Utils.waitForCondition(BooleanSupplier condition, long timeout,

Re: RFR: 8303473: Add implied {@code} in java.lang.invoke.MethodHandles [v2]

2023-03-01 Thread Jonathan Gibbons
On Wed, 1 Mar 2023 19:07:40 GMT, Pavel Rappo wrote: >> Please review this trivial fix for _comments_. While some affected comments >> aren't doc comments and none of the affected comments partake in the API >> Documentation, it seems reasonable to be consistent. > > Pavel Rappo has updated the

Re: RFR: 8303473: Add implied {@code} in java.lang.invoke.MethodHandles [v2]

2023-03-01 Thread Mandy Chung
On Wed, 1 Mar 2023 19:07:40 GMT, Pavel Rappo wrote: >> Please review this trivial fix for _comments_. While some affected comments >> aren't doc comments and none of the affected comments partake in the API >> Documentation, it seems reasonable to be consistent. > > Pavel Rappo has updated the

Re: RFR: 8294982: Implementation of Classfile API [v31]

2023-03-01 Thread Paul Sandoz
On Wed, 1 Mar 2023 15:00:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8303266: Prefer ArrayList to LinkedList in JImageTask

2023-03-01 Thread Andrey Turbanov
On Wed, 1 Mar 2023 01:32:39 GMT, Roger Riggs wrote: >In choosing how you spend your time, make your efforts and the efforts of the >reviewers count for something. It's one of the reasons, why I don't create PRs with massive replacements. I carefully choose places in the code, where I think

RFR: 8303039: Utilize `coverageLevels.txt`

2023-03-01 Thread Naoto Sato
This is a pre-requisite for supporting CLDR v43, where they combine `seeds` locales with `common` locales (https://cldr.unicode.org/index/downloads/cldr-43#h.7s25aqdv767e). In order to have the same coverage level of locales, CLDRConverter tool needs to comb through the locale files based on

Re: RFR: 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) [v4]

2023-03-01 Thread Raffaello Giulietti
On Wed, 1 Mar 2023 18:54:09 GMT, Alan Bateman wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) > >

Re: RFR: 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) [v5]

2023-03-01 Thread Raffaello Giulietti
> Add an `indexOf()` variant allowing to specify both a lower and an upper > bound on the search. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) -

Re: RFR: 8303473: Add implied {@code} in java.lang.invoke.MethodHandles [v2]

2023-03-01 Thread Lance Andersen
On Wed, 1 Mar 2023 19:07:40 GMT, Pavel Rappo wrote: >> Please review this trivial fix for _comments_. While some affected comments >> aren't doc comments and none of the affected comments partake in the API >> Documentation, it seems reasonable to be consistent. > > Pavel Rappo has updated the

Re: RFR: 8303473: Add implied {@code} in java.lang.invoke.MethodHandles

2023-03-01 Thread Pavel Rappo
On Wed, 1 Mar 2023 18:47:14 GMT, Pavel Rappo wrote: > Please review this trivial fix for _comments_. While some affected comments > aren't doc comments and none of the affected comments partake in the API > Documentation, it seems reasonable to be consistent. Inadvertently found one more typo

Re: RFR: 8303473: Add implied {@code} in java.lang.invoke.MethodHandles [v2]

2023-03-01 Thread Pavel Rappo
> Please review this trivial fix for _comments_. While some affected comments > aren't doc comments and none of the affected comments partake in the API > Documentation, it seems reasonable to be consistent. Pavel Rappo has updated the pull request incrementally with one additional commit

Re: RFR: 8303473: Add implied {@code} in java.lang.invoke.MethodHandles [v2]

2023-03-01 Thread Lance Andersen
On Wed, 1 Mar 2023 19:03:32 GMT, Pavel Rappo wrote: >> Please review this trivial fix for _comments_. While some affected comments >> aren't doc comments and none of the affected comments partake in the API >> Documentation, it seems reasonable to be consistent. > > Pavel Rappo has updated the

Re: RFR: 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) [v4]

2023-03-01 Thread Alan Bateman
On Wed, 1 Mar 2023 16:24:46 GMT, Raffaello Giulietti wrote: >> Add an `indexOf()` variant allowing to specify both a lower and an upper >> bound on the search. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > >

Re: RFR: 8303473: Add implied {@code} in java.lang.invoke.MethodHandles

2023-03-01 Thread Jonathan Gibbons
On Wed, 1 Mar 2023 18:47:14 GMT, Pavel Rappo wrote: > Please review this trivial fix for _comments_. While some affected comments > aren't doc comments and none of the affected comments partake in the API > Documentation, it seems reasonable to be consistent. Marked as reviewed by jjg

RFR: 8303473: Add implied {@code} in java.lang.invoke.MethodHandles

2023-03-01 Thread Pavel Rappo
Please review this trivial fix for _comments_. While some affected comments aren't doc comments and none of the affected comments partake in the API Documentation, it seems reasonable to be consistent. - Commit messages: - Initial commit Changes:

RFR: 8303431: [JVMCI] libgraal annotation API

2023-03-01 Thread Doug Simon
This PR extends JVMCI with new API (`jdk.vm.ci.meta.Annotated`) for accessing annotations. The main differences from `java.lang.reflect.AnnotatedElement` are: * Each `Annotated` method explicitly specifies the annotation type(s) for which it wants annotation data. That is, there is no direct

Re: RFR: 8303175: (fs) Deprecate com.sun.nio.file.SensitivityWatchEventModifier for removal [v4]

2023-03-01 Thread Brian Burkhalter
> Deprecate `SensitivityWatchEventModifier` for now instead of directly > removing it as proposed in #12626. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8303175: Change @deprecated verbiage in SensitivityWatchEventModifier

Integrated: 8303401: Add a Vector API equalsIgnoreCase micro benchmark

2023-03-01 Thread Eirik Bjorsnos
On Tue, 28 Feb 2023 15:59:26 GMT, Eirik Bjorsnos wrote: > This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set of > benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark serves > as an example of how vectorization can be useful also in the area of text >

Re: RFR: JDK-8302027: Port fdlibm trig functions (sin, cos, tan) to Java

2023-03-01 Thread Joseph D. Darcy
On 3/1/2023 8:16 AM, Raffaello Giulietti wrote: On Wed, 1 Mar 2023 14:27:09 GMT, Andrey Turbanov wrote: Last and certainly not least in the port of FDLIBM to Java, the transcendental methods for sin, cos, and tan. Some more tests are to be written in the StrictMath directory to verify that

Re: RFR: 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) [v4]

2023-03-01 Thread Raffaello Giulietti
On Wed, 1 Mar 2023 18:09:32 GMT, Roger Riggs wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) > > This is looking good. > When the single char

Re: RFR: JDK-8295859: Update Manual Test Groups [v6]

2023-03-01 Thread Bill Huang
> This task is created to update the manual test groups. Bill Huang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits: - Merge branch 'JDK-8295859' of gh:bwhuang-us/jdk into JDK-8295859 - Added missing manual tests from

Withdrawn: JDK-8295859: Update Manual Test Groups

2023-03-01 Thread Bill Huang
On Tue, 25 Oct 2022 23:10:53 GMT, Bill Huang wrote: > This task is created to update the manual test groups. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/10864

Integrated: 8303232: java.util.Date.parse(String) and java.util.Date(String) don't declare thrown IllegalArgumentException

2023-03-01 Thread Justin Lu
On Tue, 28 Feb 2023 00:07:05 GMT, Justin Lu wrote: > The method `java.util.Date.parse(String)` and as a result, constructor > `java.util.Date(String)` throw an `IllegalArgumentException`. This exception > is not properly referenced in the javadoc, and this PR simply adds the throws > javadoc

Re: RFR: 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) [v4]

2023-03-01 Thread Roger Riggs
On Wed, 1 Mar 2023 16:24:46 GMT, Raffaello Giulietti wrote: >> Add an `indexOf()` variant allowing to specify both a lower and an upper >> bound on the search. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > >

Re: RFR: JDK-8302027: Port fdlibm trig functions (sin, cos, tan) to Java [v2]

2023-03-01 Thread Joe Darcy
> Last and certainly not least in the port of FDLIBM to Java, the > transcendental methods for sin, cos, and tan. > > Some more tests are to be written in the StrictMath directory to verify that > the StrictMath algorihtm for sin/cos/tan is being used rather than a > different one. However, I

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v7]

2023-03-01 Thread Eirik Bjorsnos
On Wed, 1 Mar 2023 17:47:45 GMT, Paul Sandoz wrote: > Benchmark looks good. > > I think you need to look at the generated code and perf data to get more > insight into the differences you are observing. > > Sometimes array alignment can add variance to the results (which may not be > the

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v7]

2023-03-01 Thread Eirik Bjorsnos
On Wed, 1 Mar 2023 17:42:16 GMT, Paul Sandoz wrote: >> Eirik Bjorsnos has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use GT, LT, EQ operations since they seem to outperform GE, LE, NE. > >

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v8]

2023-03-01 Thread Paul Sandoz
On Wed, 1 Mar 2023 17:48:46 GMT, Eirik Bjorsnos wrote: >> This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set >> of benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark >> serves as an example of how vectorization can be useful also in the area of >>

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v7]

2023-03-01 Thread Paul Sandoz
On Wed, 1 Mar 2023 14:28:55 GMT, Eirik Bjorsnos wrote: >> This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set >> of benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark >> serves as an example of how vectorization can be useful also in the area of >>

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v8]

2023-03-01 Thread Eirik Bjorsnos
> This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set of > benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark serves > as an example of how vectorization can be useful also in the area of text > processing. It takes advantage of the fact that ASCII and

Re: RFR: 8303198: System and Runtime.exit() resilience to logging errors [v2]

2023-03-01 Thread Chris Hegarty
On Tue, 28 Feb 2023 14:09:50 GMT, Alan Bateman wrote: >> But does that logging include the thread identity? If multiple threads can >> race to exit and all log, then the developer/user needs to know which >> logging came from which thread. > >> But does that logging include the thread

Re: RFR: 8303198: System and Runtime.exit() resilience to logging errors [v2]

2023-03-01 Thread Roger Riggs
> Consolidate logging and handle exceptions by printing to standard error and > ignoring the exception. > Exceptions while logging will not interfere with Runtime.exit. Roger Riggs has updated the pull request incrementally with one additional commit since the last revision: Add exit status

Re: RFR: 8303405: fix @returnss typo in ReflectionFactory

2023-03-01 Thread Naoto Sato
On Wed, 1 Mar 2023 00:24:31 GMT, Justin Lu wrote: > The following typo: `@returnss` was reported on line _482 of Reflection > Factory.java_. > > In addition to fixing that, I have replaced multiple instances of `@returns` > with `@return` in the same file. Marked as reviewed by naoto

Re: RFR: 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) [v3]

2023-03-01 Thread Raffaello Giulietti
On Tue, 28 Feb 2023 13:31:56 GMT, Raffaello Giulietti wrote: >> Add an `indexOf()` variant allowing to specify both a lower and an upper >> bound on the search. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > >

Re: RFR: 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) [v4]

2023-03-01 Thread Raffaello Giulietti
> Add an `indexOf()` variant allowing to specify both a lower and an upper > bound on the search. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) -

Re: RFR: JDK-8302027: Port fdlibm trig functions (sin, cos, tan) to Java

2023-03-01 Thread Raffaello Giulietti
On Wed, 1 Mar 2023 05:28:34 GMT, Joe Darcy wrote: > Last and certainly not least in the port of FDLIBM to Java, the > transcendental methods for sin, cos, and tan. > > Some more tests are to be written in the StrictMath directory to verify that > the StrictMath algorihtm for sin/cos/tan is

Re: RFR: JDK-8302027: Port fdlibm trig functions (sin, cos, tan) to Java

2023-03-01 Thread Raffaello Giulietti
On Wed, 1 Mar 2023 14:27:09 GMT, Andrey Turbanov wrote: >> Last and certainly not least in the port of FDLIBM to Java, the >> transcendental methods for sin, cos, and tan. >> >> Some more tests are to be written in the StrictMath directory to verify that >> the StrictMath algorihtm for

Re: RFR: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test [v6]

2023-03-01 Thread Matthew Donovan
> Removed SSLSocketParametersTest.sh script (which just called a Java file) and > configured the java code to run directly with jtreg Matthew Donovan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in

Re: RFR: 8303198: System and Runtime.exit() resilience to logging errors

2023-03-01 Thread Jaikiran Pai
On Wed, 1 Mar 2023 15:13:06 GMT, Roger Riggs wrote: >> src/java.base/share/classes/java/lang/Shutdown.java line 186: >> >>> 184: try { >>> 185: // Exceptions from the Logger are printed but do not >>> prevent exit >>> 186:

Re: RFR: 8303198: System and Runtime.exit() resilience to logging errors

2023-03-01 Thread Roger Riggs
On Wed, 1 Mar 2023 11:03:39 GMT, Jaikiran Pai wrote: >> Consolidate logging and handle exceptions by printing to standard error and >> ignoring the exception. >> Exceptions while logging will not interfere with Runtime.exit. > > src/java.base/share/classes/java/lang/Shutdown.java line 186: >

Re: RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message [v4]

2023-03-01 Thread Alan Bateman
On Wed, 1 Mar 2023 10:10:12 GMT, Ravali Yatham wrote: >> Added specific class loader object to proxy IllegalArgumentException from >> which the class was not visible >> >> The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 > > Ravali Yatham has updated the pull request

Re: UUID creation performance

2023-03-01 Thread Roger Riggs
Hi, That's an interesting idea.  Recently VarHandle access methods were created by JDK-8300236 [1] [2] in the jdk.internal.util package. See the ByteArray and ByteArrayLittleEndian classes. See how that would affect performance and leverage existing VarHandles. Thanks, Roger [1]

Re: RFR: 8294982: Implementation of Classfile API [v31]

2023-03-01 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one.

Re: RFR: JDK-8302027: Port fdlibm trig functions (sin, cos, tan) to Java

2023-03-01 Thread Andrey Turbanov
On Wed, 1 Mar 2023 05:28:34 GMT, Joe Darcy wrote: > Last and certainly not least in the port of FDLIBM to Java, the > transcendental methods for sin, cos, and tan. > > Some more tests are to be written in the StrictMath directory to verify that > the StrictMath algorihtm for sin/cos/tan is

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v7]

2023-03-01 Thread Eirik Bjorsnos
> This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set of > benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark serves > as an example of how vectorization can be useful also in the area of text > processing. It takes advantage of the fact that ASCII and

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v6]

2023-03-01 Thread Eirik Bjorsnos
On Wed, 1 Mar 2023 09:10:47 GMT, Eirik Bjorsnos wrote: >> This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set >> of benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark >> serves as an example of how vectorization can be useful also in the area of >>

Re: RFR: 8301492: Modernize equals() method of ResourceBundle.CacheKey and Bundles.CacheKey [v3]

2023-03-01 Thread Sergey Tsypanov
On Wed, 1 Feb 2023 10:36:12 GMT, Sergey Tsypanov wrote: >> `ResourceBundle.CacheKey.equals()` and `Bundles.CacheKey.equals()` are quire >> outdated. This simple clean-up modernizes them. > > Sergey Tsypanov has updated the pull request incrementally with one > additional commit since the last

Re: RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v3]

2023-03-01 Thread Martin Doerr
On Tue, 28 Feb 2023 20:51:50 GMT, Jorn Vernee wrote: >> Martin Doerr has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove size restriction for structs. Add TODO for Big Endian. > >

Re: RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v3]

2023-03-01 Thread Jorn Vernee
On Wed, 1 Mar 2023 06:37:45 GMT, Martin Doerr wrote: > There will surely be more when looking into Big Endian support after merging > with your recent work on > https://github.com/openjdk/panama-foreign/compare/foreign-memaccess+abi...JornVernee:panama-foreign:OOB I will try to move this into

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v5]

2023-03-01 Thread Jim Laskey
> Add the ability to repeatedly append char and CharSequence data to > StringBuilder/StringBuffer. Jim Laskey has updated the pull request incrementally with two additional commits since the last revision: - Move @since in subclasses - Move @since - Changes: - all:

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v4]

2023-03-01 Thread Jim Laskey
On Tue, 28 Feb 2023 22:08:34 GMT, Roger Riggs wrote: >> Jim Laskey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Remove @throws IndexOutOfBoundsException >> - Change error report to use "is negative" > >

UUID creation performance

2023-03-01 Thread Brett Okken
Is there any interest in updating the static UUID.randomUUID() and UUID.nameUUIDFromBytes(byte[]) factory methods to use either a ByteBuffer or byteArrayViewVarHandle to convert the byte[] to 2 long values then do the bit twiddling? These methods are really dominated by time to create/populate the

Re: RFR: 8303405: fix @returnss typo in ReflectionFactory

2023-03-01 Thread Lance Andersen
On Wed, 1 Mar 2023 00:24:31 GMT, Justin Lu wrote: > The following typo: `@returnss` was reported on line _482 of Reflection > Factory.java_. > > In addition to fixing that, I have replaced multiple instances of `@returns` > with `@return` in the same file. Marked as reviewed by lancea

Re: RFR: 8303198: System and Runtime.exit() resilience to logging errors

2023-03-01 Thread Jaikiran Pai
On Mon, 27 Feb 2023 15:41:01 GMT, Roger Riggs wrote: > Consolidate logging and handle exceptions by printing to standard error and > ignoring the exception. > Exceptions while logging will not interfere with Runtime.exit. src/java.base/share/classes/java/lang/Shutdown.java line 186: > 184:

Re: RFR: 8302204: Optimize BigDecimal.divide

2023-03-01 Thread Raffaello Giulietti
On Wed, 1 Mar 2023 06:40:01 GMT, Xiaowei Lu wrote: >>> > After making sure that `intVal` is even, and before attempting a division >>> > by a power of 10, it might help to check if 5 divides `intVal` in the >>> > first place. If it doesn't, there no point in performing the division. >>> > It

Re: 8281301: Map.of() calls with null argument should throw more contextual information.

2023-03-01 Thread Kasper Nielsen
I've been in situations as well where a bit more context would have been very useful for some collection NPEs. While lambdas are overkill. I do think there are some more low-level solutions. requireNonNull(k0) can be replaced with with requireNonNull(k0, "key is null"); For the indexed versions

Re: RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message [v4]

2023-03-01 Thread Ravali Yatham
> Added specific class loader object to proxy IllegalArgumentException from > which the class was not visible > > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 Ravali Yatham has updated the pull request incrementally with one additional commit since the last

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-03-01 Thread Adam Sotona
On Thu, 16 Feb 2023 14:19:12 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > >

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-03-01 Thread Adam Sotona
On Thu, 16 Feb 2023 14:58:21 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > >

  1   2   >