Withdrawn: 8302267: [jittester] Improve separation of test generation and execution

2023-04-22 Thread duke
On Mon, 13 Feb 2023 09:55:52 GMT, Evgeny Nikitin wrote: > Please review a set of improvements that should improve working with other > fuzzing generators and usage of JitTesterDriver with tests generated not by > the JITTester: > > - Provide better separation of individual test generation

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v3]

2023-04-22 Thread Laurent Bourgès
On Sat, 22 Apr 2023 16:08:49 GMT, Laurent Bourgès wrote: >> * Optimized mixed insertion sort >> * Optimized insertion sort >> * Optimized Radix sort >> * Updated microbenchmark >> >> I am going on previous PR by Vladimir Yaroslavskyi: >> https://github.com/openjdk/jdk/pull/3938 > >

Re: RFR: 8306697: Add method to obtain String for CONSTANT_Class_info in ClassDesc [v2]

2023-04-22 Thread Chen Liang
> Add a method `internalName` (name subject to discussion) to `ClassDesc`, > which allows easily obtaining a String for representation of a class constant > in CONSTANT_Class_info. > > The motivation of this API is that avoiding frequent String creations via > caching (enabled by this new API,

RFR: 8306698: Add overloads to MethodTypeDesc::of

2023-04-22 Thread Chen Liang
Please review this patch adding two new convenience methods that allows easier access to MethodTypeDesc instances and its associated CSR as well. This is a necessity to allow #13186 to reduce array copies in a few scenarios; the implementation of the two methods will be updated there.

Re: RFR: 8306697: Add method to obtain String for CONSTANT_Class_info in ClassDesc

2023-04-22 Thread Chen Liang
On Sat, 22 Apr 2023 15:12:48 GMT, Chen Liang wrote: > Add a method `internalName` (name subject to discussion) to `ClassDesc`, > which allows easily obtaining a String for representation of a class constant > in CONSTANT_Class_info. > > The motivation of this API is that avoiding frequent

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v3]

2023-04-22 Thread Laurent Bourgès
> * Optimized mixed insertion sort > * Optimized insertion sort > * Optimized Radix sort > * Updated microbenchmark > > I am going on previous PR by Vladimir Yaroslavskyi: > https://github.com/openjdk/jdk/pull/3938 Laurent Bourgès has updated the pull request incrementally with one

RFR: 8306697: Add method to obtain String for CONSTANT_Class_info in ClassDesc

2023-04-22 Thread Chen Liang
Add a method `internalName` (name subject to discussion) to `ClassDesc`, which allows easily obtaining a String for representation of a class constant in CONSTANT_Class_info. The motivation of this API is that avoiding frequent String creations via caching (enabled by this new API, will be in

Re: RFR: JDK-8304036: Use CommandLine class from shared module [v5]

2023-04-22 Thread Christian Stein
> This pull request addresses the open ends left by > [JDK-8236919](https://bugs.openjdk.org/browse/JDK-8236919): > - #11272 > > Changes: > - [x] Extend list of targeted exports of `jdk.internal.opt/jdk.internal.opt` > to `jdk.compiler` and `jdk.javadoc` > - [x] Use shared `CommandLine.java` in

Re: RFR: 8304917: Remove unused function declarations in check_classname.h

2023-04-22 Thread Thiago Henrique Hüpner
On Fri, 17 Mar 2023 14:17:00 GMT, Thiago Henrique Hüpner wrote: > Both functions "VerifyClassname" and "VerifyFixClassname" are not used. The > functions that are used in the Class.c are "verifyClassname" and > "verifyFixClassname", which are declared in the "check_classname.h" header Could

Re: RFR: JDK-8304036: Use CommandLine class from shared module [v4]

2023-04-22 Thread Christian Stein
> This pull request addresses the open ends left by > [JDK-8236919](https://bugs.openjdk.org/browse/JDK-8236919): > - #11272 > > Changes: > - [x] Extend list of targeted exports of `jdk.internal.opt/jdk.internal.opt` > to `jdk.compiler` and `jdk.javadoc` > - [x] Use shared `CommandLine.java` in

Re: RFR: JDK-8304036: Use CommandLine class from shared module [v3]

2023-04-22 Thread Christian Stein
> This pull request addresses the open ends left by > [JDK-8236919](https://bugs.openjdk.org/browse/JDK-8236919): > - #11272 > > Changes: > - [x] Extend list of targeted exports of `jdk.internal.opt/jdk.internal.opt` > to `jdk.compiler` and `jdk.javadoc` > - [x] Use shared `CommandLine.java` in

Re: RFR: JDK-8304036: Use CommandLine class from shared module [v2]

2023-04-22 Thread Christian Stein
On Fri, 21 Apr 2023 21:42:58 GMT, Mandy Chung wrote: >> Christian Stein has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >>

Re: Discussion: Prefer passing MethodHandles.Lookup over @CallerSensitive

2023-04-22 Thread Alan Bateman
On 21/04/2023 22:37, mandy.ch...@oracle.com wrote: : On 4/21/23 1:58 PM, Johannes Kuhn wrote: This line works with Java 7 - 16:     MethodHandles.publicLookup().findStatic(System.class, "setSecurityManager", MethodType.methodType(void.class, SecurityManager.class)); In Java 17

Re: RFR: 8266571: Sequenced Collections [v10]

2023-04-22 Thread ExE Boss
On Fri, 21 Apr 2023 22:33:13 GMT, Stuart Marks wrote: >> PR for Sequenced Collections implementation. > > Stuart Marks has updated the pull request incrementally with two additional > commits since the last revision: > > - Wording tweaks to SequencedMap / NavigableMap. > - Change "The

Re: RFR: 8266571: Sequenced Collections [v2]

2023-04-22 Thread ExE Boss
On Wed, 19 Apr 2023 02:43:53 GMT, Stuart Marks wrote: >> src/java.base/share/classes/java/util/LinkedHashSet.java line 297: >> >>> 295: */ >>> 296: public SequencedSet reversed() { >>> 297: class ReverseLinkedHashSetView extends AbstractSet >>> implements SequencedSet { >> >>

Re: RFR: 8306678: Replace use of os.version with an internal Version record

2023-04-22 Thread ExE Boss
On Fri, 21 Apr 2023 16:44:13 GMT, Roger Riggs wrote: > Create an internal Version record to hold and compare versions of the form > (major, minor, micro). > Add `OperatingSystem.version()` to return the version of the running OS. > Replace uses of os.version in java.base. > Subsequent PRs will

Re: RFR: 8305092: Improve Thread.sleep(millis, nanos) for sub-millisecond granularity [v10]

2023-04-22 Thread Alan Bateman
On Fri, 21 Apr 2023 13:21:09 GMT, Aleksey Shipilev wrote: >> Java API has the `Thread.sleep(millis, nanos)` method exposed to users. The >> documentation for that method clearly says the precision and accuracy are >> dependent on the underlying system behavior. However, it always rounds up >>

Re: RFR: 8266571: Sequenced Collections [v8]

2023-04-22 Thread Nir Lisker
On Fri, 21 Apr 2023 22:14:58 GMT, Stuart Marks wrote: >> src/java.base/share/classes/java/util/SequencedMap.java line 152: >> >>> 150: var it = entrySet().iterator(); >>> 151: return it.hasNext() ? Map.Entry.copyOf(it.next()) : null; >>> 152: } >> >> Would is be better to