Re: Remove unnecessary method call in PriorityBlockingQueue

2023-05-24 Thread David Holmes
Hi Roger, On 25/05/2023 4:57 am, Roger Riggs wrote: Hi, The upstream source of PriorityBlockingQueue is the concurrency library maintained by Doug Lea. Noting this suggestion to the Concurrency Interest mailing list is recommended. [1] Unfortunately Doug's mailing list has never returned

Re: RFR: 8308475: Make the thread dump files generated by jcmd Thread.dump_to_file jtreg failure handler action easily accessible

2023-05-24 Thread Jaikiran Pai
On Sun, 21 May 2023 09:19:47 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to improve the > accessibility of the thread dump files that are generated by the `jcmd > Thread.dump_to_file` command configured in the failure handler > configurations? This

Re: [External] : Re: Classes used in method body are loaded lazily or eagerly depending on method return type

2023-05-24 Thread David Holmes
On 25/05/2023 12:34 am, Raffaello Giulietti wrote: As mentioned in my previous email, if you move the member class ChildClass out of TestLoading (out of the nest), and make it a top-level class like     public class ChildClass extends TestLoading.BaseClass {     } and change     URL

Re: RFR: 8308780: Fix the Java Integer types on Windows

2023-05-24 Thread David Holmes
On Wed, 24 May 2023 13:56:05 GMT, Julian Waters wrote: > On Windows, the basic Java Integer types are defined as long and __int64 > respectively. In particular, the former is rather problematic since it breaks > compilation as the Visual C++ becomes stricter and more compliant with every >

Re: RFR: 8308475: Make the thread dump files generated by jcmd Thread.dump_to_file jtreg failure handler action easily accessible

2023-05-24 Thread Leonid Mesnik
On Sun, 21 May 2023 09:19:47 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to improve the > accessibility of the thread dump files that are generated by the `jcmd > Thread.dump_to_file` command configured in the failure handler > configurations? This

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v4]

2023-05-24 Thread Jiangli Zhou
On Wed, 24 May 2023 21:47:49 GMT, Jiangli Zhou wrote: > > > My build job is still running, but it has failed in two distinct ways > > > already. See below for mac fix. Our cross build of arm32 fails with this > > > message: > > > ``` > > > [2023-05-24T19:25:15,310Z] > > >

Re: RFR: 8308735: Typos in parameter names

2023-05-24 Thread Brian Burkhalter
On Wed, 24 May 2023 23:32:18 GMT, Pavel Rappo wrote: > Please review this simple fix. +1 - Marked as reviewed by bpb (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14136#pullrequestreview-1442923610

Re: RFR: 8308735: Typos in parameter names

2023-05-24 Thread Iris Clark
On Wed, 24 May 2023 23:32:18 GMT, Pavel Rappo wrote: > Please review this simple fix. Looks good. (I'm not sure I'd characterize this as a "typo", more like a failure to adjust "cut and paste" replication. Regardless you're fixing an error.) - Marked as reviewed by iris

Re: RFR: 8308735: Typos in parameter names

2023-05-24 Thread Naoto Sato
On Wed, 24 May 2023 23:32:18 GMT, Pavel Rappo wrote: > Please review this simple fix. LGTM - Marked as reviewed by naoto (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14136#pullrequestreview-1442893076

RFR: 8308735: Typos in parameter names

2023-05-24 Thread Pavel Rappo
Please review this simple fix. - Commit messages: - Fix typos Changes: https://git.openjdk.org/jdk/pull/14136/files Webrev: https://webrevs.openjdk.org/?repo=jdk=14136=00 Issue: https://bugs.openjdk.org/browse/JDK-8308735 Stats: 9 lines in 3 files changed: 0 ins; 0 del; 9 mod

Re: RFR: 8174722: Wrong behavior of DecimalFormat with RoundingMode.UP in special case

2023-05-24 Thread Naoto Sato
On Wed, 24 May 2023 18:47:45 GMT, Joe Darcy wrote: >>> I just wonder if it is ok to reverse the rounding/truncation only in this >>> special case. If the truncation always comes first, then 0.00 would be >>> correct (then 1.01 may be something wrong). Looks to me that the original >>> comment

Re: RFR: 8308452: Extend internal Architecture enum with byte order and address size

2023-05-24 Thread Martin Doerr
On Fri, 19 May 2023 19:19:40 GMT, Roger Riggs wrote: > The internal enum jdk.internal.util.Architecture does not provide information > about the big or little endianness or the address size (64 or 32 bits). The > endian-ness and address size are intrinsic to the architecture. > > The values

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v4]

2023-05-24 Thread Jiangli Zhou
On Wed, 24 May 2023 20:52:38 GMT, Erik Joelsson wrote: > > My build job is still running, but it has failed in two distinct ways > > already. See below for mac fix. Our cross build of arm32 fails with this > > message: > > ``` > > [2023-05-24T19:25:15,310Z] > >

Re: RFR: 8308293: A linker should expose the layouts it supports [v5]

2023-05-24 Thread ExE Boss
On Wed, 24 May 2023 09:22:08 GMT, Maurizio Cimadamore wrote: >> This patch adds an instance method on `Linker`, namely >> `Linker::canonicalLayouts` which returns all the layouts known by the linker >> as implementing some ABI type. For instance, if I call this on my machine >> (Linux/x64) I

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v5]

2023-05-24 Thread Jiangli Zhou
> Original description for JDK-8307194 change: > - > This PR is branched from the makefile changes for > https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for > handling the JDK/hotspot static libraries: > > - Build hotspot libjvm.a and JDK static libraries for >

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v4]

2023-05-24 Thread Jiangli Zhou
On Wed, 24 May 2023 20:52:38 GMT, Erik Joelsson wrote: >> My build job is still running, but it has failed in two distinct ways >> already. See below for mac fix. Our cross build of arm32 fails with this >> message: >> >> >> [2023-05-24T19:25:15,310Z] >>

Re: RFR: 8300038: Make new version of JNU_GetStringPlatformChars which checks for null characters [v3]

2023-05-24 Thread Michael McMahon
On Wed, 24 May 2023 14:30:01 GMT, Alan Bateman wrote: > I skimmed through the changes and mostly look okay. There's a few usage of > "NULL" in exception messages that I assume should be "NUL character". > Probably need to bump the copyright date on several files. You might want to > find a

Re: RFR: 8300038: Make new version of JNU_GetStringPlatformChars which checks for null characters [v4]

2023-05-24 Thread Michael McMahon
> This PR creates a new version of the JNI utility function > JNU_GetStringPlatformChars called JNU_GetStringPlatformCharsStrict, which > performs additional validation of the returned string, namely that it does > not contain any embedded NULL characters. If any such characters are found >

Re: RFR: 8174722: Wrong behavior of DecimalFormat with RoundingMode.UP in special case [v2]

2023-05-24 Thread Justin Lu
> Please review this PR, which addresses a case where Decimal Format would > violate certain RoundingMode contracts given the right pattern and double. > > For example, > > > DecimalFormat df = new DecimalFormat(); > df.setRoundingMode(RoundingMode.UP); > double small = 0.0001; > double big =

Re: RFR: 8300491: SymbolLookup::libraryLookup accepts strings with terminators [v2]

2023-05-24 Thread Paul Sandoz
On Wed, 24 May 2023 17:09:23 GMT, Maurizio Cimadamore wrote: >> There is a difference in behavior between `System::loadLibrary` and >> `SymbolLookup::libraryLookup(String)`. While the former catches library >> names containing NULL chars (because, internally it uses Path/File logic, >> which

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v4]

2023-05-24 Thread Erik Joelsson
On Mon, 22 May 2023 21:27:58 GMT, Jiangli Zhou wrote: >> Original description for JDK-8307194 change: >> - >> This PR is branched from the makefile changes for >> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for >> handling the JDK/hotspot static libraries: >> >>

RFR: 8308803: Improve java/util/UUID/UUIDTest.java

2023-05-24 Thread Aleksey Shipilev
UUID is very important class that is used to track identities of objects in large scale systems. Yet, the coverage in JDK test is disappointing: it tests only 100 of UUID instances per test, which is way too small to detect collisions due to the bad randomness for example. I have some pending

Re: RFR: 8308022: update for deprecated sprintf for java.base [v2]

2023-05-24 Thread Xue-Lei Andrew Fan
On Mon, 15 May 2023 17:21:14 GMT, Daniel Fuchs wrote: > The libnet changes look reasonable to me. @dfuch Thank you for the review. This patch may be still too big as a few components were involved. To easy to review process, I opened a new PR for libnet update, and will reverse the libnet

Re: RFR: 8308022: update for deprecated sprintf for java.base [v2]

2023-05-24 Thread Xue-Lei Andrew Fan
> Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because > of security concerns. The issue was addressed in > [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for building > failure, and >

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v4]

2023-05-24 Thread Erik Joelsson
On Fri, 19 May 2023 21:20:19 GMT, Erik Joelsson wrote: >> Jiangli Zhou has updated the pull request incrementally with one additional >> commit since the last revision: >> >> - Add $$($1_LD) $$($1_SYSROOT_LDFLAGS) to $1_VARDEPS if $(TOOLCHAIN_TYPE) >> is gcc or clang, as suggested by

Integrated: JDK-8308040 Evaluate new public types in non-public classes

2023-05-24 Thread Jim Laskey
On Wed, 17 May 2023 19:14:20 GMT, Jim Laskey wrote: > As reported by Marc Hoffman of javaalmanac.io, in a recent JDK 21 build there > are new public types nested in non-public interfaces: > > java.lang.runtime.ReferenceKey.SoftKey > java.lang.runtime.ReferenceKey.StrongKey >

Re: RFR: JDK-8308040 Evaluate new public types in non-public classes

2023-05-24 Thread Roger Riggs
On Wed, 17 May 2023 19:14:20 GMT, Jim Laskey wrote: > As reported by Marc Hoffman of javaalmanac.io, in a recent JDK 21 build there > are new public types nested in non-public interfaces: > > java.lang.runtime.ReferenceKey.SoftKey > java.lang.runtime.ReferenceKey.StrongKey >

Re: RFR: JDK-8308040 Evaluate new public types in non-public classes

2023-05-24 Thread Joe Darcy
On Wed, 17 May 2023 19:14:20 GMT, Jim Laskey wrote: > As reported by Marc Hoffman of javaalmanac.io, in a recent JDK 21 build there > are new public types nested in non-public interfaces: > > java.lang.runtime.ReferenceKey.SoftKey > java.lang.runtime.ReferenceKey.StrongKey >

RFR: JDK-8308040 Evaluate new public types in non-public classes

2023-05-24 Thread Jim Laskey
As reported by Marc Hoffman of javaalmanac.io, in a recent JDK 21 build there are new public types nested in non-public interfaces: java.lang.runtime.ReferenceKey.SoftKey java.lang.runtime.ReferenceKey.StrongKey java.lang.runtime.ReferenceKey.WeakKey java.util.Digits.DecimalDigits

Re: Remove unnecessary method call in PriorityBlockingQueue

2023-05-24 Thread Viktor Klang
Sounds very reasonable. From: core-libs-dev on behalf of Aleksei Ivanov Sent: Wednesday, 24 May 2023 20:03 To: Robin Gong ; core-libs Subject: Re: Remove unnecessary method call in PriorityBlockingQueue Hi Robin, This belongs in core-libs. On 24/05/2023

Re: RFR: 8174722: Wrong behavior of DecimalFormat with RoundingMode.UP in special case

2023-05-24 Thread Joe Darcy
On Wed, 24 May 2023 18:36:39 GMT, Justin Lu wrote: > > I just wonder if it is ok to reverse the rounding/truncation only in this > > special case. If the truncation always comes first, then 0.00 would be > > correct (then 1.01 may be something wrong). Looks to me that the original > > comment

Re: RFR: 8174722: Wrong behavior of DecimalFormat with RoundingMode.UP in special case

2023-05-24 Thread Justin Lu
On Wed, 24 May 2023 17:36:50 GMT, Naoto Sato wrote: > I just wonder if it is ok to reverse the rounding/truncation only in this > special case. If the truncation always comes first, then 0.00 would be > correct (then 1.01 may be something wrong). Looks to me that the original > comment

Re: RFR: 8307990: jspawnhelper must close its writing side of a pipe before reading from it

2023-05-24 Thread Thomas Stuefe
On Wed, 24 May 2023 14:30:10 GMT, Volker Simonis wrote: >>> > Sorry, but I don't understand this argument. If we do a short read we >>> > will work with corrupted ChildStuff and SpawnInfo >>> > structures. This can in the extreme case execute arbitrary code (e.g. if >>> > ChildStuff.argv is

Re: Remove unnecessary method call in PriorityBlockingQueue

2023-05-24 Thread Aleksei Ivanov
Hi Robin, This belongs in core-libs. On 24/05/2023 16:50, Robin Gong wrote: Hi, Recently, I found this constructor in PriorityBlockingQueue:   public PriorityBlockingQueue(int initialCapacity,                                  Comparator comparator) {         if (initialCapacity <

Re: RFR: 8306647: Implementation of Structured Concurrency (Preview)

2023-05-24 Thread Andrey Turbanov
On Thu, 11 May 2023 13:08:55 GMT, Alan Bateman wrote: > This is the implementation of: > > - JEP 453: Structured Concurrency (Preview) > - JEP 446: Scoped Values (Preview) > > For the most part, this is just moving code and tests. StructuredTaskScope > moves to j.u.concurrent as a preview

Re: RFR: 8174722: Wrong behavior of DecimalFormat with RoundingMode.UP in special case

2023-05-24 Thread Naoto Sato
On Tue, 23 May 2023 23:16:01 GMT, Justin Lu wrote: > Please review this PR, which addresses a case where Decimal Format would > violate certain RoundingMode contracts given the right pattern and double. > > For example, > > > DecimalFormat df = new DecimalFormat(); >

Re: RFR: 8300491: SymbolLookup::libraryLookup accepts strings with terminators [v2]

2023-05-24 Thread Maurizio Cimadamore
> There is a difference in behavior between `System::loadLibrary` and > `SymbolLookup::libraryLookup(String)`. While the former catches library names > containing NULL chars (because, internally it uses Path/File logic, which > reject those), `SymbolLookup` does not. As a result, it is possible

Re: RFR: 8300491: SymbolLookup::libraryLookup accepts strings with terminators

2023-05-24 Thread Maurizio Cimadamore
On Wed, 24 May 2023 16:30:25 GMT, Paul Sandoz wrote: > Do you also need to test on `SymbolLookup` returned from > `Linker::defaultLookup`? Yeah - some test would be better. - PR Comment: https://git.openjdk.org/jdk/pull/14126#issuecomment-1561568364

Re: RFR: 8300491: SymbolLookup::libraryLookup accepts strings with terminators

2023-05-24 Thread Paul Sandoz
On Wed, 24 May 2023 15:22:15 GMT, Maurizio Cimadamore wrote: > There is a difference in behavior between `System::loadLibrary` and > `SymbolLookup::libraryLookup(String)`. While the former catches library names > containing NULL chars (because, internally it uses Path/File logic, which >

Re: RFR: 8308452: Extend internal Architecture enum with byte order and address size

2023-05-24 Thread Alan Bateman
On Fri, 19 May 2023 19:19:40 GMT, Roger Riggs wrote: > The internal enum jdk.internal.util.Architecture does not provide information > about the big or little endianness or the address size (64 or 32 bits). The > endian-ness and address size are intrinsic to the architecture. > > The values

Re: RFR: 8290499: new File(parent, \"/\") breaks normalization – creates File with slash at the end

2023-05-24 Thread Brian Burkhalter
On Wed, 24 May 2023 15:25:37 GMT, Roger Riggs wrote: >> In `java.io.File`, change the constructors `File(File,String)` and >> `File(String,String)` so that they do not for typical cases return a `File` >> whose path has a trailing name separator. > >

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v19]

2023-05-24 Thread Jim Laskey
> Add flexible main methods and anonymous main classes to the Java language. Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Ignore SKIPs (semicolon class declarations) - Changes: - all:

RFR: 8300491: SymbolLookup::libraryLookup accepts strings with terminators

2023-05-24 Thread Maurizio Cimadamore
There is a difference in behavior between `System::loadLibrary` and `SymbolLookup::libraryLookup(String)`. While the former catches library names containing NULL chars (because, internally it uses Path/File logic, which reject those), `SymbolLookup` does not. As a result, it is possible to load

Re: RFR: 8290499: new File(parent, \"/\") breaks normalization – creates File with slash at the end

2023-05-24 Thread Roger Riggs
On Tue, 23 May 2023 22:49:57 GMT, Brian Burkhalter wrote: > In `java.io.File`, change the constructors `File(File,String)` and > `File(String,String)` so that they do not for typical cases return a `File` > whose path has a trailing name separator.

RFR: 8308452: Extend internal Architecture enum with byte order and address size

2023-05-24 Thread Roger Riggs
The internal enum jdk.internal.util.Architecture does not provide information about the big or little endianness or the address size (64 or 32 bits). The endian-ness and address size are intrinsic to the architecture. The values of the enum are extended to separately identify the big endian

Re: RFR: 8308452: Extend internal Architecture enum with byte order and address size

2023-05-24 Thread Martin Doerr
On Fri, 19 May 2023 19:19:40 GMT, Roger Riggs wrote: > The internal enum jdk.internal.util.Architecture does not provide information > about the big or little endianness or the address size (64 or 32 bits). The > endian-ness and address size are intrinsic to the architecture. > > The values

Re: RFR: 8304006: jlink should create the jimage file in the native endian for the target platform [v17]

2023-05-24 Thread Roger Riggs
On Wed, 29 Mar 2023 01:40:36 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change which proposes to fix the issue >> reported in https://bugs.openjdk.org/browse/JDK-8206890? >> >> The `jlink` command allows a `--endian` option to specify the byte order in >> the generated

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v4]

2023-05-24 Thread Jiangli Zhou
On Fri, 19 May 2023 21:20:19 GMT, Erik Joelsson wrote: >> Jiangli Zhou has updated the pull request incrementally with one additional >> commit since the last revision: >> >> - Add $$($1_LD) $$($1_SYSROOT_LDFLAGS) to $1_VARDEPS if $(TOOLCHAIN_TYPE) >> is gcc or clang, as suggested by

Re: [External] : Re: Classes used in method body are loaded lazily or eagerly depending on method return type

2023-05-24 Thread Raffaello Giulietti
As mentioned in my previous email, if you move the member class ChildClass out of TestLoading (out of the nest), and make it a top-level class like public class ChildClass extends TestLoading.BaseClass { } and change URL classFileB =

Re: RFR: 8300038: Make new version of JNU_GetStringPlatformChars which checks for null characters [v3]

2023-05-24 Thread Alan Bateman
On Wed, 24 May 2023 10:14:23 GMT, Michael McMahon wrote: >> This PR creates a new version of the JNI utility function >> JNU_GetStringPlatformChars called JNU_GetStringPlatformCharsStrict, which >> performs additional validation of the returned string, namely that it does >> not contain any

Re: RFR: 8307990: jspawnhelper must close its writing side of a pipe before reading from it

2023-05-24 Thread Volker Simonis
On Fri, 19 May 2023 15:43:30 GMT, Roger Riggs wrote: >>> Sorry, but I don't understand this argument. If we do a short read we will >>> work with corrupted ChildStuff and SpawnInfo >>> structures. This can in the extreme case execute arbitrary code (e.g. if >>> ChildStuff.argv is not fully

Re: RFR: 8307990: jspawnhelper must close its writing side of a pipe before reading from it [v6]

2023-05-24 Thread Volker Simonis
> Since JDK13, executing commands in a sub-process defaults to the so called > `POSIX_SPAWN` launching mechanism (i.e. > `-Djdk.lang.Process.launchMechanism=POSIX_SPAWN`) on Linux. This works by > using `posix_spawn(3)` to firstly start a tiny helper program called > `jspawnhelper` in a

RFR: 8308780: Fix the Java Integer types on Windows

2023-05-24 Thread Julian Waters
On Windows, the basic Java Integer types are defined as long and __int64 respectively. In particular, the former is rather problematic since it breaks compilation as the Visual C++ becomes stricter and more compliant with every release, which means the way Windows code treats long as a typedef

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v18]

2023-05-24 Thread Jim Laskey
> Add flexible main methods and anonymous main classes to the Java language. Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Allow unqualified access to unnamed class (internally visible) - Changes: - all:

Re: RFR: 8308761: New test TestHFA needs adaptation for JDK-8308276

2023-05-24 Thread Maurizio Cimadamore
On Wed, 24 May 2023 13:44:40 GMT, Martin Doerr wrote: >> Do you prefer removing it? > > I think it's not important. I'll just integrate it to get the tests working > again. Yeah, let's integrate - PR Review Comment: https://git.openjdk.org/jdk/pull/14116#discussion_r1204172106

Re: RFR: 8308761: New test TestHFA needs adaptation for JDK-8308276

2023-05-24 Thread Martin Doerr
On Wed, 24 May 2023 12:56:55 GMT, Martin Doerr wrote: >> It's probably not required. It was derived from a jextract generated file. > > Do you prefer removing it? I think it's not important. I'll just integrate it to get the tests working again. - PR Review Comment:

Re: RFR: 8308549: Classfile API should fail to generate over-sized Code attribute [v2]

2023-05-24 Thread Jaikiran Pai
On Wed, 24 May 2023 12:57:59 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/impl/DirectCodeBuilder.java >> line 314: >> >>> 312: >>> 313: int codeLength = curPc(); >>> 314: if (codeLength >= 65536) { >> >> Hello Adam, looking at

Integrated: 8308761: New test TestHFA needs adaptation for JDK-8308276

2023-05-24 Thread Martin Doerr
On Wed, 24 May 2023 09:16:46 GMT, Martin Doerr wrote: > Please review this trivial adaptation for JDK-8308276. This pull request has now been integrated. Changeset: 7764f46e Author:Martin Doerr URL: https://git.openjdk.org/jdk/commit/7764f46e9e3a46e39419ce35aaca8efdb3669872 Stats:

Re: RFR: 8308549: Classfile API should fail to generate over-sized Code attribute [v2]

2023-05-24 Thread Adam Sotona
> Classfile API allowed to generate Code attribute exceeding the 65k limit. No > exception has been thrown during class generation and the class failed > verification later during class loading. > This patch adds Code size limit check throwing IllegalArgumentException. > The patch also adds

Re: RFR: 8308761: New test TestHFA needs adaptation for JDK-8308276

2023-05-24 Thread Matthias Baesken
On Wed, 24 May 2023 09:16:46 GMT, Martin Doerr wrote: > Please review this trivial adaptation for JDK-8308276. Marked as reviewed by mbaesken (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14116#pullrequestreview-1441800497

Re: RFR: 8308549: Classfile API should fail to generate over-sized Code attribute

2023-05-24 Thread Adam Sotona
On Wed, 24 May 2023 12:04:05 GMT, Jaikiran Pai wrote: >> Classfile API allowed to generate Code attribute exceeding the 65k limit. No >> exception has been thrown during class generation and the class failed >> verification later during class loading. >> This patch adds Code size limit check

Re: RFR: 8308761: New test TestHFA needs adaptation for JDK-8308276

2023-05-24 Thread Martin Doerr
On Wed, 24 May 2023 12:48:00 GMT, Martin Doerr wrote: >> test/jdk/java/foreign/TestHFA.java line 53: >> >>> 51: final static SymbolLookup lookup = SymbolLookup.loaderLookup(); >>> 52: >>> 53: static final OfFloat FLOAT = JAVA_FLOAT.withByteAlignment(4); >> >> Is this even required -

Re: RFR: 8308761: New test TestHFA needs adaptation for JDK-8308276

2023-05-24 Thread Martin Doerr
On Wed, 24 May 2023 12:12:25 GMT, Maurizio Cimadamore wrote: >> Please review this trivial adaptation for JDK-8308276. > > test/jdk/java/foreign/TestHFA.java line 53: > >> 51: final static SymbolLookup lookup = SymbolLookup.loaderLookup(); >> 52: >> 53: static final OfFloat FLOAT =

Integrated: JDK-8298066: java/util/concurrent/locks/Lock/OOMEInAQS.java timed out

2023-05-24 Thread Viktor Klang
On Mon, 22 May 2023 13:12:02 GMT, Viktor Klang wrote: > Doubling the max heap size since not all GCs might have compressed OOPs, so > this change should make this test more robust. > > Cleared with @DougLea This pull request has now been integrated. Changeset: 544978cb Author:Viktor

Re: RFR: 8304006: jlink should create the jimage file in the native endian for the target platform [v17]

2023-05-24 Thread Jaikiran Pai
On Wed, 29 Mar 2023 01:40:36 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change which proposes to fix the issue >> reported in https://bugs.openjdk.org/browse/JDK-8206890? >> >> The `jlink` command allows a `--endian` option to specify the byte order in >> the generated

Re: RFR: 8308761: New test TestHFA needs adaptation for JDK-8308276

2023-05-24 Thread Maurizio Cimadamore
On Wed, 24 May 2023 09:16:46 GMT, Martin Doerr wrote: > Please review this trivial adaptation for JDK-8308276. Looks good - I apologize for having missed it. test/jdk/java/foreign/TestHFA.java line 53: > 51: final static SymbolLookup lookup = SymbolLookup.loaderLookup(); > 52: > 53:

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v17]

2023-05-24 Thread Jim Laskey
On Tue, 23 May 2023 20:04:45 GMT, Jim Laskey wrote: >> Add flexible main methods and anonymous main classes to the Java language. > > Jim Laskey has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 33 commits: > > - Fix missing

Re: RFR: 8308549: Classfile API should fail to generate over-sized Code attribute

2023-05-24 Thread Jaikiran Pai
On Tue, 23 May 2023 12:54:20 GMT, Adam Sotona wrote: > Classfile API allowed to generate Code attribute exceeding the 65k limit. No > exception has been thrown during class generation and the class failed > verification later during class loading. > This patch adds Code size limit check

Re: RFR: JDK-8027711: Unify wildcarding syntax for CompileCommand and CompileOnly [v2]

2023-05-24 Thread Tobias Holenstein
On Tue, 23 May 2023 07:55:35 GMT, Christian Hagedorn wrote: >> Tobias Holenstein has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Update Test8211698.java >> - Update src/hotspot/share/compiler/compilerOracle.cpp >> >>

Re: RFR: 8308549: Classfile API should fail to generate over-sized Code attribute

2023-05-24 Thread Adam Sotona
On Tue, 23 May 2023 15:13:04 GMT, Chen Liang wrote: > On a side note, does Classfile API reject methods with too many slots > (locals) (MethodTypeDesc can represent parameter lists with over 255 slots) > or stack (operand)? Classfile API does not perform any extra verifications of

Re: RFR: JDK-8282797: CompileCommand parsing errors should exit VM [v3]

2023-05-24 Thread Tobias Holenstein
On Wed, 24 May 2023 09:30:58 GMT, Tobias Hartmann wrote: >> Tobias Holenstein has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update Scenario.java >> - Update compilerOracle.cpp > >

Re: RFR: JDK-8282797: CompileCommand parsing errors should exit VM [v3]

2023-05-24 Thread Tobias Holenstein
> Currently, errors during compile command parsing just print an error but > don't exit the VM. As a result, issues go unnoticed. > > With this PR the behavior is changed to exit the VM when an error occurs. > > E.g. `java -XX:CompileCommand=compileonly,HashMap:: -version` will exit the > VM

Re: RFR: JDK-8282797: CompileCommand parsing errors should exit VM [v3]

2023-05-24 Thread Tobias Holenstein
On Wed, 24 May 2023 08:20:32 GMT, Christian Hagedorn wrote: >> Tobias Holenstein has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update Scenario.java >> - Update compilerOracle.cpp > > src/hotspot/share/compiler/compilerOracle.cpp

Re: RFR: JDK-8282797: CompileCommand parsing errors should exit VM [v2]

2023-05-24 Thread Tobias Holenstein
On Wed, 24 May 2023 09:29:53 GMT, Tobias Hartmann wrote: >> Tobias Holenstein has updated the pull request incrementally with four >> additional commits since the last revision: >> >> - Update >> test/hotspot/jtreg/compiler/compilercontrol/share/scenario/Scenario.java >> >>

Re: RFR: JDK-8282797: CompileCommand parsing errors should exit VM [v2]

2023-05-24 Thread Tobias Holenstein
> Currently, errors during compile command parsing just print an error but > don't exit the VM. As a result, issues go unnoticed. > > With this PR the behavior is changed to exit the VM when an error occurs. > > E.g. `java -XX:CompileCommand=compileonly,HashMap:: -version` will exit the > VM

Re: RFR: JDK-8282797: CompileCommand parsing errors should exit VM [v2]

2023-05-24 Thread Tobias Holenstein
On Wed, 24 May 2023 09:29:10 GMT, Christian Hagedorn wrote: >> Tobias Holenstein has updated the pull request incrementally with four >> additional commits since the last revision: >> >> - Update >> test/hotspot/jtreg/compiler/compilercontrol/share/scenario/Scenario.java >> >>

Re: RFR: 8300038: Make new version of JNU_GetStringPlatformChars which checks for null characters [v3]

2023-05-24 Thread Michael McMahon
> This PR creates a new version of the JNI utility function > JNU_GetStringPlatformChars called JNU_GetStringPlatformCharsStrict, which > performs additional validation of the returned string, namely that it does > not contain any embedded NULL characters. If any such characters are found >

Re: RFR: 8308293: A linker should expose the layouts it supports [v6]

2023-05-24 Thread Maurizio Cimadamore
> This patch adds an instance method on `Linker`, namely > `Linker::canonicalLayouts` which returns all the layouts known by the linker > as implementing some ABI type. For instance, if I call this on my machine > (Linux/x64) I get this: > > > jshell> import java.lang.foreign.*; > > jshell>

Re: RFR: JDK-8282797: CompileCommand parsing errors should exit VM

2023-05-24 Thread Tobias Hartmann
On Tue, 2 May 2023 11:35:54 GMT, Tobias Holenstein wrote: > Currently, errors during compile command parsing just print an error but > don't exit the VM. As a result, issues go unnoticed. > > With this PR the behavior is changed to exit the VM when an error occurs. > > E.g. `java

Re: RFR: JDK-8282797: CompileCommand parsing errors should exit VM

2023-05-24 Thread Christian Hagedorn
On Tue, 2 May 2023 11:35:54 GMT, Tobias Holenstein wrote: > Currently, errors during compile command parsing just print an error but > don't exit the VM. As a result, issues go unnoticed. > > With this PR the behavior is changed to exit the VM when an error occurs. > > E.g. `java

Re: RFR: 8308293: A linker should expose the layouts it supports [v4]

2023-05-24 Thread Maurizio Cimadamore
On Mon, 22 May 2023 09:34:53 GMT, Maurizio Cimadamore wrote: >> This patch adds an instance method on `Linker`, namely >> `Linker::canonicalLayouts` which returns all the layouts known by the linker >> as implementing some ABI type. For instance, if I call this on my machine >> (Linux/x64) I

RFR: 8308761: New test TestHFA needs adaptation for JDK-8308276

2023-05-24 Thread Martin Doerr
Please review this trivial adaptation for JDK-8308276. - Commit messages: - 8308761: New test TestHFA needs adaptation for JDK-8308276 Changes: https://git.openjdk.org/jdk/pull/14116/files Webrev: https://webrevs.openjdk.org/?repo=jdk=14116=00 Issue:

Re: RFR: 8308293: A linker should expose the layouts it supports [v5]

2023-05-24 Thread Maurizio Cimadamore
> This patch adds an instance method on `Linker`, namely > `Linker::canonicalLayouts` which returns all the layouts known by the linker > as implementing some ABI type. For instance, if I call this on my machine > (Linux/x64) I get this: > > > jshell> import java.lang.foreign.*; > > jshell>

Integrated: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview)

2023-05-24 Thread Martin Doerr
On Wed, 22 Feb 2023 05:31:46 GMT, Martin Doerr wrote: > Implementation of "Foreign Function & Memory API" for linux on Power (Little > Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification". > > This PR does not include code for VaList support because it's supposed to get >

Re: RFR: JDK-8298066: java/util/concurrent/locks/Lock/OOMEInAQS.java timed out [v3]

2023-05-24 Thread Viktor Klang
On Wed, 24 May 2023 06:07:54 GMT, Alan Bateman wrote: >> Viktor Klang has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains two commits: >> >> - Removing OOMEInAQS from zgc problem list >> - JDK-8298066: Increasing max heap size for

Re: RFR: JDK-8298066: java/util/concurrent/locks/Lock/OOMEInAQS.java timed out [v4]

2023-05-24 Thread Viktor Klang
> Doubling the max heap size since not all GCs might have compressed OOPs, so > this change should make this test more robust. > > Cleared with @DougLea Viktor Klang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v17]

2023-05-24 Thread Naoki Kishida
On Tue, 23 May 2023 20:04:45 GMT, Jim Laskey wrote: >> Add flexible main methods and anonymous main classes to the Java language. > > Jim Laskey has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 33 commits: > > - Fix missing

Re: RFR: 8308108: Support Unicode extension for collation settings [v5]

2023-05-24 Thread Alan Bateman
On Mon, 22 May 2023 17:59:18 GMT, Naoto Sato wrote: >> This change intends to interpret the BCP47 U extension wrt collation >> settings in the given `Locale`, then applies them to the created instances >> in the 1-arg factory method in `Collator`. A corresponding CSR has also been >> drafted.

Re: RFR: 8308475: Make the thread dump files generated by jcmd Thread.dump_to_file jtreg failure handler action easily accessible

2023-05-24 Thread Alan Bateman
On Sun, 21 May 2023 09:19:47 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to improve the > accessibility of the thread dump files that are generated by the `jcmd > Thread.dump_to_file` command configured in the failure handler > configurations? This

Re: RFR: JDK-8298066: java/util/concurrent/locks/Lock/OOMEInAQS.java timed out [v3]

2023-05-24 Thread Alan Bateman
On Tue, 23 May 2023 09:02:27 GMT, Viktor Klang wrote: >> Doubling the max heap size since not all GCs might have compressed OOPs, so >> this change should make this test more robust. >> >> Cleared with @DougLea > > Viktor Klang has updated the pull request with a new target base due to a >