> The access hack for array class clone is only applied to `checkAccess` but
> missing before call to `restrictProtectedReceiver`, causing the array
> receiver type to be incorrectly replaced by the lookupClass type. This patch
> fixes that and adds a test to ensure an original lookup resolves
On Wed, 31 May 2023 03:43:25 GMT, Chen Liang wrote:
>> test/jdk/java/lang/invoke/findVirtual/FindVirtualArrayCloneTest.java line 70:
>>
>>> 68: var cloneMh = MethodHandles.lookup()
>>> 69: .findVirtual(String[].class, "clone",
>>> MethodType.methodType(Object.class));
On Tue, 30 May 2023 22:20:23 GMT, David Holmes wrote:
> What testing was done on this fix before integration? I don't even see Git
> Hub Actions being run.
@dholmes-ora
I did see earlier that Github Action ran (In the 'Checks' tab) and finished,
and I believed the Windows failure is not
On Wed, 31 May 2023 01:40:22 GMT, Chen Liang wrote:
>> The access hack for array class clone is only applied to `checkAccess` but
>> missing before call to `restrictProtectedReceiver`, causing the array
>> receiver type to be incorrectly replaced by the lookupClass type. This patch
>> fixes
> The access hack for array class clone is only applied to `checkAccess` but
> missing before call to `restrictProtectedReceiver`, causing the array
> receiver type to be incorrectly replaced by the lookupClass type. This patch
> fixes that and adds a test to ensure an original lookup resolves
On Tue, 30 May 2023 23:39:52 GMT, Mandy Chung wrote:
>> test/jdk/java/lang/invoke/findVirtual/FindVirtualArrayCloneTest.java line 28:
>>
>>> 26: * @bug 8299505
>>> 27: * @run junit FindVirtualArrayCloneTest
>>> 28: * @summary Ensures Arrays' clone doesn't have incorrect receiver type
>>>
On Wed, 31 May 2023 00:27:24 GMT, Chen Liang wrote:
> Apparently, calling utility methods from sun.invoke, like the
> ensureOriginalLookup in this patch, also triggers this check.
It should not trigger `checkPackageAccess` if it does not implement the
interface AFAICT.
It would trigger
On Wed, 31 May 2023 00:48:18 GMT, Mandy Chung wrote:
>>> Is it more straight-forward to keep a `ClassValue` and each
>>> wrapper instance class has an entry of `TRUE` value; otherwise, `FALSE`?
>>
>> Then we still need to obtain the implemented interface and original method
>> handle
On Wed, 31 May 2023 00:01:56 GMT, Mandy Chung wrote:
> Is it more straight-forward to keep a `ClassValue` and each wrapper
> instance class has an entry of `TRUE` value; otherwise, `FALSE`?
Then we still need to obtain the implemented interface and original method
handle information every
On Fri, 26 May 2023 22:18:17 GMT, Chen Liang wrote:
>> If we can avoid implementing `sun.invoke.WrapperInstance`, this package
>> access check issue would go away. Do you think you can look into it?
>
> I think we can probably insert a static final field in a wrapper instance
> class to point
The JDWP spec for StackFrame.SetValue currently states:
"If the thread is a virtual thread then this command can be used to set
"
"the value of local variables in the top-most frame when the thread is "
"suspended at a breakpoint or single step event. The target VM may
On Tue, 30 May 2023 23:38:16 GMT, Mandy Chung wrote:
>> The access hack for array class clone is only applied to `checkAccess` but
>> missing before call to `restrictProtectedReceiver`, causing the array
>> receiver type to be incorrectly replaced by the lookupClass type. This patch
>> fixes
On Sat, 6 May 2023 18:15:56 GMT, Chen Liang wrote:
> The access hack for array class clone is only applied to `checkAccess` but
> missing before call to `restrictProtectedReceiver`, causing the array
> receiver type to be incorrectly replaced by the lookupClass type. This patch
> fixes that
> Time to get JDK 22 underway...
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 24 commits:
- Merge branch 'master' into JDK-8306584
- Merge branch 'master' into JDK-8306584
- Merge branch 'master' into JDK-8306584
-
On Tue, 30 May 2023 20:14:59 GMT, Joe Darcy wrote:
>> Ah, when new non-preview language structures are added. With two new
>> language features in JDK 21, looks like it is time for me to add another
>> one; thanks.
>
> Better to fix this omission in JDK 21; please see
>
On Mon, 29 May 2023 02:20:07 GMT, Chang Peng wrote:
>> In Vector API Java level, vector mask is represented as a boolean array with
>> 0x00/0x01 (8 bits of each element) as values, aka in-memory format. When it
>> is loaded into vector register, e.g. Neon, the in-memory format will be
>>
On Thu, 25 May 2023 20:23:27 GMT, Mandy Chung wrote:
> Change `ClassFileDumper` constructor to take a `String` rather than `Path` to
> avoid the file system implementation classes loaded during startup. In
> addition, `FilePermission` also causes the default file system to be
> initialized.
On Tue, 30 May 2023 18:42:54 GMT, Coleen Phillimore wrote:
>> JoKern65 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> forgotton _
>
> src/hotspot/share/runtime/javaThread.cpp line 115:
>
>> 113: #include
>> 114: #endif
>> 115:
>
>
On Tue, 30 May 2023 18:35:44 GMT, Joe Darcy wrote:
>> Time to get JDK 22 underway...
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 23 commits:
>
> - Merge branch 'master' into JDK-8306584
> - Merge branch
On Tue, 30 May 2023 09:15:13 GMT, Aleksey Shipilev wrote:
>> UUID is very important class that is used to track identities of objects in
>> large scale systems. Yet, the coverage in JDK test is disappointing: it
>> tests only 100 of UUID instances per test, which is way too small to detect
>>
On Tue, 23 May 2023 20:49:43 GMT, Joe Darcy wrote:
>> test/langtools/tools/javac/versions/Versions.java line 93:
>>
>>> 91: TWENTY(false,"64.0", "20", Versions::checksrc20),
>>> 92: TWENTY_ONE(false,"65.0", "21", Versions::checksrc20),
>>> 93:
On Fri, 26 May 2023 08:31:46 GMT, JoKern65 wrote:
>> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
>> on AIX , we run into various "warnings as errors".
>> Some of those are in shared codebase and could be addressed by small
>> adjustments.
>> A lot of those
> Time to get JDK 22 underway...
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 23 commits:
- Merge branch 'master' into JDK-8306584
- Merge branch 'master' into JDK-8306584
- Sync in symbol changes for JDK 21 build 24.
On Thu, 25 May 2023 22:19:18 GMT, Naoto Sato wrote:
>> Amending the description about the default decomposition mode in
>> `Collator.NO_DECOMPOSITION` javadoc.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> use present
On Wed, 24 May 2023 19:20:09 GMT, Xue-Lei Andrew Fan wrote:
>> Hi,
>>
>> May I have this update reviewed?
>>
>> The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because
>> of security concerns. The issue was addressed in
>>
On Tue, 30 May 2023 17:37:24 GMT, Mandy Chung wrote:
>> Change `ClassFileDumper` constructor to take a `String` rather than `Path`
>> to avoid the file system implementation classes loaded during startup. In
>> addition, `FilePermission` also causes the default file system to be
>>
> This is the implementation of:
>
> - JEP 453: Structured Concurrency (Preview)
> - JEP 446: Scoped Values (Preview)
>
> For the most part, this is just moving code and tests. StructuredTaskScope
> moves to j.u.concurrent as a preview API, ScopedValue moves to j.lang as a
> preview API, and
On Tue, 30 May 2023 17:37:24 GMT, Mandy Chung wrote:
>> Change `ClassFileDumper` constructor to take a `String` rather than `Path`
>> to avoid the file system implementation classes loaded during startup. In
>> addition, `FilePermission` also causes the default file system to be
>>
> Change `ClassFileDumper` constructor to take a `String` rather than `Path` to
> avoid the file system implementation classes loaded during startup. In
> addition, `FilePermission` also causes the default file system to be
> initialized.
>
> This patch changes `ClassFileDumper` to validate
On Thu, 25 May 2023 08:21:39 GMT, Alan Bateman wrote:
>> This is the implementation of:
>>
>> - JEP 453: Structured Concurrency (Preview)
>> - JEP 446: Scoped Values (Preview)
>>
>> For the most part, this is just moving code and tests. StructuredTaskScope
>> moves to j.u.concurrent as a
On Wed, 24 May 2023 19:20:09 GMT, Xue-Lei Andrew Fan wrote:
>> Hi,
>>
>> May I have this update reviewed?
>>
>> The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because
>> of security concerns. The issue was addressed in
>>
> Explain in java.lang.Class how unnamed classes are modeled in core reflection.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains seven
On Wed, 10 May 2023 14:52:58 GMT, Mahendra Chhipa wrote:
>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented the review comments.
Apologies
On Wed, 10 May 2023 14:41:02 GMT, Mahendra Chhipa wrote:
>> test/jdk/javax/xml/jaxp/datatype/8033980/SerializationTest.java line 232:
>>
>>> 230: * JDKGregorianCalendarAndDurationSerData.java files.
>>> 231: * @param baos
>>> 232: */
>>
>> I think there needs to be a general
On Fri, 26 May 2023 14:57:21 GMT, Roger Riggs wrote:
> Decouple the jdk.internal.util OperatingSystem and Version classes to
> simplify class loading and avoid an indirect cyclic initialization.
>
> Move the method to get the current OS version from OperatingSystem to the
> Version class and
On Tue, 30 May 2023 13:02:52 GMT, Martin Doerr wrote:
> Do you happen to know why Architecture.current() misses the "le"?
@TheRealMDoerr The makefile that does the substitution (in GensrcMisc.gmk) for
the OPENJDK_TARGET_CPU is using the _CANONICAL form of the architecture (that
maps ppc64le
On Sat, 27 May 2023 21:04:51 GMT, Joe Darcy wrote:
> Straightforward doc refactoring to use snippets.
This pull request has now been integrated.
Changeset: 1b8e6bf3
Author:Joe Darcy
URL:
https://git.openjdk.org/jdk/commit/1b8e6bf31ccc0eb2db3c26ed2fac2c406eda53be
Stats: 28 lines
On Sun, 28 May 2023 18:50:45 GMT, Alan Bateman wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> src/java.base/share/classes/java/lang/Class.java line 426:
>
>> 424: * {@snippet
On Tue, 30 May 2023 16:42:05 GMT, Joe Darcy wrote:
>> Straightforward doc refactoring to use snippets.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respond to review feedback.
Marked as reviewed by alanb (Reviewer).
> Straightforward doc refactoring to use snippets.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/14194/files
- new:
On Tue, 30 May 2023 09:15:13 GMT, Aleksey Shipilev wrote:
>> UUID is very important class that is used to track identities of objects in
>> large scale systems. Yet, the coverage in JDK test is disappointing: it
>> tests only 100 of UUID instances per test, which is way too small to detect
>>
On Tue, 30 May 2023 12:17:00 GMT, Jorn Vernee wrote:
> The issue is that the fallback linker uses `copyFrom` when copying a by-value
> struct argument to an internal buffer, without first adjusting the size of
> the argument segment. This means that if the argument segment is 'too large'
>
On Sat, 27 May 2023 15:33:37 GMT, Kim Barrett wrote:
>> I am basically worried that undefining malloc, even if it seems harmless
>> now, exposes us to difficult-to-investigate problems down the road, since it
>> depends on how the libc devs will reform those macros in the future. I would
>>
On Tue, 30 May 2023 12:17:00 GMT, Jorn Vernee wrote:
> The issue is that the fallback linker uses `copyFrom` when copying a by-value
> struct argument to an internal buffer, without first adjusting the size of
> the argument segment. This means that if the argument segment is 'too large'
>
On Tue, 30 May 2023 13:31:16 GMT, Jie Fu wrote:
> Just remove the `static` to fix the build failure.
> Thanks.
This pull request has now been integrated.
Changeset: 15e02853
Author:Jie Fu
URL:
https://git.openjdk.org/jdk/commit/15e028530ad6408693e9f21fb94daa705b951897
Stats: 4
On Tue, 30 May 2023 13:40:42 GMT, Tobias Hartmann wrote:
> Looks good and trivial.
Thanks @TobiHartmann .
-
PR Comment: https://git.openjdk.org/jdk/pull/14218#issuecomment-1568458529
On Tue, 30 May 2023 13:31:16 GMT, Jie Fu wrote:
> Just remove the `static` to fix the build failure.
> Thanks.
Looks good and trivial.
-
Marked as reviewed by thartmann (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14218#pullrequestreview-1450983424
On Mon, 29 May 2023 02:20:07 GMT, Chang Peng wrote:
>> In Vector API Java level, vector mask is represented as a boolean array with
>> 0x00/0x01 (8 bits of each element) as values, aka in-memory format. When it
>> is loaded into vector register, e.g. Neon, the in-memory format will be
>>
Just remove the `static` to fix the build failure.
Thanks.
-
Commit messages:
- 8309110: Build failure after JDK-8307795 due to warnings in micro-bechmark
StoreMaskTrueCount.java
Changes: https://git.openjdk.org/jdk/pull/14218/files
Webrev:
On Fri, 26 May 2023 17:23:01 GMT, Thomas Stuefe wrote:
> Still think it would be cleaner and simpler to set the FD in the parent to
> CLOEXEC, before doing posix_spawn, and at the same time set the childStuff
> variable to -1 to prevent the child from attempting to re-close it.
> Reconsider?
On Thu, 25 May 2023 15:25:40 GMT, Volker Simonis wrote:
>> Since JDK13, executing commands in a sub-process defaults to the so called
>> `POSIX_SPAWN` launching mechanism (i.e.
>> `-Djdk.lang.Process.launchMechanism=POSIX_SPAWN`) on Linux. This works by
>> using `posix_spawn(3)` to firstly
> Since JDK13, executing commands in a sub-process defaults to the so called
> `POSIX_SPAWN` launching mechanism (i.e.
> `-Djdk.lang.Process.launchMechanism=POSIX_SPAWN`) on Linux. This works by
> using `posix_spawn(3)` to firstly start a tiny helper program called
> `jspawnhelper` in a
On Fri, 26 May 2023 15:45:24 GMT, Roger Riggs wrote:
>> The internal enum jdk.internal.util.Architecture does not provide
>> information about the big or little endianness or the address size (64 or 32
>> bits). The endian-ness and address size are intrinsic to the architecture.
>>
>> The
The issue is that the fallback linker uses `copyFrom` when copying a by-value
struct argument to an internal buffer, without first adjusting the size of the
argument segment. This means that if the argument segment is 'too large' (i.e.
larger than the layout it was linked with) we fail with an
On Mon, 15 May 2023 02:58:46 GMT, Chang Peng wrote:
> In Vector API Java level, vector mask is represented as a boolean array with
> 0x00/0x01 (8 bits of each element) as values, aka in-memory format. When it
> is loaded into vector register, e.g. Neon, the in-memory format will be
>
On Tue, 30 May 2023 08:49:35 GMT, Alan Bateman wrote:
>> command: make test CONF=fastdebug JTREG="VM_OPTIONS=-Xcomp"
>> TEST=gc/TestAllocHumongousFragment.java
>> error info:
>>
>> Caused by: java.lang.NullPointerException: Cannot invoke
>> "sun.util.locale.BaseLocale.getVariant()" because
On Mon, 29 May 2023 10:39:19 GMT, Maurizio Cimadamore
wrote:
> There's an obvious bug in `AbstractMemorySegmentImpl::reinterpret(long,
> Arena, Consumer)`: this method does not pass the consumer down to the
> internal implementation method (it just passes `null`). As a result, the
> cleanup
On Tue, 30 May 2023 08:49:35 GMT, Alan Bateman wrote:
>> command: make test CONF=fastdebug JTREG="VM_OPTIONS=-Xcomp"
>> TEST=gc/TestAllocHumongousFragment.java
>> error info:
>>
>> Caused by: java.lang.NullPointerException: Cannot invoke
>> "sun.util.locale.BaseLocale.getVariant()" because
On Mon, 29 May 2023 07:33:36 GMT, Francesco Nigro wrote:
>> Also there is a lot of use cases where the type switch is called only with
>> instances of the same class, for those scenarii, the VM should be able to
>> fully remove the type switch and inline the body of the corresponding case
>>
On Tue, 30 May 2023 09:15:13 GMT, Aleksey Shipilev wrote:
>> UUID is very important class that is used to track identities of objects in
>> large scale systems. Yet, the coverage in JDK test is disappointing: it
>> tests only 100 of UUID instances per test, which is way too small to detect
>>
On Mon, 29 May 2023 06:53:35 GMT, Jaikiran Pai wrote:
> Overall, this test-only change look OK to me.
Thanks for looking at it! I believe I addressed the comments in the revision.
-
PR Comment: https://git.openjdk.org/jdk/pull/14134#issuecomment-1568078384
> UUID is very important class that is used to track identities of objects in
> large scale systems. Yet, the coverage in JDK test is disappointing: it tests
> only 100 of UUID instances per test, which is way too small to detect
> collisions due to the bad randomness for example.
>
> I have
On Mon, 29 May 2023 06:48:10 GMT, Jaikiran Pai wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments
>
> test/jdk/java/util/UUID/UUIDTest.java line 40:
>
>> 38: private static final int COUNT =
On Tue, 30 May 2023 08:31:08 GMT, SUN Guoyun wrote:
> command: make test CONF=fastdebug JTREG="VM_OPTIONS=-Xcomp"
> TEST=gc/TestAllocHumongousFragment.java
> error info:
>
> Caused by: java.lang.NullPointerException: Cannot invoke
> "sun.util.locale.BaseLocale.getVariant()" because "base" is
On Tue, 30 May 2023 08:31:08 GMT, SUN Guoyun wrote:
> command: make test CONF=fastdebug JTREG="VM_OPTIONS=-Xcomp"
> TEST=gc/TestAllocHumongousFragment.java
> error info:
>
> Caused by: java.lang.NullPointerException: Cannot invoke
> "sun.util.locale.BaseLocale.getVariant()" because "base" is
command: make test CONF=fastdebug JTREG="VM_OPTIONS=-Xcomp"
TEST=gc/TestAllocHumongousFragment.java
error info:
Caused by: java.lang.NullPointerException: Cannot invoke
"sun.util.locale.BaseLocale.getVariant()" because "base" is null
at
On Mon, 29 May 2023 22:29:26 GMT, Artem Semenov wrote:
>> When using the clang compiler to build OpenJDk on Linux, we encounter
>> various "warnings as errors".
>> They can be fixed with small changes.
>
> Artem Semenov has updated the pull request incrementally with one additional
> commit
67 matches
Mail list logo
