On Tue, 20 Jun 2023 18:36:40 GMT, Volker Simonis wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> feedback Volker and Roger
>
> Still good :)
Thanks @simonis and @RogerRiggs !
-
PR Comment:
On Sat, 17 Jun 2023 18:24:54 GMT, Thomas Stuefe wrote:
> Reported by [jarabe...@gmail.com](mailto:jarabe...@gmail.com) [1]
>
> jspawnhelper uses argv[0] to receive the fd string from the parent. That
> breaks with conventions and trips over certain tools like binfmt_misc.
>
> For details,
On Wed, 21 Jun 2023 00:13:24 GMT, Chen Liang wrote:
>> Correct misstatement that the Class object for a primitive type can only be
>> be access via fields like java.lang.Integer.TYPE.
>
> src/java.base/share/classes/java/lang/Class.java line 818:
>
>> 816: * they represent, namely {@code
On Wed, 21 Jun 2023 00:00:54 GMT, Joe Darcy wrote:
> Correct misstatement that the Class object for a primitive type can only be
> be access via fields like java.lang.Integer.TYPE.
src/java.base/share/classes/java/lang/Class.java line 818:
> 816: * they represent, namely {@code boolean},
Hi all,
This pull request contains a backport of commit
[e022e876](https://github.com/openjdk/jdk/commit/e022e876543b65b531027662326f35b497861f33)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Jorn Vernee on 21 Jun 2023 and was
On Tue, 20 Jun 2023 23:58:53 GMT, Jorn Vernee wrote:
>> src/java.base/share/classes/java/lang/foreign/Linker.java line 659:
>>
>>> 657: * against which the index is validated is available.
>>> 658: *
>>> 659: * @param index the index of the first variadic argument
Correct misstatement that the Class object for a primitive type can only be be
access via fields like java.lang.Integer.TYPE.
-
Commit messages:
- Fix whitespace.
- JDK-8310267: Javadoc for Class#isPrimitive() is incorrect regarding Class
objects for primitives
Changes:
On Wed, 14 Jun 2023 19:30:10 GMT, Jorn Vernee wrote:
> Add missing alignment checks for the alignment constraint of the root layout
> of a VarHandle created through `MemoryLayout::varHandle` and a MethodHandle
> `MemoryLayout::sliceHandle`.
>
> Testing: `jdk_foreign` test suite
This pull
On Tue, 20 Jun 2023 22:54:47 GMT, Maurizio Cimadamore
wrote:
>> Improve the specification of `Linker.Option.firstVariadicArg`, by specifying
>> more clearly which index values are valid.
>
> src/java.base/share/classes/java/lang/foreign/Linker.java line 652:
>
>> 650: * The {@code
On Tue, 20 Jun 2023 23:57:05 GMT, Jorn Vernee wrote:
>> src/java.base/share/classes/java/lang/foreign/Linker.java line 652:
>>
>>> 650: * The {@code index} value must be greater than zero, and less
>>> than or equal to the number of argument layouts
>>> 651: * of the function
On Tue, 20 Jun 2023 22:59:42 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/java/lang/foreign/Linker.java line 650:
>>
>>> 648: * function descriptor associated with a downcall
>>> linkage request}
>>> 649: *
>>> 650: * The {@code index}
On Tue, 20 Jun 2023 14:21:26 GMT, Jorn Vernee wrote:
> Improve the specification of `Linker.Option.firstVariadicArg`, by specifying
> more clearly which index values are valid.
src/java.base/share/classes/java/lang/foreign/Linker.java line 650:
> 648: * function descriptor
On Tue, 20 Jun 2023 22:53:53 GMT, Maurizio Cimadamore
wrote:
>> Improve the specification of `Linker.Option.firstVariadicArg`, by specifying
>> more clearly which index values are valid.
>
> src/java.base/share/classes/java/lang/foreign/Linker.java line 650:
>
>> 648: *
On Fri, 28 Apr 2023 01:03:28 GMT, Jiangli Zhou wrote:
> Initial implementation for supporting building a fully statically linked
> (with a desired set of JDK native libraries and libjvm) Java launcher
> executable, which is named as 'javastatic'.
>
> In this PR, the support is only added for
On Tue, 20 Jun 2023 18:23:09 GMT, Roger Riggs wrote:
> A positive number is any number that is greater than 0. **Unlike positive
> integers**, which include 0
math.net seems pretty alone in this. I find the notion bizarre. There seems to
be an overwhelming majority of sources that consider 0
On Mon, 19 Jun 2023 06:55:52 GMT, Axel Boldt-Christmas
wrote:
>> The current implementation for testing generational ZGC with jtreg is
>> implemented with a filter on the mode flag `ZGenerational`. Because of this
>> only environments which set this flag explicitly will run most of the tests.
On Tue, 20 Jun 2023 19:15:35 GMT, Mandy Chung wrote:
>> Compact profiles are defined in Java SE 8 and are legacy in Java SE 9. jdeps
>> -profile option was deprecated for removal in JDK 21. This option can be
>> removed in JDK 22. Customers can use jdeps to find the set of modules
>> required
On Tue, 20 Jun 2023 19:15:35 GMT, Mandy Chung wrote:
>> Compact profiles are defined in Java SE 8 and are legacy in Java SE 9. jdeps
>> -profile option was deprecated for removal in JDK 21. This option can be
>> removed in JDK 22. Customers can use jdeps to find the set of modules
>> required
> Compact profiles are defined in Java SE 8 and are legacy in Java SE 9. jdeps
> -profile option was deprecated for removal in JDK 21. This option can be
> removed in JDK 22. Customers can use jdeps to find the set of modules
> required by their applications instead.
Mandy Chung has updated
On Tue, 20 Jun 2023 10:55:12 GMT, Alan Bateman wrote:
> I think we've converged on the right motivation. If would be good to check if
> there are TLS tests that could run with --limit-modules java.base, that would
> give confidence that the API/implementation will work when the run-time image
Compact profiles are defined in Java SE 8 and are legacy in Java SE 9. jdeps
-profile option was deprecated for removal in JDK 21. This option can be
removed in JDK 22. Customers can use jdeps to find the set of modules required
by their applications instead.
-
Commit messages:
-
On Tue, 20 Jun 2023 16:48:42 GMT, Thomas Stuefe wrote:
>> Reported by [jarabe...@gmail.com](mailto:jarabe...@gmail.com) [1]
>>
>> jspawnhelper uses argv[0] to receive the fd string from the parent. That
>> breaks with conventions and trips over certain tools like binfmt_misc.
>>
>> For
On Sun, 18 Jun 2023 19:33:07 GMT, Jens Lidestrom wrote:
> Where did you get this idea? A "positive" means a number that is _greater_
> than zero.
One of my colleagues with a strong math background has corrected many of my API
javadoc comments seeking to avoid any ambiguity. See reference
On Tue, 20 Jun 2023 13:54:15 GMT, Christian Stein wrote:
> Please review this update to `java`'s help output for `--module-path`/`-p`.
>
> This PR also updates the output for the closely related
> `--upgrade-module-path` option.
>
> Thanks in advance!
This looks okay to me. Please also
On Tue, 20 Jun 2023 17:25:16 GMT, Erik Joelsson wrote:
> The changes look ok.
Thanks. I'll wait for approval on https://bugs.openjdk.org/browse/JDK-8307858
as well.
-
PR Comment: https://git.openjdk.org/jdk21/pull/26#issuecomment-1599256118
On Tue, 20 Jun 2023 17:24:03 GMT, Erik Joelsson wrote:
> > @erikj - You did a round of Mach5 testing on the JDK22 version of this fix.
> > Do you have plans to redo that testing for the JDK21 backport?
>
> I have done testing of the JDK 21 version of the patch and it's running
> cleanly.
On Mon, 19 Jun 2023 01:34:59 GMT, David Holmes wrote:
>> src/java.base/share/classes/java/lang/Class.java line 395:
>>
>>> 393: * attached thread), the system class loader is used.
>>> 394: *
>>> 395: * @param className the binary name
>>> of the class
>>
>> Where do these
> This PR clarifies the spec of the 3-arg Class::forName regarding the format
> of the name for an array type which is of the form: one or more of "[" +
> binary name of the element type + ";'.
Mandy Chung has updated the pull request incrementally with one additional
commit since the last
On Sat, 17 Jun 2023 00:35:22 GMT, Mandy Chung wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull
On Tue, 20 Jun 2023 17:13:26 GMT, Joe Darcy wrote:
> I had occasion to read over the javadoc sources in java.lang.Object recently
> and noticed a few items that could be updated.
>
> There are some new or expanded API notes referring to methods in
> java.util.Objects. I added these references
On Tue, 20 Jun 2023 17:02:04 GMT, Roger Riggs wrote:
> Hi all,
>
> This pull request contains a backport of commit [33c6ec9d] from the
> [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being backported was authored by Roger Riggs on 19 Jun 2023
> and was
On Fri, 16 Jun 2023 22:10:08 GMT, Daniel D. Daugherty
wrote:
> @erikj - You did a round of Mach5 testing on the JDK22 version of this fix.
> Do you have plans to redo that testing for the JDK21 backport?
I have done testing of the JDK 21 version of the patch and it's running cleanly.
On Fri, 16 Jun 2023 20:36:07 GMT, Jiangli Zhou wrote:
> 8307858: [REDO] JDK-8307194 Add make target for optionally building a
> complete set of all JDK and hotspot libjvm static libraries
The changes look ok.
-
Marked as reviewed by erikj (Reviewer).
PR Review:
I had occasion to read over the javadoc sources in java.lang.Object recently
and noticed a few items that could be updated.
There are some new or expanded API notes referring to methods in
java.util.Objects. I added these references as apiNote items rather than, say,
`@see` tags since `@see`
Hi all,
This pull request contains a backport of commit [33c6ec9d] from the
[openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Roger Riggs on 19 Jun 2023 and
was reviewed by Paul Hohensee, Aleksey Shipilev and Ao Qi.
Thanks!
On Tue, 20 Jun 2023 17:02:04 GMT, Roger Riggs wrote:
> Hi all,
>
> This pull request contains a backport of commit [33c6ec9d] from the
> [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being backported was authored by Roger Riggs on 19 Jun 2023
> and was
On Tue, 20 Jun 2023 16:26:58 GMT, Aleksey Shipilev wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct mps64el test case
>
> Hey @RogerRiggs, could you ask bots to backport to JDK 21? I'll then review
> that
On Tue, 20 Jun 2023 16:48:42 GMT, Thomas Stuefe wrote:
>> Reported by [jarabe...@gmail.com](mailto:jarabe...@gmail.com) [1]
>>
>> jspawnhelper uses argv[0] to receive the fd string from the parent. That
>> breaks with conventions and trips over certain tools like binfmt_misc.
>>
>> For
> Reported by [jarabe...@gmail.com](mailto:jarabe...@gmail.com) [1]
>
> jspawnhelper uses argv[0] to receive the fd string from the parent. That
> breaks with conventions and trips over certain tools like binfmt_misc.
>
> For details, see linked ML discussion.
>
> [1]
On Tue, 20 Jun 2023 15:49:42 GMT, Glavo wrote:
> 8310105: LoongArch64 builds are broken after JDK-8304913
This pull request has now been integrated.
Changeset: 7e788939
Author:Glavo
Committer: Aleksey Shipilev
URL:
On Tue, 20 Jun 2023 15:08:13 GMT, Thomas Stuefe wrote:
>> src/java.base/unix/native/jspawnhelper/jspawnhelper.c line 139:
>>
>>> 137: ChildStuff c;
>>> 138: struct stat buf;
>>> 139: /* argv[1] contains the fd number to read all the child info */
>>
>> I would prefer to also fix
On Thu, 15 Jun 2023 17:44:01 GMT, Roger Riggs wrote:
>> Add mipsel and mips64el to the Architecture enum.
>> (Later to be backported to JDK 21)
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Correct mps64el test case
Hey
On Tue, 20 Jun 2023 15:49:42 GMT, Glavo wrote:
> 8310105: LoongArch64 builds are broken after JDK-8304913
The change looks fine.
This is a build breakage. I adjusted the priority to P2.
-
Marked as reviewed by shade (Reviewer).
PR Review:
On Tue, 20 Jun 2023 15:56:34 GMT, Kevin Rushforth wrote:
>> 8310105: LoongArch64 builds are broken after JDK-8304913
>
> @Glavo If the priority of the bug, which is listed as P4, is correct (which I
> suspect it is not), this would not meet the criteria for integrating into JDK
> 21 during
On Tue, 20 Jun 2023 15:49:42 GMT, Glavo wrote:
> 8310105: LoongArch64 builds are broken after JDK-8304913
@Glavo If the priority of the bug, which is listed as P4, is correct (which I
suspect it is not), this would not meet the criteria for integrating into JDK
21 during RDP1. If this is
8310105: LoongArch64 builds are broken after JDK-8304913
-
Commit messages:
- Backport 137a5f7c2ce35258702b28565f6feb7cb7f1d68e
Changes: https://git.openjdk.org/jdk21/pull/39/files
Webrev: https://webrevs.openjdk.org/?repo=jdk21=39=00
Issue:
Improve the specification of `Linker.Option.firstVariadicArg`, by specifying
more clearly which index values are valid.
-
Commit messages:
- improve firstVariadicArg doc
Changes: https://git.openjdk.org/jdk/pull/14565/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=14565=00
On Mon, 19 Jun 2023 14:58:13 GMT, Per Minborg wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [b412fc79](https://github.com/openjdk/jdk/commit/b412fc79c3c2548df10918090beedaf6b2d08d96)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit
On Tue, 20 Jun 2023 15:00:29 GMT, Roger Riggs wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> correct comment
>
> src/java.base/unix/native/jspawnhelper/jspawnhelper.c line 139:
>
>> 137: ChildStuff c;
>>
On Mon, 19 Jun 2023 06:07:26 GMT, Thomas Stuefe wrote:
>> Reported by [jarabe...@gmail.com](mailto:jarabe...@gmail.com) [1]
>>
>> jspawnhelper uses argv[0] to receive the fd string from the parent. That
>> breaks with conventions and trips over certain tools like binfmt_misc.
>>
>> For
On Tue, 20 Jun 2023 13:54:15 GMT, Christian Stein wrote:
> Please review this update to `java`'s help output for `--module-path`/`-p`.
>
> This PR also updates the output for the closely related
> `--upgrade-module-path` option.
>
> Thanks in advance!
On Mon, 19 Jun 2023 14:58:13 GMT, Per Minborg wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [b412fc79](https://github.com/openjdk/jdk/commit/b412fc79c3c2548df10918090beedaf6b2d08d96)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit
Please review this update to `java`'s help output for `--module-path`/`-p`.
This PR also updates the output for the closely related `--upgrade-module-path`
option.
Thanks in advance!
-
Commit messages:
- Update `--upgrade-module-path` description
- 8309670: java -help output for
On Tue, 20 Jun 2023 12:10:23 GMT, Kevin Rushforth wrote:
> Since this is a P4 Enhancement, you will need approval to backport this to
> JDK 21 during RDP1. See the "Late-Enhancement Request Process" section of
> [JEP 3](https://openjdk.org/jeps/3).
Test and documentation bugs and
Currently, a number of tests fail on macOS because they miss the core file
(e.g. serviceability/sa/TestJmapCore.java).
The reason is that configure detects on some setups that codesign does not work
("checking if debug mode codesign is possible... no) .
So adding the needed entitlement to
On Mon, 19 Jun 2023 14:58:13 GMT, Per Minborg wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [b412fc79](https://github.com/openjdk/jdk/commit/b412fc79c3c2548df10918090beedaf6b2d08d96)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit
On Tue, 20 Jun 2023 11:17:40 GMT, Axel Boldt-Christmas
wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [a0595761](https://github.com/openjdk/jdk/commit/a0595761ef35c4eec8cb84326a869b9473cd5bba)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The
Hi all,
This pull request contains a backport of commit
[a0595761](https://github.com/openjdk/jdk/commit/a0595761ef35c4eec8cb84326a869b9473cd5bba)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Axel Boldt-Christmas on 20 Jun 2023
On Tue, 20 Jun 2023 00:57:46 GMT, Sean Mullan wrote:
> > Maybe you are thinking about the size of libsunec or non-technical issues
> > that meant it wasn't included by some distributions? There weren't an issue
> > with deciding which providers to include to java.base. I think the
> >
On Tue, 13 Jun 2023 20:36:28 GMT, Anthony Scarpino
wrote:
> Hi,
>
> I need a code review for moving the contents of the jdk.crypto.ec module into
> java.base. This moves the SunEC JCE Provider (Elliptic Curve) into
> java.base. EC has always been separate from the base module/pkg because
On Fri, 16 Jun 2023 09:14:10 GMT, Axel Boldt-Christmas
wrote:
> The current implementation for testing generational ZGC with jtreg is
> implemented with a filter on the mode flag `ZGenerational`. Because of this
> only environments which set this flag explicitly will run most of the tests.
>
On Mon, 19 Jun 2023 06:55:52 GMT, Axel Boldt-Christmas
wrote:
>> The current implementation for testing generational ZGC with jtreg is
>> implemented with a filter on the mode flag `ZGenerational`. Because of this
>> only environments which set this flag explicitly will run most of the tests.
On Mon, 19 Jun 2023 09:04:17 GMT, Thomas Stuefe wrote:
> How much time do we spend now in GHAs on the additional Zgenerational tests?
> In any case, this makes sense.
This adds around 40 more tests per platform. The runtime of GHA seems to have a
lot of run to run variance. Most new tests are
On Tue, 9 May 2023 00:12:19 GMT, Stuart Marks wrote:
> This isn't correct. When length() returns Integer.MIN_VALUE, this doesn't
> _necessarily_ cause get(from, to) to always return an empty BitSet. Well, it
> does in the current implementation, but that's simply a bug that can be
> fixed.
On Tue, 13 Jun 2023 15:48:31 GMT, Christian Wimmer wrote:
> We (as the Native Image team) are OK with this. Our testing will detect that
> pretty quickly, and then the new code can be fixed.
That may well be the case. However, until all the concerns raised by OpenJDK
reviewers who have looked
On Wed, 12 Apr 2023 07:12:10 GMT, Julian Waters wrote:
>> C11 has been stable for a long time on all platforms, so native code can use
>> the standard alignas operator for alignment requirements
>
> Julian Waters has updated the pull request incrementally with four additional
> commits since
> C11 has been stable for a long time on all platforms, so native code can use
> the standard alignas operator for alignment requirements
Julian Waters has updated the pull request incrementally with three additional
commits since the last revision:
- Whitespace
- Revert
- _MSC_VER
On Thu, 1 Jun 2023 11:49:24 GMT, Julian Waters wrote:
>> On Windows, the basic Java Integer types are defined as long and __int64
>> respectively. In particular, the former is rather problematic since it
>> breaks compilation as the Visual C++ becomes stricter and more compliant
>> with every
68 matches
Mail list logo
