On Tue, 11 Jul 2023 23:47:30 GMT, airsquared wrote:
> [JDK-8309032](https://bugs.openjdk.org/browse/JDK-8309032),
> [JDK-8306488](https://bugs.openjdk.org/browse/JDK-8306488)
This also resolved [JDK-8306488](https://bugs.openjdk.org/browse/JDK-8306488),
if someone can mark it as such.
On Wed, 19 Jul 2023 10:58:58 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to deprecate for
>> removal the `-Xdebug` option and `-debug` option of the `java` command?
>> This addresses https://bugs.openjdk.org/browse/JDK-8227229.
>>
>> As noted in the
8309032: jpackage does not work for module projects unless --module-path is
specified
-
Commit messages:
- Backport dfe764e3f85784752d69fd51306644732e808d38
Changes: https://git.openjdk.org/jdk21/pull/140/files
Webrev: https://webrevs.openjdk.org/?repo=jdk21=140=00
Issue:
On Thu, 20 Jul 2023 02:04:53 GMT, Chen Liang wrote:
>>> A similar performance decrease have been discussed here: [#14752
>>> (comment)](https://github.com/openjdk/jdk/pull/14752#discussion_r1250888931)
>>>
>>> Can you check whether adding `@ForceInline` on `Objects.equals` help with
>>> JIT?
On Thu, 20 Jul 2023 02:04:53 GMT, Alexey Semenyuk wrote:
>> [JDK-8309032](https://bugs.openjdk.org/browse/JDK-8309032),
>> [JDK-8306488](https://bugs.openjdk.org/browse/JDK-8306488)
>
> @sashamatveev would you like to review the change before I sponsor it?
@alexeysemenyukoracle Looks good.
On Tue, 11 Jul 2023 23:47:30 GMT, airsquared wrote:
> [JDK-8309032](https://bugs.openjdk.org/browse/JDK-8309032),
> [JDK-8306488](https://bugs.openjdk.org/browse/JDK-8306488)
This pull request has now been integrated.
Changeset: dfe764e3
Author:airsquared
On Tue, 11 Jul 2023 23:47:30 GMT, airsquared wrote:
> [JDK-8309032](https://bugs.openjdk.org/browse/JDK-8309032),
> [JDK-8306488](https://bugs.openjdk.org/browse/JDK-8306488)
Marked as reviewed by almatvee (Reviewer).
-
PR Review:
On Thu, 20 Jul 2023 01:27:41 GMT, Glavo wrote:
>> The changes to `Arrays.hashCode(Object[])` in JDK-8312164 caused its
>> performance is reduced by about 80%.
>>
>> This PR reverts this change.
>
>> A similar performance decrease have been discussed here: [#14752
>>
On Tue, 11 Jul 2023 23:47:30 GMT, airsquared wrote:
> [JDK-8309032](https://bugs.openjdk.org/browse/JDK-8309032),
> [JDK-8306488](https://bugs.openjdk.org/browse/JDK-8306488)
@sashamatveev would you like to review the change before I sponsor it?
-
PR Comment:
On Thu, 20 Jul 2023 01:11:43 GMT, Glavo wrote:
> The changes to `Arrays.hashCode(Object[])` in JDK-8312164 caused its
> performance is reduced by about 80%.
>
> This PR reverts this change.
JMH Benchmark:
public class HashCode {
@Param({"1", "10", "100", "1"})
private int size;
The changes to `Arrays.hashCode(Object[])` in JDK-8312164 caused its
performance is reduced by about 80%.
This PR reverts this change.
-
Commit messages:
- Add benchmark
- Revert changes to Arrays.hashCode(Object[]) in JDK-8312164
Changes:
On Thu, 20 Jul 2023 01:11:43 GMT, Glavo wrote:
> The changes to `Arrays.hashCode(Object[])` in JDK-8312164 caused its
> performance is reduced by about 80%.
>
> This PR reverts this change.
A similar performance decrease have been discussed here:
On Tue, 18 Jul 2023 01:57:56 GMT, Chen Liang wrote:
>> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
>> implementation of MethodHandleProxies.asInterface has a few issues:
>> 1. Exposes too much information via Proxy supertype (and WrapperInstance
>> interface)
>>
> `VarForm::getMemberName` currently throws UOE with no information if the
> requested access mode is unsupported. To provide the var handle
> information, move the access mode check to `VarHandle` so that the exception
> message can include the var handle information. Changes include:
>
>
On Wed, 19 Jul 2023 13:14:23 GMT, Pavel Rappo wrote:
>> Please review this PR to refactor Arrays.hashCode for long[], boolean[], and
>> Object[]. I've been told elsewhere that it shouldn't have significant
>> performance implications.
>
> Pavel Rappo has updated the pull request incrementally
On Wed, 19 Jul 2023 23:48:03 GMT, Mandy Chung wrote:
>> `VarForm::getMemberName` currently throws UOE with no information if the
>> requested access mode is unsupported. To provide the var handle
>> information, move the access mode check to `VarHandle` so that the exception
>> message can
On Wed, 19 Jul 2023 22:08:04 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> equals for BitSet.
>>
>> I couldn't see how to refactor hashCode using Arrays utility methods in a
>> way that preserves its specification. So, aside from
On Tue, 18 Jul 2023 01:57:56 GMT, Chen Liang wrote:
>> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
>> implementation of MethodHandleProxies.asInterface has a few issues:
>> 1. Exposes too much information via Proxy supertype (and WrapperInstance
>> interface)
>>
On Wed, 19 Jul 2023 23:48:03 GMT, Mandy Chung wrote:
>> `VarForm::getMemberName` currently throws UOE with no information if the
>> requested access mode is unsupported. To provide the var handle
>> information, move the access mode check to `VarHandle` so that the exception
>> message can
On Tue, 18 Jul 2023 15:33:46 GMT, Alexey Semenyuk wrote:
>> [JDK-8309032](https://bugs.openjdk.org/browse/JDK-8309032),
>> [JDK-8306488](https://bugs.openjdk.org/browse/JDK-8306488)
>
> Marked as reviewed by asemenyuk (Reviewer).
@alexeysemenyukoracle would you be able to sponsor this change?
On Wed, 19 Jul 2023 02:19:58 GMT, Mandy Chung wrote:
>> `VarForm::getMemberName` currently throws UOE with no information if the
>> requested access mode is unsupported. To provide the var handle
>> information, move the access mode check to `VarHandle` so that the exception
>> message can
On Wed, 19 Jul 2023 23:37:41 GMT, Jorn Vernee wrote:
> Note that `IndirectVarHandle` calls `super.checkAccessModeThenIsDirect`, so
> it ends up doing the check any way, I think?
In the initial patch, it was distinct; it was migrated to call
`isAccessModeSupported` in a subsequent change, so
On Wed, 19 Jul 2023 02:19:58 GMT, Mandy Chung wrote:
>> `VarForm::getMemberName` currently throws UOE with no information if the
>> requested access mode is unsupported. To provide the var handle
>> information, move the access mode check to `VarHandle` so that the exception
>> message can
On Wed, 19 Jul 2023 02:19:58 GMT, Mandy Chung wrote:
>> `VarForm::getMemberName` currently throws UOE with no information if the
>> requested access mode is unsupported. To provide the var handle
>> information, move the access mode check to `VarHandle` so that the exception
>> message can
> `VarForm::getMemberName` currently throws UOE with no information if the
> requested access mode is unsupported. To provide the var handle
> information, move the access mode check to `VarHandle` so that the exception
> message can include the var handle information. Changes include:
>
>
On Thu, 13 Jul 2023 23:05:48 GMT, Glavo wrote:
>> `ByteArray` and `ByteArrayLittleEndian` are very useful tool classes that
>> can be used in many places to performance tuning.
>>
>> Currently they are implemented by `VarHandle`, so using them may have some
>> impact on startup time.
>>
>>
On Mon, 10 Jul 2023 18:29:36 GMT, Pavel Rappo wrote:
> I suggest we introduce the required utility method (i.e. hashOfRange) in
> ArraysSupport first.
Introducing such a method might take a while. Let me push a commit that
restores hash code
values, while still using modern utilities to
> Please review this PR to use modern APIs and language features to simplify
> equals for BitSet.
>
> I couldn't see how to refactor hashCode using Arrays utility methods in a way
> that preserves its specification. So, aside from refactoring its doc comment
> and annotating it with
On Thu, 13 Jul 2023 10:50:30 GMT, Pavel Rappo wrote:
> Please review this PR to use modern APIs and language features to simplify
> equals for BitSet.
>
> I couldn't see how to refactor hashCode using Arrays utility methods in a way
> that preserves its specification. So, aside from
On Thu, 13 Jul 2023 10:50:30 GMT, Pavel Rappo wrote:
> Please review this PR to use modern APIs and language features to simplify
> equals for BitSet.
>
> I couldn't see how to refactor hashCode using Arrays utility methods in a way
> that preserves its specification. So, aside from
On Wed, 19 Jul 2023 12:58:43 GMT, Matthew Donovan wrote:
> This PR removes javax/rmi/ssl/SSLSocketParametersTest.sh from the
> ProblemList. The script was removed in JDK-8298939 and the Java code
> refactored to be a jtreg test.
Marked as reviewed by xuelei (Reviewer).
-
PR
On Thu, 13 Jul 2023 10:50:30 GMT, Pavel Rappo wrote:
> Please review this PR to use modern APIs and language features to simplify
> equals for BitSet.
>
> I couldn't see how to refactor hashCode using Arrays utility methods in a way
> that preserves its specification. So, aside from
On Thu, 13 Jul 2023 14:50:55 GMT, Roger Riggs wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> equals for BitSet.
>>
>> I couldn't see how to refactor hashCode using Arrays utility methods in a
>> way that preserves its specification. So, aside from
On Thu, 13 Jul 2023 23:23:42 GMT, Justin Lu wrote:
> Please review this PR which refactors more java.util.Locale tests to JUnit
> with some minor cleanup as well.
>
> Although some of the files could benefit from being renamed bugNNN to
> something more descriptive, this makes reviewing
On Thu, 13 Jul 2023 23:05:48 GMT, Glavo wrote:
>> `ByteArray` and `ByteArrayLittleEndian` are very useful tool classes that
>> can be used in many places to performance tuning.
>>
>> Currently they are implemented by `VarHandle`, so using them may have some
>> impact on startup time.
>>
>>
On Wed, 19 Jul 2023 19:41:57 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8312197)
>> which updates the javadoc for the constructor of MessageFormat regarding a
>> `null` locale,
>>
>> `MessageFormat` when created with a `null` locale may throw
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8312197)
> which updates the javadoc for the constructor of MessageFormat regarding a
> `null` locale,
>
> `MessageFormat` when created with a `null` locale may throw a
> `NullPointerException` either during the object
On Tue, 18 Jul 2023 20:06:56 GMT, Andrey Turbanov wrote:
> Found opportunity to make static `ServiceLoader.LANG_ACCESS` field `final`.
src/java.base/share/classes/java/util/ServiceLoader.java line 426:
> 424:
> 425: private static final JavaLangAccess LANG_ACCESS =
> 426:
Found opportunity to make static `ServiceLoader.LANG_ACCESS` field `final`.
-
Commit messages:
- 8312414: Make java.util.ServiceLoader.LANG_ACCESS final
- [PATCH] Make java.util.ServiceLoader.LANG_ACCESS final
Changes: https://git.openjdk.org/jdk/pull/14926/files
Webrev:
On Wed, 19 Jul 2023 10:58:58 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to deprecate for
>> removal the `-Xdebug` option and `-debug` option of the `java` command?
>> This addresses https://bugs.openjdk.org/browse/JDK-8227229.
>>
>> As noted in the
On Thu, 13 Jul 2023 23:05:48 GMT, Glavo wrote:
>> `ByteArray` and `ByteArrayLittleEndian` are very useful tool classes that
>> can be used in many places to performance tuning.
>>
>> Currently they are implemented by `VarHandle`, so using them may have some
>> impact on startup time.
>>
>>
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8312197)
> which updates the javadoc for the constructor of MessageFormat regarding a
> `null` locale,
>
> `MessageFormat` when created with a `null` locale may throw a
> `NullPointerException` either during the object
On Tue, 18 Jul 2023 22:09:48 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Slight wording adjustment
>> - Review: Explicitly declare when NPE thrown instead of 'may'
>
>
On Wed, 19 Jul 2023 17:15:34 GMT, Martin Buchholz wrote:
> > > BitSet#equals
> >
> >
> > Did you mean BitSet#hashCode?
>
> No. BitSet#equals uses the private fields and methods of its argument, which
> OO purists would never allow. If the other is a subclass with a different
> private
This PR removes javax/rmi/ssl/SSLSocketParametersTest.sh from the ProblemList.
The script was removed in JDK-8298939 and the Java code refactored to be a
jtreg test.
-
Commit messages:
- 8312320: Remove javax/rmi/ssl/SSLSocketParametersTest.sh from ProblemList
Changes:
On Mon, 17 Jul 2023 09:36:35 GMT, Pavel Rappo wrote:
> Please review this PR to refactor Arrays.hashCode for long[], boolean[], and
> Object[]. I've been told elsewhere that it shouldn't have significant
> performance implications.
This pull request has now been integrated.
Changeset:
On Wed, 19 Jul 2023 15:10:45 GMT, Pavel Rappo wrote:
> > BitSet#equals
>
> Did you mean BitSet#hashCode?
No. BitSet#equals uses the private fields and methods of its argument, which OO
purists would never allow.
If the other is a subclass with a different private representation, this code
On Wed, 22 Feb 2023 15:23:13 GMT, Raffaello Giulietti
wrote:
> The `default` method `nextDouble(double origin, double bound)` in
> `java.util.random.RandomGenerator` aims at generating a uniformly and
> spatially equidistributed random `double` in the left-closed and right-open
> range
> This now uses Thread.isVirtual to distinguish spin vs immediate block cases,
> enabling re-introduction of spin control from the previous version, removing
> anomalies like this one.
Doug Lea has updated the pull request with a new target base due to a merge or
a rebase. The incremental
On Wed, 19 Jul 2023 14:04:59 GMT, Jim Laskey wrote:
>> java.lang.runtime.ReferencedKeyMap was introduced to provide a concurrent
>> caching scheme for Carrier objects. The technique used is generally useful
>> for a variety of caching schemes and is being moved to be shared in other
>> parts
On Wed, 19 Jul 2023 15:05:06 GMT, Martin Buchholz wrote:
> BitSet#equals
Did you mean BitSet#hashCode?
-
PR Comment: https://git.openjdk.org/jdk/pull/14868#issuecomment-1642274647
On Wed, 19 Jul 2023 14:04:59 GMT, Jim Laskey wrote:
>> java.lang.runtime.ReferencedKeyMap was introduced to provide a concurrent
>> caching scheme for Carrier objects. The technique used is generally useful
>> for a variety of caching schemes and is being moved to be shared in other
>> parts
On Thu, 13 Jul 2023 10:50:30 GMT, Pavel Rappo wrote:
> Please review this PR to use modern APIs and language features to simplify
> equals for BitSet.
>
> I couldn't see how to refactor hashCode using Arrays utility methods in a way
> that preserves its specification. So, aside from
On Thu, 13 Jul 2023 10:50:30 GMT, Pavel Rappo wrote:
> Please review this PR to use modern APIs and language features to simplify
> equals for BitSet.
>
> I couldn't see how to refactor hashCode using Arrays utility methods in a way
> that preserves its specification. So, aside from
> java.lang.runtime.ReferencedKeyMap was introduced to provide a concurrent
> caching scheme for Carrier objects. The technique used is generally useful
> for a variety of caching schemes and is being moved to be shared in other
> parts of the jdk. The MethodType interning case is one example.
On Tue, 18 Jul 2023 14:56:53 GMT, Chen Liang wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update test to check for gc.
>
> src/java.base/share/classes/jdk/internal/util/ReferencedKeyMap.java line 354:
>
>> 352:
On Fri, 14 Apr 2023 15:53:41 GMT, Alan Bateman wrote:
>> @AlanBateman
>> It is a known issue that size() may return a negative integer, see
>> [JDK-8230557](https://bugs.openjdk.org/browse/JDK-8230557), and the accepted
>> workaround is to interpret the returned integer as an unsigned value
On Wed, 19 Jul 2023 13:14:23 GMT, Pavel Rappo wrote:
>> Please review this PR to refactor Arrays.hashCode for long[], boolean[], and
>> Object[]. I've been told elsewhere that it shouldn't have significant
>> performance implications.
>
> Pavel Rappo has updated the pull request incrementally
On Wed, 19 Jul 2023 13:07:01 GMT, Pavel Rappo wrote:
>> Please review this PR to refactor Arrays.hashCode for long[], boolean[], and
>> Object[]. I've been told elsewhere that it shouldn't have significant
>> performance implications.
>
> Pavel Rappo has updated the pull request incrementally
> Please review this PR to refactor Arrays.hashCode for long[], boolean[], and
> Object[]. I've been told elsewhere that it shouldn't have significant
> performance implications.
Pavel Rappo has updated the pull request incrementally with one additional
commit since the last revision:
Fix
> Please review this PR to refactor Arrays.hashCode for long[], boolean[], and
> Object[]. I've been told elsewhere that it shouldn't have significant
> performance implications.
Pavel Rappo has updated the pull request incrementally with two additional
commits since the last revision:
- Fix
This PR refactors the SSLSocketParametersTest by removing redundant/unnecessary
classes and cleans up the logic around expected exceptions.
-
Commit messages:
- added javadocs to new methods
- 8303525: Refactor/cleanup
open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java
On Tue, 18 Jul 2023 14:53:09 GMT, Chen Liang wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update test to check for gc.
>
> src/java.base/share/classes/jdk/internal/util/ReferencedKeySet.java line 97:
>
>> 95:
> Can I please get a review of this change which proposes to deprecate for
> removal the `-Xdebug` option and `-debug` option of the `java` command? This
> addresses https://bugs.openjdk.org/browse/JDK-8227229.
>
> As noted in the JBS issue this option is currently a no-op and has been there
On Wed, 19 Jul 2023 07:05:45 GMT, Jaikiran Pai wrote:
> I had initially considered that but had noticed that there's a small
> difference between the generic warning message "Warning: %s option is
> deprecated and may be removed in a future release." printed by the launcher
> and the one
On Wed, 19 Jul 2023 07:05:51 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to deprecate for
>> removal the `-Xdebug` option and `-debug` option of the `java` command?
>> This addresses https://bugs.openjdk.org/browse/JDK-8227229.
>>
>> As noted in the
On Wed, 19 Jul 2023 07:07:40 GMT, Jaikiran Pai wrote:
> I would like inputs on the
> test/hotspot/jtreg/runtime/6294277/SourceDebugExtension.java test. That test
> launches java passing it the -Xdebug option and was introduced as part of
> https://bugs.openjdk.org/browse/JDK-6294277. -Xdebug
On Wed, 19 Jul 2023 07:05:51 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to deprecate for
>> removal the `-Xdebug` option and `-debug` option of the `java` command?
>> This addresses https://bugs.openjdk.org/browse/JDK-8227229.
>>
>> As noted in the
On Tue, 18 Jul 2023 12:41:32 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to deprecate for
>> removal the `-Xdebug` option and `-debug` option of the `java` command?
>> This addresses https://bugs.openjdk.org/browse/JDK-8227229.
>>
>> As noted in the
> Can I please get a review of this change which proposes to deprecate for
> removal the `-Xdebug` option and `-debug` option of the `java` command? This
> addresses https://bugs.openjdk.org/browse/JDK-8227229.
>
> As noted in the JBS issue this option is currently a no-op and has been there
70 matches
Mail list logo
