RFR: 8307408: Some jdk/sun/tools/jhsdb tests don't pass test JVM args to the debuggee JVM

2023-08-04 Thread Chris Plummer
Normally we want the test args passed to the SA debuggee. In fact for proper SA test coverage, it is more important for the test args to be passed to the debuggee than to be passed to the test or the the SA tool that the test launches. For a couple of jhsdb tests that launch jshell as the

Re: RFR: 8041488: Locale-Dependent List Patterns [v4]

2023-08-04 Thread Naoto Sato
> Introducing a new formatting class for locale-dependent list patterns. The > class is to provide the functionality from the Unicode Consortium's LDML > specification for [list > patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns). > For example, given a list of

Re: RFR: JDK-8313670: Simplify shared lib name handling code in some tests

2023-08-04 Thread Serguei Spitsyn
On Fri, 4 Aug 2023 18:34:52 GMT, Chris Plummer wrote: >> There is coding e.g. in >> https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java#L72 >> that deals with shared lib naming on different OS. >> This code should be simplified. > >

Integrated: 8311517: Add performance information to ArrayList javadoc

2023-08-04 Thread dan1st
On Wed, 26 Jul 2023 11:02:20 GMT, dan1st wrote: > The [JEP for sequenced collections](https://openjdk.org/jeps/431) would add > addFirst(), removeFirst() and reversed() methods to lists. > However, the Javadoc of List mentions: > > The size, isEmpty, get, set, iterator, and listIterator

Integrated: 8159527: Collections mutator methods should all be marked as optional operations

2023-08-04 Thread Stuart Marks
On Wed, 2 Aug 2023 20:11:35 GMT, Stuart Marks wrote: > Adjust the leading javadoc sentence of several collections mutator methods to > include "(optional operation)" as appropriate. Also adjust doc for > UnsupportedOperationException on those methods as necessary. This pull request has now

Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v3]

2023-08-04 Thread Weibing Xiao
> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if > the is an IOException generation when the output stream was flushing the > buffer. > > Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657. Weibing Xiao has updated the pull request incrementally

Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v2]

2023-08-04 Thread Weibing Xiao
On Fri, 4 Aug 2023 18:24:04 GMT, Weibing Xiao wrote: >> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if >> the is an IOException generation when the output stream was flushing the >> buffer. >> >> Please refer to the bug

Re: RFR: JDK-8313670: Simplify shared lib name handling code in some tests

2023-08-04 Thread Chris Plummer
On Fri, 4 Aug 2023 09:59:41 GMT, Matthias Baesken wrote: > There is coding e.g. in > https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java#L72 > that deals with shared lib naming on different OS. > This code should be simplified. Changes

Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v2]

2023-08-04 Thread Weibing Xiao
> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if > the is an IOException generation when the output stream was flushing the > buffer. > > Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657. Weibing Xiao has updated the pull request incrementally

Wrong exception in ComputedConstant#orElse Javadoc

2023-08-04 Thread Daniel Schmid
When viewing the propsed Javadoc of ComputedConstant#orElse (https://cr.openjdk.org/~pminborg/computed-constant/api/java.base/java/lang/ComputedConstant.html#orElse(V)),it mentions throwing an NoSuchElementException in case the element cannot be bound. However, the Javadoc also mentions

Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors

2023-08-04 Thread Aleksei Efimov
On Thu, 3 Aug 2023 17:32:43 GMT, Weibing Xiao wrote: > com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if > the is an IOException generation when the output stream was flushing the > buffer. > > Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657.

Re: RFR: 8311517: Add performance information to ArrayList javadoc [v2]

2023-08-04 Thread Stuart Marks
On Fri, 4 Aug 2023 07:11:58 GMT, dan1st wrote: >> Thanks for the updates. I've drafted a CSR; see link in header. Please take >> a look. > >> Thanks for the updates. I've drafted a CSR; see link in header. Please take >> a look. > > @stuart-marks Thanks, the CSR looks good to me. I guess the

Re: RFR: 8311517: Add performance information to ArrayList javadoc [v2]

2023-08-04 Thread Brian Burkhalter
On Fri, 4 Aug 2023 15:36:05 GMT, dan1st wrote: >> src/java.base/share/classes/java/util/ArrayList.java line 46: >> >>> 44: * {@code listIterator}, and {@code reversed} operations run in >>> constant time. >>> 45: * The {@code add}, and {@code addLast} operations runs in amortized >>> 46: *

Re: RFR: 8311517: Add performance information to ArrayList javadoc [v2]

2023-08-04 Thread Brian Burkhalter
On Thu, 27 Jul 2023 06:31:06 GMT, dan1st wrote: >> The [JEP for sequenced collections](https://openjdk.org/jeps/431) would add >> addFirst(), removeFirst() and reversed() methods to lists. >> However, the Javadoc of List mentions: >> > The size, isEmpty, get, set, iterator, and listIterator

Re: RFR: 8311517: Add performance information to ArrayList javadoc [v2]

2023-08-04 Thread dan1st
On Fri, 4 Aug 2023 15:31:59 GMT, Brian Burkhalter wrote: >> dan1st has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 8311517: ArrayList Javadoc of getFirst/getLast/removeLast >> >> as requested by >>

Re: RFR: 8311517: Add performance information to ArrayList javadoc [v2]

2023-08-04 Thread Brian Burkhalter
On Thu, 27 Jul 2023 06:31:06 GMT, dan1st wrote: >> The [JEP for sequenced collections](https://openjdk.org/jeps/431) would add >> addFirst(), removeFirst() and reversed() methods to lists. >> However, the Javadoc of List mentions: >> > The size, isEmpty, get, set, iterator, and listIterator

Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors

2023-08-04 Thread Mark Sheppard
On Thu, 3 Aug 2023 17:32:43 GMT, Weibing Xiao wrote: > com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if > the is an IOException generation when the output stream was flushing the > buffer. > > Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657.

RFR: 8313768: Reduce interaction with volatile field in j.u.l.StreamHandler

2023-08-04 Thread Sergey Tsypanov
In `publish0()`, `flush0()` and `flushAndClose()`methods of `StreamHandler` we read multiple times from volatile writer. The access number can be reduced by reading the field into local variable once. - Commit messages: - 8313768: Reduce interaction with volatile field in

Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors

2023-08-04 Thread Weibing Xiao
On Thu, 3 Aug 2023 17:59:10 GMT, Alan Bateman wrote: >> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if >> the is an IOException generation when the output stream was flushing the >> buffer. >> >> Please refer to the bug

RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors

2023-08-04 Thread Weibing Xiao
com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if the is an IOException generation when the output stream was flushing the buffer. Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657. - Commit messages: - reformat the code - remove

Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors

2023-08-04 Thread Alan Bateman
On Thu, 3 Aug 2023 17:32:43 GMT, Weibing Xiao wrote: > com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if > the is an IOException generation when the output stream was flushing the > buffer. > > Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657.

RFR: JDK-8313670: Simplify shared lib name handling code in some tests

2023-08-04 Thread Matthias Baesken
There is coding e.g. in https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java#L72 that deals with shared lib naming on different OS. This code should be simplified. - Commit messages: - JDK-8313670 Changes:

Re: RFR: 8311517: Add performance information to ArrayList javadoc [v2]

2023-08-04 Thread Raffaello Giulietti
On Thu, 27 Jul 2023 06:31:06 GMT, dan1st wrote: >> The [JEP for sequenced collections](https://openjdk.org/jeps/431) would add >> addFirst(), removeFirst() and reversed() methods to lists. >> However, the Javadoc of List mentions: >> > The size, isEmpty, get, set, iterator, and listIterator

[jdk21] RFR: 8312976: MatchResult produces StringIndexOutOfBoundsException for groups outside match

2023-08-04 Thread Raffaello Giulietti
Hi all, This pull request contains a backport of commit [61c58fdd](https://github.com/openjdk/jdk/commit/61c58fdd00727da2841a052477e4f4ecfa7094d6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Raffaello Giulietti on 4 Aug 2023 and

Integrated: 8312976: MatchResult produces StringIndexOutOfBoundsException for groups outside match

2023-08-04 Thread Raffaello Giulietti
On Thu, 27 Jul 2023 11:25:57 GMT, Raffaello Giulietti wrote: > Fixes a bug showing up after > [JDK-8132995](https://bugs.openjdk.org/browse/JDK-8132995) when there are > capturing groups outside the match. This pull request has now been integrated. Changeset: 61c58fdd Author:Raffaello

Re: RFR: 8311517: Add performance information to ArrayList javadoc [v2]

2023-08-04 Thread dan1st
On Fri, 4 Aug 2023 03:08:26 GMT, Stuart Marks wrote: > Thanks for the updates. I've drafted a CSR; see link in header. Please take a > look. @stuart-marks Thanks, the CSR looks good to me. I guess the `Fix versions` field will be added when the CSR is reviewed? - PR Comment: