> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
sid8606 has updated the pull request incrementally with one additional commit
since the last revision:
Fix indentation
Signed-off-by: Sidraya
-
Changes:
- all:
On Sun, 6 Aug 2023 09:32:08 GMT, Andrey Turbanov wrote:
>> sid8606 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo
>>
>> Signed-off-by: Sidraya
>
>
On Mon, 7 Aug 2023 13:37:57 GMT, Martin Doerr wrote:
>> sid8606 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo
>>
>> Signed-off-by: Sidraya
>
> src/hotspot/cpu/s390/foreignGlobals_s390.cpp line 154:
>
>> 152: }
On Mon, 7 Aug 2023 19:44:48 GMT, Andrey Turbanov wrote:
>> Couple of static fields in Math are used only once and can be replaced with
>> literals `0x1p512`/`0x1p-512 `
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
> Couple of static fields in Math are used only once and can be replaced with
> literals `0x1p512`/`0x1p-512 `
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8313875: Make fields final in java.util.Math: twoToTheDoubleScaleUp,
On Mon, 7 Aug 2023 17:35:34 GMT, Andrey Turbanov wrote:
>> src/java.base/share/classes/java/lang/Math.java line 3425:
>>
>>> 3423: // Constants used in scalb
>>> 3424: private static final double twoToTheDoubleScaleUp =
>>> powerOfTwoD(512);
>>> 3425: private static final double
On Mon, 7 Aug 2023 16:43:49 GMT, Raffaello Giulietti
wrote:
>> Couple of static fields in Math could be declared `final`.
>
> src/java.base/share/classes/java/lang/Math.java line 3425:
>
>> 3423: // Constants used in scalb
>> 3424: private static final double twoToTheDoubleScaleUp =
On Thu, 3 Aug 2023 16:31:01 GMT, Justin Lu wrote:
> Please review this PR which updates the IANA data from version 05-11-2023 to
> version
> [08-02-2023](https://mm.icann.org/pipermail/ietf-languages-announcements/2023-August/88.html).
>
> The contents of the update added variant subtag
On Thu, 13 Jul 2023 17:57:16 GMT, Andrey Turbanov wrote:
> Couple of static fields in Math could be declared `final`.
src/java.base/share/classes/java/lang/Math.java line 3425:
> 3423: // Constants used in scalb
> 3424: private static final double twoToTheDoubleScaleUp =
>
On Thu, 13 Jul 2023 17:57:16 GMT, Andrey Turbanov wrote:
> Couple of static fields in Math could be declared `final`.
+1
-
Marked as reviewed by bpb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14875#pullrequestreview-1565684801
Fix these -Wconversion warnings in the foreign benchmarks:
./test/micro/org/openjdk/bench/java/lang/foreign/libQSortJNI.c: In function
‘Java_org_openjdk_bench_java_lang_foreign_QSort_jni_1qsort_1optimized’:
./test/micro/org/openjdk/bench/java/lang/foreign/libQSortJNI.c:59:17: warning:
On Thu, 13 Jul 2023 17:57:16 GMT, Andrey Turbanov wrote:
> Couple of static fields in Math could be declared `final`.
Marked as reviewed by darcy (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14875#pullrequestreview-1565476822
On Thu, 6 Jul 2023 17:34:10 GMT, Severin Gehwolf wrote:
> Please review this patch which adds a "jmodless" jlink mode to the JDK.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory `jmods`). This is
>
On Tue, 1 Aug 2023 06:29:28 GMT, sid8606 wrote:
>> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
>
> sid8606 has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Fix typo
>
> Signed-off-by: Sidraya
On Tue, 1 Aug 2023 06:29:28 GMT, sid8606 wrote:
>> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
>
> sid8606 has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Fix typo
>
> Signed-off-by: Sidraya
This PR fixes a formatting error in a copyright header.
-
Commit messages:
- Restore enablePreview
- Fix copyright formatting in TestFree
Changes: https://git.openjdk.org/jdk/pull/15175/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=15175=00
Issue:
On Mon, 7 Aug 2023 12:27:39 GMT, Per Minborg wrote:
> This PR fixes a formatting error in a copyright header.
Looks good and trivial to me.
-
Marked as reviewed by thartmann (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15175#pullrequestreview-1565217211
On Mon, 7 Aug 2023 12:27:39 GMT, Per Minborg wrote:
> This PR fixes a formatting error in a copyright header.
This pull request has now been integrated.
Changeset: bbbfa217
Author:Per Minborg
URL:
https://git.openjdk.org/jdk/commit/bbbfa217a030e90e41c036203f85b764927f4848
Stats:
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
> failed with "InterruptedException: sleep interrupted" and related issues.
>
> This is a major ForkJoin update (and hard to review -- sorry) that finally
> addresses incompatibilities between ExecutorService and
On Thu, 13 Jul 2023 17:57:16 GMT, Andrey Turbanov wrote:
> Couple of static fields in Math could be declared `final`.
Looks good and trivial.
-
Marked as reviewed by redestad (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14875#pullrequestreview-1565168404
> This PR suggests updating some of the ill-formed copyright headers in the FFM
> API and the implementation and test thereof.
>
> Some of the test files will have now the "classpath" exception. Is this
> correct?
Per Minborg has updated the pull request incrementally with one additional
On Wed, 26 Jul 2023 15:43:12 GMT, Per Minborg wrote:
> This PR suggests updating some of the ill-formed copyright headers in the FFM
> API and the implementation and test thereof.
>
> Some of the test files will have now the "classpath" exception. Is this
> correct?
This pull request has now
On Mon, 7 Aug 2023 10:53:20 GMT, Per Minborg wrote:
>> This PR suggests updating some of the ill-formed copyright headers in the
>> FFM API and the implementation and test thereof.
>>
>> Some of the test files will have now the "classpath" exception. Is this
>> correct?
>
> Per Minborg has
Couple of static fields in Math could be declared `final`.
-
Commit messages:
- [PATCH] Make fields final in java.util.Math: twoToTheDoubleScaleUp,
twoToTheDoubleScaleDown
Changes: https://git.openjdk.org/jdk/pull/14875/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=14875=00
On Fri, 4 Aug 2023 19:09:58 GMT, Weibing Xiao wrote:
>> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if
>> the is an IOException generation when the output stream was flushing the
>> buffer.
>>
>> Please refer to the bug
On Fri, 4 Aug 2023 19:09:58 GMT, Weibing Xiao wrote:
>> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if
>> the is an IOException generation when the output stream was flushing the
>> buffer.
>>
>> Please refer to the bug
On Mon, 7 Aug 2023 08:57:56 GMT, Per Minborg wrote:
>> This PR suggests updating some of the ill-formed copyright headers in the
>> FFM API and the implementation and test thereof.
>>
>> Some of the test files will have now the "classpath" exception. Is this
>> correct?
>
> Per Minborg has
> This PR suggests updating some of the ill-formed copyright headers in the FFM
> API and the implementation and test thereof.
>
> Some of the test files will have now the "classpath" exception. Is this
> correct?
Per Minborg has updated the pull request incrementally with two additional
On Mon, 7 Aug 2023 06:42:54 GMT, Vyom Tewari wrote:
>> Weibing Xiao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update error message
>
> src/java.naming/share/classes/com/sun/jndi/ldap/Connection.java line 702:
>
>> 700:
>> 701:
On Sat, 29 Jul 2023 12:29:13 GMT, David Holmes wrote:
>> This PR suggests updating some of the ill-formed copyright headers in the
>> FFM API and the implementation and test thereof.
>>
>> Some of the test files will have now the "classpath" exception. Is this
>> correct?
>
>
On Fri, 4 Aug 2023 19:09:58 GMT, Weibing Xiao wrote:
>> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if
>> the is an IOException generation when the output stream was flushing the
>> buffer.
>>
>> Please refer to the bug
On Fri, 4 Aug 2023 20:55:25 GMT, Serguei Spitsyn wrote:
>> test/lib/jdk/test/lib/Platform.java line 376:
>>
>>> 374: }
>>> 375: }
>>> 376:
>>
>> The following tests could leverage this new API. Just look for calls to
>> `Platform.sharedLibraryExt()`:
>>
>>
32 matches
Mail list logo
